Re: [PATCH v2 14/35] PCI: hv: switch hv_get_dom_num() to use atomic find_bit()

From: Yury Norov <yury.norov@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"Wei Liu" <wei.liu@kernel.org>,
	"Dexuan Cui" <decui@microsoft.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
	"Jan Kara" <jack@suse.cz>,
	"Mirsad Todorovac" <mirsad.todorovac@alu.unizg.hr>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Maxim Kuvyrkov" <maxim.kuvyrkov@linaro.org>,
	"Alexey Klimov" <klimov.linux@gmail.com>,
	"Bart Van Assche" <bvanassche@acm.org>,
	"Sergey Shtylyov" <s.shtylyov@omp.ru>,
	"Michael Kelley" <mhklinux@outlook.com>
Subject: Re: [PATCH v2 14/35] PCI: hv: switch hv_get_dom_num() to use atomic find_bit()
Date: Fri, 8 Dec 2023 10:34:20 -0800	[thread overview]
Message-ID: <ZXNhrHWLu6LydQvp@yury-ThinkPad> (raw)
In-Reply-To: <20231204191427.GA623236@bhelgaas>

On Mon, Dec 04, 2023 at 01:14:27PM -0600, Bjorn Helgaas wrote:
> On Sun, Dec 03, 2023 at 11:32:46AM -0800, Yury Norov wrote:
> > The function traverses bitmap with for_each_clear_bit() just to allocate
> > a bit atomically. We can do it better with a dedicated find_and_set_bit().
> 
> No objection from me, but please tweak the subject line to match
> previous hv history, i.e., capitalize the first word after the prefix:
> 
>   PCI: hv: Use atomic find_and_set_bit()
> 
> I think there's value in using similar phrasing across the whole
> series.  Some subjects say "optimize xyz()", some say "rework xyz()",
> some "rework xyz()", etc.  I think it's more informative to include
> the "atomic" and "find_bit()" ideas in the subject than the specific
> functions that *use* it.
> 
> I also like how some of the other commit logs clearly say what the
> patch does, e.g., "Simplify by using dedicated find_and_set_bit()", as
> opposed to just "We can do it better ..." which technically doesn't
> say what the patch does.
> 
> Very nice simplification in all these users, thanks for doing it!
> 
> I assume you'll merge these all together since they depend on [01/35],
> so:
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Thank you Bjorn!

Now as many people asked to move their subsystems patch together with
#1, I think, if no objections, it's simpler to pull all the series in
bitmap-for-next.

I'm going to align commit messages wording, as you suggested, address
some other comments, and will send v3 this weekend.

Thanks,
Yury