All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Dmitry Safonov <dima@arista.com>
Cc: Shuah Khan <shuah@kernel.org>, David Ahern <dsahern@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Salam Noureddine <noureddine@arista.com>,
	Bob Gilligan <gilligan@arista.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	netdev@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>
Subject: Re: [PATCH 02/12] selftests/net: Verify that TCP-AO complies with ignoring ICMPs
Date: Mon, 18 Dec 2023 17:03:21 +0800	[thread overview]
Message-ID: <ZYAK2U4GikRKFLQs@Laptop-X1> (raw)
In-Reply-To: <20231215-tcp-ao-selftests-v1-2-f6c08180b985@arista.com>

On Fri, Dec 15, 2023 at 02:36:16AM +0000, Dmitry Safonov wrote:
> Hand-crafted ICMP packets are sent to the server, the server checks for
> hard/soft errors and fails if any.
> 
> Expected output for ipv4 version:
> > # ./icmps-discard_ipv4
> > 1..3
> > # 3164[lib/setup.c:166] rand seed 1642623745
> > TAP version 13
> > # 3164[lib/proc.c:207]    Snmp6             Ip6InReceives: 0 => 1
> > # 3164[lib/proc.c:207]    Snmp6             Ip6InNoRoutes: 0 => 1
> > # 3164[lib/proc.c:207]    Snmp6               Ip6InOctets: 0 => 76
> > # 3164[lib/proc.c:207]    Snmp6            Ip6InNoECTPkts: 0 => 1
> > # 3164[lib/proc.c:207]      Tcp                    InSegs: 2 => 203
> > # 3164[lib/proc.c:207]      Tcp                   OutSegs: 1 => 202
> > # 3164[lib/proc.c:207]  IcmpMsg                   InType3: 0 => 543
> > # 3164[lib/proc.c:207]     Icmp                    InMsgs: 0 => 543
> > # 3164[lib/proc.c:207]     Icmp            InDestUnreachs: 0 => 543
> > # 3164[lib/proc.c:207]       Ip                InReceives: 2 => 746
> > # 3164[lib/proc.c:207]       Ip                InDelivers: 2 => 746
> > # 3164[lib/proc.c:207]       Ip               OutRequests: 1 => 202
> > # 3164[lib/proc.c:207]    IpExt                  InOctets: 132 => 61684
> > # 3164[lib/proc.c:207]    IpExt                 OutOctets: 68 => 31324
> > # 3164[lib/proc.c:207]    IpExt               InNoECTPkts: 2 => 744
> > # 3164[lib/proc.c:207]   TcpExt               TCPPureAcks: 1 => 2
> > # 3164[lib/proc.c:207]   TcpExt           TCPOrigDataSent: 0 => 200
> > # 3164[lib/proc.c:207]   TcpExt              TCPDelivered: 0 => 199
> > # 3164[lib/proc.c:207]   TcpExt                 TCPAOGood: 2 => 203
> > # 3164[lib/proc.c:207]   TcpExt         TCPAODroppedIcmps: 0 => 541
> > ok 1 InDestUnreachs delivered 543
> > ok 2 Server survived 20000 bytes of traffic
> > ok 3 ICMPs ignored 541
> > # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> Expected output for ipv6 version:
> > # ./icmps-discard_ipv6
> > 1..3
> > # 3186[lib/setup.c:166] rand seed 1642623803
> > TAP version 13
> > # 3186[lib/proc.c:207]    Snmp6             Ip6InReceives: 4 => 568
> > # 3186[lib/proc.c:207]    Snmp6             Ip6InDelivers: 3 => 564
> > # 3186[lib/proc.c:207]    Snmp6            Ip6OutRequests: 2 => 204
> > # 3186[lib/proc.c:207]    Snmp6            Ip6InMcastPkts: 1 => 4
> > # 3186[lib/proc.c:207]    Snmp6           Ip6OutMcastPkts: 0 => 1
> > # 3186[lib/proc.c:207]    Snmp6               Ip6InOctets: 320 => 70420
> > # 3186[lib/proc.c:207]    Snmp6              Ip6OutOctets: 160 => 35512
> > # 3186[lib/proc.c:207]    Snmp6          Ip6InMcastOctets: 72 => 336
> > # 3186[lib/proc.c:207]    Snmp6         Ip6OutMcastOctets: 0 => 76
> > # 3186[lib/proc.c:207]    Snmp6            Ip6InNoECTPkts: 4 => 568
> > # 3186[lib/proc.c:207]    Snmp6               Icmp6InMsgs: 1 => 361
> > # 3186[lib/proc.c:207]    Snmp6              Icmp6OutMsgs: 1 => 2
> > # 3186[lib/proc.c:207]    Snmp6       Icmp6InDestUnreachs: 0 => 360
> > # 3186[lib/proc.c:207]    Snmp6      Icmp6OutMLDv2Reports: 0 => 1
> > # 3186[lib/proc.c:207]    Snmp6              Icmp6InType1: 0 => 360
> > # 3186[lib/proc.c:207]    Snmp6           Icmp6OutType143: 0 => 1
> > # 3186[lib/proc.c:207]      Tcp                    InSegs: 2 => 203
> > # 3186[lib/proc.c:207]      Tcp                   OutSegs: 1 => 202
> > # 3186[lib/proc.c:207]   TcpExt               TCPPureAcks: 1 => 2
> > # 3186[lib/proc.c:207]   TcpExt           TCPOrigDataSent: 0 => 200
> > # 3186[lib/proc.c:207]   TcpExt              TCPDelivered: 0 => 199
> > # 3186[lib/proc.c:207]   TcpExt                 TCPAOGood: 2 => 203
> > # 3186[lib/proc.c:207]   TcpExt         TCPAODroppedIcmps: 0 => 360
> > ok 1 Icmp6InDestUnreachs delivered 360
> > ok 2 Server survived 20000 bytes of traffic
> > ok 3 ICMPs ignored 360
> > # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> Signed-off-by: Dmitry Safonov <dima@arista.com>

Tested-by: Hangbin Liu <liuhangbin@gmail.com>

  reply	other threads:[~2023-12-18  9:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15  2:36 [PATCH 00/12] selftests/net: Add TCP-AO tests Dmitry Safonov
2023-12-15  2:36 ` [PATCH 01/12] selftests/net: Add TCP-AO library Dmitry Safonov
2024-01-12 18:02   ` Nassiri, Mohammad
2023-12-15  2:36 ` [PATCH 02/12] selftests/net: Verify that TCP-AO complies with ignoring ICMPs Dmitry Safonov
2023-12-18  9:03   ` Hangbin Liu [this message]
2023-12-15  2:36 ` [PATCH 03/12] selftests/net: Add TCP-AO ICMPs accept test Dmitry Safonov
2023-12-18  9:04   ` Hangbin Liu
2023-12-15  2:36 ` [PATCH 04/12] selftests/net: Add a test for TCP-AO keys matching Dmitry Safonov
2023-12-18  9:05   ` Hangbin Liu
2023-12-15  2:36 ` [PATCH 05/12] selftests/net: Add test for TCP-AO add setsockopt() command Dmitry Safonov
2023-12-18  9:06   ` Hangbin Liu
2023-12-15  2:36 ` [PATCH 06/12] selftests/net: Add TCP-AO + TCP-MD5 + no sign listen socket tests Dmitry Safonov
2023-12-18  9:08   ` Hangbin Liu
2023-12-15  2:36 ` [PATCH 07/12] selftests/net: Add test/benchmark for removing MKTs Dmitry Safonov
2023-12-18  9:09   ` Hangbin Liu
2023-12-15  2:36 ` [PATCH 08/12] selftests/net: Add TCP_REPAIR TCP-AO tests Dmitry Safonov
2023-12-18  9:10   ` Hangbin Liu
2023-12-15  2:36 ` [PATCH 09/12] selftests/net: Add SEQ number extension test Dmitry Safonov
2023-12-18  9:11   ` Hangbin Liu
2023-12-15  2:36 ` [PATCH 10/12] selftests/net: Add TCP-AO RST test Dmitry Safonov
2023-12-18  9:11   ` Hangbin Liu
2023-12-15  2:36 ` [PATCH 11/12] selftests/net: Add TCP-AO selfconnect/simultaneous connect test Dmitry Safonov
2023-12-18  9:12   ` Hangbin Liu
2023-12-15  2:36 ` [PATCH 12/12] selftests/net: Add TCP-AO key-management test Dmitry Safonov
2024-01-12 18:57   ` Nassiri, Mohammad
2024-01-15 18:05     ` Dmitry Safonov
2024-01-15 22:26       ` Nassiri, Mohammad
2023-12-18  9:36 ` [PATCH 00/12] selftests/net: Add TCP-AO tests Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYAK2U4GikRKFLQs@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=0x7f454c46@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dima@arista.com \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=gilligan@arista.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=noureddine@arista.com \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.