From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E58BC48BEF for ; Sat, 17 Feb 2024 03:23:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rbBHy-0001eL-Tz; Fri, 16 Feb 2024 22:22:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbBHy-0001eB-4h for qemu-devel@nongnu.org; Fri, 16 Feb 2024 22:22:54 -0500 Received: from wfout6-smtp.messagingengine.com ([64.147.123.149]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbBHw-0002P0-89 for qemu-devel@nongnu.org; Fri, 16 Feb 2024 22:22:53 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.west.internal (Postfix) with ESMTP id F22F11C0008B; Fri, 16 Feb 2024 22:22:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 16 Feb 2024 22:22:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708140169; x=1708226569; bh=Yf01G1o+UqIKYBUWB3l3I2awerZSH20vNqLMgLnpFvQ=; b= SJex7i+3Guapf/FPfjKqWk1wTYsbEushu7ikiT0korY2KlM7lsdrp+CfJyDAQSzV NVNO3DCJqhSTbGyf/zOEuG2w+3GSFBin9X2ECG+l6vu9DcKzj6CkbvyptRfZTjd/ 0ithZ2XMUKWPmjS+tCGflCTjsbhkY4uzfQLWNCz4dMFd3U9r1wKRWpqE947F6DdZ hrDX1gZUd1YTB5bYkHrP+H25XwZIzkmD3yGyDUgwMslk+LMj9foaxwryfUo2hwvI 9CHIOXbpgE8B6FJpSmJmEGvKpev3hz5OegidlUGUT0bXfSop6L+MqwSlsQk25zUK Qay7AZ78REEGjHycXyy6pw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1708140169; x=1708226569; bh=Yf01G1o+UqIKYBUWB3l3I2awerZS H20vNqLMgLnpFvQ=; b=LGriUFRndYn0Gg2wp4qY+gFliYUL2uQMMZgSsk8x05jZ g5ktO6+oCLVdCwVGKQpU0aCRT6fCKl8zGu428AN15dgCuNKgoFc49b+sznJFitsM 9wqt6juyVlff73uZJz8jFwDevfZ6mvya891R/qLoXOMwBpPKcQcvs6/rhbzxGpoq AdSCaOSAPV6XQzzLI5f8R5dYy0+1BbcbmvW6DhUlksL3qa9mzrGDs9f/yk70KQAG uoBxoYpxGKHbUN7Ya4p0z44FfBGYWLo5evkJYd97IUuj5bgKsrT8oLMLMDitU6tf FYzZAebXInWdng+FG8KuWyGLE7QZxWEKBobaqcXCvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdefgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeiledu vdekjeeukefhffetgeefiefffeejjedvieejvdfgjeehteduvdekffduieenucffohhmrg hinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Feb 2024 22:22:48 -0500 (EST) Date: Sat, 17 Feb 2024 04:22:45 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH] i386: load kernel on xen using DMA Message-ID: References: <20210426034709.595432-1-marmarek@invisiblethingslab.com> <87sg1feemf.fsf@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q0+3eHKn/djYPxYa" Content-Disposition: inline In-Reply-To: <87sg1feemf.fsf@linaro.org> Received-SPF: none client-ip=64.147.123.149; envelope-from=marmarek@invisiblethingslab.com; helo=wfout6-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --Q0+3eHKn/djYPxYa Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sat, 17 Feb 2024 04:22:45 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH] i386: load kernel on xen using DMA On Fri, Jun 18, 2021 at 09:54:14AM +0100, Alex Benn=C3=A9e wrote: >=20 > Marek Marczykowski-G=C3=B3recki writes: >=20 > > Kernel on Xen is loaded via fw_cfg. Previously it used non-DMA version, > > which loaded the kernel (and initramfs) byte by byte. Change this > > to DMA, to load in bigger chunks. > > This change alone reduces load time of a (big) kernel+initramfs from > > ~10s down to below 1s. > > > > This change was suggested initially here: > > https://lore.kernel.org/xen-devel/20180216204031.000052e9@gmail.com/ > > Apparently this alone is already enough to get massive speedup. > > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > --- > > hw/i386/pc.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > index 8a84b25a03..14e43d4da4 100644 > > --- a/hw/i386/pc.c > > +++ b/hw/i386/pc.c > > @@ -839,7 +839,8 @@ void xen_load_linux(PCMachineState *pcms) > > =20 > > assert(MACHINE(pcms)->kernel_filename !=3D NULL); > > =20 > > - fw_cfg =3D fw_cfg_init_io(FW_CFG_IO_BASE); > > + fw_cfg =3D fw_cfg_init_io_dma(FW_CFG_IO_BASE, FW_CFG_IO_BASE + 4, > > + &address_space_memory); > > fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, x86ms->boot_cpus); > > rom_set_fw(fw_cfg); >=20 > Gentle ping. The fix looks perfectly sane to me but I don't have any x86 > Xen HW to test this one. Are the x86 maintainers happy to take this on? Ping... >=20 > FWIW: >=20 > Reviewed-by: Alex Benn=C3=A9e >=20 > --=20 > Alex Benn=C3=A9e >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --Q0+3eHKn/djYPxYa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmXQJoYACgkQ24/THMrX 1yymZAf8ChLekrtLpigwAq1cK/g9+kUbjLWHksGz666MCdEgd5P+Zy0KSbfa4A/6 PR2754T9zgqf5JCGFkaE9uCKYG3AtQpqXvQO7tLI4GicrIBO1YHYp094OV2F97oT KTxdR97aYPbKJ78SfRf4phU6lFq1BFFEMs9SsPEYF/g+i1AsP8m+F40AHw7CiK/G vCznXYoHwIhRFHPbf/lEkBVLHE7L7J12hMXM1Q0j7n3MMGHWMhmN9WL1T4EfSjHf oGs+2CrWIJ70LW8BbdklCZpEmH692PmuY/br+CiyauL+l4EioPtvZrm3NAlLdKet 509POMwoSg+3YNbl8aRAD1wkx7+baQ== =IVfk -----END PGP SIGNATURE----- --Q0+3eHKn/djYPxYa--