From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 82B4D481AB for ; Mon, 19 Feb 2024 18:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708366953; cv=none; b=ZsUjBlCpoOluCVbFtDK8FpzJFGOn3RAtwkjm/wx5d+k6KUM3QCcJSSfDNuEIBuIEHHb4exYNgEYsvdZkLYZ+5kM6sPPPI0mn2Ct4DRnpZPq1HPu6IRISoQUUUbetFyfVsbq2F+LbXw5CnGK7gtFqtAbFGwkL1BC6rQdPJwSAf4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708366953; c=relaxed/simple; bh=btrFO5+2vaS7IMyffuC98/87q7X/ok+FsHXq6YojZkU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WW1mHI3uStxP8pXh9s68EKJSWniNn4MQNjr1AdJ59hBYb9vDwEly3PPh6lVNK3xi46ZtghxUOdV2kbv0b/lrTuCreFy2aw5v7gp1klDv82XQU6rm9ZfyGl6yWo7FbJ6ckT0c/c0xJc+5ZtRLmTsOoTfG4Q6bN9GnV3qAIWml3dM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 63CFBFEC; Mon, 19 Feb 2024 10:23:10 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.67.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 94A623F73F; Mon, 19 Feb 2024 10:22:28 -0800 (PST) Date: Mon, 19 Feb 2024 18:22:21 +0000 From: Mark Rutland To: Arnd Bergmann Cc: Ard Biesheuvel , Geert Uytterhoeven , Fangrui Song , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jisheng Zhang , Dave Martin , Peter Smith , llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" Message-ID: References: <20240206074552.541154-1-maskray@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Feb 19, 2024 at 06:06:19PM +0100, Arnd Bergmann wrote: > On Mon, Feb 19, 2024, at 16:41, Ard Biesheuvel wrote: > > On Mon, 19 Feb 2024 at 15:43, Geert Uytterhoeven wrote: > >> On Mon, Feb 19, 2024 at 11:57 AM Ard Biesheuvel wrote: > >> > On Mon, 19 Feb 2024 at 11:56, Ard Biesheuvel wrote: > > >> > https://godbolt.org/z/GTnf3vPaT > >> > >> I could reproduce the issue on v6.8-rc5 using arm64 defconfig > >> and x86_64-gcc-5.5.0-nolibc-aarch64-linux.tar.xz from > >> https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/5.5.0/: > >> > > > > OK, I managed to do so as well. > > > > And GCC 6.4 from the same source works correctly. > > > > Not sure whether there are any plans to bump the minimal GCC version > > any time soon (cc'ing Arnd), but we should probably drop this change > > until that happens. > > From what I can tell, we may as well formally raise the minimum > gcc version to 8.1+ already, as that is a version that is > actually used in distros, and we have been on 5.1+ for a few > years already. > > Not sure if there are any other benefits to gcc-8 besides > allowing minor cleanups. Arguably a minor cleanup, but on arm64 that'd allow us to get rid of the old mcount-based ftrace implementation and rely on -fpatchable-function-entry. On its own that'd save ~130 lines of asm and ~70 lines of C, but it'd also remove some constraints on other features (e.g. the mcount-based form's graph tracer isn't compatible with pointer authentication), it would simplify a few things going forwards (e.g. the implementation of RELIABLE_STACKTRACE, since we could rely on having ftrace_regs and a single trampoline), and the remaining support would be better tested. I've wanted to remove the old ftrace implementation for a while, but on its own it was never important/urgent enough to justify bumping to GCC 8+. Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45714C48BC3 for ; Mon, 19 Feb 2024 18:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JwiWCuyPzFXyHH7JijXzg4/U6btSMBqLCStxV/hKEKw=; b=xZVLg51Vxfnui+ 1w33DibCyNGO10sB2U4YzzmrRlblE2V7fThTJgoSi/1rYGvP0iA0rlO2sgT0sPfM2S+rCMCyLsyYH uPfzTax6zkw1AzXAil+JgMWEgPB2BiEc3rY8x0YoMouigyWVN9SBnE1FNYCin6ojlaR87Rrg6i+dE rsfo0vIaFpnbKjiKW6Rr1/XFYq3fUQPZ0OyxQvaRckZ+VUzft27h1w0pqmlpgGNudX2CuaSwMat20 asIcNpvtn61em0WpYDGG7WYCKjoXXVmyNWa+6azwDIwyY5TcGQiHYdUivOvRZ2dFJJbhrrW4gIgCk GDTOeEbc8hjXEu9MRnYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc8Hn-0000000Bg6W-27el; Mon, 19 Feb 2024 18:22:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc8Hk-0000000Bg5g-2pzu for linux-arm-kernel@lists.infradead.org; Mon, 19 Feb 2024 18:22:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 63CFBFEC; Mon, 19 Feb 2024 10:23:10 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.67.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 94A623F73F; Mon, 19 Feb 2024 10:22:28 -0800 (PST) Date: Mon, 19 Feb 2024 18:22:21 +0000 From: Mark Rutland To: Arnd Bergmann Cc: Ard Biesheuvel , Geert Uytterhoeven , Fangrui Song , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jisheng Zhang , Dave Martin , Peter Smith , llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" Message-ID: References: <20240206074552.541154-1-maskray@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_102236_786609_03EEA403 X-CRM114-Status: GOOD ( 24.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBGZWIgMTksIDIwMjQgYXQgMDY6MDY6MTlQTSArMDEwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBPbiBNb24sIEZlYiAxOSwgMjAyNCwgYXQgMTY6NDEsIEFyZCBCaWVzaGV1dmVsIHdy b3RlOgo+ID4gT24gTW9uLCAxOSBGZWIgMjAyNCBhdCAxNTo0MywgR2VlcnQgVXl0dGVyaG9ldmVu IDxnZWVydEBsaW51eC1tNjhrLm9yZz4gd3JvdGU6Cj4gPj4gT24gTW9uLCBGZWIgMTksIDIwMjQg YXQgMTE6NTfigK9BTSBBcmQgQmllc2hldXZlbCA8YXJkYkBrZXJuZWwub3JnPiB3cm90ZToKPiA+ PiA+IE9uIE1vbiwgMTkgRmViIDIwMjQgYXQgMTE6NTYsIEFyZCBCaWVzaGV1dmVsIDxhcmRiQGtl cm5lbC5vcmc+IHdyb3RlOgo+IAo+ID4+ID4gaHR0cHM6Ly9nb2Rib2x0Lm9yZy96L0dUbmYzdlBh VAo+ID4+Cj4gPj4gSSBjb3VsZCByZXByb2R1Y2UgdGhlIGlzc3VlIG9uIHY2LjgtcmM1IHVzaW5n IGFybTY0IGRlZmNvbmZpZwo+ID4+IGFuZCB4ODZfNjQtZ2NjLTUuNS4wLW5vbGliYy1hYXJjaDY0 LWxpbnV4LnRhci54eiBmcm9tCj4gPj4gaHR0cHM6Ly9jZG4ua2VybmVsLm9yZy9wdWIvdG9vbHMv Y3Jvc3N0b29sL2ZpbGVzL2Jpbi94ODZfNjQvNS41LjAvOgo+ID4+Cj4gPgo+ID4gT0ssIEkgbWFu YWdlZCB0byBkbyBzbyBhcyB3ZWxsLgo+ID4KPiA+IEFuZCBHQ0MgNi40IGZyb20gdGhlIHNhbWUg c291cmNlIHdvcmtzIGNvcnJlY3RseS4KPiA+Cj4gPiBOb3Qgc3VyZSB3aGV0aGVyIHRoZXJlIGFy ZSBhbnkgcGxhbnMgdG8gYnVtcCB0aGUgbWluaW1hbCBHQ0MgdmVyc2lvbgo+ID4gYW55IHRpbWUg c29vbiAoY2MnaW5nIEFybmQpLCBidXQgd2Ugc2hvdWxkIHByb2JhYmx5IGRyb3AgdGhpcyBjaGFu Z2UKPiA+IHVudGlsIHRoYXQgaGFwcGVucy4KPiAKPiBGcm9tIHdoYXQgSSBjYW4gdGVsbCwgd2Ug bWF5IGFzIHdlbGwgZm9ybWFsbHkgcmFpc2UgdGhlIG1pbmltdW0KPiBnY2MgdmVyc2lvbiB0byA4 LjErIGFscmVhZHksIGFzIHRoYXQgaXMgYSB2ZXJzaW9uIHRoYXQgaXMKPiBhY3R1YWxseSB1c2Vk IGluIGRpc3Ryb3MsIGFuZCB3ZSBoYXZlIGJlZW4gb24gNS4xKyBmb3IgYSBmZXcKPiB5ZWFycyBh bHJlYWR5Lgo+IAo+IE5vdCBzdXJlIGlmIHRoZXJlIGFyZSBhbnkgb3RoZXIgYmVuZWZpdHMgdG8g Z2NjLTggYmVzaWRlcwo+IGFsbG93aW5nIG1pbm9yIGNsZWFudXBzLgoKQXJndWFibHkgYSBtaW5v ciBjbGVhbnVwLCBidXQgb24gYXJtNjQgdGhhdCdkIGFsbG93IHVzIHRvIGdldCByaWQgb2YgdGhl IG9sZAptY291bnQtYmFzZWQgZnRyYWNlIGltcGxlbWVudGF0aW9uIGFuZCByZWx5IG9uIC1mcGF0 Y2hhYmxlLWZ1bmN0aW9uLWVudHJ5LgpPbiBpdHMgb3duIHRoYXQnZCBzYXZlIH4xMzAgbGluZXMg b2YgYXNtIGFuZCB+NzAgbGluZXMgb2YgQywgYnV0IGl0J2QgYWxzbwpyZW1vdmUgc29tZSBjb25z dHJhaW50cyBvbiBvdGhlciBmZWF0dXJlcyAoZS5nLiB0aGUgbWNvdW50LWJhc2VkIGZvcm0ncyBn cmFwaAp0cmFjZXIgaXNuJ3QgY29tcGF0aWJsZSB3aXRoIHBvaW50ZXIgYXV0aGVudGljYXRpb24p LCBpdCB3b3VsZCBzaW1wbGlmeSBhIGZldwp0aGluZ3MgZ29pbmcgZm9yd2FyZHMgKGUuZy4gdGhl IGltcGxlbWVudGF0aW9uIG9mIFJFTElBQkxFX1NUQUNLVFJBQ0UsIHNpbmNlIHdlCmNvdWxkIHJl bHkgb24gaGF2aW5nIGZ0cmFjZV9yZWdzIGFuZCBhIHNpbmdsZSB0cmFtcG9saW5lKSwgYW5kIHRo ZSByZW1haW5pbmcKc3VwcG9ydCB3b3VsZCBiZSBiZXR0ZXIgdGVzdGVkLgoKSSd2ZSB3YW50ZWQg dG8gcmVtb3ZlIHRoZSBvbGQgZnRyYWNlIGltcGxlbWVudGF0aW9uIGZvciBhIHdoaWxlLCBidXQg b24gaXRzIG93bgppdCB3YXMgbmV2ZXIgaW1wb3J0YW50L3VyZ2VudCBlbm91Z2ggdG8ganVzdGlm eSBidW1waW5nIHRvIEdDQyA4Ky4KCk1hcmsuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==