From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B1A64414; Fri, 23 Feb 2024 07:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708672185; cv=none; b=sBctHtSs6UFbM2dZtCa4NZcUfXrMoXlRpmO/Euwc1m/NyA+gXTBmEMjyRQ6j2YdNnHk+iqAtYir58fhj5aPFJvbiArwV9c0JZJB4DMwG8cKRLFHktMELTraqDAee6CGhPkoAS2aVs7OYwCOyb6Gy4SUOL3NSOYt7b6vcTeppWEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708672185; c=relaxed/simple; bh=Zz70VcC6ec8uW9MYAOTjf18dTlcTTAeDita2hNGYrmI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RZBDAt3NpKM9xe0xlGSL2XVIv24W/JwcUAZCVCog82JR1vSPCe6gmgrDaNe1xEZ6ZA4gppJihCkHISLixtTtK3BW87cF0MlMsncu8zeCbmZjLrxzuqM5sBZsPVRPi+eDqufCTRC8ge8fvnxvBX8SNxQRUpxESBK9hCC0M8r3WAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=iwwqeyI9; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iwwqeyI9" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=m+Owkp1rvs3wqHimfEH8BwiCegvG2RGz55AKhwheUbg=; b=iwwqeyI9c3+8e3/yCE9TC/w5CH +apLO/tqnHj5OoEfskS2+ieWWgT6wYzNDVHvLRUwZCrkIRWwHo0xJ1V7anDQ2Z2tcXnO5OkeyDwlB OYvrcCpFFGqai+oPl73PV76BDln7Vcb8zlKN3VhzOYCOZ1ju0MawnKpEf/NFKZxR0Van91cOu2bbx 7yMT2BVLFcJE5nNV9q6xK60ppA8eZzGA5zDW2AkwKAregxIwBLSQT6mfq6dkikHwvD0kk8yGu3M0b evY+e5fafMmBj4yVCqPfcV9bHRRMBY26AF9b5bihcdFFw1bGbqxouM33wVdEeNI2goEITiCuBSog3 fApTjHIQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdPgi-00000008G7y-2lsb; Fri, 23 Feb 2024 07:09:40 +0000 Date: Thu, 22 Feb 2024 23:09:40 -0800 From: Christoph Hellwig To: Elliot Berman Cc: Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , Fuad Tabba , Sean Christopherson , Andrew Morton , linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v17 19/35] arch/mm: Export direct {un,}map functions Message-ID: References: <20240222-gunyah-v17-0-1e9da6763d38@quicinc.com> <20240222-gunyah-v17-19-1e9da6763d38@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222-gunyah-v17-19-1e9da6763d38@quicinc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Feb 22, 2024 at 03:16:42PM -0800, Elliot Berman wrote: > Firmware and hypervisor drivers can donate system heap memory to their > respective firmware/hypervisor entities. Those drivers should unmap the > pages from the kernel's logical map before doing so. > > Export can_set_direct_map, set_direct_map_invalid_noflush, and > set_direct_map_default_noflush. Err, not they should not. And not using such super low-level interfaces from modular code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF6B8C5478C for ; Fri, 23 Feb 2024 07:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CZ9Aq+YSGGGsc4qyumQgHdI8xAYSuvzV1oVUsZZ9Mhg=; b=WfpVuVRZBWPhHY 0QSgD9qrdNxRf4zyM3SICZezKv/CznQxS/lfAD+gmwuHFU8dDRkzss+hgKDag57WnEwivoXYbnqRB lmKMRH5YGlN7l4A4xKh+LXOhHA2IEKbc+q/T+jCMqkLI4b2GjVLIJVkQ+6oLKdy6S+dYU4d4kYwR6 3xgZ9XCgj/LsKqaG/sDl1dJHywQB30CH/+hCCyyu5do5cs6bzD8YvAT4GvZGEEMGqWx6QtqmpPoew VYwL8XYfB42KFeFXcTKO/rO0J/Tw1GLe/AQ2x4xgNmWc/xHFgjXhfU12bXuNr5kNrO2P/Jq7F291C vt1bpZdXGZKIMNZZzngQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdPgk-00000008G8l-2QLh; Fri, 23 Feb 2024 07:09:43 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdPgi-00000008G7y-2lsb; Fri, 23 Feb 2024 07:09:40 +0000 Date: Thu, 22 Feb 2024 23:09:40 -0800 From: Christoph Hellwig To: Elliot Berman Cc: Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , Fuad Tabba , Sean Christopherson , Andrew Morton , linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v17 19/35] arch/mm: Export direct {un,}map functions Message-ID: References: <20240222-gunyah-v17-0-1e9da6763d38@quicinc.com> <20240222-gunyah-v17-19-1e9da6763d38@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240222-gunyah-v17-19-1e9da6763d38@quicinc.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 22, 2024 at 03:16:42PM -0800, Elliot Berman wrote: > Firmware and hypervisor drivers can donate system heap memory to their > respective firmware/hypervisor entities. Those drivers should unmap the > pages from the kernel's logical map before doing so. > > Export can_set_direct_map, set_direct_map_invalid_noflush, and > set_direct_map_default_noflush. Err, not they should not. And not using such super low-level interfaces from modular code. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel