From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF27B8833 for ; Sun, 25 Feb 2024 07:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708845487; cv=none; b=XX8foVPv70Zk073eW10P+5LDDSPpTywieyxd64rvGug7y2X6ufUUWI7ee6/4uLXG3uKYgvDSjSX0g2kV5aNWO7hKSfG6TayeNVox1L9xlnDS+yTFLDKOSiNAZVu0OW208GIEvKjb3HoSLziX5XOzCXIyoiylqxNAJpV42OfMn84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708845487; c=relaxed/simple; bh=zZeR+n7PWvpkQ2JHycsa1jX0C5jjNU85zAeYoCrL7/E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BMbxH5WmnPnMtH5khTbUkBJw6Vs3QuxJ4Ix7OwPRsuGtxnOEVx3r+K9g6FK/FsOHUFOAK3tl85SbskCA0AeLPt5OWJEL+dGUrfkLdJ/kJNSo86ZHaf8z38zcTlAikt1uOsRbz6Pcb4CzZceMHru9+bvMr8VZ/m1oIQy4xkcb7DE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=e+HRpC9l; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="e+HRpC9l" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2d23d301452so29462171fa.1 for ; Sat, 24 Feb 2024 23:18:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1708845483; x=1709450283; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PrE6SPjvHEFxjwPlVIy+3LIJdPdKbmsIWC5aSbnqvCA=; b=e+HRpC9lSCGPhJR3647j79z1VEilhRzZcX/hs2XXyW6MFsgXxVCScPypGOSoVsoA1s KzY3ILSJVwRoKL2R2L6NLELohEWJKkC9t5QzbIm/Do13qAsNRwSbifsWQ9Dlc+1H+lYi j+T1Zm02+KOpbgAARIrjuVSqBRBuZvfyn9qhqtpx5VDOTOlpFM5M0o2PcrOp3ZejaUE+ HE2zN1Xlo0muITdtar6YmpUm56fbSjO3rhH9LGz7gEJjtyiPgmSB1SqcxnnoJeZawXvU LU1AYrQDWNgz+W9n03AkbjomPWk4s4GHXzijwTKCd6798KX5l9Xj2qKhiOcjazodFyFm 8Rvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708845483; x=1709450283; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PrE6SPjvHEFxjwPlVIy+3LIJdPdKbmsIWC5aSbnqvCA=; b=RLKf8ASp/vaDA+v07Ym+x8UDjghHJiabiBs3cOClIUqvOAV08A3i2DBcuFq/vExrnd v03C1fvL0ZIu0Cx+I5ME0XF39gXBY7msO1ipS9vV0i69RWahTcjKNpxy3G0VeZ+o+nPE X9TWLKxPTRDIwAk3eR5NvZAoORebQm40qRMMGd2eM7HKh634sH3Z25BaRXzt2IN61yNh QmhcuJM6IT8dXeC5MUqXbFokWS7Vgoh1TgmsfRrDnkbIA3hgeuLlsUsMe9EO+wF6Lyoz nddaJ1tEstqs/22WOHHs90Z96aUEkxia4CCs6N/0F3vwmlDEMLmuDpLfS3GhyTBJeOnt mrtw== X-Forwarded-Encrypted: i=1; AJvYcCWY46AoIN4Y261USjUyFZ3XXLRSX34lleWZdAXLujyo5OC88JQEEzSVFKoni5KOvusvm8x5lOciF9C+EDqkNlYk/Dhwh3Ux X-Gm-Message-State: AOJu0Yxoj62arZh+ZdMBMulP/mUaGL32TsitqhmPH/WqUMeqgvohWgIC tuFwzrrXCGZUMtdm+yKPD4FtcFQalJj9tcCshT3APU00Sqnum6J3hJ/Fcs27OnQ= X-Google-Smtp-Source: AGHT+IGcbdy4Bs2kvvhSFmFEX1zM6pEjLy9i+beyz5COb8QRME+qrUAGr7Ggv7xa/c46aE3AhjgdOg== X-Received: by 2002:a2e:2201:0:b0:2d2:6c74:58d6 with SMTP id i1-20020a2e2201000000b002d26c7458d6mr1976900lji.44.1708845482789; Sat, 24 Feb 2024 23:18:02 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id v6-20020a5d6786000000b0033dd4783058sm204275wru.9.2024.02.24.23.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 23:18:02 -0800 (PST) Date: Sun, 25 Feb 2024 08:18:00 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: Mateusz Polchlopek , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, horms@kernel.org, przemyslaw.kitszel@intel.com, Lukasz Czapnik Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param Message-ID: References: <20240219100555.7220-1-mateusz.polchlopek@intel.com> <20240219100555.7220-5-mateusz.polchlopek@intel.com> <20240221153805.20fbaf47@kernel.org> <20240222150717.627209a9@kernel.org> <20240223062757.788e686d@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223062757.788e686d@kernel.org> Fri, Feb 23, 2024 at 03:27:57PM CET, kuba@kernel.org wrote: >On Fri, 23 Feb 2024 10:45:01 +0100 Jiri Pirko wrote: >>> Jiri, I'm not aware of any other devices with this sort of trade off. >>> We shouldn't add the param if either: >>> - this can be changed dynamically as user instantiates rate limiters; >>> - we know other devices have similar needs. >>> If neither of those is true, param seems fine to me.. >> >> Where is this policy documented? If not, could you please? Let's make >> this policy clear for now and for the future. > >Because you think it's good as a policy or because not so much? >Both of the points are a judgment call, at least from upstream >perspective since we're working with very limited information. >So enshrining this as a "policy" is not very practical. No, I don't mind the policy. Up to you. Makes sense to me. I'm just saying it would be great to have this written down so everyone can easily tell which kind of param is and is not acceptable. > >Do you recall any specific param that got rejected from mlx5? >Y'all were allowed to add the eq sizing params, which I think >is not going to be mlx5-only for long. Otherwise I only remember >cases where I'd try to push people to use the resource API, which >IMO is better for setting limits and delegating resources. I don't have anything solid in mind, I would have to look it up. But there is certainly quite big amount of uncertainties among my colleagues to jundge is some param would or would not be acceptable to you. That's why I believe it would save a lot of people time to write the policy down in details, with examples, etc. Could you please? Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5E22C47DD9 for ; Sun, 25 Feb 2024 07:18:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 53E7C81FCB; Sun, 25 Feb 2024 07:18:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hwK_IgCEZrIC; Sun, 25 Feb 2024 07:18:10 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org BD5B881FCD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1708845490; bh=PrE6SPjvHEFxjwPlVIy+3LIJdPdKbmsIWC5aSbnqvCA=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=TTTnPa6M7gEmnvWd6ZnOxmgkMIhxk38MYG+WB4pGSGxifwLskRYXiGog+8oWQDwFc glAaG8UMZT5Orr6M+V72ydikUWfP6D16yh7B3m019fzPNltpx49UtC6PYZVKcxan32 BnFWFS+VauNoMMFcgBy9v/SZnDYKDDaYGVtp2bXYQhHeViIIDn/kzJ83HQbsazkth5 kxy2yOhzy4ZX8srQDAnH9xj9ZI6eMbrYpRwjTbx8IRVXeqIkesT3ZxVBjpVA0cmA/F sh68qq3k3w8QhUfB+6jX1YLTmYgcaizdN013vKx9Kgconkl7l4csR9sH5Ip5Y+3hFf OUP+utMcSNGWA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id BD5B881FCD; Sun, 25 Feb 2024 07:18:10 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C90A21BF20D for ; Sun, 25 Feb 2024 07:18:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B4C4440710 for ; Sun, 25 Feb 2024 07:18:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fi7R2f_rTZwP for ; Sun, 25 Feb 2024 07:18:07 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::22e; helo=mail-lj1-x22e.google.com; envelope-from=jiri@resnulli.us; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 04BFD4070E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 04BFD4070E Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by smtp4.osuosl.org (Postfix) with ESMTPS id 04BFD4070E for ; Sun, 25 Feb 2024 07:18:05 +0000 (UTC) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2d21cdbc85bso33741501fa.2 for ; Sat, 24 Feb 2024 23:18:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708845483; x=1709450283; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PrE6SPjvHEFxjwPlVIy+3LIJdPdKbmsIWC5aSbnqvCA=; b=ZVE67MK5AjIf8oZCg2tLtqb4MHJUmboqmfQSuVOQzpY0YcWx/UvFb6/eT96GCTlkV6 owjcm4je16tmB79b3ogzsWPES7qST6PuFit3+VNQjHH2J7CceKxDa307JETyyWlid5KF Jklmu8YB7vllR/N1rQPYxKVQDPkVZg+1muXjyBj+LmpIiUxu72PDfHxGkWhQeC2VrEHu or6J7UZxyrqC8R85OziPdzFisoU1oHXvvDeIfWbvDpUQFWKvcDQqhwK7RBiOv9mvJ3BB 5UduTisFpEc3ECTXjIGrEWLwSc9tNCFgtv1SQqORlY50RnFeNZWVlfNeWzMRbeefHCxM wsaA== X-Forwarded-Encrypted: i=1; AJvYcCXTqmIws8mcFVazb6EwrdyYk+SSFQoqnu1vBjgzWIKlMQ7WVMdroRC7Zr5Giicj60/BWtk/gvO0cvaMyJr72G6Z9t5xQBdWDkb8pT3a3YSiOA== X-Gm-Message-State: AOJu0YyobMGfZ8L29kr4Yx5Gzu1Eugun1bOJYrqXWvYbLieG6Z45emIw 04EEOZZuxTcIRYWAR4E3wk4GgGorbo1dpXqWeu5lRE1i9M3CQWm4gy7vGEd7x+I= X-Google-Smtp-Source: AGHT+IGcbdy4Bs2kvvhSFmFEX1zM6pEjLy9i+beyz5COb8QRME+qrUAGr7Ggv7xa/c46aE3AhjgdOg== X-Received: by 2002:a2e:2201:0:b0:2d2:6c74:58d6 with SMTP id i1-20020a2e2201000000b002d26c7458d6mr1976900lji.44.1708845482789; Sat, 24 Feb 2024 23:18:02 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id v6-20020a5d6786000000b0033dd4783058sm204275wru.9.2024.02.24.23.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 23:18:02 -0800 (PST) Date: Sun, 25 Feb 2024 08:18:00 +0100 From: Jiri Pirko To: Jakub Kicinski Message-ID: References: <20240219100555.7220-1-mateusz.polchlopek@intel.com> <20240219100555.7220-5-mateusz.polchlopek@intel.com> <20240221153805.20fbaf47@kernel.org> <20240222150717.627209a9@kernel.org> <20240223062757.788e686d@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223062757.788e686d@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1708845483; x=1709450283; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PrE6SPjvHEFxjwPlVIy+3LIJdPdKbmsIWC5aSbnqvCA=; b=b6BJQvCS8qBZCOV5RmxLUMtcirVjiXOE/8cX90KkG4lDP8RSQWd2zs/XxT2F8fcXqn +racL9dgYTMyTPSqF+7g0FSmsNy5b92XUrj2YQZGhH+wNwQ+oH+LWsR2nlfIPIMhnxtf KlQ1v2U23ov2Y0ubget7D5CKfeqonu5PMp3He0PqdfSO0i244GiDGwvV8DUClDP2YEov V4JQ9CUFXWXxUSM+SEkYgNDSu78sqldIu3TZnngqXPT5hDC8hyTSzmSe3Rg8y0zTjqlY L7htdmZpsh5UBs6wHZ5YccD+KtQ3yHG8xX4dZbW981ONS/4dUx1JgekyKdqkhPpunJOs jnBQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=none (p=none dis=none) header.from=resnulli.us X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=b6BJQvCS Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mateusz Polchlopek , netdev@vger.kernel.org, Lukasz Czapnik , intel-wired-lan@lists.osuosl.org, horms@kernel.org, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Fri, Feb 23, 2024 at 03:27:57PM CET, kuba@kernel.org wrote: >On Fri, 23 Feb 2024 10:45:01 +0100 Jiri Pirko wrote: >>> Jiri, I'm not aware of any other devices with this sort of trade off. >>> We shouldn't add the param if either: >>> - this can be changed dynamically as user instantiates rate limiters; >>> - we know other devices have similar needs. >>> If neither of those is true, param seems fine to me.. >> >> Where is this policy documented? If not, could you please? Let's make >> this policy clear for now and for the future. > >Because you think it's good as a policy or because not so much? >Both of the points are a judgment call, at least from upstream >perspective since we're working with very limited information. >So enshrining this as a "policy" is not very practical. No, I don't mind the policy. Up to you. Makes sense to me. I'm just saying it would be great to have this written down so everyone can easily tell which kind of param is and is not acceptable. > >Do you recall any specific param that got rejected from mlx5? >Y'all were allowed to add the eq sizing params, which I think >is not going to be mlx5-only for long. Otherwise I only remember >cases where I'd try to push people to use the resource API, which >IMO is better for setting limits and delegating resources. I don't have anything solid in mind, I would have to look it up. But there is certainly quite big amount of uncertainties among my colleagues to jundge is some param would or would not be acceptable to you. That's why I believe it would save a lot of people time to write the policy down in details, with examples, etc. Could you please? Thanks!