Re: [PATCH v5 13/13] qapi/cxl.json: Add QMP interfaces to print out accepted and pending DC extents

From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: nifan.cxl@gmail.com, qemu-devel@nongnu.org,
	linux-cxl@vger.kernel.org, gregory.price@memverge.com,
	ira.weiny@intel.com, dan.j.williams@intel.com,
	a.manzanares@samsung.com, dave@stgolabs.net,
	nmtadam.samsung@gmail.com, jim.harris@samsung.com,
	Jorgen.Hansen@wdc.com, wj28.lee@gmail.com,
	Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH v5 13/13] qapi/cxl.json: Add QMP interfaces to print out accepted and pending DC extents
Date: Tue, 5 Mar 2024 16:15:30 +0000	[thread overview]
Message-ID: <ZedFIp5gK4aXsqD-@redhat.com> (raw)
In-Reply-To: <20240305160908.000010c5@Huawei.com>

On Tue, Mar 05, 2024 at 04:09:08PM +0000, Jonathan Cameron via wrote:
> On Mon,  4 Mar 2024 11:34:08 -0800
> nifan.cxl@gmail.com wrote:
> 
> > From: Fan Ni <fan.ni@samsung.com>
> > 
> > With the change, we add the following two QMP interfaces to print out
> > extents information in the device,
> > 1. cxl-display-accepted-dc-extents: print out the accepted DC extents in
> >    the device;
> > 2. cxl-display-pending-to-add-dc-extents: print out the pending-to-add
> >    DC extents in the device;
> > The output is appended to a file passed to the command and by default
> > it is /tmp/dc-extent.txt.
> Hi Fan,
> 
> Is there precedence for this sort of logging to a file from a qmp
> command?  I can see something like this being useful.

This is pretty unusual.

For runtime debugging information our strong preference is to integrate
'trace' probes throughout the code:

  https://www.qemu.org/docs/master/devel/tracing.html#tracing

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|