From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B033EC54E68 for ; Tue, 19 Mar 2024 10:07:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.695283.1084913 (Exim 4.92) (envelope-from ) id 1rmWNO-0008Kl-5m; Tue, 19 Mar 2024 10:07:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 695283.1084913; Tue, 19 Mar 2024 10:07:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rmWNO-0008Ke-32; Tue, 19 Mar 2024 10:07:22 +0000 Received: by outflank-mailman (input) for mailman id 695283; Tue, 19 Mar 2024 10:07:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rmWNN-0008KW-90 for xen-devel@lists.xenproject.org; Tue, 19 Mar 2024 10:07:21 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78ac37aa-e5d8-11ee-afdd-a90da7624cb6; Tue, 19 Mar 2024 11:07:19 +0100 (CET) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-414645c349dso2528035e9.1 for ; Tue, 19 Mar 2024 03:07:19 -0700 (PDT) Received: from localhost ([85.31.135.62]) by smtp.gmail.com with ESMTPSA id r8-20020a05600c458800b0041409cabb39sm9594865wmo.18.2024.03.19.03.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 03:07:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78ac37aa-e5d8-11ee-afdd-a90da7624cb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1710842839; x=1711447639; darn=lists.xenproject.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=22m8F5eHnsE6I2JCG0BhWJG1Y5otjS1Oa7T2DIPkqvQ=; b=aep+QgYuiYzfNl3pR1KfjiCaU8DNBl+OQXd89fsLIiXfa0z1nFOY6ejrBDFKTJhEaj kKw+8MU9vAC9CmOFnenVHBUcePER9DjXAonadFfprvofZievOaTkxUjCvYzr11XDHI04 N8CWLg6oNQLVoF9JO+YDgOtKacH8UYksWVkPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710842839; x=1711447639; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=22m8F5eHnsE6I2JCG0BhWJG1Y5otjS1Oa7T2DIPkqvQ=; b=naCiEA85LFGhaxB3jej943lP0p8L/OXoMyhMGyhzc5E3786XMPvs/qj5o9KbV/IyvK Tuvjig3flC2KR5VFgkW6JgAZZr1G9ep1uFMbsQizhOyjARLfX47qlj+iae0ZBdn0jhaH fOY6yn6sPlGHIbU5ANCQcsy/8o7QOuahGsMGS++K5r6Cph8/JKBkcNosmwvr5nkq8aK8 YjnrmliUZmppmhEUmPtMPal2rBCqLjwZUOK99cC7KuJqIcafNJ+1/U91XLHNAw4QznSf jtCJhSNhW0cISVgjWtJbXhlI137P/XimGrRI/QxEkJd359JAJuLOxpWwMyxhfuKd53CI kubQ== X-Forwarded-Encrypted: i=1; AJvYcCUwdZFiidprK9LOj70LVDsD/ahB8yXsI2DjwOGo66cRBv2CRKT/C9mg/cWTM3bEwwnQgjIR/vKbkLXVbo6qz+tZmD7zKqydVA4w9iGcX6Y= X-Gm-Message-State: AOJu0Yz46WKZ1qfX0BpcqzktczhTdpafwB0y86UfEUCv0SS9j15ZwQKl G0lfBVCUOgmIMB/lbsKVz0VEri3PRsX+bNIj/88N7XsMvwMlU90Dz0LJYBGYQeU= X-Google-Smtp-Source: AGHT+IECcFdhl0pRbNSvdU2cfGnY0CD+EqLRB7uBA/J+1I2E/bml/msXTE5CRyPb5CGdgRevL0VsUg== X-Received: by 2002:a05:600c:5022:b0:414:e6e:756a with SMTP id n34-20020a05600c502200b004140e6e756amr2052727wmr.9.1710842839052; Tue, 19 Mar 2024 03:07:19 -0700 (PDT) Date: Tue, 19 Mar 2024 11:07:18 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ross Lagerwall Cc: grub-devel@gnu.org, xen-devel@lists.xenproject.org, Andrew Cooper , Daniel Kiper Subject: Re: [PATCH 2/7] multiboot2: Allow 64-bit entry tags Message-ID: References: <20240313150748.791236-1-ross.lagerwall@citrix.com> <20240313150748.791236-3-ross.lagerwall@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240313150748.791236-3-ross.lagerwall@citrix.com> On Wed, Mar 13, 2024 at 03:07:43PM +0000, Ross Lagerwall wrote: > Binaries may be built with entry points above 4G. While bootloaders may > relocate them below 4G, it should be possible for the binary to specify > those entry points. Therefore, extend the multiboot2 protocol such that > 64 bit addresses are allowed for entry points. The extension is done in > a backwards-compatible way. > > Signed-off-by: Ross Lagerwall > --- > doc/multiboot.texi | 32 +++++++++++++++++++------------- > doc/multiboot2.h | 6 +++++- > 2 files changed, 24 insertions(+), 14 deletions(-) > > diff --git a/doc/multiboot.texi b/doc/multiboot.texi > index d12719c744eb..049afab53c1f 100644 > --- a/doc/multiboot.texi > +++ b/doc/multiboot.texi > @@ -522,12 +522,12 @@ header. > > @example > @group > - +-------------------+ > -u16 | type = 3 | > -u16 | flags | > -u32 | size | > -u32 | entry_addr | > - +-------------------+ > + +-------------------+ > +u16 | type = 3 | > +u16 | flags | > +u32 | size | > +u32 / u64 | entry_addr | > + +-------------------+ I might be confused, but this entry point is used in 32bit protected mode, and hence a 64bit value is simply impossible to use according to the protocol in "3.3 I386 machine state". Unless that section is expanded to describe other protocols that use the entry address in a way where 64bits could be meaningful it seems pointless to expand the field. > @end group > @end example > > @@ -538,7 +538,10 @@ The meaning of each is as follows: > > @item entry_addr > The physical address to which the boot loader should jump in order to > -start running the operating system. > +start running the operating system. @samp{entry_addr} may be specified > +either as a @samp{u32} or @samp{u64}. The bootloader should use the > +header size to determine the size of @samp{entry_addr}. > + > @end table > > @subsection EFI i386 entry address tag of Multiboot2 header > @@ -573,12 +576,12 @@ tag of Multiboot2 header are ignored. > > @example > @group > - +-------------------+ > -u16 | type = 9 | > -u16 | flags | > -u32 | size | > -u32 | entry_addr | > - +-------------------+ > + +-------------------+ > +u16 | type = 9 | > +u16 | flags | > +u32 | size | > +u32 / u64 | entry_addr | > + +-------------------+ This does seem sensible. Thanks, Roger. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D877C54E5D for ; Tue, 19 Mar 2024 10:07:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmWNR-0004GK-A2; Tue, 19 Mar 2024 06:07:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmWNP-0004Fh-55 for grub-devel@gnu.org; Tue, 19 Mar 2024 06:07:23 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmWNM-0004Kv-VO for grub-devel@gnu.org; Tue, 19 Mar 2024 06:07:22 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4146178270dso5907595e9.1 for ; Tue, 19 Mar 2024 03:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1710842839; x=1711447639; darn=gnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=22m8F5eHnsE6I2JCG0BhWJG1Y5otjS1Oa7T2DIPkqvQ=; b=WZ9xZprI0c/u5nJEzN40p63V1zT+4T66tua2q8/sWVKAQGFSngWbCV2+rJPH+O3IQx c4l7zXGf55m6br4WoeSl0Qq952BHSwkd7Jg1eDKSpgAB738Nk60ASb/LRx45HiyqJPXW qCPgvgKn+D6u62In11sCtGQdBnHsFlihYZjx0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710842839; x=1711447639; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=22m8F5eHnsE6I2JCG0BhWJG1Y5otjS1Oa7T2DIPkqvQ=; b=jma2Ew3E3bsoKniyTeVlR6ZE2aD76IThrvtxXTyXwNOdQxHfebHFjEKgkP7YEIIDKt NuilCQL0wnphuA90IRq8TYbsoPCsphPFpARz456fHiXNHwC2O6x5m6eXamSOeCM/r03h 3AtZZdA8DI/OdzHrxIxQ939XRy8xyj+HM3Uguw6HjDPxIv5i7QMDLlc2TGDcmr0imnta bFoSnusWsYlODl3JZfbSnLd+cTBwIe/6CO/QBAEa2/8kqzz++i3SxEqMcj9TXGK4zXpO iIBev06GTjNHQ3AZWB9tFEkDiQa6KHedggQVbH3HHotAjl9D5dC6R4seU0HQrTiD4qLy Yw8g== X-Gm-Message-State: AOJu0YxIj9CSLFXSh1cDWPjSTI32KZI9FEwqZ5zau2mkJtMgjkJRigWk w3M7KPfhVPHcTi43JnVME6rASgryR2MSXQSEzb4JGqEyNLQP4zV24Vk1nWMtxbY= X-Google-Smtp-Source: AGHT+IECcFdhl0pRbNSvdU2cfGnY0CD+EqLRB7uBA/J+1I2E/bml/msXTE5CRyPb5CGdgRevL0VsUg== X-Received: by 2002:a05:600c:5022:b0:414:e6e:756a with SMTP id n34-20020a05600c502200b004140e6e756amr2052727wmr.9.1710842839052; Tue, 19 Mar 2024 03:07:19 -0700 (PDT) Received: from localhost ([85.31.135.62]) by smtp.gmail.com with ESMTPSA id r8-20020a05600c458800b0041409cabb39sm9594865wmo.18.2024.03.19.03.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 03:07:18 -0700 (PDT) Date: Tue, 19 Mar 2024 11:07:18 +0100 To: Ross Lagerwall Subject: Re: [PATCH 2/7] multiboot2: Allow 64-bit entry tags Message-ID: References: <20240313150748.791236-1-ross.lagerwall@citrix.com> <20240313150748.791236-3-ross.lagerwall@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240313150748.791236-3-ross.lagerwall@citrix.com> Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=roger.pau@cloud.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?utf-8?q?Roger_Pau_Monn=C3=A9_via_Grub-devel?= Reply-To: The development of GNU GRUB Cc: Roger Pau =?utf-8?B?TW9ubsOp?= , grub-devel@gnu.org, xen-devel@lists.xenproject.org, Andrew Cooper , Daniel Kiper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org T24gV2VkLCBNYXIgMTMsIDIwMjQgYXQgMDM6MDc6NDNQTSArMDAwMCwgUm9zcyBMYWdlcndhbGwg d3JvdGU6Cj4gQmluYXJpZXMgbWF5IGJlIGJ1aWx0IHdpdGggZW50cnkgcG9pbnRzIGFib3ZlIDRH LiBXaGlsZSBib290bG9hZGVycyBtYXkKPiByZWxvY2F0ZSB0aGVtIGJlbG93IDRHLCBpdCBzaG91 bGQgYmUgcG9zc2libGUgZm9yIHRoZSBiaW5hcnkgdG8gc3BlY2lmeQo+IHRob3NlIGVudHJ5IHBv aW50cy4gVGhlcmVmb3JlLCBleHRlbmQgdGhlIG11bHRpYm9vdDIgcHJvdG9jb2wgc3VjaCB0aGF0 Cj4gNjQgYml0IGFkZHJlc3NlcyBhcmUgYWxsb3dlZCBmb3IgZW50cnkgcG9pbnRzLiBUaGUgZXh0 ZW5zaW9uIGlzIGRvbmUgaW4KPiBhIGJhY2t3YXJkcy1jb21wYXRpYmxlIHdheS4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBSb3NzIExhZ2Vyd2FsbCA8cm9zcy5sYWdlcndhbGxAY2l0cml4LmNvbT4KPiAt LS0KPiAgZG9jL211bHRpYm9vdC50ZXhpIHwgMzIgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tLS0KPiAgZG9jL211bHRpYm9vdDIuaCAgIHwgIDYgKysrKystCj4gIDIgZmlsZXMgY2hhbmdl ZCwgMjQgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Rv Yy9tdWx0aWJvb3QudGV4aSBiL2RvYy9tdWx0aWJvb3QudGV4aQo+IGluZGV4IGQxMjcxOWM3NDRl Yi4uMDQ5YWZhYjUzYzFmIDEwMDY0NAo+IC0tLSBhL2RvYy9tdWx0aWJvb3QudGV4aQo+ICsrKyBi L2RvYy9tdWx0aWJvb3QudGV4aQo+IEBAIC01MjIsMTIgKzUyMiwxMiBAQCBoZWFkZXIuCj4gIAo+ ICBAZXhhbXBsZQo+ICBAZ3JvdXAKPiAtICAgICAgICArLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiAt dTE2ICAgICB8IHR5cGUgPSAzICAgICAgICAgIHwKPiAtdTE2ICAgICB8IGZsYWdzICAgICAgICAg ICAgIHwKPiAtdTMyICAgICB8IHNpemUgICAgICAgICAgICAgIHwKPiAtdTMyICAgICB8IGVudHJ5 X2FkZHIgICAgICAgIHwKPiAtICAgICAgICArLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiArICAgICAg ICAgICstLS0tLS0tLS0tLS0tLS0tLS0tKwo+ICt1MTYgICAgICAgfCB0eXBlID0gMyAgICAgICAg ICB8Cj4gK3UxNiAgICAgICB8IGZsYWdzICAgICAgICAgICAgIHwKPiArdTMyICAgICAgIHwgc2l6 ZSAgICAgICAgICAgICAgfAo+ICt1MzIgLyB1NjQgfCBlbnRyeV9hZGRyICAgICAgICB8Cj4gKyAg ICAgICAgICArLS0tLS0tLS0tLS0tLS0tLS0tLSsKCkkgbWlnaHQgYmUgY29uZnVzZWQsIGJ1dCB0 aGlzIGVudHJ5IHBvaW50IGlzIHVzZWQgaW4gMzJiaXQgcHJvdGVjdGVkCm1vZGUsIGFuZCBoZW5j ZSBhIDY0Yml0IHZhbHVlIGlzIHNpbXBseSBpbXBvc3NpYmxlIHRvIHVzZSBhY2NvcmRpbmcgdG8K dGhlIHByb3RvY29sIGluICIzLjMgSTM4NiBtYWNoaW5lIHN0YXRlIi4KClVubGVzcyB0aGF0IHNl Y3Rpb24gaXMgZXhwYW5kZWQgdG8gZGVzY3JpYmUgb3RoZXIgcHJvdG9jb2xzIHRoYXQgdXNlCnRo ZSBlbnRyeSBhZGRyZXNzIGluIGEgd2F5IHdoZXJlIDY0Yml0cyBjb3VsZCBiZSBtZWFuaW5nZnVs IGl0IHNlZW1zCnBvaW50bGVzcyB0byBleHBhbmQgdGhlIGZpZWxkLgoKPiAgQGVuZCBncm91cAo+ ICBAZW5kIGV4YW1wbGUKPiAgCj4gQEAgLTUzOCw3ICs1MzgsMTAgQEAgVGhlIG1lYW5pbmcgb2Yg ZWFjaCBpcyBhcyBmb2xsb3dzOgo+ICAKPiAgQGl0ZW0gZW50cnlfYWRkcgo+ICBUaGUgcGh5c2lj YWwgYWRkcmVzcyB0byB3aGljaCB0aGUgYm9vdCBsb2FkZXIgc2hvdWxkIGp1bXAgaW4gb3JkZXIg dG8KPiAtc3RhcnQgcnVubmluZyB0aGUgb3BlcmF0aW5nIHN5c3RlbS4KPiArc3RhcnQgcnVubmlu ZyB0aGUgb3BlcmF0aW5nIHN5c3RlbS4gQHNhbXB7ZW50cnlfYWRkcn0gbWF5IGJlIHNwZWNpZmll ZAo+ICtlaXRoZXIgYXMgYSBAc2FtcHt1MzJ9IG9yIEBzYW1we3U2NH0uIFRoZSBib290bG9hZGVy IHNob3VsZCB1c2UgdGhlCj4gK2hlYWRlciBzaXplIHRvIGRldGVybWluZSB0aGUgc2l6ZSBvZiBA c2FtcHtlbnRyeV9hZGRyfS4KPiArCj4gIEBlbmQgdGFibGUKPiAgCj4gIEBzdWJzZWN0aW9uIEVG SSBpMzg2IGVudHJ5IGFkZHJlc3MgdGFnIG9mIE11bHRpYm9vdDIgaGVhZGVyCj4gQEAgLTU3Mywx MiArNTc2LDEyIEBAIHRhZyBvZiBNdWx0aWJvb3QyIGhlYWRlciBhcmUgaWdub3JlZC4KPiAgCj4g IEBleGFtcGxlCj4gIEBncm91cAo+IC0gICAgICAgICstLS0tLS0tLS0tLS0tLS0tLS0tKwo+IC11 MTYgICAgIHwgdHlwZSA9IDkgICAgICAgICAgfAo+IC11MTYgICAgIHwgZmxhZ3MgICAgICAgICAg ICAgfAo+IC11MzIgICAgIHwgc2l6ZSAgICAgICAgICAgICAgfAo+IC11MzIgICAgIHwgZW50cnlf YWRkciAgICAgICAgfAo+IC0gICAgICAgICstLS0tLS0tLS0tLS0tLS0tLS0tKwo+ICsgICAgICAg ICAgKy0tLS0tLS0tLS0tLS0tLS0tLS0rCj4gK3UxNiAgICAgICB8IHR5cGUgPSA5ICAgICAgICAg IHwKPiArdTE2ICAgICAgIHwgZmxhZ3MgICAgICAgICAgICAgfAo+ICt1MzIgICAgICAgfCBzaXpl ICAgICAgICAgICAgICB8Cj4gK3UzMiAvIHU2NCB8IGVudHJ5X2FkZHIgICAgICAgIHwKPiArICAg ICAgICAgICstLS0tLS0tLS0tLS0tLS0tLS0tKwoKVGhpcyBkb2VzIHNlZW0gc2Vuc2libGUuCgpU aGFua3MsIFJvZ2VyLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KR3J1Yi1kZXZlbCBtYWlsaW5nIGxpc3QKR3J1Yi1kZXZlbEBnbnUub3JnCmh0dHBzOi8v bGlzdHMuZ251Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2dydWItZGV2ZWwK