From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8187E1E494; Tue, 19 Mar 2024 20:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710880060; cv=none; b=d3oWkZSssV8bhbL5nN4rksRvmzByxp2cL8QtFrskorCLOio9YT7U9Oky/y3VG86GU0/BamYiSMc0WcuYAUQFATmlzJvgvnkofCuxTeFhZNuZCSxN+n6Ftwp0Uj0REJr1zm9aZ61qkOy0TEb3GfPBJddDVjMRnnU9aCaFAuKVYpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710880060; c=relaxed/simple; bh=280xtHLxGvOmxcn1ud+ofPYxJ3fY+ofYH1kJIxf2IT0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OuYGN0n1rHU6BDNxWjaLVAh2TlAZxzqin+SyUgGAjefyLs7xW30tU4EPeKgEwe6eNLwuNkLSU2yvKWIW7SqjnUJn+KL25t+u7b4gHYGACj+i83FM8lOSinPvbzJ1KpPcKAkEBr3VkgadYSoLa9hbC1I5GI5vIt8m9zdME0ubuNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rmg32-0006OW-1A; Tue, 19 Mar 2024 20:27:00 +0000 Date: Tue, 19 Mar 2024 20:26:55 +0000 From: Daniel Golle To: Andrew Lunn Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , DENG Qingfang , Sean Wang , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Ren=E9?= van Dorst , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Message-ID: References: <20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v> <00ec9779-19ce-4005-83f0-f4abf37350fc@arinc9.com> <6cb585f6-6da8-45a2-a28b-2fb556f95672@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6cb585f6-6da8-45a2-a28b-2fb556f95672@lunn.ch> On Tue, Mar 19, 2024 at 08:38:03PM +0100, Andrew Lunn wrote: > > I would argue that EEE advertisement on the PHY should be enabled by > > default. > > That is an open question at the moment. For some use cases, it can add > extra delay and jitter which can cause problems. I've heard people > doing PTP don't like EEE for example. MediaTek consumer-grade hardware doesn't support PTP and hence that quite certainly won't ever be an issue with all switch ICs supported by the mt7530 driver. I'd rather first change the (configuration) default in OpenWrt (which is arguable the way most people are using this hardware), also because that will be more visible/obvious for users. Or even just make EEE configurable in the LuCI web-UI as a first step so users start playing with it. After all, I also have a hard time imagining that MediaTek disabled EEE in their downstream driver for no reason: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/24091177a18ba7f2dd8d928a8f5b27b14df46b16 > > The current phylib core code leaves the PHY advertisement whatever its > reset default is. So we leave it to the manufacture to decide if it > should be enabled or disabled by default. It is policy, so it should > really be down to user space to configure EEE how it wants it. I very much agree with that policy, changing the default definitely feels like something which could affect quite a lot of people and should be done very carefully, if at all. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8105BC54E71 for ; Tue, 19 Mar 2024 20:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rK+/JUwQ9An6X0vZuDNbic2kzrijGq9qrItyvUrWOTE=; b=qAJ+wlsNRdJESa yCe/tmdV/eI0fNFY9Qo4KxwUyhwUH8opD4/8bkH1bcZpRncHikt3xwtmDCnzuZajxqcxAQzkB/XVC mCf768sQ+t+ykbL4kSPTrreZuodKM4Lg+tXq5bQf+ApXouBa0Z+FjjRNlomTYX6r94/kPVp8Vq4cb hSRVLCcDDYmwLflv17XKlwUSEwhBgXRt3TbMcvLUenpGRur8LdNdjn1u00WXz3bBZKOPOj0bZQTgs PyFRaLcahYwBYA2mU0xHKEunyX+HhEH3FBW0oYQBYvcF1Fl8cMbZ2olD/C5p1CDPBOBD78CrFvdDn orVUoO4gQEH22W7TOz2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmg3n-0000000E7rf-45mp; Tue, 19 Mar 2024 20:27:47 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmg3k-0000000E7qu-0DbC; Tue, 19 Mar 2024 20:27:45 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rmg32-0006OW-1A; Tue, 19 Mar 2024 20:27:00 +0000 Date: Tue, 19 Mar 2024 20:26:55 +0000 From: Daniel Golle To: Andrew Lunn Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , DENG Qingfang , Sean Wang , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Ren=E9?= van Dorst , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Message-ID: References: <20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v> <00ec9779-19ce-4005-83f0-f4abf37350fc@arinc9.com> <6cb585f6-6da8-45a2-a28b-2fb556f95672@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6cb585f6-6da8-45a2-a28b-2fb556f95672@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_132744_119707_EC266DD6 X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 19, 2024 at 08:38:03PM +0100, Andrew Lunn wrote: > > I would argue that EEE advertisement on the PHY should be enabled by > > default. > > That is an open question at the moment. For some use cases, it can add > extra delay and jitter which can cause problems. I've heard people > doing PTP don't like EEE for example. MediaTek consumer-grade hardware doesn't support PTP and hence that quite certainly won't ever be an issue with all switch ICs supported by the mt7530 driver. I'd rather first change the (configuration) default in OpenWrt (which is arguable the way most people are using this hardware), also because that will be more visible/obvious for users. Or even just make EEE configurable in the LuCI web-UI as a first step so users start playing with it. After all, I also have a hard time imagining that MediaTek disabled EEE in their downstream driver for no reason: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/24091177a18ba7f2dd8d928a8f5b27b14df46b16 > > The current phylib core code leaves the PHY advertisement whatever its > reset default is. So we leave it to the manufacture to decide if it > should be enabled or disabled by default. It is policy, so it should > really be down to user space to configure EEE how it wants it. I very much agree with that policy, changing the default definitely feels like something which could affect quite a lot of people and should be done very carefully, if at all. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel