From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C280D33CD0; Tue, 19 Mar 2024 18:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710872761; cv=none; b=cjhsWe/pJgmszeUFlvuB7KuKNsVR56jPtVtHIuPGSRjaeIHtQFX9tKq9r7qy0xQAx2dAGveWmiliF03SWpV9c7bq7Ibqj7ziIn7DUzCfFKNRUuVogmtwlUFAWs+O7mDeSDtA4pMUKOKN3+l9JI06HBpAuHifvOv+o0FzhHtTctg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710872761; c=relaxed/simple; bh=+B2/YuQBg7yNiILnBdMyRTQ5naKzC7rhn0eUUKSPVr0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KpDU+oIP80SOuD2ltCK1SQoLWohYQESmGe7437oOewSl/9aPwy1093c8uKQKwwu/fAYt52z45g5IOAbNxpGjvDYknuGsvLtu9NR384A1liIo4NZ8qeoIY/QcCSnnXzyOfKqm573tgXdjApub1K9D9WngRANXbtACB1YAJ92ocwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rme9R-0005tO-32; Tue, 19 Mar 2024 18:25:30 +0000 Date: Tue, 19 Mar 2024 18:25:22 +0000 From: Daniel Golle To: arinc.unal@arinc9.com Cc: DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Ren=E9?= van Dorst , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Message-ID: References: <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?=> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?=> On Mon, Mar 18, 2024 at 10:46:22AM +0300, Arınç ÜNAL via B4 Relay wrote: > Hi. > > This patch series fixes EEE support for MT7531 and the switch on the MT7988 > SoC. EEE did not work on MT7531 on most boards before this, it is unclear > what's the status on MT7988 SoC switch as I don't have the hardware. EEE seems to already work just fine on the MT7988 built-in switch, at least on the BPI-R4. I don't think the SoC has bootstrap pins related to EEE like stand-alone MT753x may have. root@bpi-r4:~# ethtool --show-eee lan1 EEE settings for lan1: EEE status: disabled Tx LPI: 30 (us) Supported EEE link modes: 100baseT/Full 1000baseT/Full Advertised EEE link modes: Not reported Link partner advertised EEE link modes: 100baseT/Full 1000baseT/Full root@bpi-r4:~# ethtool --set-eee lan1 eee on root@bpi-r4:~# ethtool --show-eee lan1 EEE settings for lan1: EEE status: enabled - inactive Tx LPI: 30 (us) Supported EEE link modes: 100baseT/Full 1000baseT/Full Advertised EEE link modes: 100baseT/Full 1000baseT/Full Link partner advertised EEE link modes: Not reported root@bpi-r4:~# ethtool --show-eee lan1 EEE settings for lan1: EEE status: enabled - active Tx LPI: 30 (us) Supported EEE link modes: 100baseT/Full 1000baseT/Full Advertised EEE link modes: 100baseT/Full 1000baseT/Full Link partner advertised EEE link modes: 100baseT/Full 1000baseT/Full So don't fix if it ain't broken maybe...? > > Signed-off-by: Arınç ÜNAL > --- > Arınç ÜNAL (3): > net: dsa: mt7530: fix enabling EEE on MT7531 switch on all boards > net: dsa: mt7530: fix disabling EEE on failure on MT7531 and MT7988 > net: phy: mediatek-ge: do not disable EEE advertisement > > drivers/net/dsa/mt7530.c | 7 +++++++ > drivers/net/dsa/mt7530.h | 7 ++++++- > drivers/net/phy/mediatek-ge.c | 3 --- > 3 files changed, 13 insertions(+), 4 deletions(-) > --- > base-commit: ea80e3ed09ab2c2b75724faf5484721753e92c31 > change-id: 20240317-for-net-mt7530-fix-eee-for-mt7531-mt7988-a5c5453cc0e8 > > Best regards, > -- > Arınç ÜNAL > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC159C54E68 for ; Tue, 19 Mar 2024 18:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LH+rOrFATj8AN+dvwRedwZe2yn3Uj5fVRV5NE5QCMIA=; b=m4jT2dSRlpx1IF kUdPVrfGu4Npg7LA1GQubs5XppKYwYaznpBDD1XEF8SpjoaWq6VSV2XcqBmoRx4ZzWgFlcAPICfdq 5f9LY7VkaUuk3v86TM4YXZAULyUMUm+ABpMKUKNjG/h1HeKc0dm24nbFNoMOGxkyRvXhujHGRLs9w 5Tse2WdTAjgkT9PMf0tU+wyusfjpj86ppagtBRuuyz46suY7SBUx0aYF3EOe6RmoPVuuRhttsDxWP gxR/iQhORe19qLe4B3pVgICwbMvRtFLrRewqYM1GY1ljbBlZBRuLzqm/T0A+1tLFWkh/HLC1ILTD3 aKcSXTwqYea6hRpx5VOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rme9x-0000000DoRP-0CoQ; Tue, 19 Mar 2024 18:26:01 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rme9u-0000000DoP1-0jsT; Tue, 19 Mar 2024 18:25:59 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rme9R-0005tO-32; Tue, 19 Mar 2024 18:25:30 +0000 Date: Tue, 19 Mar 2024 18:25:22 +0000 From: Daniel Golle To: arinc.unal@arinc9.com Cc: DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Ren=E9?= van Dorst , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Message-ID: References: <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?=> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?=> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_112558_269920_945AF24D X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMTgsIDIwMjQgYXQgMTA6NDY6MjJBTSArMDMwMCwgQXLEsW7DpyDDnE5BTCB2 aWEgQjQgUmVsYXkgd3JvdGU6Cj4gSGkuCj4gCj4gVGhpcyBwYXRjaCBzZXJpZXMgZml4ZXMgRUVF IHN1cHBvcnQgZm9yIE1UNzUzMSBhbmQgdGhlIHN3aXRjaCBvbiB0aGUgTVQ3OTg4Cj4gU29DLiBF RUUgZGlkIG5vdCB3b3JrIG9uIE1UNzUzMSBvbiBtb3N0IGJvYXJkcyBiZWZvcmUgdGhpcywgaXQg aXMgdW5jbGVhcgo+IHdoYXQncyB0aGUgc3RhdHVzIG9uIE1UNzk4OCBTb0Mgc3dpdGNoIGFzIEkg ZG9uJ3QgaGF2ZSB0aGUgaGFyZHdhcmUuCgpFRUUgc2VlbXMgdG8gYWxyZWFkeSB3b3JrIGp1c3Qg ZmluZSBvbiB0aGUgTVQ3OTg4IGJ1aWx0LWluIHN3aXRjaCwgYXQgbGVhc3QKb24gdGhlIEJQSS1S NC4gSSBkb24ndCB0aGluayB0aGUgU29DIGhhcyBib290c3RyYXAgcGlucyByZWxhdGVkIHRvIEVF RSBsaWtlCnN0YW5kLWFsb25lIE1UNzUzeCBtYXkgaGF2ZS4KCnJvb3RAYnBpLXI0On4jIGV0aHRv b2wgLS1zaG93LWVlZSBsYW4xCkVFRSBzZXR0aW5ncyBmb3IgbGFuMToKICAgIEVFRSBzdGF0dXM6 IGRpc2FibGVkCiAgICBUeCBMUEk6IDMwICh1cykKICAgIFN1cHBvcnRlZCBFRUUgbGluayBtb2Rl czogIDEwMGJhc2VUL0Z1bGwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDEwMDBiYXNl VC9GdWxsCiAgICBBZHZlcnRpc2VkIEVFRSBsaW5rIG1vZGVzOiAgTm90IHJlcG9ydGVkCiAgICBM aW5rIHBhcnRuZXIgYWR2ZXJ0aXNlZCBFRUUgbGluayBtb2RlczogIDEwMGJhc2VUL0Z1bGwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMTAwMGJhc2VUL0Z1bGwK CnJvb3RAYnBpLXI0On4jIGV0aHRvb2wgLS1zZXQtZWVlIGxhbjEgZWVlIG9uCnJvb3RAYnBpLXI0 On4jIGV0aHRvb2wgLS1zaG93LWVlZSBsYW4xCkVFRSBzZXR0aW5ncyBmb3IgbGFuMToKICAgIEVF RSBzdGF0dXM6IGVuYWJsZWQgLSBpbmFjdGl2ZQogICAgVHggTFBJOiAzMCAodXMpCiAgICBTdXBw b3J0ZWQgRUVFIGxpbmsgbW9kZXM6ICAxMDBiYXNlVC9GdWxsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAxMDAwYmFzZVQvRnVsbAogICAgQWR2ZXJ0aXNlZCBFRUUgbGluayBtb2Rlczog IDEwMGJhc2VUL0Z1bGwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAxMDAwYmFzZVQv RnVsbAogICAgTGluayBwYXJ0bmVyIGFkdmVydGlzZWQgRUVFIGxpbmsgbW9kZXM6ICBOb3QgcmVw b3J0ZWQKcm9vdEBicGktcjQ6fiMgZXRodG9vbCAtLXNob3ctZWVlIGxhbjEKRUVFIHNldHRpbmdz IGZvciBsYW4xOgogICAgRUVFIHN0YXR1czogZW5hYmxlZCAtIGFjdGl2ZQogICAgVHggTFBJOiAz MCAodXMpCiAgICBTdXBwb3J0ZWQgRUVFIGxpbmsgbW9kZXM6ICAxMDBiYXNlVC9GdWxsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAxMDAwYmFzZVQvRnVsbAogICAgQWR2ZXJ0aXNlZCBF RUUgbGluayBtb2RlczogIDEwMGJhc2VUL0Z1bGwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAxMDAwYmFzZVQvRnVsbAogICAgTGluayBwYXJ0bmVyIGFkdmVydGlzZWQgRUVFIGxpbmsg bW9kZXM6ICAxMDBiYXNlVC9GdWxsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIDEwMDBiYXNlVC9GdWxsCgpTbyBkb24ndCBmaXggaWYgaXQgYWluJ3QgYnJva2Vu IG1heWJlLi4uPwoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBBcsSxbsOnIMOcTkFMIDxhcmluYy51bmFs QGFyaW5jOS5jb20+Cj4gLS0tCj4gQXLEsW7DpyDDnE5BTCAoMyk6Cj4gICAgICAgbmV0OiBkc2E6 IG10NzUzMDogZml4IGVuYWJsaW5nIEVFRSBvbiBNVDc1MzEgc3dpdGNoIG9uIGFsbCBib2FyZHMK PiAgICAgICBuZXQ6IGRzYTogbXQ3NTMwOiBmaXggZGlzYWJsaW5nIEVFRSBvbiBmYWlsdXJlIG9u IE1UNzUzMSBhbmQgTVQ3OTg4Cj4gICAgICAgbmV0OiBwaHk6IG1lZGlhdGVrLWdlOiBkbyBub3Qg ZGlzYWJsZSBFRUUgYWR2ZXJ0aXNlbWVudAo+IAo+ICBkcml2ZXJzL25ldC9kc2EvbXQ3NTMwLmMg ICAgICB8IDcgKysrKysrKwo+ICBkcml2ZXJzL25ldC9kc2EvbXQ3NTMwLmggICAgICB8IDcgKysr KysrLQo+ICBkcml2ZXJzL25ldC9waHkvbWVkaWF0ZWstZ2UuYyB8IDMgLS0tCj4gIDMgZmlsZXMg Y2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAtLS0KPiBiYXNlLWNv bW1pdDogZWE4MGUzZWQwOWFiMmMyYjc1NzI0ZmFmNTQ4NDcyMTc1M2U5MmMzMQo+IGNoYW5nZS1p ZDogMjAyNDAzMTctZm9yLW5ldC1tdDc1MzAtZml4LWVlZS1mb3ItbXQ3NTMxLW10Nzk4OC1hNWM1 NDUzY2MwZTgKPiAKPiBCZXN0IHJlZ2FyZHMsCj4gLS0gCj4gQXLEsW7DpyDDnE5BTCA8YXJpbmMu dW5hbEBhcmluYzkuY29tPgo+IAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=