From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44414C54E58 for ; Wed, 20 Mar 2024 10:46:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmtSe-0002ns-AK; Wed, 20 Mar 2024 06:46:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmtST-0002nW-Pc for qemu-devel@nongnu.org; Wed, 20 Mar 2024 06:46:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmtSS-00084T-6e for qemu-devel@nongnu.org; Wed, 20 Mar 2024 06:46:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710931566; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=VcqbGzJDsoqa/tkbrawIaj6+8GThlodPeknsR4cunAw=; b=Fkc17MtIUnkZXM8+WkzloxF1aIDqSAGzmPAr8X48VyA2Inec/UTjaP27jbumbXtdqH8Zks kXukpt1tUwYHNFBKdi8VLz4VQDozT3YKU5xpAYYwfHxWEGeYKpfbIThPS8JCIeFU1gtg4Y gtdxYMMplMAItsdC97d1VEWpqA79DQE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-1mBMQmyYOO-XGiAeNRyepQ-1; Wed, 20 Mar 2024 06:46:03 -0400 X-MC-Unique: 1mBMQmyYOO-XGiAeNRyepQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A5F003800BAD; Wed, 20 Mar 2024 10:46:02 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A93D517A91; Wed, 20 Mar 2024 10:46:00 +0000 (UTC) Date: Wed, 20 Mar 2024 10:45:54 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yuan Liu Cc: peterx@redhat.com, farosas@suse.de, qemu-devel@nongnu.org, hao.xiang@bytedance.com, bryan.zhang@bytedance.com, nanhai.zou@intel.com Subject: Re: [PATCH v5 7/7] tests/migration-test: add qpl compression test Message-ID: References: <20240319164527.1873891-1-yuan1.liu@intel.com> <20240319164527.1873891-8-yuan1.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240319164527.1873891-8-yuan1.liu@intel.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.417, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Mar 20, 2024 at 12:45:27AM +0800, Yuan Liu wrote: > add qpl to compression method test for multifd migration > > the migration with qpl compression needs to access IAA hardware > resource, please run "check-qtest" with sudo or root permission, > otherwise migration test will fail That's not an acceptable requirement. If someone builds QEMU with QPL, the migration test *must* pass 100% reliably when either running on a host without the QPL required hardware, or when lacking permissions. The test case needs to detect these scenarios and automatically skip the test if it is incapable of running successfully. This raises another question though. If QPL migration requires running as root, then it is effectively unusable for QEMU, as no sane deployment ever runs QEMU as root. Is there a way to make QPL work for non-root users ? > > Signed-off-by: Yuan Liu > Reviewed-by: Nanhai Zou > --- > tests/qtest/migration-test.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 71895abb7f..052d0d60fd 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -2815,6 +2815,15 @@ test_migrate_precopy_tcp_multifd_zstd_start(QTestState *from, > } > #endif /* CONFIG_ZSTD */ > > +#ifdef CONFIG_QPL > +static void * > +test_migrate_precopy_tcp_multifd_qpl_start(QTestState *from, > + QTestState *to) > +{ > + return test_migrate_precopy_tcp_multifd_start_common(from, to, "qpl"); > +} > +#endif /* CONFIG_QPL */ > + > static void test_multifd_tcp_none(void) > { > MigrateCommon args = { > @@ -2880,6 +2889,17 @@ static void test_multifd_tcp_zstd(void) > } > #endif > > +#ifdef CONFIG_QPL > +static void test_multifd_tcp_qpl(void) > +{ > + MigrateCommon args = { > + .listen_uri = "defer", > + .start_hook = test_migrate_precopy_tcp_multifd_qpl_start, > + }; > + test_precopy_common(&args); > +} > +#endif > + > #ifdef CONFIG_GNUTLS > static void * > test_migrate_multifd_tcp_tls_psk_start_match(QTestState *from, > @@ -3789,6 +3809,10 @@ int main(int argc, char **argv) > migration_test_add("/migration/multifd/tcp/plain/zstd", > test_multifd_tcp_zstd); > #endif > +#ifdef CONFIG_QPL > + migration_test_add("/migration/multifd/tcp/plain/qpl", > + test_multifd_tcp_qpl); > +#endif > #ifdef CONFIG_GNUTLS > migration_test_add("/migration/multifd/tcp/tls/psk/match", > test_multifd_tcp_tls_psk_match); > -- > 2.39.3 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|