From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34A2E3BBFA; Wed, 20 Mar 2024 11:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710932934; cv=none; b=b4vunODEKQhwh3pBnwaE3cCvQWil0GpUJ9cb9F2YjhzR7IcTpOdzBuRqyjKws99SNCBeRk/Of8ASObuKOqhXN6RkfgLXU3Gou3rv7ZpjIAZ91U3fniTwo2a03NLfl5vNcdayhahlkpgk76y5yy1Ftpunz9fzivCfXGhWEnzfRr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710932934; c=relaxed/simple; bh=GVLutt18GQlJPG4WB2z9PrJepa+Hhk6WaYlpmouuWbo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bJdN8Jg2hvPkuOEstgUTl6ZAlU32JLnEIeAEgva18tjs0eBtUcCGDC6AiB1P/Y+fRp3084+K6l2LL/mHQfLRbhSDfJT+bvqBNvHO6ANq0SJY3paHMR1rXoJ5cazbDpdhKSlnt8usrYVndEja4KCMvRgylhB3HfqdcCpiAte055c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rmtnv-00017k-0M; Wed, 20 Mar 2024 11:08:19 +0000 Date: Wed, 20 Mar 2024 11:08:12 +0000 From: Daniel Golle To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Ren=E9?= van Dorst , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Message-ID: References: <20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v1-0-3f17226344e8@arinc9.com> <9d111cc9-c73a-4d3c-83f5-3f59e6c8841f@arinc9.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d111cc9-c73a-4d3c-83f5-3f59e6c8841f@arinc9.com> On Wed, Mar 20, 2024 at 11:10:19AM +0300, Arınç ÜNAL wrote: > On 18.03.2024 10:46, Arınç ÜNAL via B4 Relay wrote: > > Hi. > > > > This patch series fixes EEE support for MT7531 and the switch on the MT7988 > > SoC. EEE did not work on MT7531 on most boards before this, it is unclear > > what's the status on MT7988 SoC switch as I don't have the hardware. > > > > Signed-off-by: Arınç ÜNAL > > I see the state of this patch series is deferred on patchwork. I see that I > forgot to delegate this to the net tree. As I don't see any objections in > this series, I'll send v2 with it tomorrow. Sorry, but imho it should go to net-next, and you might have overlook it but there have been some concerns. For sure it should not go to net tree as you are enabling a new feature and not fixing anything which is broken. EEE on MT7988 works fine as of now (see my reply), EEE on MT7531 was supposedly intentionally disabled for reasons we should ask MTK people about. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72055C54E58 for ; Wed, 20 Mar 2024 11:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MlqDeUf1bNPYRpvD9XrafyueRPiX6WhCOjz1WdOC4IE=; b=gIRiyZkXFkvzTb wU391SvfESvqkjTM2P7MBSYltPmUTK3tDQIdmpOGUbQP7IfqVg/4MTJSUoq5Nn9UedsTOYDkEEspA NE+wiUUI3I1WgbipmFY9SM9IFWdA2C678RJ349rM3QanlM+qyRyNakLVcFvEBz3ctRqWmQnZo11z9 rv4/njALoqJU0PLt6fgt8F6oNoHBDOw7HgpPufUlU8Lt3P15Ko2YYtb/3nm4FBRt2kKInQZq+1LFi dJRf1Hd484RVLZa1A0r4fYQ2YSTxwmd0BT3z8mFcZ8+WxOCAQoZLtuDoO8lgT8EPborC/Q7wbdy7K I4K1s+je9RpulAnTuLgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmtoW-0000000GtTx-1uv3; Wed, 20 Mar 2024 11:08:56 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmtoT-0000000GtQz-1MaS; Wed, 20 Mar 2024 11:08:54 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rmtnv-00017k-0M; Wed, 20 Mar 2024 11:08:19 +0000 Date: Wed, 20 Mar 2024 11:08:12 +0000 From: Daniel Golle To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Ren=E9?= van Dorst , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Message-ID: References: <20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v1-0-3f17226344e8@arinc9.com> <9d111cc9-c73a-4d3c-83f5-3f59e6c8841f@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9d111cc9-c73a-4d3c-83f5-3f59e6c8841f@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240320_040853_398640_83541866 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXIgMjAsIDIwMjQgYXQgMTE6MTA6MTlBTSArMDMwMCwgQXLEsW7DpyDDnE5BTCB3 cm90ZToKPiBPbiAxOC4wMy4yMDI0IDEwOjQ2LCBBcsSxbsOnIMOcTkFMIHZpYSBCNCBSZWxheSB3 cm90ZToKPiA+IEhpLgo+ID4gCj4gPiBUaGlzIHBhdGNoIHNlcmllcyBmaXhlcyBFRUUgc3VwcG9y dCBmb3IgTVQ3NTMxIGFuZCB0aGUgc3dpdGNoIG9uIHRoZSBNVDc5ODgKPiA+IFNvQy4gRUVFIGRp ZCBub3Qgd29yayBvbiBNVDc1MzEgb24gbW9zdCBib2FyZHMgYmVmb3JlIHRoaXMsIGl0IGlzIHVu Y2xlYXIKPiA+IHdoYXQncyB0aGUgc3RhdHVzIG9uIE1UNzk4OCBTb0Mgc3dpdGNoIGFzIEkgZG9u J3QgaGF2ZSB0aGUgaGFyZHdhcmUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEFyxLFuw6cgw5xO QUwgPGFyaW5jLnVuYWxAYXJpbmM5LmNvbT4KPiAKPiBJIHNlZSB0aGUgc3RhdGUgb2YgdGhpcyBw YXRjaCBzZXJpZXMgaXMgZGVmZXJyZWQgb24gcGF0Y2h3b3JrLiBJIHNlZSB0aGF0IEkKPiBmb3Jn b3QgdG8gZGVsZWdhdGUgdGhpcyB0byB0aGUgbmV0IHRyZWUuIEFzIEkgZG9uJ3Qgc2VlIGFueSBv YmplY3Rpb25zIGluCj4gdGhpcyBzZXJpZXMsIEknbGwgc2VuZCB2MiB3aXRoIGl0IHRvbW9ycm93 LgoKU29ycnksIGJ1dCBpbWhvIGl0IHNob3VsZCBnbyB0byBuZXQtbmV4dCwgYW5kIHlvdSBtaWdo dCBoYXZlIG92ZXJsb29rCml0IGJ1dCB0aGVyZSBoYXZlIGJlZW4gc29tZSBjb25jZXJucy4KCkZv ciBzdXJlIGl0IHNob3VsZCBub3QgZ28gdG8gbmV0IHRyZWUgYXMgeW91IGFyZSBlbmFibGluZyBh IG5ldyBmZWF0dXJlCmFuZCBub3QgZml4aW5nIGFueXRoaW5nIHdoaWNoIGlzIGJyb2tlbi4gRUVF IG9uIE1UNzk4OCB3b3JrcyBmaW5lIGFzCm9mIG5vdyAoc2VlIG15IHJlcGx5KSwgRUVFIG9uIE1U NzUzMSB3YXMgc3VwcG9zZWRseSBpbnRlbnRpb25hbGx5CmRpc2FibGVkIGZvciByZWFzb25zIHdl IHNob3VsZCBhc2sgTVRLIHBlb3BsZSBhYm91dC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK