From: Sasha Levin <sashal@kernel.org>
To: Ralph Siemsen <ralph.siemsen@linaro.org>
Cc: gregkh@linuxfoundation.org, herbert@gondor.apana.org.au,
patches@lists.linux.dev, stable@vger.kernel.org
Subject: Re: v4.19 backport request for crypto af_alg
Date: Wed, 20 Mar 2024 11:38:12 -0400 [thread overview]
Message-ID: <ZfsC5FvYwg85nc9o@sashalap> (raw)
In-Reply-To: <20240320143143.1643630-1-ralph.siemsen@linaro.org>
On Wed, Mar 20, 2024 at 10:31:43AM -0400, Ralph Siemsen wrote:
>I have found a regression in userspace behaviour after commit 67b164a871a
>got backported into 4.19.306 as commit 19af0310c8767. The regression
>can be fixed by backporting two additional commits, detailed below.
>
>The regression can be reproduced with the following sequence:
>
>echo some text > plain.txt
>openssl enc -k mysecret -aes-256-cbc -in plain.txt -out cipher.txt -engine afalg
>
>It fails intermittently with the message "error writing to file", but
>this error is a bit misleading, the actual problem is that the kernel
>returns -16 (EBUSY) on the encoding operation.
>
>The EBUSY comes from the newly added in-flight check. This check is correct,
>however it fails on 4.19 kernel, because it is missing two earlier commits:
>
>f3c802a1f3001 crypto: algif_aead - Only wake up when ctx->more is zero
>21dfbcd1f5cbf crypto: algif_aead - fix uninitialized ctx->init
>
>I was able to cherry-pick those into 4.19.y, with just a minor conflict
>in one case. With those applied, the openssl command no longer fails.
>
>Similar fixes are likely needed in 5.4.y, however I did not test this.
>
>No change is needed in 5.10 or newer, as the two commits are present.
>
>Please add the two commits to 4.19.y (and probably also 5.4.y).
I'll add both to 4.19. They already exist in 5.4. Thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2024-03-20 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 14:31 v4.19 backport request for crypto af_alg Ralph Siemsen
2024-03-20 15:38 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfsC5FvYwg85nc9o@sashalap \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=patches@lists.linux.dev \
--cc=ralph.siemsen@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.