All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	Dave Jiang <dave.jiang@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-cxl@vger.kernel.org
Subject: Re: [PATCH 1/4] cxl/region: Move cxl_dpa_to_region() work to the region driver
Date: Thu, 4 Apr 2024 08:08:08 -0700	[thread overview]
Message-ID: <Zg7CWDe6F1uW+3cN@aschofie-mobl2> (raw)
In-Reply-To: <20240403182448.00003c79@Huawei.com>

On Wed, Apr 03, 2024 at 06:24:48PM +0100, Jonathan Cameron wrote:
> On Wed, 27 Mar 2024 21:36:30 -0700
> alison.schofield@intel.com wrote:
> 
> > From: Alison Schofield <alison.schofield@intel.com>
> > 
> > This helper belongs in the region driver as it is only useful
> > with CONFIG_CXL_REGION. Add stubs in core.h for when the region
> stub
> 
> > driver is not built.
> > 
> > Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> Otherwise, does what is says on the tin.
s/is/it

And TIL:
"It does exactly what it says on the tin" was originally an advertising
slogan in the United Kingdom, which then became a common idiomatic phrase
in that country. It colloquially means that the name of something is an
accurate description of its qualities." Wikipedia

Watch for reuse in my reviews.

Thanks Jonathan!
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 

  reply	other threads:[~2024-04-04 15:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28  4:36 [PATCH 0/4] Add DPA->HPA translation to dram & general_media alison.schofield
2024-03-28  4:36 ` [PATCH 1/4] cxl/region: Move cxl_dpa_to_region() work to the region driver alison.schofield
2024-04-03 17:24   ` Jonathan Cameron
2024-04-04 15:08     ` Alison Schofield [this message]
2024-04-16 15:59   ` Ira Weiny
2024-03-28  4:36 ` [PATCH 2/4] cxl/region: Move cxl_trace_hpa() " alison.schofield
2024-04-03 17:27   ` Jonathan Cameron
2024-04-16 16:05   ` Ira Weiny
2024-03-28  4:36 ` [PATCH 3/4] cxl/core: Add region info to cxl_general_media and cxl_dram events alison.schofield
2024-03-28 15:33   ` kernel test robot
2024-04-03 20:16   ` Jonathan Cameron
2024-04-04 15:31     ` Alison Schofield
2024-04-16 17:01   ` Ira Weiny
2024-04-17  0:39     ` Alison Schofield
2024-03-28  4:36 ` [PATCH 4/4] cxl/core: Remove cxlr dependency from cxl_poison trace events alison.schofield
2024-04-03 20:19   ` Jonathan Cameron
2024-04-16 18:14   ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zg7CWDe6F1uW+3cN@aschofie-mobl2 \
    --to=alison.schofield@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.