From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BDE7C54E67 for ; Wed, 27 Mar 2024 14:37:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B1256B0089; Wed, 27 Mar 2024 10:37:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1617D6B00A0; Wed, 27 Mar 2024 10:37:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 029896B00A2; Wed, 27 Mar 2024 10:37:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D9DB46B00A0 for ; Wed, 27 Mar 2024 10:37:46 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A20BB120434 for ; Wed, 27 Mar 2024 14:37:46 +0000 (UTC) X-FDA: 81943072932.11.E10706B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id ABD292000C for ; Wed, 27 Mar 2024 14:37:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QdnKJycV; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711550265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HE6UcSKKS+aZzc+vLdfkJL0NPQZ8Ywvx131EIF9caPE=; b=5SnTgqerhQO7WPkZ/ll+lf99oOqgswzbFzhhFkD0sTrsF5D+NPNnPjz81Hk/ZEs5Na9lL1 2Yv5sIQTk7lomtBV2M62BvikTGWLzCym9S+RmrC6NLc+f1ha2ek/BjVCwntmvoiPFQwgsd 2oUQxUsTwqQBV8YG7tkizYHQLJ7UXpU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711550265; a=rsa-sha256; cv=none; b=Xw5cJLxkhdDAg3bDQgXWpl88XPdgodMkJlvEeIVXtoGsQ66KHkNpDXhHiYVE1m1vRa3aAs vYGGG53wV5t8WTTs/2xtQnXTNUSGi0nq/SyF/plV0yH04jtOOS0BykfBcGLeXiy0TFChmQ aBVXd5iiIcwOxQZAY+Eg8co5baLOLxQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QdnKJycV; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HE6UcSKKS+aZzc+vLdfkJL0NPQZ8Ywvx131EIF9caPE=; b=QdnKJycVoBlE6BZaEOkvdjZr3U QtvWs+iGge3RsHfK5IDNRW62KApt0UtGiVkrq35sOOwlDX8ZNMUGJdFCEBooaD4J0/dkOocGepsX8 atakX97i06Y12cLLu5n8UxtswxNBOQhtoOnCRwXIjkdZIRNjZAjTmbCBSG8Ng1JwEbMS6+cEE+mM9 Gt/82yrX8fAr5YkJ2FTq7DBkDhLgttpxaZDKZpDsRUJpI6bj62O4Qlvvf/CfXQhLS0333ZM/43NhC k52iRrHst/G1URZgI4fOT0FdOEjzEb7sQA8+sqWTXYIOZ3fsEVo6N3uQ4D2GSTe/CgSlxOoCqbWXf GZYcRDtQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpUPM-000000043io-3614; Wed, 27 Mar 2024 14:37:40 +0000 Date: Wed, 27 Mar 2024 14:37:40 +0000 From: Matthew Wilcox To: Ryan Roberts Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 07/10] mm: Convert arch_clear_hugepage_flags to take a folio Message-ID: References: <20240326171045.410737-1-willy@infradead.org> <20240326171045.410737-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: ABD292000C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: oewdjfkfo7p3karzohe5szp4dtjf9ome X-HE-Tag: 1711550264-814719 X-HE-Meta: U2FsdGVkX19v2IuHx+ZfOHe3ehxnYkhlhPZ4iNB7S6z/PwKXUQXvmaBwO0eyzV/4QTln7aESANfjiO9eQbrzFq5F6W/hvCtO7xTmA+l7qIG6SL9HuaXstEgRoSpYnG4cL2QpV87pr6Dbq1sZ2i8212QWgI7pUSYEuRrzT/fjMBN/b1BwTB5PqmqzRDlpG8Ssq1IV7Tkorg5qQ81FoLfdgF2t4wMi2yCvax8JKQLXiD8Rk+IxHJD6SW1WDT5KdlKJXm6Ly4fLoWn4I5IfYYi5OfmR+XPm5y1Hy6FZ1b528Az0sawzSST8/pkedPsTcihzowRZHqiUgfyPaHpNhoegNYJtBLNDEvREOna+GN9Evane3UsPSx0uZbna33ojWsky2FU6nkmloUZ4pWJTtuFu6I88u1tCO9cNGLBZKIYh6t8RYfUe2jNtE31+FwgYbTTWTDkI+ZJcmodKetBGUyiwEPGZgrzDcClkYCuI9yx6/iZtAi6lz5CiOABtzzoyWSlAhH25Gny5lUOIfgTXo6r5B3fh2mcGf69RplcciOU0u2edIo2dlgdZIcXdHj2xW9854/sOk7LPwAsPTEh5p9kXdLD5/9P6R/MFWD8EuuTBcJmOh5U3Knc51dbaS5eNH9EM5qPNkOCqSe6zjCAnCvSUelehfD4TCb6YH8uRr2gWF22DHoe4LwKfuHuAzdI6ZLkaAHpz/FRGSq3NYawogxj/7LOiz7CUIpexfDngm89aA3BxmyUgzO8UeKyw8Q+7kAzANL33TyV7turLclUOKJ7bXit+BZy0FAB2xTCaA7Me4/NaoQFJJKMB4q1uSbT8by9WqTow3uSFG70ywhDCCui6JhcZTNQ6EDiOPvVeIBRE3/laPo5K0zD81eWArOHGWDnJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 01:02:24PM +0000, Ryan Roberts wrote: > > #ifndef arch_clear_hugepage_flags > > You need to update this line to the new name. Currently failing to build on > arm64 since it now defines the new arch_clear_hugetlb_flags. Oops. Andrew, please add -fix: diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 5001d1b6c46d..1a17d03b2fa5 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -836,7 +836,7 @@ static inline int is_hugepage_only_range(struct mm_struct *mm, #define is_hugepage_only_range is_hugepage_only_range #endif -#ifndef arch_clear_hugepage_flags +#ifndef arch_clear_hugetlb_flags static inline void arch_clear_hugetlb_flags(struct folio *folio) { } #define arch_clear_hugetlb_flags arch_clear_hugetlb_flags #endif