From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9336C12F39B for ; Thu, 28 Mar 2024 15:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711638047; cv=none; b=a96dVSVBfPy+3o+p+sXDdCZoqLLuaC5vQMisKxojlgte+KiJ5B7dC16GZnPQGZZ5ko4xFCyEpLuWa5LGb+jbWorr9+GrOM/oR0SRLjLC9USKJXTGPyOrH0+mtNfPQzgs5au02TryraM+i3TISL7jJx38nD3H+t8kwJcRjsRMMhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711638047; c=relaxed/simple; bh=EoHim42owK348cZhl/I9M1pymb0CHHmvTuAnkh/utqo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bXc7UNNj0QNbcY8op2f8VbVOv/K/vX0s1rE+vL9CmuIaL4Ov7BUFy1A9dsQx46ll6xzw9igKTA+x+UBrB/UY5YSygufZx9VRgMxXJCmn9g7ood8PbCQgcdndaxohj/ybCAOf6laWb+MD5bEc0jsfmeVTIGIAGm5Ja4Hy5ceJLFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jookia.org; spf=none smtp.mailfrom=jookia.org; dkim=pass (2048-bit key) header.d=jookia.org header.i=@jookia.org header.b=LGKHhnyS; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jookia.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=jookia.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jookia.org header.i=@jookia.org header.b="LGKHhnyS" Date: Fri, 29 Mar 2024 01:56:24 +1100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1711638043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwp1Qw0/EtEt4456dlzV/Bdcj7tMPkZXlkry1Wr4Z8Y=; b=LGKHhnySkPwGebCdv/mVHphyxvQc8crAcv2Oui6bANMhmRHEJY6K/I2Ih6ly5HFvYpnUHr RaUk1/+0ZaAAyPuNk32vxYEQYx4aouN64DPVOXSzVM0WlRfOVF3VvetqnNrc7RB6mHZfUR inf9ihorMeBYe1/lMJsjrHpxhqHn/RM3fcBpIbCgRU5OFMhfta4Roy8pnpjHXNQhBSuCtA 0ZUlE2egI+t8HpZUXQuAiqiYiO023tOnBUL8Gs0BxbWGG2YGwH2bL9q89kJuOAViz0zvBS AEIE4C395ksCyP/I+kqd4xxYCwZBNHvU5GWaOirrFG3WcF3d3oxrDVehHlndWw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Mark Brown Cc: Jernej =?utf-8?Q?=C5=A0krabec?= , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: sunxi: sun4i-i2s: Enable 32-bit audio formats Message-ID: References: <20240326-sunxi_s32-v1-1-899f71dcb1e6@jookia.org> <23447395.6Emhk5qWAg@jernej-laptop> <9055efa5-8da6-47b2-b2db-d1f8e02d2267@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9055efa5-8da6-47b2-b2db-d1f8e02d2267@sirena.org.uk> X-Migadu-Flow: FLOW_OUT On Thu, Mar 28, 2024 at 01:56:42PM +0000, Mark Brown wrote: > On Thu, Mar 28, 2024 at 01:21:21PM +1100, John Watts wrote: > > On Wed, Mar 27, 2024 at 08:53:32PM +0100, Jernej Škrabec wrote: > > > > I wish it would be that simple. SUN4I_FORMATS is cross section of all I2S > > > variants that are supported by this driver. If you check A10, you'll see that > > > it doesn't support S32. > > > > If you want to add support for S32, you'll have to add new quirk for each > > > variant. > > > Yes, A10 doesn't support it. But it should error out in hw_params due to > > get_sr not supporting 32-bit, no? > > The constraints shouldn't be advertising things that hw_params() will > error out on, sometimes there are contingent constraints that prevent > this but something that just doesn't work isn't one of those times. Oh right! I'm not sure how I forgot about this, given I went through this exact discussion for my wm8782 patch. I'll try and get v2 patch for this soon. :) John. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06C49C54E64 for ; Thu, 28 Mar 2024 15:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PDwuyCOGOAYPYbMjC9VOWt6nXp7x/iQJDKq9Jh5H7Ns=; b=bWT/+tNjqKTcLG Pz9hJjiBxkKVbINIUBGt8S3w2+AQIrcBsS97HpEWDZIVxoKBKH8Rs1p5qO31Q/QnuFmNtfXkkwBCP 4A+ks+253uycESXGFSp53qe+64d42NA7TQ7TGj3C8CUoDsNHZeFEwVBU7N1dOGyZrx6s9MTKKCfAq UMnRMKukhOC1p1TWfLwH/yrGswhhu31k7b9nafjjWEiWmI4FuZrz1ayprbY1CUq7j+FuKqZ2VIbTc GOemGttXp+bJov4aUZXT7ERhOwpn3TZPKCGFhXZntp6LSYIp3KmtVG/98PbOJHJV5dklW6sVMxnHJ fdmjTC848Gc7AK1TeRdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rprFc-0000000ER4Z-0q3q; Thu, 28 Mar 2024 15:01:08 +0000 Received: from out-175.mta1.migadu.com ([95.215.58.175]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rprFG-0000000EQto-2ukb for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 15:00:48 +0000 Date: Fri, 29 Mar 2024 01:56:24 +1100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1711638043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwp1Qw0/EtEt4456dlzV/Bdcj7tMPkZXlkry1Wr4Z8Y=; b=LGKHhnySkPwGebCdv/mVHphyxvQc8crAcv2Oui6bANMhmRHEJY6K/I2Ih6ly5HFvYpnUHr RaUk1/+0ZaAAyPuNk32vxYEQYx4aouN64DPVOXSzVM0WlRfOVF3VvetqnNrc7RB6mHZfUR inf9ihorMeBYe1/lMJsjrHpxhqHn/RM3fcBpIbCgRU5OFMhfta4Roy8pnpjHXNQhBSuCtA 0ZUlE2egI+t8HpZUXQuAiqiYiO023tOnBUL8Gs0BxbWGG2YGwH2bL9q89kJuOAViz0zvBS AEIE4C395ksCyP/I+kqd4xxYCwZBNHvU5GWaOirrFG3WcF3d3oxrDVehHlndWw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Mark Brown Cc: Jernej =?utf-8?Q?=C5=A0krabec?= , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: sunxi: sun4i-i2s: Enable 32-bit audio formats Message-ID: References: <20240326-sunxi_s32-v1-1-899f71dcb1e6@jookia.org> <23447395.6Emhk5qWAg@jernej-laptop> <9055efa5-8da6-47b2-b2db-d1f8e02d2267@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9055efa5-8da6-47b2-b2db-d1f8e02d2267@sirena.org.uk> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_080047_402206_06798523 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMjgsIDIwMjQgYXQgMDE6NTY6NDJQTSArMDAwMCwgTWFyayBCcm93biB3cm90 ZToKPiBPbiBUaHUsIE1hciAyOCwgMjAyNCBhdCAwMToyMToyMVBNICsxMTAwLCBKb2huIFdhdHRz IHdyb3RlOgo+ID4gT24gV2VkLCBNYXIgMjcsIDIwMjQgYXQgMDg6NTM6MzJQTSArMDEwMCwgSmVy bmVqIMWga3JhYmVjIHdyb3RlOgo+IAo+ID4gPiBJIHdpc2ggaXQgd291bGQgYmUgdGhhdCBzaW1w bGUuIFNVTjRJX0ZPUk1BVFMgaXMgY3Jvc3Mgc2VjdGlvbiBvZiBhbGwgSTJTCj4gPiA+IHZhcmlh bnRzIHRoYXQgYXJlIHN1cHBvcnRlZCBieSB0aGlzIGRyaXZlci4gSWYgeW91IGNoZWNrIEExMCwg eW91J2xsIHNlZSB0aGF0Cj4gPiA+IGl0IGRvZXNuJ3Qgc3VwcG9ydCBTMzIuCj4gCj4gPiA+IElm IHlvdSB3YW50IHRvIGFkZCBzdXBwb3J0IGZvciBTMzIsIHlvdSdsbCBoYXZlIHRvIGFkZCBuZXcg cXVpcmsgZm9yIGVhY2gKPiA+ID4gdmFyaWFudC4KPiAKPiA+IFllcywgQTEwIGRvZXNuJ3Qgc3Vw cG9ydCBpdC4gQnV0IGl0IHNob3VsZCBlcnJvciBvdXQgaW4gaHdfcGFyYW1zIGR1ZSB0bwo+ID4g Z2V0X3NyIG5vdCBzdXBwb3J0aW5nIDMyLWJpdCwgbm8/Cj4gCj4gVGhlIGNvbnN0cmFpbnRzIHNo b3VsZG4ndCBiZSBhZHZlcnRpc2luZyB0aGluZ3MgdGhhdCBod19wYXJhbXMoKSB3aWxsCj4gZXJy b3Igb3V0IG9uLCBzb21ldGltZXMgdGhlcmUgYXJlIGNvbnRpbmdlbnQgY29uc3RyYWludHMgdGhh dCBwcmV2ZW50Cj4gdGhpcyBidXQgc29tZXRoaW5nIHRoYXQganVzdCBkb2Vzbid0IHdvcmsgaXNu J3Qgb25lIG9mIHRob3NlIHRpbWVzLgoKT2ggcmlnaHQhIEknbSBub3Qgc3VyZSBob3cgSSBmb3Jn b3QgYWJvdXQgdGhpcywgZ2l2ZW4gSSB3ZW50IHRocm91Z2ggdGhpcwpleGFjdCBkaXNjdXNzaW9u IGZvciBteSB3bTg3ODIgcGF0Y2guCgpJJ2xsIHRyeSBhbmQgZ2V0IHYyIHBhdGNoIGZvciB0aGlz IHNvb24uIDopCgpKb2huLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=