From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C5B0CD11DD for ; Thu, 28 Mar 2024 19:40:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06C2A6B00A2; Thu, 28 Mar 2024 15:40:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01BF06B00A3; Thu, 28 Mar 2024 15:40:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E25D36B00A4; Thu, 28 Mar 2024 15:40:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C44C36B00A2 for ; Thu, 28 Mar 2024 15:40:41 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 829D7A03D4 for ; Thu, 28 Mar 2024 19:40:41 +0000 (UTC) X-FDA: 81947465082.27.B71E754 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 8253040016 for ; Thu, 28 Mar 2024 19:40:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DIWRLWer; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711654840; a=rsa-sha256; cv=none; b=4rHXXzygglmhUk07UY7wdUQKUeU+WBS14xdZ4VR4zfefk1GFRQaEurjD7d2PBSLv8weD0o p3uGTSQ7J/p5ByWjJcO/Ef7Tp4qRMhj2DCcZHp4+kc+CSjSlsij+OUrjx6KDIWhA5A6Ekk +5/tiNc6M5/QX0Lykg2mga/XF9IwwLU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DIWRLWer; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711654840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0QPeGyyDHX9FBUpzGtwcoedIxGwwPDwZCOkxKBRDrGc=; b=AFgkkZZvk2VWqRggjOoHKhy97Bb8zktPdZCf2OPJeplZ1H2QaXY+wD8Rxy7rq3WtqwNokt zZwyB2a7DwljSn4KLIFhyqLtCSzBAUOD/LyEWiNUAfF/mxnjZl3YI4HrcnueUKhOqB8PRD GiOx4zqe5nnR77WyPxeSAjjCf+m+tc8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0QPeGyyDHX9FBUpzGtwcoedIxGwwPDwZCOkxKBRDrGc=; b=DIWRLWeryE7NRbIFTYi//Kuv/Q lcDnANCMii+D9SwsQHc86c3ltwXkfH/hzoRVu3PEgBlsSvdh10Da0GFzVPercQpYj8nw3poFpsNWJ MfuVFmlvfQWFgNmOW+PMrnlANyXp9RL0z0kaHaLA9Y7n5hy+5enVx5OMzLAeIUu7/ElAiyKQOrNwv unsTGVUmTfI6EQn4FbvT8wbRVJNlYjZBXmedsBJK6pIAtM/ZdFCb3ms2FqySjHinfhfdojG5LKtKb dlg05mcTgqxaBaToMHt0YcbBOvQCQeXzKMeFDF9VcPACxCGEnx6APjsFtU9CvPRuoJfBCu3XaL0zY tmvV9nPQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpvc5-000000072ns-1hk0; Thu, 28 Mar 2024 19:40:37 +0000 Date: Thu, 28 Mar 2024 19:40:37 +0000 From: Matthew Wilcox To: Svetly Todorov Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 02/10] xtensa: Remove uses of PG_arch_1 on individual pages Message-ID: References: <20240326171045.410737-1-willy@infradead.org> <20240326171045.410737-3-willy@infradead.org> <7cdfb64c-c751-4a59-93fd-4bfa625c43ac@memverge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cdfb64c-c751-4a59-93fd-4bfa625c43ac@memverge.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8253040016 X-Stat-Signature: 8awuuxzibskjq9apmrerwr7y9uzzkx6w X-HE-Tag: 1711654839-844894 X-HE-Meta: U2FsdGVkX19YnayReiSgr0GwCsDLtk/u1zp07HDtGdpQneKN1pmnBYKrLWOU8tO4I7GNqaZI/0kriMBnxkXUbWqQccyjzNC3lr0o1S97utjyVawOxzBcb+f7JkDKgFdqpa3W+VlucDw2I/p/Yk8Dc0VivpVpQ14snnoVGVkUmFVd2SlkstXJHTdb1gPlcxirAm9Czsfdc0dmi+yHjZlyx58NMJnuIBbkprhgTg02505VFkSzOLuAiRwrukFHTrZ3RYmmchYQUqKNmCD4IOQ7cJeEC7EF4SckGtEMJ2pX+0ylG8ylWCfy0IWOMNONZkxy5vSmcHEBKTSS0dQdoEhX/6yhB/wDFrs7vqXsFR4No8wr0wQXG1SlVEckWqtPHeQ9vQijZqk5MHF7V+lX264mGVdQbDE1akwWa+jhcCRbIzV1BATlMjz5Ax0wYmRHoVlIxMW91uV/wLIqZM2s/zt5/dl4CdRlVg9Bp1f9t9CdjmuBYIOlzfc6b1tQ0ws95vgKg7/5oqV2IuL4qEZ6o+pgDaVX2LFlqBaJM+znklQoOR8ggEO/7kuZ5a6CNmj+4uiJ7zaMaBhEj9GvQ76ZV2w814Ki4R+ukR6QrIH8+G77pbQrM3YriTS8Fz5lSlbWCPd/3yc76kNSz9/CbUcq2ZnDK8LcL/KAFexMME6FEUiG+9TA0jz1IFUrVUP5esMRuPDjvCYhz2KYf+E4Fmlhg1DAahwl8vN3TCKAar6FDwr1By9JAXfsct5GfzOtVdNdeJAxDW78nGzeGL78yn2Ghy3vS5C2rHiK4YdoEBAZuGbXyldmOGVVHzIoatorReMn4KBPfFyx2rHngqEotYKlAN+xw57Nw1qzlpb3ZwWe9x6l7mDGhk/Dqvnm2A6A6yCMwm0uK1/CUSIZaPKtQlOgpGVtftOCoJn9wpqVcgHd7cqtlj3yYEnRtRbKoFEqKzSCsyI6qRUEP6QXvEb4oHUYTa7 Jh/p0sjP t/sdJNRDe+lu4Ur6yxpFCG1AEjNZhWBEm/dpC4akMqVoQ8LhrV12Xs3hj2e0TrBMUtmzd9W0LWqy6beU6SUwBhjvW/at8jHZup1bevUxk/fU2fw9pq4GBznEmBou/l+HKSkamuSyvRGLQqUltBAMV4c3tfW8UuA0y/nZrPEvXB2p3DEMPLWGRciiIbit8nauB/sb+dr7gTFPqfV10BI0A7BcjQwxyg0C1oGYEb9bseP3VY2lDsvFBTp/BSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 28, 2024 at 12:36:30PM -0700, Svetly Todorov wrote: > The fix for this particular file looks good, > but some other architectures still use page->flags > to test/set PG_arch_1 aliases: > > ./arch/arc/include/asm/cacheflush.h:#define PG_dc_clean PG_arch_1 > ./arch/arm/include/asm/cacheflush.h:#define PG_dcache_clean PG_arch_1 > ./arch/arm64/include/asm/cacheflush.h:#define PG_dcache_clean PG_arch_1 > > (in arch): grep -rI . -e 'page->flags' > > ./s390/include/asm/hugetlb.h: clear_bit(PG_arch_1, &page->flags); > ./s390/mm/hugetlbpage.c: if (!test_and_set_bit(PG_arch_1, &page->flags)) > ./sh/include/asm/hugetlb.h: clear_bit(PG_dcache_clean, &page->flags); > ./sh/mm/cache-sh4.c: test_bit(PG_dcache_clean, &page->flags) && Fixed elsewhere in this patch series. > ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); > ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); > ./s390/kernel/uv.c: set_bit(PG_arch_1, &page->flags); > ./s390/kernel/uv.c: if (!test_bit(PG_arch_1, &page->flags)) > ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); > ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); > ./s390/mm/gmap.c: set_bit(PG_arch_1, &page->flags); > > ... (not an exhaustive list) ... s390 is a disaster area for use of page->flags. I've sent patches with no response or "we can't do that" responses. I'm ignoring them until I get more useful responses. > But at least for xtensa, this LGTM. > > Reviewed-by: Svetly Todorov Thanks.