From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: Michael Walle <michael@walle.cc>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] Add BR2_ROOTFS_POST_{PRE_BUILD|POST_BUILD|FAKEROOT|IMAGE}_SCRIPT_ARGS
Date: Thu, 28 Mar 2024 21:53:53 +0100 [thread overview]
Message-ID: <ZgXY4brxHcFDwxzJ@landeda> (raw)
In-Reply-To: <20240328140919.157664-1-heiko.thiery@gmail.com>
Heiko, All,
iReply v2, because I'm dumb and too hasty...
On 2024-03-28 15:09 +0100, Heiko Thiery spake thusly:
[--SNIP--]
> diff --git a/system/Config.in b/system/Config.in
> index 33ca69b933..1bb4c89b36 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -695,20 +695,60 @@ config BR2_ROOTFS_POST_IMAGE_SCRIPT
>
> config BR2_ROOTFS_POST_SCRIPT_ARGS
> string "Extra arguments passed to custom scripts"
> - depends on BR2_ROOTFS_POST_BUILD_SCRIPT != "" \
> + depends on BR2_ROOTFS_PRE_BUILD_SCRIPT != "" \
> + || BR2_ROOTFS_POST_BUILD_SCRIPT != "" \
> || BR2_ROOTFS_POST_FAKEROOT_SCRIPT != "" \
> || BR2_ROOTFS_POST_IMAGE_SCRIPT != ""
> help
> - Pass these additional arguments to each post-build or
> - post-image scripts.
> + Pass these additional arguments to each pre-build, post-build,
> + post-fakeroot and post-image scripts.
Those two huinks were unrelated to the change: in fact they were a fix
for an actual issue that pre-existed.
I've split those into their own commit, wrote a commit log that explains
the issue, and applied that commit before adding the new options.
This will make it easier to backport to stable branches.
Applied to master, thanks.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-03-28 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 14:09 [Buildroot] [PATCH v2] Add BR2_ROOTFS_POST_{PRE_BUILD|POST_BUILD|FAKEROOT|IMAGE}_SCRIPT_ARGS Heiko Thiery
2024-03-28 20:50 ` Yann E. MORIN
2024-03-28 20:53 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgXY4brxHcFDwxzJ@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=heiko.thiery@gmail.com \
--cc=michael@walle.cc \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.