From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B509522EE5; Sun, 7 Apr 2024 11:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712488994; cv=none; b=PX6yI0v9srZUrI7C4W16tSqUo0vPkresHN8I+aJHSP1TPJrUnZwPJFK95Zr7DHl65WXI23Qa9rl3C395/tp8aE7jC2+/O9jzI3vvxiZM8vtCZ9B4JEF7KD5TvUIMNus4v3b93Kzj5ahmhSZ8ZFVt0k7f28fbeClA441iMS145Dc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712488994; c=relaxed/simple; bh=5suR5ejrCA9fwoRJgZKID0FTG3hpL42flJ7EeEBlYuI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HT0dK09TFA1pXgLuP1QyqjJ9+L0/1iou7Kq/BZbp7wnh9fmDULQbWYqOmMQw5pcWBcP7pC3fXEDY05lYiCFGGU/ht95f8cH4aWTcrM2Y7PnYHeMqHof7TmdgT/mdu+Wi5TekWn/40XAkk0jR9q/roDa/6gPYgz2gWW86ZsCTFe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GL/LcCAM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GL/LcCAM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2CEAC43390; Sun, 7 Apr 2024 11:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712488994; bh=5suR5ejrCA9fwoRJgZKID0FTG3hpL42flJ7EeEBlYuI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GL/LcCAMHHwG1RjtRD1qwdMfbicOlrbROY0L21dD4sFAxjAQIvA3VK1O2gzwZ+wj0 Nr45B8vc0nqcQk7+dzlaq3tH+e+CbLZRg8NsxvJec3FhtD9U30WhoaJSB2MxZwQnBZ AyZfPmYQv++1o2fksPW93jOdCjg2EXBbWwfWwRJx/vgMdsm1AVgyMWZnz2Hsktf9PX sFmyhXCbht5iJLccVlEHICpgIgPGxPWWWZzwPwDD1H3GoCjrK/27ZUF4HMUMjZ71I1 GMh7cySb4Lpi1JBXCun8kedcXSVAjqpNNZ9ro/3q3BsjFtj5KFDOAvGf2QN632m7vb P0Pe0F1hrC/Rg== Date: Sun, 7 Apr 2024 16:53:10 +0530 From: Vinod Koul To: Inochi Amaoto Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Liu Gui , Jingbao Qiu , dlan@gentoo.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v6 2/3] soc/sophgo: add top sysctrl layout file for CV18XX/SG200X Message-ID: References: Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 29-03-24, 10:04, Inochi Amaoto wrote: > The "top" system controller of CV18XX/SG200X exposes control > register access for various devices. Add soc header file to > describe it. > > Signed-off-by: Inochi Amaoto > --- > include/soc/sophgo/cv1800-sysctl.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 include/soc/sophgo/cv1800-sysctl.h > > diff --git a/include/soc/sophgo/cv1800-sysctl.h b/include/soc/sophgo/cv1800-sysctl.h > new file mode 100644 > index 000000000000..b9396d33e240 > --- /dev/null > +++ b/include/soc/sophgo/cv1800-sysctl.h > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * Copyright (C) 2023 Inochi Amaoto > + */ > + > +#ifndef CV1800_SYSCTL_H > +#define CV1800_SYSCTL_H > + > +/* > + * SOPHGO CV1800/SG2000 SoC top system controller registers offsets. > + */ > + > +#define CV1800_CONF_INFO 0x004 > +#define CV1800_SYS_CTRL_REG 0x008 > +#define CV1800_USB_PHY_CTRL_REG 0x048 > +#define CV1800_SDMA_DMA_CHANNEL_REMAP0 0x154 > +#define CV1800_SDMA_DMA_CHANNEL_REMAP1 0x158 > +#define CV1800_TOP_TIMER_CLK_SEL 0x1a0 > +#define CV1800_TOP_WDT_CTRL 0x1a8 > +#define CV1800_DDR_AXI_URGENT_OW 0x1b8 > +#define CV1800_DDR_AXI_URGENT 0x1bc > +#define CV1800_DDR_AXI_QOS_0 0x1d8 > +#define CV1800_DDR_AXI_QOS_1 0x1dc > +#define CV1800_SD_PWRSW_CTRL 0x1f4 > +#define CV1800_SD_PWRSW_TIME 0x1f8 > +#define CV1800_DDR_AXI_QOS_OW 0x23c > +#define CV1800_SD_CTRL_OPT 0x294 > +#define CV1800_SDMA_DMA_INT_MUX 0x298 Why are these register defines in soc, all the dma registers should belong to dma driver and other IPs, why do you need a common header?? -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF5B2CD128A for ; Sun, 7 Apr 2024 11:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t2v2FD+Rk58XEWblq2TqHkE7F5o/JKc6cv6rnRoWO94=; b=oXm72N0W0ZpgX8 S4SauEYDhvKdCndjuXYN9ZSgfZEE4bwYTV92C3PwkuiNz0Dzxzttuu0/9t6UNsYybnmc1tSY+jAkh eWF+P5jKVsVyqiqY/8XfMhbS8ITaMNGFOBdwKtkLVpwLxxClRl+oSruOOYvCTLMTPOlPNk7mCGDkZ atvBY9zGCvIExPuMTS4O1TQXwGtt97Ne7dvcsH6Hn3YxwXSkyKiHVfhpqcY/cqTWuXjMSgQqe2DDD Xq3hEe/sEQ92PS+J18pCO52B97VFFpmONTcuuEJvRJzP1sJSgCt+S3wqhDK0Q9F+gkLbHrEmBxKJA TKk3s5BiCLJaA0oGXbBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtQcK-0000000CQTC-1GsQ; Sun, 07 Apr 2024 11:23:20 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtQcG-0000000CQSS-3TEY for linux-riscv@lists.infradead.org; Sun, 07 Apr 2024 11:23:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8C8C960691; Sun, 7 Apr 2024 11:23:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2CEAC43390; Sun, 7 Apr 2024 11:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712488994; bh=5suR5ejrCA9fwoRJgZKID0FTG3hpL42flJ7EeEBlYuI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GL/LcCAMHHwG1RjtRD1qwdMfbicOlrbROY0L21dD4sFAxjAQIvA3VK1O2gzwZ+wj0 Nr45B8vc0nqcQk7+dzlaq3tH+e+CbLZRg8NsxvJec3FhtD9U30WhoaJSB2MxZwQnBZ AyZfPmYQv++1o2fksPW93jOdCjg2EXBbWwfWwRJx/vgMdsm1AVgyMWZnz2Hsktf9PX sFmyhXCbht5iJLccVlEHICpgIgPGxPWWWZzwPwDD1H3GoCjrK/27ZUF4HMUMjZ71I1 GMh7cySb4Lpi1JBXCun8kedcXSVAjqpNNZ9ro/3q3BsjFtj5KFDOAvGf2QN632m7vb P0Pe0F1hrC/Rg== Date: Sun, 7 Apr 2024 16:53:10 +0530 From: Vinod Koul To: Inochi Amaoto Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Liu Gui , Jingbao Qiu , dlan@gentoo.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v6 2/3] soc/sophgo: add top sysctrl layout file for CV18XX/SG200X Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240407_042316_953265_95C4BAE4 X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 29-03-24, 10:04, Inochi Amaoto wrote: > The "top" system controller of CV18XX/SG200X exposes control > register access for various devices. Add soc header file to > describe it. > > Signed-off-by: Inochi Amaoto > --- > include/soc/sophgo/cv1800-sysctl.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 include/soc/sophgo/cv1800-sysctl.h > > diff --git a/include/soc/sophgo/cv1800-sysctl.h b/include/soc/sophgo/cv1800-sysctl.h > new file mode 100644 > index 000000000000..b9396d33e240 > --- /dev/null > +++ b/include/soc/sophgo/cv1800-sysctl.h > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * Copyright (C) 2023 Inochi Amaoto > + */ > + > +#ifndef CV1800_SYSCTL_H > +#define CV1800_SYSCTL_H > + > +/* > + * SOPHGO CV1800/SG2000 SoC top system controller registers offsets. > + */ > + > +#define CV1800_CONF_INFO 0x004 > +#define CV1800_SYS_CTRL_REG 0x008 > +#define CV1800_USB_PHY_CTRL_REG 0x048 > +#define CV1800_SDMA_DMA_CHANNEL_REMAP0 0x154 > +#define CV1800_SDMA_DMA_CHANNEL_REMAP1 0x158 > +#define CV1800_TOP_TIMER_CLK_SEL 0x1a0 > +#define CV1800_TOP_WDT_CTRL 0x1a8 > +#define CV1800_DDR_AXI_URGENT_OW 0x1b8 > +#define CV1800_DDR_AXI_URGENT 0x1bc > +#define CV1800_DDR_AXI_QOS_0 0x1d8 > +#define CV1800_DDR_AXI_QOS_1 0x1dc > +#define CV1800_SD_PWRSW_CTRL 0x1f4 > +#define CV1800_SD_PWRSW_TIME 0x1f8 > +#define CV1800_DDR_AXI_QOS_OW 0x23c > +#define CV1800_SD_CTRL_OPT 0x294 > +#define CV1800_SDMA_DMA_INT_MUX 0x298 Why are these register defines in soc, all the dma registers should belong to dma driver and other IPs, why do you need a common header?? -- ~Vinod _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv