From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59EC5145FEA for ; Sat, 27 Apr 2024 22:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714256386; cv=none; b=D1Yho8mHtfaPwignkwj08Tnf/F64/6rS9VcF8dbG4ZvffH1wE0+USLUmVvO2WIdhyS77HLydEp7qCY8lNcfTjgfBK2uCOWyUKZo20MeNZrqGhn3mHMa9iOb8qLKqlfgLK8d1I4oEx49PU/15UjtZsySHT6XfdHg0yKmX/OrIQRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714256386; c=relaxed/simple; bh=zt+W3q+Hvk19yWapYFFCiZ+hsTgrOUeWeyvEmbZm2Ls=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S2QRvNOoF9FEgsc2mWvwfI4BNw4xv04GBRB4W9fZKCKe5xNKi37V10S/88JpCucKmfKV0rmdrxERBU0BErb7We47lY4OqJWAD9S1NrSgqQNKSQ+qcaHwZRQkpHZOnv0WjshVZeL7VKGgkYLR89rZx7L+OXVfH4YmKI8sJEjbBrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QAPq51ZN; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QAPq51ZN" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5188f5dd62dso1533e87.0 for ; Sat, 27 Apr 2024 15:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714256382; x=1714861182; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=h3EqdV1cLUjuhm5Iq+lAUnqb4b0RY2+WR64uEdCo72o=; b=QAPq51ZN5WhY+fg31Ls0NY5Q9XE0px31NkKqtce1Xk86XZ3Cg4QJJzQisF3GkutG5w 9hEVGRwKRvW7504E8hBcqu7f4QZLjW4GDmccuYwDCSnDYWl9wpjI0rnnRmtSM74EL03A gsn7V0il+fqKU0EVFUyylttFRKXv4AR62y7R2XSUzFfXuUPUNsygzFCPAvGaENAKFp7m 5yZrHu6q8TnbAS1DPAqK2vJACeZNqY5y72Zk8GW3fvqNJOa0XDcOPqI3AwxJXPILLLkt RBWYcoYflXPe8m/+l05qwXOuwE1WOvX/HNBIxWnE3NUJp7YV0HDsEmx9egi4AVtTCVs/ R31g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714256382; x=1714861182; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h3EqdV1cLUjuhm5Iq+lAUnqb4b0RY2+WR64uEdCo72o=; b=vjZKTbTpNekQe/6iKBNDycbIkOwhOYMAw3lnSsmDYetPb2tK6YEmhO4KxAOECHe5/z 05et+8wcW1fNp7Qg5kYjPuuFQhkERQbt3MgIMfAYA52TK8ZhKeZofaeo7gjsaNylaYlN Y3UrJC+BuFKGOGMudq4PE4aFoDr85YtpAPAQ+nJeKlJY0s/XHiHC+SePAN6RV27HYBzI e5kXCKHAnNOFE7DakfWSyZj8Y4BiblNed2lT3aG7x4kiSrO9LFjtbXU9saKRO1CsscpI Vlo3bAysr8qUroU8TS3k5aflNQ9qh877TuNQQS6uLKMPA9XN1qzzWXwm4Iov3PmhL2Va TLcA== X-Forwarded-Encrypted: i=1; AJvYcCU9kMGyxfey2/cOQj+9nxY16md2XN1ShGfI2B7hisTtm7JgrdrRbCPoqC3WJlFxoqpqi2a4OAODW8386zHSpbYGAfeAxeQODQ== X-Gm-Message-State: AOJu0YziOwWBUU397qHVbYN6yTTPmZCQAPiwPitMHYAn42YA+cTfQ3+X bhTreheUyJ/AHmSKgYVW+8x1A4BEKxXHMcMLs2XdpXdDtJEgagVGBzMkNcE9sA== X-Google-Smtp-Source: AGHT+IG+6yrjzRA8FcBXQd6yCX5t+zowVD9Nanhc4t+NuiGe4rpqSbSc/uueQ2J/GTaL2DXAlYJ6wg== X-Received: by 2002:a19:e048:0:b0:51d:68cb:e505 with SMTP id g8-20020a19e048000000b0051d68cbe505mr11781lfj.4.1714256382275; Sat, 27 Apr 2024 15:19:42 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id l7-20020adffe87000000b0034c7330da82sm4130390wrr.80.2024.04.27.15.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 15:19:41 -0700 (PDT) Date: Sat, 27 Apr 2024 22:19:37 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v7 5/9] iommu/arm-smmu-v3: Make arm_smmu_alloc_cd_ptr() Message-ID: References: <0-v7-cb149db3a320+3b5-smmuv3_newapi_p2_jgg@nvidia.com> <5-v7-cb149db3a320+3b5-smmuv3_newapi_p2_jgg@nvidia.com> <20240422142053.GD49823@nvidia.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240422142053.GD49823@nvidia.com> On Mon, Apr 22, 2024 at 11:20:53AM -0300, Jason Gunthorpe wrote: > On Fri, Apr 19, 2024 at 09:14:21PM +0000, Mostafa Saleh wrote: > > Hi Jason, > > > > On Tue, Apr 16, 2024 at 04:28:16PM -0300, Jason Gunthorpe wrote: > > > Only the attach callers can perform an allocation for the CD table entry, > > > the other callers must not do so, they do not have the correct locking and > > > they cannot sleep. Split up the functions so this is clear. > > > > > > arm_smmu_get_cd_ptr() will return pointer to a CD table entry without > > > doing any kind of allocation. > > > > > > arm_smmu_alloc_cd_ptr() will allocate the table and any required > > > leaf. > > > > > > A following patch will add lockdep assertions to arm_smmu_alloc_cd_ptr() > > > once the restructuring is completed and arm_smmu_alloc_cd_ptr() is never > > > called in the wrong context. > > > > > > Signed-off-by: Jason Gunthorpe > > > --- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 61 +++++++++++++-------- > > > 1 file changed, 39 insertions(+), 22 deletions(-) > > > > > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > > index f3df1ec8d258dc..a0d1237272936f 100644 > > > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > > @@ -98,6 +98,7 @@ static struct arm_smmu_option_prop arm_smmu_options[] = { > > > > > > static int arm_smmu_domain_finalise(struct arm_smmu_domain *smmu_domain, > > > struct arm_smmu_device *smmu); > > > +static int arm_smmu_alloc_cd_tables(struct arm_smmu_master *master); > > > > > > static void parse_driver_options(struct arm_smmu_device *smmu) > > > { > > > @@ -1207,29 +1208,51 @@ static void arm_smmu_write_cd_l1_desc(__le64 *dst, > > > struct arm_smmu_cd *arm_smmu_get_cd_ptr(struct arm_smmu_master *master, > > > u32 ssid) > > > { > > > - __le64 *l1ptr; > > > - unsigned int idx; > > > struct arm_smmu_l1_ctx_desc *l1_desc; > > > - struct arm_smmu_device *smmu = master->smmu; > > > struct arm_smmu_ctx_desc_cfg *cd_table = &master->cd_table; > > > > > > + if (!cd_table->cdtab) > > > + return NULL; > > > + > > > if (cd_table->s1fmt == STRTAB_STE_0_S1FMT_LINEAR) > > > return (struct arm_smmu_cd *)(cd_table->cdtab + > > > ssid * CTXDESC_CD_DWORDS); > > > > > > - idx = ssid >> CTXDESC_SPLIT; > > > - l1_desc = &cd_table->l1_desc[idx]; > > > - if (!l1_desc->l2ptr) { > > > - if (arm_smmu_alloc_cd_leaf_table(smmu, l1_desc)) > > > - return NULL; > > > + l1_desc = &cd_table->l1_desc[ssid / CTXDESC_L2_ENTRIES]; > > > > These operations used to be shift and bit masking which made sense as it does > > what hardware does, is there any reason you changed it to division and modulo? > > I checked the disassembly and gcc does the right thing as constants are power > > of 2, but I am just curious. > > I generally prefer the clarity and succinctness of / and % instead of > hacking up bit operations that the compiler will generate > automatically anyhow. > > If bit extractions should be used it is better to wrap it in > FIELD_GET() than open code it.. > > > > +static struct arm_smmu_cd *arm_smmu_alloc_cd_ptr(struct arm_smmu_master *master, > > > + u32 ssid) > > > +{ > > > + struct arm_smmu_ctx_desc_cfg *cd_table = &master->cd_table; > > > + struct arm_smmu_device *smmu = master->smmu; > > > + > > > + if (!cd_table->cdtab) { > > > + if (arm_smmu_alloc_cd_tables(master)) > > > + return NULL; > > > } > > > - idx = ssid & (CTXDESC_L2_ENTRIES - 1); > > > - return &l1_desc->l2ptr[idx]; > > > + > > > + if (cd_table->s1fmt == STRTAB_STE_0_S1FMT_64K_L2) { > > > + unsigned int idx = ssid >> CTXDESC_SPLIT; > > > > Ok, now it’s a shift, I think we should be consistent with how we > > calculate the index. > > Sure. Change that to / will make CTXDESC_SPLIT unused except in > computing CTXDESC_L2_ENTRIES so that can be simplified too: > > -#define CTXDESC_SPLIT 10 > -#define CTXDESC_L2_ENTRIES (1 << CTXDESC_SPLIT) > +#define CTXDESC_L2_ENTRIES 1024 > Sounds good, I don’t think it matters much as long as its consistent, but anyway the split is defined by the spec to be either 6, 8 or 10. So split size has to be a power of 2. > > > > @@ -1357,7 +1380,7 @@ int arm_smmu_write_ctx_desc(struct arm_smmu_master *master, int ssid, > > > if (WARN_ON(ssid >= (1 << cd_table->s1cdmax))) > > > return -E2BIG; > > > > > > - cd_table_entry = arm_smmu_get_cd_ptr(master, ssid); > > > + cd_table_entry = arm_smmu_alloc_cd_ptr(master, ssid); > > > > The only path allocates the main table is “arm_smmu_attach_dev”, > > There are two places that allocate the leaf, arm_smmu_attach_dev() > (for the RID) and arm_smmu_sva_set_dev_pasid() (for a PASID) > > At this moment all the paths are relying on the above to allocate the > leaf. The next patch makes arm_smmu_attach_dev() allocate the leaf > itself. A few more patches also makes the PASID path allocate the leaf > itself, when the above is removed. > > > I guess it would be more robust to leave that as is and have 2 > > versions of get_cd, one that allocates leaf and one that is not > > allocating, what do you think? > > I'm not sure what you are asking? We have two versions. One is called > alloc and one is called get. That have different locking requirements > on the caller so they have different names. I would not call them both > get? > My point is that arm_smmu_alloc_cd_ptr() doesn’t only allocate the leaf, but also the L1 through arm_smmu_alloc_cd_tables() IMO, arm_smmu_alloc_cd_ptr() should only allocate leafs. And inside arm_smmu_attach_dev() it calls arm_smmu_alloc_cd_tables(). This makes it clear which path is expected to allocate the L1 table. And arm_smmu_get_cd_ptr() will remain as is. Thanks, Mostafa > Thanks, > Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 236F6C4345F for ; Sat, 27 Apr 2024 22:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JMblvwELl/buyO/iMiyWohGUBZ85m2ZfKW43yieV14g=; b=A45xioNrMW03PY JKN79NF6mOXPIVq4WpVENkYAUN07D+biTx/zhILZsIK8ob7WXkfano2XT31Z7bJ9mUCWX1sFEeDOr XNU+hLwDmEXYl3M9MZgozEo48gs1aK409NxMbgjN2K/peYSMcrDQKR8/unwg28D5dGp3JODz+H+Dn cG+WKx4biOd0c+PdUmZkEUEipXLPHf0UdnhLDxpQDBK7i4LPfPgajJzDz03m7AY0+/SEoD1R9mDtI 61H/t13dgrrcUrJ+n3kkJhEX0lHiNIfXHySZvSIXR1Ndgdg6ntqHdvV/W5hIyFdSMiZYVV6v46vD1 +GrurC12OQ5zCsNNRgeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0qOZ-0000000GKvY-2Wsz; Sat, 27 Apr 2024 22:19:47 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0qOW-0000000GKun-1h1M for linux-arm-kernel@lists.infradead.org; Sat, 27 Apr 2024 22:19:46 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-5188f5dd62dso1535e87.0 for ; Sat, 27 Apr 2024 15:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714256382; x=1714861182; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=h3EqdV1cLUjuhm5Iq+lAUnqb4b0RY2+WR64uEdCo72o=; b=s3hxW0/oHaVryY8U9Cbjuy6h859ucOTQ+bl+VrgAG6JS7ZJwp/q1qEmgRHUzYEyuRE gyu+RSBqkQWmL2S+jmBq3dS6AOsb9hcqmRXoQzJgHLekJv0CPywP1Sju1Rk27mIwQvZa 0UOpAqV5VdQ/1+UWCFlS/E8yyOrTC6w5+3GRMktPasKanXOkclzZjq8v+Dk/cuXGAcdV B8n1qRG9ucCYg5YhHhYrnnLqVSksBWeP4OdMUAQWrg0KBqyyYwwe3ujxkYaNt3HddAu/ KY7V2KBHByLwsP58qH/Tv1SKDf+oOTFkgc0YgYCbxhG30upmDt8l+g5xs5dBVT1cN9FZ TEgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714256382; x=1714861182; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h3EqdV1cLUjuhm5Iq+lAUnqb4b0RY2+WR64uEdCo72o=; b=mb3WemkmdLqiFjmZvt8fUyt+qrbMrq0eKsTenZk+kbAuE5KU/Ba5erKqEhWvFae52w 2En/1WqaYDS6sTJ7sNj6ch2ZDZm6r5hWJiIlXmXQ8zEwMjkk3BXccmQacJ7ejzSagKNI zkW0GRCbHIL2gfMeAXOe1lfH4LsJ44Vwo8i8+meO4IPzCwEbIMVJFYnAf1owGnsk53oo bCjuBXjrAE/CoJcehCMlppR545wFPjmtJgLROLo/40hHAVPoCfD4UNXw0oTkDriLjvRX U69ePd/Ai0OZZ3VZOWo4K2p+R+c6S/EG1iHLcvuAvtHOq3dx/VOZ9GjGpK6HzrHeUHZX RiVQ== X-Forwarded-Encrypted: i=1; AJvYcCUaBeFsGYDhT1MoUVHBaZf40DyPah9ROl33j2Uz24e4WFh+Pzj8aBD4F+GEmilRf1i+vmey9/+ZrqTm44+H2jnZd/1Fe217zVg+e0wvhe2VrZCV45g= X-Gm-Message-State: AOJu0YxMEyg2RPq7b1g8dalhHe60ImvJilsrhzenLEo3O70gln20Q+hk 9xdXDjtDYfPFUpPMWBmdzmZeIJB1wYmfrVJu0cNj51vSw0SJbDHqWu8xLTMa1g== X-Google-Smtp-Source: AGHT+IG+6yrjzRA8FcBXQd6yCX5t+zowVD9Nanhc4t+NuiGe4rpqSbSc/uueQ2J/GTaL2DXAlYJ6wg== X-Received: by 2002:a19:e048:0:b0:51d:68cb:e505 with SMTP id g8-20020a19e048000000b0051d68cbe505mr11781lfj.4.1714256382275; Sat, 27 Apr 2024 15:19:42 -0700 (PDT) Received: from google.com (180.232.140.34.bc.googleusercontent.com. [34.140.232.180]) by smtp.gmail.com with ESMTPSA id l7-20020adffe87000000b0034c7330da82sm4130390wrr.80.2024.04.27.15.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 15:19:41 -0700 (PDT) Date: Sat, 27 Apr 2024 22:19:37 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Eric Auger , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v7 5/9] iommu/arm-smmu-v3: Make arm_smmu_alloc_cd_ptr() Message-ID: References: <0-v7-cb149db3a320+3b5-smmuv3_newapi_p2_jgg@nvidia.com> <5-v7-cb149db3a320+3b5-smmuv3_newapi_p2_jgg@nvidia.com> <20240422142053.GD49823@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240422142053.GD49823@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240427_151944_484701_580EF474 X-CRM114-Status: GOOD ( 44.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBcHIgMjIsIDIwMjQgYXQgMTE6MjA6NTNBTSAtMDMwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IE9uIEZyaSwgQXByIDE5LCAyMDI0IGF0IDA5OjE0OjIxUE0gKzAwMDAsIE1vc3Rh ZmEgU2FsZWggd3JvdGU6Cj4gPiBIaSBKYXNvbiwKPiA+IAo+ID4gT24gVHVlLCBBcHIgMTYsIDIw MjQgYXQgMDQ6Mjg6MTZQTSAtMDMwMCwgSmFzb24gR3VudGhvcnBlIHdyb3RlOgo+ID4gPiBPbmx5 IHRoZSBhdHRhY2ggY2FsbGVycyBjYW4gcGVyZm9ybSBhbiBhbGxvY2F0aW9uIGZvciB0aGUgQ0Qg dGFibGUgZW50cnksCj4gPiA+IHRoZSBvdGhlciBjYWxsZXJzIG11c3Qgbm90IGRvIHNvLCB0aGV5 IGRvIG5vdCBoYXZlIHRoZSBjb3JyZWN0IGxvY2tpbmcgYW5kCj4gPiA+IHRoZXkgY2Fubm90IHNs ZWVwLiBTcGxpdCB1cCB0aGUgZnVuY3Rpb25zIHNvIHRoaXMgaXMgY2xlYXIuCj4gPiA+IAo+ID4g PiBhcm1fc21tdV9nZXRfY2RfcHRyKCkgd2lsbCByZXR1cm4gcG9pbnRlciB0byBhIENEIHRhYmxl IGVudHJ5IHdpdGhvdXQKPiA+ID4gZG9pbmcgYW55IGtpbmQgb2YgYWxsb2NhdGlvbi4KPiA+ID4g Cj4gPiA+IGFybV9zbW11X2FsbG9jX2NkX3B0cigpIHdpbGwgYWxsb2NhdGUgdGhlIHRhYmxlIGFu ZCBhbnkgcmVxdWlyZWQKPiA+ID4gbGVhZi4KPiA+ID4gCj4gPiA+IEEgZm9sbG93aW5nIHBhdGNo IHdpbGwgYWRkIGxvY2tkZXAgYXNzZXJ0aW9ucyB0byBhcm1fc21tdV9hbGxvY19jZF9wdHIoKQo+ ID4gPiBvbmNlIHRoZSByZXN0cnVjdHVyaW5nIGlzIGNvbXBsZXRlZCBhbmQgYXJtX3NtbXVfYWxs b2NfY2RfcHRyKCkgaXMgbmV2ZXIKPiA+ID4gY2FsbGVkIGluIHRoZSB3cm9uZyBjb250ZXh0Lgo+ ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogSmFzb24gR3VudGhvcnBlIDxqZ2dAbnZpZGlhLmNv bT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2lvbW11L2FybS9hcm0tc21tdS12My9hcm0tc21t dS12My5jIHwgNjEgKysrKysrKysrKysrKy0tLS0tLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwg MzkgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYyBiL2RyaXZlcnMv aW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMKPiA+ID4gaW5kZXggZjNkZjFlYzhk MjU4ZGMuLmEwZDEyMzcyNzI5MzZmIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2lvbW11L2Fy bS9hcm0tc21tdS12My9hcm0tc21tdS12My5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJt L2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMKPiA+ID4gQEAgLTk4LDYgKzk4LDcgQEAgc3RhdGlj IHN0cnVjdCBhcm1fc21tdV9vcHRpb25fcHJvcCBhcm1fc21tdV9vcHRpb25zW10gPSB7Cj4gPiA+ ICAKPiA+ID4gIHN0YXRpYyBpbnQgYXJtX3NtbXVfZG9tYWluX2ZpbmFsaXNlKHN0cnVjdCBhcm1f c21tdV9kb21haW4gKnNtbXVfZG9tYWluLAo+ID4gPiAgCQkJCSAgICBzdHJ1Y3QgYXJtX3NtbXVf ZGV2aWNlICpzbW11KTsKPiA+ID4gK3N0YXRpYyBpbnQgYXJtX3NtbXVfYWxsb2NfY2RfdGFibGVz KHN0cnVjdCBhcm1fc21tdV9tYXN0ZXIgKm1hc3Rlcik7Cj4gPiA+ICAKPiA+ID4gIHN0YXRpYyB2 b2lkIHBhcnNlX2RyaXZlcl9vcHRpb25zKHN0cnVjdCBhcm1fc21tdV9kZXZpY2UgKnNtbXUpCj4g PiA+ICB7Cj4gPiA+IEBAIC0xMjA3LDI5ICsxMjA4LDUxIEBAIHN0YXRpYyB2b2lkIGFybV9zbW11 X3dyaXRlX2NkX2wxX2Rlc2MoX19sZTY0ICpkc3QsCj4gPiA+ICBzdHJ1Y3QgYXJtX3NtbXVfY2Qg KmFybV9zbW11X2dldF9jZF9wdHIoc3RydWN0IGFybV9zbW11X21hc3RlciAqbWFzdGVyLAo+ID4g PiAgCQkJCQl1MzIgc3NpZCkKPiA+ID4gIHsKPiA+ID4gLQlfX2xlNjQgKmwxcHRyOwo+ID4gPiAt CXVuc2lnbmVkIGludCBpZHg7Cj4gPiA+ICAJc3RydWN0IGFybV9zbW11X2wxX2N0eF9kZXNjICps MV9kZXNjOwo+ID4gPiAtCXN0cnVjdCBhcm1fc21tdV9kZXZpY2UgKnNtbXUgPSBtYXN0ZXItPnNt bXU7Cj4gPiA+ICAJc3RydWN0IGFybV9zbW11X2N0eF9kZXNjX2NmZyAqY2RfdGFibGUgPSAmbWFz dGVyLT5jZF90YWJsZTsKPiA+ID4gIAo+ID4gPiArCWlmICghY2RfdGFibGUtPmNkdGFiKQo+ID4g PiArCQlyZXR1cm4gTlVMTDsKPiA+ID4gKwo+ID4gPiAgCWlmIChjZF90YWJsZS0+czFmbXQgPT0g U1RSVEFCX1NURV8wX1MxRk1UX0xJTkVBUikKPiA+ID4gIAkJcmV0dXJuIChzdHJ1Y3QgYXJtX3Nt bXVfY2QgKikoY2RfdGFibGUtPmNkdGFiICsKPiA+ID4gIAkJCQkJICAgICAgc3NpZCAqIENUWERF U0NfQ0RfRFdPUkRTKTsKPiA+ID4gIAo+ID4gPiAtCWlkeCA9IHNzaWQgPj4gQ1RYREVTQ19TUExJ VDsKPiA+ID4gLQlsMV9kZXNjID0gJmNkX3RhYmxlLT5sMV9kZXNjW2lkeF07Cj4gPiA+IC0JaWYg KCFsMV9kZXNjLT5sMnB0cikgewo+ID4gPiAtCQlpZiAoYXJtX3NtbXVfYWxsb2NfY2RfbGVhZl90 YWJsZShzbW11LCBsMV9kZXNjKSkKPiA+ID4gLQkJCXJldHVybiBOVUxMOwo+ID4gPiArCWwxX2Rl c2MgPSAmY2RfdGFibGUtPmwxX2Rlc2Nbc3NpZCAvIENUWERFU0NfTDJfRU5UUklFU107Cj4gPiAK PiA+IFRoZXNlIG9wZXJhdGlvbnMgdXNlZCB0byBiZSBzaGlmdCBhbmQgYml0IG1hc2tpbmcgd2hp Y2ggbWFkZSBzZW5zZSBhcyBpdCBkb2VzCj4gPiB3aGF0IGhhcmR3YXJlIGRvZXMsIGlzIHRoZXJl IGFueSByZWFzb24geW91IGNoYW5nZWQgaXQgdG8gZGl2aXNpb24gYW5kIG1vZHVsbz8KPiA+IEkg Y2hlY2tlZCB0aGUgZGlzYXNzZW1ibHkgYW5kIGdjYyBkb2VzIHRoZSByaWdodCB0aGluZyBhcyBj b25zdGFudHMgYXJlIHBvd2VyCj4gPiBvZiAyLCBidXQgSSBhbSBqdXN0IGN1cmlvdXMuCj4gCj4g SSBnZW5lcmFsbHkgcHJlZmVyIHRoZSBjbGFyaXR5IGFuZCBzdWNjaW5jdG5lc3Mgb2YgLyBhbmQg JSBpbnN0ZWFkIG9mCj4gaGFja2luZyB1cCBiaXQgb3BlcmF0aW9ucyB0aGF0IHRoZSBjb21waWxl ciB3aWxsIGdlbmVyYXRlCj4gYXV0b21hdGljYWxseSBhbnlob3cuCj4gCj4gSWYgYml0IGV4dHJh Y3Rpb25zIHNob3VsZCBiZSB1c2VkIGl0IGlzIGJldHRlciB0byB3cmFwIGl0IGluCj4gRklFTERf R0VUKCkgdGhhbiBvcGVuIGNvZGUgaXQuLgo+IAo+ID4gPiArc3RhdGljIHN0cnVjdCBhcm1fc21t dV9jZCAqYXJtX3NtbXVfYWxsb2NfY2RfcHRyKHN0cnVjdCBhcm1fc21tdV9tYXN0ZXIgKm1hc3Rl ciwKPiA+ID4gKwkJCQkJCSB1MzIgc3NpZCkKPiA+ID4gK3sKPiA+ID4gKwlzdHJ1Y3QgYXJtX3Nt bXVfY3R4X2Rlc2NfY2ZnICpjZF90YWJsZSA9ICZtYXN0ZXItPmNkX3RhYmxlOwo+ID4gPiArCXN0 cnVjdCBhcm1fc21tdV9kZXZpY2UgKnNtbXUgPSBtYXN0ZXItPnNtbXU7Cj4gPiA+ICsKPiA+ID4g KwlpZiAoIWNkX3RhYmxlLT5jZHRhYikgewo+ID4gPiArCQlpZiAoYXJtX3NtbXVfYWxsb2NfY2Rf dGFibGVzKG1hc3RlcikpCj4gPiA+ICsJCQlyZXR1cm4gTlVMTDsKPiA+ID4gIAl9Cj4gPiA+IC0J aWR4ID0gc3NpZCAmIChDVFhERVNDX0wyX0VOVFJJRVMgLSAxKTsKPiA+ID4gLQlyZXR1cm4gJmwx X2Rlc2MtPmwycHRyW2lkeF07Cj4gPiA+ICsKPiA+ID4gKwlpZiAoY2RfdGFibGUtPnMxZm10ID09 IFNUUlRBQl9TVEVfMF9TMUZNVF82NEtfTDIpIHsKPiA+ID4gKwkJdW5zaWduZWQgaW50IGlkeCA9 IHNzaWQgPj4gQ1RYREVTQ19TUExJVDsKPiA+IAo+ID4gT2ssIG5vdyBpdOKAmXMgYSBzaGlmdCwg SSB0aGluayB3ZSBzaG91bGQgYmUgY29uc2lzdGVudCB3aXRoIGhvdyB3ZQo+ID4gY2FsY3VsYXRl IHRoZSBpbmRleC4KPiAKPiBTdXJlLiBDaGFuZ2UgdGhhdCB0byAvIHdpbGwgbWFrZSBDVFhERVND X1NQTElUIHVudXNlZCBleGNlcHQgaW4KPiBjb21wdXRpbmcgQ1RYREVTQ19MMl9FTlRSSUVTIHNv IHRoYXQgY2FuIGJlIHNpbXBsaWZpZWQgdG9vOgo+IAo+IC0jZGVmaW5lIENUWERFU0NfU1BMSVQg ICAgICAgICAgICAgICAgICAxMAo+IC0jZGVmaW5lIENUWERFU0NfTDJfRU5UUklFUyAgICAgICAg ICAgICAoMSA8PCBDVFhERVNDX1NQTElUKQo+ICsjZGVmaW5lIENUWERFU0NfTDJfRU5UUklFUyAg ICAgICAgICAgICAxMDI0Cj4gCgpTb3VuZHMgZ29vZCwgSSBkb27igJl0IHRoaW5rIGl0IG1hdHRl cnMgbXVjaCBhcyBsb25nIGFzIGl0cyBjb25zaXN0ZW50LCBidXQKYW55d2F5IHRoZSBzcGxpdCBp cyBkZWZpbmVkIGJ5IHRoZSBzcGVjIHRvIGJlIGVpdGhlciA2LCA4IG9yIDEwLgpTbyBzcGxpdCBz aXplIGhhcyB0byBiZSBhIHBvd2VyIG9mIDIuCgo+IAo+ID4gPiBAQCAtMTM1Nyw3ICsxMzgwLDcg QEAgaW50IGFybV9zbW11X3dyaXRlX2N0eF9kZXNjKHN0cnVjdCBhcm1fc21tdV9tYXN0ZXIgKm1h c3RlciwgaW50IHNzaWQsCj4gPiA+ICAJaWYgKFdBUk5fT04oc3NpZCA+PSAoMSA8PCBjZF90YWJs ZS0+czFjZG1heCkpKQo+ID4gPiAgCQlyZXR1cm4gLUUyQklHOwo+ID4gPiAgCj4gPiA+IC0JY2Rf dGFibGVfZW50cnkgPSBhcm1fc21tdV9nZXRfY2RfcHRyKG1hc3Rlciwgc3NpZCk7Cj4gPiA+ICsJ Y2RfdGFibGVfZW50cnkgPSBhcm1fc21tdV9hbGxvY19jZF9wdHIobWFzdGVyLCBzc2lkKTsKPiA+ IAo+ID4gVGhlIG9ubHkgcGF0aCBhbGxvY2F0ZXMgdGhlIG1haW4gdGFibGUgaXMg4oCcYXJtX3Nt bXVfYXR0YWNoX2RlduKAnSwKPiAKPiBUaGVyZSBhcmUgdHdvIHBsYWNlcyB0aGF0IGFsbG9jYXRl IHRoZSBsZWFmLCBhcm1fc21tdV9hdHRhY2hfZGV2KCkKPiAoZm9yIHRoZSBSSUQpIGFuZCBhcm1f c21tdV9zdmFfc2V0X2Rldl9wYXNpZCgpIChmb3IgYSBQQVNJRCkKPiAKPiBBdCB0aGlzIG1vbWVu dCBhbGwgdGhlIHBhdGhzIGFyZSByZWx5aW5nIG9uIHRoZSBhYm92ZSB0byBhbGxvY2F0ZSB0aGUK PiBsZWFmLiBUaGUgbmV4dCBwYXRjaCBtYWtlcyBhcm1fc21tdV9hdHRhY2hfZGV2KCkgYWxsb2Nh dGUgdGhlIGxlYWYKPiBpdHNlbGYuIEEgZmV3IG1vcmUgcGF0Y2hlcyBhbHNvIG1ha2VzIHRoZSBQ QVNJRCBwYXRoIGFsbG9jYXRlIHRoZSBsZWFmCj4gaXRzZWxmLCB3aGVuIHRoZSBhYm92ZSBpcyBy ZW1vdmVkLgo+IAo+ID4gSSBndWVzcyBpdCB3b3VsZCBiZSBtb3JlIHJvYnVzdCB0byBsZWF2ZSB0 aGF0IGFzIGlzIGFuZCBoYXZlIDIKPiA+IHZlcnNpb25zIG9mIGdldF9jZCwgb25lIHRoYXQgYWxs b2NhdGVzIGxlYWYgYW5kIG9uZSB0aGF0IGlzIG5vdAo+ID4gYWxsb2NhdGluZywgd2hhdCBkbyB5 b3UgdGhpbms/Cj4gCj4gSSdtIG5vdCBzdXJlIHdoYXQgeW91IGFyZSBhc2tpbmc/IFdlIGhhdmUg dHdvIHZlcnNpb25zLiBPbmUgaXMgY2FsbGVkCj4gYWxsb2MgYW5kIG9uZSBpcyBjYWxsZWQgZ2V0 LiBUaGF0IGhhdmUgZGlmZmVyZW50IGxvY2tpbmcgcmVxdWlyZW1lbnRzCj4gb24gdGhlIGNhbGxl ciBzbyB0aGV5IGhhdmUgZGlmZmVyZW50IG5hbWVzLiBJIHdvdWxkIG5vdCBjYWxsIHRoZW0gYm90 aAo+IGdldD8KPiAKCk15IHBvaW50IGlzIHRoYXQgYXJtX3NtbXVfYWxsb2NfY2RfcHRyKCkgZG9l c27igJl0IG9ubHkgYWxsb2NhdGUgdGhlIGxlYWYsCmJ1dCBhbHNvIHRoZSBMMSB0aHJvdWdoIGFy bV9zbW11X2FsbG9jX2NkX3RhYmxlcygpCgpJTU8sIGFybV9zbW11X2FsbG9jX2NkX3B0cigpIHNo b3VsZCBvbmx5IGFsbG9jYXRlIGxlYWZzLiBBbmQgaW5zaWRlCmFybV9zbW11X2F0dGFjaF9kZXYo KSBpdCBjYWxscyBhcm1fc21tdV9hbGxvY19jZF90YWJsZXMoKS4KVGhpcyBtYWtlcyBpdCBjbGVh ciB3aGljaCBwYXRoIGlzIGV4cGVjdGVkIHRvIGFsbG9jYXRlIHRoZSBMMSB0YWJsZS4KCkFuZCBh cm1fc21tdV9nZXRfY2RfcHRyKCkgd2lsbCByZW1haW4gYXMgaXMuCgpUaGFua3MsCk1vc3RhZmEK Cj4gVGhhbmtzLAo+IEphc29uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==