From: Juerg Haefliger <juergh@protonmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Juerg Haefliger <juerg.haefliger@canonical.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files
Date: Wed, 27 Apr 2022 15:46:33 +0000 [thread overview]
Message-ID: <_GyJWTeZu6emLzFDC3fwvOlBC6CqO2OT6cl_P8DnD9DHXND2rEgLQu6naToxpYZzorpJVZXkVJ1JB3ASqcRSncyBCcov8084Q8YABhoDCL4=@protonmail.com> (raw)
In-Reply-To: <7E038C77-771A-415D-B963-128EB5DD9D48@holtmann.org>
------- Original Message -------
On Wednesday, April 27th, 2022 at 14:49, Marcel Holtmann <marcel@holtmann.org> wrote:
>
>
> Hi Juerg,
>
> > The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE
> > macros to povide that information via modinfo.
> >
> > Signed-off-by: Juerg Haefliger juergh@protonmail.com
> > ---
> > drivers/bluetooth/ath3k.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> > index 88262d3a9392..56e9a64177ae 100644
> > --- a/drivers/bluetooth/ath3k.c
> > +++ b/drivers/bluetooth/ath3k.c
> > @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver");
> > MODULE_VERSION(VERSION);
> > MODULE_LICENSE("GPL");
> > MODULE_FIRMWARE(ATH3K_FIRMWARE);
> > +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu");
> > +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu");
>
>
> since when do we allow GLOB pattern matching here?
Not sure when that was first introduced but:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75729e110e680687668fd5b4bdd7b25c92e9c00d
...Juerg
> Regards
>
> Marcel
prev parent reply other threads:[~2022-04-27 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 6:35 [PATCH] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files Juerg Haefliger
2022-04-27 7:13 ` bluez.test.bot
2022-04-27 12:49 ` [PATCH] " Marcel Holtmann
2022-04-27 15:46 ` Juerg Haefliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='_GyJWTeZu6emLzFDC3fwvOlBC6CqO2OT6cl_P8DnD9DHXND2rEgLQu6naToxpYZzorpJVZXkVJ1JB3ASqcRSncyBCcov8084Q8YABhoDCL4=@protonmail.com' \
--to=juergh@protonmail.com \
--cc=johan.hedberg@gmail.com \
--cc=juerg.haefliger@canonical.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.