From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5FDC43334 for ; Fri, 8 Jul 2022 21:24:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238904AbiGHVYr (ORCPT ); Fri, 8 Jul 2022 17:24:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238498AbiGHVYq (ORCPT ); Fri, 8 Jul 2022 17:24:46 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF41D2A250 for ; Fri, 8 Jul 2022 14:24:43 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id y3so158958iof.4 for ; Fri, 08 Jul 2022 14:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=42cZlLqESbSzGOIQC6IhKSPqgo/QyLTrwwAMCp9WNzo=; b=IV0paG90JHXaGZbrxl8pRjANIsQWCXppiwcKYlmXVIxXcJ27wNUF4yH2g+6tA4C+qd mamfHwnW/lcS3+Uv/gPQPJf5q/UUMz6XSShpn+/NkJMb/c/gai50uarqyLdYdTFa7a08 wnNNt2hidpsVCeeD1GYrXUswLcElFqWYI67m0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=42cZlLqESbSzGOIQC6IhKSPqgo/QyLTrwwAMCp9WNzo=; b=JYGO3x/hWSwFZK/Tt1rUUV2rNE62OB2c63dEwrnfKwQ5xUko9sGmPgm9aqkMKc9iiG tE9ZNU+tBzdb3OSmAW8QWFg4Oe8C6mnInEXtTXFtJD/Hny8V8wM8qjpmxnup/2CnRQ3d YPd50xSB+m2AVeOVVYBWtI6rXeuEiwTCS3KrJ69Fc6YRddnP3qmN3Am9OJp4Q+66vJTr GhfTJpKnSTbwZ6+1He0SOhSB+7omS6yyHXvIfRtGWWFhBXQ5hEl7jm5LG8PuiBfQISN4 gXVUVEHXpjKWCYFgDeV/r7xOZrHHz6b1vDS06HDqmHJf//qgLsRQ+TUl9mxLkjgXVp6d FnSg== X-Gm-Message-State: AJIora+UGqmpH0F2+ffDbGEuOgK7ot5EOvMFTxubVLbJJg6Q+ZXRup8n /Gt/6fmQRe2Nfjf6oSU6XUd60Q== X-Google-Smtp-Source: AGRyM1sZRJgZl+2OfYXRBrVXka293FsGfZm0I0q0MCwgNYiktkDFQ9OSDQ5BXDPGzW4St1/3aCUuqA== X-Received: by 2002:a05:6638:438b:b0:33c:b617:fb46 with SMTP id bo11-20020a056638438b00b0033cb617fb46mr3370276jab.238.1657315483051; Fri, 08 Jul 2022 14:24:43 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id a13-20020a927f0d000000b002d8f50441absm16814624ild.10.2022.07.08.14.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jul 2022 14:24:42 -0700 (PDT) Subject: Re: [PATCH v6 3/4] kunit: Taint the kernel when KUnit tests are run To: Daniel Latypov Cc: David Gow , Andrew Morton , Brendan Higgins , "Guilherme G . Piccoli" , Sebastian Reichel , John Ogness , Joe Fradley , Luis Chamberlain , Nathan Chancellor , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Andy Shevchenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jani Nikula , Lucas De Marchi , Aaron Tomlin , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Michal Marek , Nick Desaulniers , Jonathan Corbet , linux-kbuild@vger.kernel.org, Greg KH , Masahiro Yamada , Kees Cook , Shuah Khan References: <20220708044847.531566-1-davidgow@google.com> <20220708044847.531566-3-davidgow@google.com> From: Shuah Khan Message-ID: Date: Fri, 8 Jul 2022 15:24:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 7/8/22 3:22 PM, Shuah Khan wrote: > On 7/8/22 3:00 PM, Daniel Latypov wrote: >> On Fri, Jul 8, 2022 at 1:22 PM Shuah Khan wrote: >>> >>> On 7/7/22 10:48 PM, David Gow wrote: >>>> Make KUnit trigger the new TAINT_TEST taint when any KUnit test is run. >>>> Due to KUnit tests not being intended to run on production systems, and >>>> potentially causing problems (or security issues like leaking kernel >>>> addresses), the kernel's state should not be considered safe for >>>> production use after KUnit tests are run. >>>> >>>> This both marks KUnit modules as test modules using MODULE_INFO() and >>>> manually taints the kernel when tests are run (which catches builtin >>>> tests). >>>> >>>> Acked-by: Luis Chamberlain >>>> Tested-by: Daniel Latypov >>>> Reviewed-by: Brendan Higgins >>>> Signed-off-by: David Gow >>>> --- >>>> >>>> No changes since v5: >>>> https://lore.kernel.org/linux-kselftest/20220702040959.3232874-3-davidgow@google.com/ >>>> >>>> No changes since v4: >>>> https://lore.kernel.org/linux-kselftest/20220701084744.3002019-3-davidgow@google.com/ >>>> >>> >>> David, Brendan, Andrew, >>> >>> Just confirming the status of these patches. I applied v4 1/3 and v4 3/4 >>> to linux-kselftest kunit for 5.20-rc1. >>> I am seeing v5 and v6 now. Andrew applied v5 looks like. Would you like >>> me to drop the two I applied? Do we have to refresh with v6? >> >> Just noting here that there'll be a merge conflict between this patch >> (3/4) and some other patches lined up to go through the kunit tree: >> https://patchwork.kernel.org/project/linux-kselftest/patch/20220625050838.1618469-2-davidgow@google.com/ >> >> Not sure how we want to handle that. >> > > I can go drop the two patches and have Andrew carry the series through > mm tree. > Sorry spoke too soon. Yes there are others that might have conflicts as Daniel pointed out: https://patchwork.kernel.org/project/linux-kselftest/patch/20220625050838.1618469-2-davidgow@google.com/ thanks, -- Shuah