From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8263BC4332E for ; Thu, 19 Mar 2020 15:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5798520724 for ; Thu, 19 Mar 2020 15:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727690AbgCSPsI (ORCPT ); Thu, 19 Mar 2020 11:48:08 -0400 Received: from mga01.intel.com ([192.55.52.88]:31964 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726912AbgCSPsI (ORCPT ); Thu, 19 Mar 2020 11:48:08 -0400 IronPort-SDR: 9gdBxmL9hnnQaMcQAJLjxnEhTQjbCA/dfCnqYRqXjgIAfQ5Muud0MD6wnxkWtXR8BsqX5DbR/7 Jjk79lqYzyMw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 08:48:07 -0700 IronPort-SDR: CGTdcGF3z7TQ09hhIoa4PjIUsXi6Tbq+unUG7nuDe2of5JawDCFCSTssDwLvkPSjQcKLQgravP imxwFtrF77Pg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,572,1574150400"; d="scan'208";a="245198430" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.249.128.140]) ([10.249.128.140]) by orsmga003.jf.intel.com with ESMTP; 19 Mar 2020 08:48:04 -0700 Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 To: Mark Brown , Dominik Brodowski Cc: kuninori.morimoto.gx@renesas.com, Pierre-Louis Bossart , Keyon Jie , alsa-devel@alsa-project.org, curtis@malainey.com, linux-kernel@vger.kernel.org, tiwai@suse.com, liam.r.girdwood@linux.intel.com References: <41d0b2b5-6014-6fab-b6a2-7a7dbc4fe020@linux.intel.com> <20200318123930.GA2433@light.dominikbrodowski.net> <20200318162029.GA3999@light.dominikbrodowski.net> <20200318192213.GA2987@light.dominikbrodowski.net> <20200318215218.GA2439@light.dominikbrodowski.net> <20200319130049.GA2244@light.dominikbrodowski.net> <20200319134139.GB3983@sirena.org.uk> From: Cezary Rojewski Message-ID: Date: Thu, 19 Mar 2020 16:48:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200319134139.GB3983@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-03-19 14:41, Mark Brown wrote: > On Thu, Mar 19, 2020 at 02:00:49PM +0100, Dominik Brodowski wrote: > >> Have some good news now, namely that a bisect is complete: That pointed to >> 1272063a7ee4 ("ASoC: soc-core: care .ignore_suspend for Component suspend"); >> therefore I've added Kuninori Morimoto to this e-mail thread. > > If that's an issue it feels more like a driver bug in that if the driver > asked for ignore_suspend then it should expect not to have the suspend > callback called. > Requested for tests with following diff applied: diff --git a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c index db7e1e87156d..6ed4c1b0a515 100644 --- a/sound/soc/intel/boards/broadwell.c +++ b/sound/soc/intel/boards/broadwell.c @@ -212,7 +212,6 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = { .init = broadwell_rt286_codec_init, .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS, - .ignore_suspend = 1, .ignore_pmdown_time = 1, .be_hw_params_fixup = broadwell_ssp0_fixup, .ops = &broadwell_rt286_ops, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 436A8C4332D for ; Thu, 19 Mar 2020 15:49:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C31D520724 for ; Thu, 19 Mar 2020 15:49:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="sGqEDmmn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C31D520724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 280BE1778; Thu, 19 Mar 2020 16:48:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 280BE1778 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584632946; bh=zFd1rVZAKvfeFtBxbCg3bYts2QcL2bqomqYikg/QkMY=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sGqEDmmnhhRmuNHx/K+Xa3k7HEYYubkkogFYHF/58nA49+VIcqlwknj6SaMwAITIl V2BAzQc/XAP6m+fu1aLhWyFVLOdeRwInQaRYSRaweSLLz2MjfwqYM9PAgrm/INdFsG NuOxSrsao8ofJJxTkGu/hQIDcvmfrGetUm3aXiiI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 83CCEF8012F; Thu, 19 Mar 2020 16:48:15 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B8038F8022B; Thu, 19 Mar 2020 16:48:13 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 70E44F8012F for ; Thu, 19 Mar 2020 16:48:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 70E44F8012F IronPort-SDR: jB3qZBiqdRkoQnmyLQDFzvTeA8frwdpLKCLBOJ+upDz2MZK/3VWZLzf9TTwSj3rs3d2CGHxjKl hSMI/SuN/KPQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 08:48:07 -0700 IronPort-SDR: CGTdcGF3z7TQ09hhIoa4PjIUsXi6Tbq+unUG7nuDe2of5JawDCFCSTssDwLvkPSjQcKLQgravP imxwFtrF77Pg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,572,1574150400"; d="scan'208";a="245198430" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.249.128.140]) ([10.249.128.140]) by orsmga003.jf.intel.com with ESMTP; 19 Mar 2020 08:48:04 -0700 Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 To: Mark Brown , Dominik Brodowski References: <41d0b2b5-6014-6fab-b6a2-7a7dbc4fe020@linux.intel.com> <20200318123930.GA2433@light.dominikbrodowski.net> <20200318162029.GA3999@light.dominikbrodowski.net> <20200318192213.GA2987@light.dominikbrodowski.net> <20200318215218.GA2439@light.dominikbrodowski.net> <20200319130049.GA2244@light.dominikbrodowski.net> <20200319134139.GB3983@sirena.org.uk> From: Cezary Rojewski Message-ID: Date: Thu, 19 Mar 2020 16:48:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200319134139.GB3983@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, curtis@malainey.com, tiwai@suse.com, Keyon Jie , Pierre-Louis Bossart , linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2020-03-19 14:41, Mark Brown wrote: > On Thu, Mar 19, 2020 at 02:00:49PM +0100, Dominik Brodowski wrote: > >> Have some good news now, namely that a bisect is complete: That pointed to >> 1272063a7ee4 ("ASoC: soc-core: care .ignore_suspend for Component suspend"); >> therefore I've added Kuninori Morimoto to this e-mail thread. > > If that's an issue it feels more like a driver bug in that if the driver > asked for ignore_suspend then it should expect not to have the suspend > callback called. > Requested for tests with following diff applied: diff --git a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c index db7e1e87156d..6ed4c1b0a515 100644 --- a/sound/soc/intel/boards/broadwell.c +++ b/sound/soc/intel/boards/broadwell.c @@ -212,7 +212,6 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = { .init = broadwell_rt286_codec_init, .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS, - .ignore_suspend = 1, .ignore_pmdown_time = 1, .be_hw_params_fixup = broadwell_ssp0_fixup, .ops = &broadwell_rt286_ops,