From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751516AbdIKUR0 (ORCPT ); Mon, 11 Sep 2017 16:17:26 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:35709 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbdIKURM (ORCPT ); Mon, 11 Sep 2017 16:17:12 -0400 X-Google-Smtp-Source: AOwi7QBHtgaDNbkBlcBM2gFtb7qXNXLm6ncaZ2SL9HaWpOIUMLrCa9VUUntRjPff7nikiUedKiaf+g== Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' To: Jan Kara , Christophe JAILLET Cc: tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> <20170911201506.GA15044@quack2.suse.cz> From: Jens Axboe Message-ID: Date: Mon, 11 Sep 2017 14:17:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170911201506.GA15044@quack2.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2017 02:15 PM, Jan Kara wrote: > On Mon 11-09-17 21:43:23, Christophe JAILLET wrote: >> If the 'kmalloc' fails, we must go through the existing error handling >> path. >> >> Signed-off-by: Christophe JAILLET > > Looks good to me. You can add: > > Reviewed-by: Jan Kara I'll queue it up, with your reviewed-by added. Thanks. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Mon, 11 Sep 2017 20:17:09 +0000 Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' Message-Id: List-Id: References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> <20170911201506.GA15044@quack2.suse.cz> In-Reply-To: <20170911201506.GA15044@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jan Kara , Christophe JAILLET Cc: tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 09/11/2017 02:15 PM, Jan Kara wrote: > On Mon 11-09-17 21:43:23, Christophe JAILLET wrote: >> If the 'kmalloc' fails, we must go through the existing error handling >> path. >> >> Signed-off-by: Christophe JAILLET > > Looks good to me. You can add: > > Reviewed-by: Jan Kara I'll queue it up, with your reviewed-by added. Thanks. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f71.google.com (mail-it0-f71.google.com [209.85.214.71]) by kanga.kvack.org (Postfix) with ESMTP id AEA446B02EE for ; Mon, 11 Sep 2017 16:17:12 -0400 (EDT) Received: by mail-it0-f71.google.com with SMTP id u2so12914769itb.7 for ; Mon, 11 Sep 2017 13:17:12 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a64sor3885335iog.208.2017.09.11.13.17.11 for (Google Transport Security); Mon, 11 Sep 2017 13:17:11 -0700 (PDT) Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> <20170911201506.GA15044@quack2.suse.cz> From: Jens Axboe Message-ID: Date: Mon, 11 Sep 2017 14:17:09 -0600 MIME-Version: 1.0 In-Reply-To: <20170911201506.GA15044@quack2.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jan Kara , Christophe JAILLET Cc: tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 09/11/2017 02:15 PM, Jan Kara wrote: > On Mon 11-09-17 21:43:23, Christophe JAILLET wrote: >> If the 'kmalloc' fails, we must go through the existing error handling >> path. >> >> Signed-off-by: Christophe JAILLET > > Looks good to me. You can add: > > Reviewed-by: Jan Kara I'll queue it up, with your reviewed-by added. Thanks. -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org