From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B00C2BA19 for ; Wed, 15 Apr 2020 10:47:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9730D20737 for ; Wed, 15 Apr 2020 10:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2896457AbgDOKSf (ORCPT ); Wed, 15 Apr 2020 06:18:35 -0400 Received: from foss.arm.com ([217.140.110.172]:41504 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896381AbgDOKPN (ORCPT ); Wed, 15 Apr 2020 06:15:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C81D1063; Wed, 15 Apr 2020 03:15:12 -0700 (PDT) Received: from [10.37.9.9] (unknown [10.37.9.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 20C533F68F; Wed, 15 Apr 2020 03:15:10 -0700 (PDT) Subject: Re: [PATCH v2 3/6] arm64/vdso: Add time napespace page To: Mark Rutland , Andrei Vagin Cc: linux-arm-kernel@lists.infradead.org, LKML , Thomas Gleixner , Dmitry Safonov References: <20200225073731.465270-1-avagin@gmail.com> <20200225073731.465270-4-avagin@gmail.com> <20200414172014.GA6705@C02TD0UTHF1T.local> <20200415100539.GA27339@C02TD0UTHF1T.local> From: Vincenzo Frascino Message-ID: Date: Wed, 15 Apr 2020 11:16:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200415100539.GA27339@C02TD0UTHF1T.local> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 4/15/20 11:05 AM, Mark Rutland wrote: > It's a shame we're not using OPTIMIZER_HIDE_VAR() for that, as it can > generate slightly better code and is easier to read than bare asm. We are not because I was not aware when I wrote this code that such a macro existed :) But you are right it clearly makes the code more readable. To make up for it, I am happy to make the effort to introduce it for both the cases and replace the assembler once this patch series gets merged. -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBAD4C3815B for ; Wed, 15 Apr 2020 10:15:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93F5E20775 for ; Wed, 15 Apr 2020 10:15:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m7+j9BGN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93F5E20775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JhSsA4aTGD6ZfveDFGjZPJmp9abjS1c96tn0uBSHVfM=; b=m7+j9BGNtcYiZ0 U5DJm5rsdx1wmba9+Cd3qX2bN8eTluZduox9FfPyLc0J6OUamnADARpfme3YuGoiYYVyUyOf6SKpy jeDvE0ML+WaaaDTKJO3chaqzLu1xRoHWTBhNxD4JGj9tapH6eeleTvhQ20bzxlCqLr+OQo74ovcHT bmVkluAOSjYLv2JARRa1ScSJ10A3U/BpsUyTXTKsRBDa78O7yrk10Wvk/Pls4FrcGtKDwISn7AOhU JCB39cvI/Oz9pEq7bIFDwRivgMHlijW5u61czmDGTNza8wvBptbl6LllU6SZQyUuVuRG7iQQjtEvz xcweEjX1XcW0QTvyIcOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOf4h-0005op-Ko; Wed, 15 Apr 2020 10:15:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOf4d-00050u-EO for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 10:15:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C81D1063; Wed, 15 Apr 2020 03:15:12 -0700 (PDT) Received: from [10.37.9.9] (unknown [10.37.9.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 20C533F68F; Wed, 15 Apr 2020 03:15:10 -0700 (PDT) Subject: Re: [PATCH v2 3/6] arm64/vdso: Add time napespace page To: Mark Rutland , Andrei Vagin References: <20200225073731.465270-1-avagin@gmail.com> <20200225073731.465270-4-avagin@gmail.com> <20200414172014.GA6705@C02TD0UTHF1T.local> <20200415100539.GA27339@C02TD0UTHF1T.local> From: Vincenzo Frascino Message-ID: Date: Wed, 15 Apr 2020 11:16:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200415100539.GA27339@C02TD0UTHF1T.local> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_031515_569601_7AB4DEE2 X-CRM114-Status: GOOD ( 11.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , LKML , linux-arm-kernel@lists.infradead.org, Dmitry Safonov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, On 4/15/20 11:05 AM, Mark Rutland wrote: > It's a shame we're not using OPTIMIZER_HIDE_VAR() for that, as it can > generate slightly better code and is easier to read than bare asm. We are not because I was not aware when I wrote this code that such a macro existed :) But you are right it clearly makes the code more readable. To make up for it, I am happy to make the effort to introduce it for both the cases and replace the assembler once this patch series gets merged. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel