From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 230F3C4743C for ; Wed, 23 Jun 2021 09:14:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EF43600CC for ; Wed, 23 Jun 2021 09:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230053AbhFWJRE (ORCPT ); Wed, 23 Jun 2021 05:17:04 -0400 Received: from foss.arm.com ([217.140.110.172]:60362 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbhFWJRD (ORCPT ); Wed, 23 Jun 2021 05:17:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7696C31B; Wed, 23 Jun 2021 02:14:46 -0700 (PDT) Received: from [10.57.10.184] (unknown [10.57.10.184]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 90D5A3F719; Wed, 23 Jun 2021 02:14:44 -0700 (PDT) Subject: Re: [RFC PATCH 3/4] cpufreq: Add Active Stats calls tracking frequency changes To: Viresh Kumar Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, amitk@kernel.org, rui.zhang@intel.com, dietmar.eggemann@arm.com, Chris.Redpath@arm.com, Beata.Michalska@arm.com, rjw@rjwysocki.net, amit.kachhap@gmail.com References: <20210622075925.16189-1-lukasz.luba@arm.com> <20210622075925.16189-4-lukasz.luba@arm.com> <20210622093258.lddlznwsndpw5mju@vireshk-i7> <20210623031517.tldkue7dcx4bt7gn@vireshk-i7> From: Lukasz Luba Message-ID: Date: Wed, 23 Jun 2021 10:14:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210623031517.tldkue7dcx4bt7gn@vireshk-i7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/21 4:15 AM, Viresh Kumar wrote: > On 22-06-21, 12:07, Lukasz Luba wrote: >> That cpufreq_stats_record_transition() is present only if >> CONFIG_CPU_FREQ_STAT is set. I didn't wanted to be dependent on >> this config. > > Right, but you can also update the dummy > cpufreq_stats_record_transition() function as well and you won't > depend on the CONFIG then. It would look a bit 'hidden', but I can do that. It will require the header active_stats.h in that cpufreq.h to add the line in the empty cpufreq_stats_record_transition(). If Rafael would also agree, then I can put it there.