From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E4EC4338F for ; Fri, 6 Aug 2021 09:35:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29E2F611BF for ; Fri, 6 Aug 2021 09:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244588AbhHFJgE (ORCPT ); Fri, 6 Aug 2021 05:36:04 -0400 Received: from mail-sn1anam02on2118.outbound.protection.outlook.com ([40.107.96.118]:6064 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S244527AbhHFJgC (ORCPT ); Fri, 6 Aug 2021 05:36:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6s+P+pztLyESNSE6p1yXQA6ha2WUydcg0MzOrclUyy54991+NeqPDA0Jhf/pfjzeKHhJJ7nzdV5fgrmqVcPiivO5Uy+KhFsJ09292Zh7txOF3ahATFqNwNH05yD6xb9hMPcqEiKg6H5JLMAIb/Tn/GvDZ1jUzt5iN32V5NHdOofRRB3xtx5ghf9SX5+MJSjx997MdPqsBckHqTJg3e1yRyUk4pSm7MpJhs0LRBpdNGP1qmt+26oOZs4oKP5VOPB0UJwDQ54d0nKICpPPTdwqrjB2LtGsMghBY5L1xyLTW4UZpIQIE+DVXSI4HwiVgP6AeC7lCtB2B3qKsX45VM0IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WheNvOQb7m5Nb2xbnVsY1/4nzMe7gWxmw7EIWbYnNb0=; b=fV/y3JndkAlDb0/AUDrE1eLGvv3tnd1MMmmr5U2g51npXsZM9s+8vvUB1SW3TiA9WYHMuh2UnX2VhVh1bNDdBT3AmbPAs2XoZ5KZ0vw/PiyhI2A1g3WKV3HTYilWgibmAjyjOKd2tPqqpzM7a5VOknAZ1ok17wSK3MkwPspoljyHv9PY1lIoCj0lqkz9W5s4pq4j1Da3vtRo8DCbhXiuquqCaBlRsMoUOPpPaYdDcmt7n+0P74N86suh41dWBbNCVQMT1HgXSlgEFHZ8lK3r1VJ0w0FXwXgt7SOOZsEuBK1g1rNtdPzyboQXtTX4Km2Oeb3jaVsyfbT35ilL6TzyLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=analogixsemi.com; dmarc=pass action=none header.from=analogixsemi.com; dkim=pass header.d=analogixsemi.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Analogixsemi.onmicrosoft.com; s=selector2-Analogixsemi-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WheNvOQb7m5Nb2xbnVsY1/4nzMe7gWxmw7EIWbYnNb0=; b=RoJE96kQ3r1Zh9XkRsDwwmZ0NOa47g3jmImYw4rYv9fnvC+wBJyIj+Vhr3s7XZHPB/c0ByqzpMbuCGjrdU3lb3U9ZZfJNoJvlPuXNithxNq6wyohB2KfExdxH+uxCOlQJQ793QbdXoWor2gkD0FOWTi0M51hhrPo/ZJu4PbsvPk= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=analogixsemi.com; Received: from BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) by BY5PR04MB6786.namprd04.prod.outlook.com (2603:10b6:a03:221::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.19; Fri, 6 Aug 2021 09:35:42 +0000 Received: from BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::5c0e:fbe5:2bd6:ec6]) by BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::5c0e:fbe5:2bd6:ec6%3]) with mapi id 15.20.4394.019; Fri, 6 Aug 2021 09:35:42 +0000 Date: Fri, 6 Aug 2021 17:35:35 +0800 From: Xin Ji To: Robert Foss , Nicolas Boichat , Andrzej Hajda , Sam Ravnborg Cc: Neil Armstrong , Laurent Pinchart , Jonas Karlman , Dan Carpenter , David Airlie , Daniel Vetter , Boris Brezillon , Hsin-Yi Wang , Torsten Duwe , Vasily Khoruzhick , Marek Szyprowski , Bernie Liang , Qilin Wen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH v2 1/1] drm/bridge: anx7625: Tune K value for IVO panel Message-ID: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-ClientProxiedBy: HK2PR02CA0188.apcprd02.prod.outlook.com (2603:1096:201:21::24) To BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from anxtwsw-Precision-3640-Tower (60.251.58.79) by HK2PR02CA0188.apcprd02.prod.outlook.com (2603:1096:201:21::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17 via Frontend Transport; Fri, 6 Aug 2021 09:35:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5d56317-af2e-4b2d-cf9a-08d958bd8efc X-MS-TrafficTypeDiagnostic: BY5PR04MB6786: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /K6LtZmzncsk7LwOuVoRKfzP2EzdiZqo69oZbt1RipJ3yVODYsOFB2PRwNseYgHokKAbkK1fguwwdqPgyu5ZfeeRXLTBHkBFCiMylPlkxzsQvJ2H+o5+lWoqmpsxIbJj7SQAPPE6AYxbsXV0bmFKj5dgWFuKDMQU2aiwZJ0Y4Eia4+KsbE5v+tfqrbaffFOty1Zk7Lak71cHuM2bLiaMFsGHNV/yUz8D7CpM8MfGiOWKyyq52Lhy6EFvAWmSoVu2CZUaW68eI1UFEiWDWNrQBA5JUESi0jFuWWVNT0+M47O8f2uMT5G+WHDMaJdp3UEpPZe6VY4HMnjVGnvWEDWAnXM/nZLD9mj8SIhqFd9yCeb19Rafcoig3BAYvBKpknYADXWRCCclqvHXctMldHjS35sT8nW7bytcF/CLkkB9BY2ARYAWr6mOBp3SwWzYSP1cfWCkixgzM+wqhUNMIrjKy1egci4PN4iasdfKT4+lWqmo1hfJo8CKcPAY1YV9u1bsrBcfmxl7sRtvOjbcvn1cukz5qonVcG7nKjHNPI6pxlVwpkOwsyMAmxEBoJ8ckRyBz9HauCSzWi/GFQ6GQR66id6S2PqJRSWNcoDyFoRDUzn4jQgWfUl6SoyJsVjeVs5VC5Kkg5+nXQ/DEk0TZ0T6MH4DqKbz4VrFvNbPhkwdPNYnUZzOx+Rs3Nw6SJEnfYBl9LtH/dQwS6ZmXBzKEIamDw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR04MB6739.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(39840400004)(346002)(136003)(396003)(86362001)(6666004)(38350700002)(38100700002)(36756003)(83380400001)(52116002)(6496006)(478600001)(26005)(66556008)(186003)(66476007)(55236004)(66946007)(8936002)(8676002)(2906002)(7416002)(6486002)(5660300002)(4326008)(316002)(54906003)(110136005)(2616005)(956004);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8xypd/H1zSnt74K/9LdeZ7du+qL0zgO1gzNLT6o2utdQ6LeIxI/BVddCyieG?= =?us-ascii?Q?zf1uQgeAB7k8CwRoWU/mrLT3eg+7sWp37CCR1Z24hQRDZFXtORFy1zj4X55W?= =?us-ascii?Q?qu7abHVFyafOHsbHsqp9M6zFxfqyCnzqj2KY7sNvfYV84c/S0znQRv4aPBgL?= =?us-ascii?Q?6YxraVFbczJzO3vOOpRm/YJyWs0dUkyWIIA3VJIbctEgUYcXIdFQw+Co4M89?= =?us-ascii?Q?zHq6WsmblLvtUqKO4U49PuzUQFqae0aqIi9ZfOlXdYSPriXMswtLjf7BSV7v?= =?us-ascii?Q?4f48aGRFJL0cfsxbZii5rF76Afvjy9LwOwi2gd3+zZgOXKE4svMcwm8hY8VQ?= =?us-ascii?Q?4XeHEa1T/WLXXqdEp5wP3oakR2I3t0QEo//0Z7cboSN3vYhbUffHgicAMWQV?= =?us-ascii?Q?Qejhpm8sggCknFYtmP0omvqFonV9gjVl36dc3Hu4TTPfykqUlCt0MRqomAMI?= =?us-ascii?Q?fWsSqkpI0oGLTBZFR3jpDbcJ2C8XLFACJtgv4pKmKvu+rZOEJRD/hbMZ+/fq?= =?us-ascii?Q?2IwvnNI8jThMbkzNHUHP5wA310oGo+89SzxehtiyKEjVrtNe7GW5tq8q8/Uh?= =?us-ascii?Q?DH1UphvoKnH4mf3V3Xv2oKdgncaxDEp69GgkBcLjh2aAxNV/WoDxRXF+tNP7?= =?us-ascii?Q?lMP55+uEHly1W0iwST7k751LaEpB3vebWvaUHJLWV0J/Lo1bGwCJPKxGbZmB?= =?us-ascii?Q?qe2FeQK8uAxlPgDDaTo+uIglktwI+FZoeKQIuW0x+I742pPAE1b9igIipHbM?= =?us-ascii?Q?Vppz6wmPF92u3BA+c+HEJpIpY98sp1y5oGaDWnaduzfCaCOkCMmc/8RqYGP7?= =?us-ascii?Q?7Ty4ds4ZUMQwnzkP8ZHtfVGmYcpG54z+3r12XLnMpXFTvnwzOkvfJrx+wN1r?= =?us-ascii?Q?sciTKIszOno040OtQsIiFbVeKmVy8GqHKO3UKf0bp8nKDeEbXWfp3gjASXMG?= =?us-ascii?Q?9uDTFShUFWnOyJVZJ4qiFs/0IJnjbp7hug51ZIa5t+cUoGHStsbUCeqIfAFR?= =?us-ascii?Q?/fqWIiAYQyeVIwNotELmHUcdzj0b+dEI4pv0IhV7M6iW2Cl8cW4ExhrMUHSC?= =?us-ascii?Q?oWZt6fOaeWgTw37DLojn575uSQMm/Sox2zNXj49Apcmr7r/LCBdG/icBOvja?= =?us-ascii?Q?WoRXFWr3nZ/rJ/fwFp3+z4qBlMvQ5t+YALRekwxUz+hakqhB2c6qQUWYDy1x?= =?us-ascii?Q?GMoqTEbfk0iy46Z6irMZBdJJLrifQ6ZVcjRdILHZwVbNwa1QRJgXGBEx+JJo?= =?us-ascii?Q?yHRVlUjg6+Gt888NpHlfrryyrVtA6E5m5uNgHwtzHCLZUK/XhB5UFXYVF0H9?= =?us-ascii?Q?pDBlgt0xBblEJZiaxvCnyQ3+?= X-OriginatorOrg: analogixsemi.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5d56317-af2e-4b2d-cf9a-08d958bd8efc X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2021 09:35:42.3529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xsgwJum1eaN4VPVP4PXPN6+Nv0alHpsFTaHWB632Kl/n1TUPBznyNWJDIXY2TKUi96oOGz9X6PVJdw/l2U7t/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6786 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IVO panel require less input video clock variation than video clock variation in DP CTS spec. This patch decreases the K value of ANX7625 which will shrink eDP Tx video clock variation to meet IVO panel's requirement. Acked-by: Sam Ravnborg Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 24 ++++++++++++++++++++--- drivers/gpu/drm/bridge/analogix/anx7625.h | 4 +++- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index a3d82377066b..9b9e3984dd38 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -384,6 +384,25 @@ static int anx7625_odfc_config(struct anx7625_data *ctx, return ret; } +/* + * The MIPI source video data exist large variation (e.g. 59Hz ~ 61Hz), + * anx7625 defined K ratio for matching MIPI input video clock and + * DP output video clock. Increase K value can match bigger video data + * variation. IVO panel has small variation than DP CTS spec, need + * decrease the K value. + */ +static int anx7625_set_k_value(struct anx7625_data *ctx) +{ + struct edid *edid = (struct edid *)ctx->slimport_edid_p.edid_raw_data; + + if (edid->mfg_id[0] == IVO_MID0 && edid->mfg_id[1] == IVO_MID1) + return anx7625_reg_write(ctx, ctx->i2c.rx_p1_client, + MIPI_DIGITAL_ADJ_1, 0x3B); + + return anx7625_reg_write(ctx, ctx->i2c.rx_p1_client, + MIPI_DIGITAL_ADJ_1, 0x3D); +} + static int anx7625_dsi_video_timing_config(struct anx7625_data *ctx) { struct device *dev = &ctx->client->dev; @@ -470,9 +489,8 @@ static int anx7625_dsi_video_timing_config(struct anx7625_data *ctx) MIPI_PLL_N_NUM_15_8, (n >> 8) & 0xff); ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p1_client, MIPI_PLL_N_NUM_7_0, (n & 0xff)); - /* Diff */ - ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p1_client, - MIPI_DIGITAL_ADJ_1, 0x3D); + + anx7625_set_k_value(ctx); ret |= anx7625_odfc_config(ctx, post_divider - 1); diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.h b/drivers/gpu/drm/bridge/analogix/anx7625.h index 034c3840028f..6dcf64c703f9 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.h +++ b/drivers/gpu/drm/bridge/analogix/anx7625.h @@ -210,7 +210,9 @@ #define MIPI_VIDEO_STABLE_CNT 0x0A #define MIPI_LANE_CTRL_10 0x0F -#define MIPI_DIGITAL_ADJ_1 0x1B +#define MIPI_DIGITAL_ADJ_1 0x1B +#define IVO_MID0 0x26 +#define IVO_MID1 0xCF #define MIPI_PLL_M_NUM_23_16 0x1E #define MIPI_PLL_M_NUM_15_8 0x1F -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10382C432BE for ; Fri, 6 Aug 2021 09:35:53 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6EE861181 for ; Fri, 6 Aug 2021 09:35:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A6EE861181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=analogixsemi.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 33349400C2; Fri, 6 Aug 2021 09:35:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ttDiujAHduTo; Fri, 6 Aug 2021 09:35:51 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id CFC56402E8; Fri, 6 Aug 2021 09:35:50 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1953E1BF3B0 for ; Fri, 6 Aug 2021 09:35:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 08C1E82D04 for ; Fri, 6 Aug 2021 09:35:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=analogixsemi.onmicrosoft.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H3RPfeIaVMAh for ; Fri, 6 Aug 2021 09:35:47 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2110.outbound.protection.outlook.com [40.107.92.110]) by smtp1.osuosl.org (Postfix) with ESMTPS id D035E82C91 for ; Fri, 6 Aug 2021 09:35:47 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6s+P+pztLyESNSE6p1yXQA6ha2WUydcg0MzOrclUyy54991+NeqPDA0Jhf/pfjzeKHhJJ7nzdV5fgrmqVcPiivO5Uy+KhFsJ09292Zh7txOF3ahATFqNwNH05yD6xb9hMPcqEiKg6H5JLMAIb/Tn/GvDZ1jUzt5iN32V5NHdOofRRB3xtx5ghf9SX5+MJSjx997MdPqsBckHqTJg3e1yRyUk4pSm7MpJhs0LRBpdNGP1qmt+26oOZs4oKP5VOPB0UJwDQ54d0nKICpPPTdwqrjB2LtGsMghBY5L1xyLTW4UZpIQIE+DVXSI4HwiVgP6AeC7lCtB2B3qKsX45VM0IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WheNvOQb7m5Nb2xbnVsY1/4nzMe7gWxmw7EIWbYnNb0=; b=fV/y3JndkAlDb0/AUDrE1eLGvv3tnd1MMmmr5U2g51npXsZM9s+8vvUB1SW3TiA9WYHMuh2UnX2VhVh1bNDdBT3AmbPAs2XoZ5KZ0vw/PiyhI2A1g3WKV3HTYilWgibmAjyjOKd2tPqqpzM7a5VOknAZ1ok17wSK3MkwPspoljyHv9PY1lIoCj0lqkz9W5s4pq4j1Da3vtRo8DCbhXiuquqCaBlRsMoUOPpPaYdDcmt7n+0P74N86suh41dWBbNCVQMT1HgXSlgEFHZ8lK3r1VJ0w0FXwXgt7SOOZsEuBK1g1rNtdPzyboQXtTX4Km2Oeb3jaVsyfbT35ilL6TzyLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=analogixsemi.com; dmarc=pass action=none header.from=analogixsemi.com; dkim=pass header.d=analogixsemi.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Analogixsemi.onmicrosoft.com; s=selector2-Analogixsemi-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WheNvOQb7m5Nb2xbnVsY1/4nzMe7gWxmw7EIWbYnNb0=; b=RoJE96kQ3r1Zh9XkRsDwwmZ0NOa47g3jmImYw4rYv9fnvC+wBJyIj+Vhr3s7XZHPB/c0ByqzpMbuCGjrdU3lb3U9ZZfJNoJvlPuXNithxNq6wyohB2KfExdxH+uxCOlQJQ793QbdXoWor2gkD0FOWTi0M51hhrPo/ZJu4PbsvPk= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=analogixsemi.com; Received: from BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) by BY5PR04MB6786.namprd04.prod.outlook.com (2603:10b6:a03:221::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.19; Fri, 6 Aug 2021 09:35:42 +0000 Received: from BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::5c0e:fbe5:2bd6:ec6]) by BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::5c0e:fbe5:2bd6:ec6%3]) with mapi id 15.20.4394.019; Fri, 6 Aug 2021 09:35:42 +0000 Date: Fri, 6 Aug 2021 17:35:35 +0800 From: Xin Ji To: Robert Foss , Nicolas Boichat , Andrzej Hajda , Sam Ravnborg Subject: [PATCH v2 1/1] drm/bridge: anx7625: Tune K value for IVO panel Message-ID: Content-Disposition: inline X-ClientProxiedBy: HK2PR02CA0188.apcprd02.prod.outlook.com (2603:1096:201:21::24) To BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from anxtwsw-Precision-3640-Tower (60.251.58.79) by HK2PR02CA0188.apcprd02.prod.outlook.com (2603:1096:201:21::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17 via Frontend Transport; Fri, 6 Aug 2021 09:35:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5d56317-af2e-4b2d-cf9a-08d958bd8efc X-MS-TrafficTypeDiagnostic: BY5PR04MB6786: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /K6LtZmzncsk7LwOuVoRKfzP2EzdiZqo69oZbt1RipJ3yVODYsOFB2PRwNseYgHokKAbkK1fguwwdqPgyu5ZfeeRXLTBHkBFCiMylPlkxzsQvJ2H+o5+lWoqmpsxIbJj7SQAPPE6AYxbsXV0bmFKj5dgWFuKDMQU2aiwZJ0Y4Eia4+KsbE5v+tfqrbaffFOty1Zk7Lak71cHuM2bLiaMFsGHNV/yUz8D7CpM8MfGiOWKyyq52Lhy6EFvAWmSoVu2CZUaW68eI1UFEiWDWNrQBA5JUESi0jFuWWVNT0+M47O8f2uMT5G+WHDMaJdp3UEpPZe6VY4HMnjVGnvWEDWAnXM/nZLD9mj8SIhqFd9yCeb19Rafcoig3BAYvBKpknYADXWRCCclqvHXctMldHjS35sT8nW7bytcF/CLkkB9BY2ARYAWr6mOBp3SwWzYSP1cfWCkixgzM+wqhUNMIrjKy1egci4PN4iasdfKT4+lWqmo1hfJo8CKcPAY1YV9u1bsrBcfmxl7sRtvOjbcvn1cukz5qonVcG7nKjHNPI6pxlVwpkOwsyMAmxEBoJ8ckRyBz9HauCSzWi/GFQ6GQR66id6S2PqJRSWNcoDyFoRDUzn4jQgWfUl6SoyJsVjeVs5VC5Kkg5+nXQ/DEk0TZ0T6MH4DqKbz4VrFvNbPhkwdPNYnUZzOx+Rs3Nw6SJEnfYBl9LtH/dQwS6ZmXBzKEIamDw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR04MB6739.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(366004)(39840400004)(346002)(136003)(396003)(86362001)(6666004)(38350700002)(38100700002)(36756003)(83380400001)(52116002)(6496006)(478600001)(26005)(66556008)(186003)(66476007)(55236004)(66946007)(8936002)(8676002)(2906002)(7416002)(6486002)(5660300002)(4326008)(316002)(54906003)(110136005)(2616005)(956004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8xypd/H1zSnt74K/9LdeZ7du+qL0zgO1gzNLT6o2utdQ6LeIxI/BVddCyieG?= =?us-ascii?Q?zf1uQgeAB7k8CwRoWU/mrLT3eg+7sWp37CCR1Z24hQRDZFXtORFy1zj4X55W?= =?us-ascii?Q?qu7abHVFyafOHsbHsqp9M6zFxfqyCnzqj2KY7sNvfYV84c/S0znQRv4aPBgL?= =?us-ascii?Q?6YxraVFbczJzO3vOOpRm/YJyWs0dUkyWIIA3VJIbctEgUYcXIdFQw+Co4M89?= =?us-ascii?Q?zHq6WsmblLvtUqKO4U49PuzUQFqae0aqIi9ZfOlXdYSPriXMswtLjf7BSV7v?= =?us-ascii?Q?4f48aGRFJL0cfsxbZii5rF76Afvjy9LwOwi2gd3+zZgOXKE4svMcwm8hY8VQ?= =?us-ascii?Q?4XeHEa1T/WLXXqdEp5wP3oakR2I3t0QEo//0Z7cboSN3vYhbUffHgicAMWQV?= =?us-ascii?Q?Qejhpm8sggCknFYtmP0omvqFonV9gjVl36dc3Hu4TTPfykqUlCt0MRqomAMI?= =?us-ascii?Q?fWsSqkpI0oGLTBZFR3jpDbcJ2C8XLFACJtgv4pKmKvu+rZOEJRD/hbMZ+/fq?= =?us-ascii?Q?2IwvnNI8jThMbkzNHUHP5wA310oGo+89SzxehtiyKEjVrtNe7GW5tq8q8/Uh?= =?us-ascii?Q?DH1UphvoKnH4mf3V3Xv2oKdgncaxDEp69GgkBcLjh2aAxNV/WoDxRXF+tNP7?= =?us-ascii?Q?lMP55+uEHly1W0iwST7k751LaEpB3vebWvaUHJLWV0J/Lo1bGwCJPKxGbZmB?= =?us-ascii?Q?qe2FeQK8uAxlPgDDaTo+uIglktwI+FZoeKQIuW0x+I742pPAE1b9igIipHbM?= =?us-ascii?Q?Vppz6wmPF92u3BA+c+HEJpIpY98sp1y5oGaDWnaduzfCaCOkCMmc/8RqYGP7?= =?us-ascii?Q?7Ty4ds4ZUMQwnzkP8ZHtfVGmYcpG54z+3r12XLnMpXFTvnwzOkvfJrx+wN1r?= =?us-ascii?Q?sciTKIszOno040OtQsIiFbVeKmVy8GqHKO3UKf0bp8nKDeEbXWfp3gjASXMG?= =?us-ascii?Q?9uDTFShUFWnOyJVZJ4qiFs/0IJnjbp7hug51ZIa5t+cUoGHStsbUCeqIfAFR?= =?us-ascii?Q?/fqWIiAYQyeVIwNotELmHUcdzj0b+dEI4pv0IhV7M6iW2Cl8cW4ExhrMUHSC?= =?us-ascii?Q?oWZt6fOaeWgTw37DLojn575uSQMm/Sox2zNXj49Apcmr7r/LCBdG/icBOvja?= =?us-ascii?Q?WoRXFWr3nZ/rJ/fwFp3+z4qBlMvQ5t+YALRekwxUz+hakqhB2c6qQUWYDy1x?= =?us-ascii?Q?GMoqTEbfk0iy46Z6irMZBdJJLrifQ6ZVcjRdILHZwVbNwa1QRJgXGBEx+JJo?= =?us-ascii?Q?yHRVlUjg6+Gt888NpHlfrryyrVtA6E5m5uNgHwtzHCLZUK/XhB5UFXYVF0H9?= =?us-ascii?Q?pDBlgt0xBblEJZiaxvCnyQ3+?= X-OriginatorOrg: analogixsemi.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5d56317-af2e-4b2d-cf9a-08d958bd8efc X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2021 09:35:42.3529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xsgwJum1eaN4VPVP4PXPN6+Nv0alHpsFTaHWB632Kl/n1TUPBznyNWJDIXY2TKUi96oOGz9X6PVJdw/l2U7t/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6786 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Jonas Karlman , David Airlie , Qilin Wen , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Vasily Khoruzhick , Boris Brezillon , Torsten Duwe , Laurent Pinchart , Daniel Vetter , Hsin-Yi Wang , Bernie Liang , Dan Carpenter , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" IVO panel require less input video clock variation than video clock variation in DP CTS spec. This patch decreases the K value of ANX7625 which will shrink eDP Tx video clock variation to meet IVO panel's requirement. Acked-by: Sam Ravnborg Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 24 ++++++++++++++++++++--- drivers/gpu/drm/bridge/analogix/anx7625.h | 4 +++- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index a3d82377066b..9b9e3984dd38 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -384,6 +384,25 @@ static int anx7625_odfc_config(struct anx7625_data *ctx, return ret; } +/* + * The MIPI source video data exist large variation (e.g. 59Hz ~ 61Hz), + * anx7625 defined K ratio for matching MIPI input video clock and + * DP output video clock. Increase K value can match bigger video data + * variation. IVO panel has small variation than DP CTS spec, need + * decrease the K value. + */ +static int anx7625_set_k_value(struct anx7625_data *ctx) +{ + struct edid *edid = (struct edid *)ctx->slimport_edid_p.edid_raw_data; + + if (edid->mfg_id[0] == IVO_MID0 && edid->mfg_id[1] == IVO_MID1) + return anx7625_reg_write(ctx, ctx->i2c.rx_p1_client, + MIPI_DIGITAL_ADJ_1, 0x3B); + + return anx7625_reg_write(ctx, ctx->i2c.rx_p1_client, + MIPI_DIGITAL_ADJ_1, 0x3D); +} + static int anx7625_dsi_video_timing_config(struct anx7625_data *ctx) { struct device *dev = &ctx->client->dev; @@ -470,9 +489,8 @@ static int anx7625_dsi_video_timing_config(struct anx7625_data *ctx) MIPI_PLL_N_NUM_15_8, (n >> 8) & 0xff); ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p1_client, MIPI_PLL_N_NUM_7_0, (n & 0xff)); - /* Diff */ - ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p1_client, - MIPI_DIGITAL_ADJ_1, 0x3D); + + anx7625_set_k_value(ctx); ret |= anx7625_odfc_config(ctx, post_divider - 1); diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.h b/drivers/gpu/drm/bridge/analogix/anx7625.h index 034c3840028f..6dcf64c703f9 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.h +++ b/drivers/gpu/drm/bridge/analogix/anx7625.h @@ -210,7 +210,9 @@ #define MIPI_VIDEO_STABLE_CNT 0x0A #define MIPI_LANE_CTRL_10 0x0F -#define MIPI_DIGITAL_ADJ_1 0x1B +#define MIPI_DIGITAL_ADJ_1 0x1B +#define IVO_MID0 0x26 +#define IVO_MID1 0xCF #define MIPI_PLL_M_NUM_23_16 0x1E #define MIPI_PLL_M_NUM_15_8 0x1F -- 2.25.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel