From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB085C433F5 for ; Thu, 16 Sep 2021 21:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C87D761216 for ; Thu, 16 Sep 2021 21:45:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237870AbhIPVqW (ORCPT ); Thu, 16 Sep 2021 17:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238100AbhIPVqT (ORCPT ); Thu, 16 Sep 2021 17:46:19 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 309A5C061766 for ; Thu, 16 Sep 2021 14:44:58 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id t20so5507337pju.5 for ; Thu, 16 Sep 2021 14:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=J7zGtdLvKvOe8ICH65aGgixwwBsF46sfmmNr6BguxYU=; b=jsYa6l8OxInYrPcDf850gMevL8Ib/4g5G6K2fQYhyle7LVVynjDg8ZpCEcdCe1h5As OYK6N+TKII0GS8JT4L+Ys2HNWzvztZ52ZwL8ZaZrKl1xhN/TBXeBZOqq2HZeFHz0B45v lkiZ6C4wJwSyJR9JrluoaukLjRn0VedZcMth+BWFcno2rhogSUl1kSM7S/GdJzptOCVG opzjKCtMUFztrNj8GrxVTtJAnHLwe1vSIgiUvH5MBciXE/1IzaTWclFtM8ThMfcLfM5L pFwLTjLM2Y6cnWWXKXMYbFIRhqNcQimMSvSW62Ai+Pq7sZwuVfdFYJkH428tSiu2Y6O+ MB5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J7zGtdLvKvOe8ICH65aGgixwwBsF46sfmmNr6BguxYU=; b=fsd2qjRjD8KVeU8RHexLSNiFN94BZQBejjWBH4aU6PPNS2QXKz4yKA2erlZ43zUJmk jzuyPFXZXMR7dG6pLByVpuG+FxmDvMFJVllOASdkWK8cTrLAHVOzNZn8qC1sybW2QXdb zihsnyfDCQ6/1mb4qN+GpS5E0DVFnFW2+YksVScdasN4DOBZD57knV6nJRZj/dLoy8fC RtNmVGbBkba0KKuJyANtV0smVcBeVFb0CCc7L4IB2qNvcQUvbFvhB1At3iCkX+sE4UL6 4VlPDSOIJ6mdEcd0CNDrl1XLjrBwvr6kYJflXWl+OPpQKc5pf90seQhslyJu6jacB2Rc U+pg== X-Gm-Message-State: AOAM533bw8P1K/jVYuvo3HUVk1/HlFwTVfUveBt9+ebWzs8OYI5bRd6V WnrBd+h+Eyn1GiYo9cpOnuY= X-Google-Smtp-Source: ABdhPJz+r2bR5Cp4aK5/9SFR11GdphDuX9bH5Y9XpLcjMwKbVRmKoXiIGmmdb7slTJJKJEz57eHa7w== X-Received: by 2002:a17:902:8503:b0:13a:366:8c46 with SMTP id bj3-20020a170902850300b0013a03668c46mr6491917plb.37.1631828697644; Thu, 16 Sep 2021 14:44:57 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id f205sm2937968pfa.92.2021.09.16.14.44.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 14:44:56 -0700 (PDT) Subject: Re: [PATCH net-next 3/4] net: dsa: b53: Improve flow control setup on BCM5301x To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20210916120354.20338-1-zajec5@gmail.com> <20210916120354.20338-4-zajec5@gmail.com> From: Florian Fainelli Message-ID: Date: Thu, 16 Sep 2021 14:44:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210916120354.20338-4-zajec5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/16/21 5:03 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > According to the Broadcom's reference driver flow control needs to be > enabled for any CPU switch port (5, 7 or 8 - depending on which one is > used). Current code makes it work only for the port 5. Use > dsa_is_cpu_port() which solved that problem. > > Signed-off-by: Rafał Miłecki Reviewed-by: Florian Fainelli Tested-by: Florian Fainelli -- Florian