From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E99C43464 for ; Mon, 21 Sep 2020 09:41:15 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEE962076B for ; Mon, 21 Sep 2020 09:41:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="niCR5aNs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEE962076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKIJg-0005jY-UK; Mon, 21 Sep 2020 09:41:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKIJf-0005jS-MD for xen-devel@lists.xenproject.org; Mon, 21 Sep 2020 09:40:59 +0000 X-Inumbo-ID: aad083be-d7ea-4c4d-9f00-bfa8c477baa6 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id aad083be-d7ea-4c4d-9f00-bfa8c477baa6; Mon, 21 Sep 2020 09:40:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1600681257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CzC+YjMWGNadFsl5pePwNNxVz4TI7BNFOlIZPG3cNVg=; b=niCR5aNs+lwW/LjSrfMQEnNq0zsvxGpVbIQiBYzCuoODjXxCPJQcsSd7iHnoV29LY2WoUC 0whn7Qeixci/AbMXe485gPIYz171k4tRGvyCF+P2JOYTCJSC1VdPkoei85i1TfiYViJ04m TSzc+Yj2INtuuS3shSiiYQwLxQsfCps= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6DCB5ADB3; Mon, 21 Sep 2020 09:41:33 +0000 (UTC) Subject: Re: qemu and Xen ABI-unstable libs To: paul@xen.org Cc: 'Ian Jackson' , "'Debian folks: Michael Tokarev'" , 'Hans van Kranenburg' , "'Xen upstream folks with an interest: Andrew Cooper'" , =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= , pkg-xen-devel@lists.alioth.debian.org, xen-devel@lists.xenproject.org, "'My Xen upstream tools co-maintainer: Wei Liu'" References: <24420.58027.291045.507128@mariner.uk.xensource.com> <001b01d68fe9$fb3ae060$f1b0a120$@xen.org> From: Jan Beulich Message-ID: Date: Mon, 21 Sep 2020 11:40:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <001b01d68fe9$fb3ae060$f1b0a120$@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 21.09.2020 09:36, Paul Durrant wrote: >> From: Xen-devel On Behalf Of Ian Jackson >> Sent: 18 September 2020 17:39 >> >> xc_domain_iomem_permission >> xc_domain_populate_physmap_exact >> xc_domain_ioport_mapping >> xc_domain_memory_mapping >> >> The things done by these calls in qemu should be done by the Xen >> toolstack (libxl), during domain creation etc., instead. > > I don't think that is practical. E.g. if a guest re-programs a PCI I/O BAR then it may necessitate re-calling > xc_domain_ioport_mapping(); the tool-stack cannot know a priori where PCI BARs will end up in guest port/memory space. In your reply I assume you meant just the latter two of the four? For these I agree, and as a result they shouldn't be domctl in the new model. Jan