From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5CCFC432BE for ; Thu, 2 Sep 2021 10:53:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7185D60F91 for ; Thu, 2 Sep 2021 10:53:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7185D60F91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLkLG-00026b-Jm for qemu-devel@archiver.kernel.org; Thu, 02 Sep 2021 06:53:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLkKR-0000mO-QU for qemu-devel@nongnu.org; Thu, 02 Sep 2021 06:52:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLkJK-0001cI-B4 for qemu-devel@nongnu.org; Thu, 02 Sep 2021 06:52:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630579868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zOtJNE36iRCRF/WQ1trRIGBYuW7H32Wc3fi221kZLNA=; b=Qwp5xYa7+oNlUocLFU2EMuQpZkT8c+ku7LFh+MI1voa99Kl70Txt3Wuawio/wXcsChDVQp QH0CiYDEq5xHxF51VVTqAGimNNbFTlp7bhaqiLh4lho2+1t1oWGtSa04n0hoIXYM0m+EqL S0pBqrEgOiCoFZS+5LTGV6lXk4PXltw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-VRNWAZMhMc21geU4JyGczg-1; Thu, 02 Sep 2021 06:51:05 -0400 X-MC-Unique: VRNWAZMhMc21geU4JyGczg-1 Received: by mail-wm1-f71.google.com with SMTP id m16-20020a7bca50000000b002ee5287d4bfso537320wml.7 for ; Thu, 02 Sep 2021 03:51:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zOtJNE36iRCRF/WQ1trRIGBYuW7H32Wc3fi221kZLNA=; b=mco0oCZ5TLJcLV/TY1uYaw1J1FaTFVVIXWzHf4ED+IzMSJiWMLtab9nqEa6wA6v8mX woQJ7qDaK5JCiMWWR+NO1vuL1uvluvIKnC8lmHDSG9qHDHImt2vCGSH43Q9LF2x4YkzN rx3OqmehEW7wIwBx8Z+lRwMs3j+ugVdczbWxqvy95kEW0jxY8GMkYncWlrB4//4cITFl 28j/jDWy2N9eKBNfRkb37jw2FiPEzfcqV56SSMDUxRRuHsAJxmQ+VXTvpVNErssA7P32 5CCQFlIMgrcYF6yvsx5d01trfVYTsZoVfwz9eQJd2c4J2ssplcoXSbImc+y35fD2KF2g gOkw== X-Gm-Message-State: AOAM530nIa6AmwTTHdHPBnW+iLEKaJYheP8xn6purU+Ao328MeXBNVRk IjKo7rxWaaRv7AfewMvaSU1yRI68qMp1F+XgxRsCBSpQfWGUTYiwPNvuM3FwK+hlIQDT0se8ni8 pHk2C5C7g6YAtQDA= X-Received: by 2002:a05:6000:344:: with SMTP id e4mr2848186wre.423.1630579864554; Thu, 02 Sep 2021 03:51:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoTnTfuV8UtgPzJGN4ddpvTLgZCXcmG1YEYR33989yH4qjB3cAWnJTW8u1AK5V12ibf/V1CA== X-Received: by 2002:a05:6000:344:: with SMTP id e4mr2848169wre.423.1630579864340; Thu, 02 Sep 2021 03:51:04 -0700 (PDT) Received: from thuth.remote.csb (pd9575431.dip0.t-ipconnect.de. [217.87.84.49]) by smtp.gmail.com with ESMTPSA id u16sm1469917wmc.41.2021.09.02.03.51.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 03:51:03 -0700 (PDT) To: Paolo Bonzini References: <20210825092023.81396-1-thuth@redhat.com> <20210825092023.81396-4-thuth@redhat.com> From: Thomas Huth Subject: Re: [PATCH v2 3/3] softmmu/vl: Deprecate the -sdl and -curses option Message-ID: Date: Thu, 2 Sep 2021 12:51:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.225, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Armbruster, Markus" , qemu-devel , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 31/08/2021 15.53, Paolo Bonzini wrote: > As an alternative, you may want to turn it into "-display sdl" rather than > poke at dpy. This isn't much more code, but it keeps the shortcut isolated > within a single "case". This follows a lot of recently cleaned up command > line parsing code such as -no-hpet, -enable-kvm, -smp etc. > > In the end (spoiler alert for my upcoming KVM Forum presentation—slides are > already on sched.com :)) what really produces complexity > is the lack of isolation/modularity. As long as UI code doesn't care about > command line parsing, and command line parsing doesn't care about global > variables from all over the place, the cost of shortcuts is so small that it > may tilt in favor of keeping them. Honestly, I'd rather like to see them removed in the end. Our user interface is so terribly inconsistent here that I think that these options are rather confusing for the users than helpful. For example, why do we have -sdl and -curses, but no -gtk ? And as a normal user, I'd also always wonder what's the difference between "-display sdl" and "-sdl", since the difference in the amount of characters that you have to type here is not that much that it justifies the shortcut option. So IMHO let's rather clean this up completely than dragging the shortcut options along forever. Thomas