All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Sean Young <sean@mess.org>
Subject: Re: [GIT PULL for v5.18-rc1] media updates
Date: Wed, 25 May 2022 08:42:26 +0200	[thread overview]
Message-ID: <a0470450-ecfd-2918-e04a-7b57c1fd7694@kernel.org> (raw)
In-Reply-To: <20220322101406.459e2950@coco.lan>

On 22. 03. 22, 10:14, Mauro Carvalho Chehab wrote:
> Hi Linus,
> 
> Please pull from:
>    git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v5.18-1
...
> Sean Young (10):
...
>        media: lirc: remove unused lirc features

Hi,

this breaks lirc build:
> [   59s] lircd.cpp:489:49: error: 'LIRC_CAN_SET_REC_FILTER' was not declared in this scope; did you mean 'LIRC_CAN_SET_REC_CARRIER'?
> [   59s]   489 |                     || (curr_driver->features & LIRC_CAN_SET_REC_FILTER)) {
> [   59s]       |                                                 ^~~~~~~~~~~~~~~~~~~~~~~
> [   59s]       |                                                 LIRC_CAN_SET_REC_CARRIER
> [   59s] lircd.cpp: In function 'void loop()':
> [   59s] lircd.cpp:2069:82: error: 'LIRC_CAN_NOTIFY_DECODE' was not declared in this scope; did you mean 'DRVCTL_NOTIFY_DECODE'?
> [   59s]  2069 |                         if (curr_driver->drvctl_func && (curr_driver->features & LIRC_CAN_NOTIFY_DECODE))
> [   59s]       |                                                                                  ^~~~~~~~~~~~~~~~~~~~~~
> [   59s]       |                                                                                  DRVCTL_NOTIFY_DECODE

So the uapi header defines should be brought back, IMO.

thanks,
-- 
js
suse labs

  parent reply	other threads:[~2022-05-25  6:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  9:14 [GIT PULL for v5.18-rc1] media updates Mauro Carvalho Chehab
2022-03-22  9:21 ` [GIT PULL for v5.18-rc1] media updates (#81961) Jenkins
2022-03-23 23:36 ` [GIT PULL for v5.18-rc1] media updates pr-tracker-bot
2022-05-25  6:42 ` Jiri Slaby [this message]
2022-05-25  6:44   ` lirc build broken [was: [GIT PULL for v5.18-rc1] media updates] Jiri Slaby
2022-05-25  8:57     ` Sean Young
2022-05-25  7:40   ` [GIT PULL for v5.18-rc1] media updates Sean Young
2022-05-25  8:09     ` Jiri Slaby
2022-05-25  8:49       ` Sean Young
2022-05-25  9:10       ` Sean Young
2022-05-25 10:46         ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0470450-ecfd-2918-e04a-7b57c1fd7694@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sean@mess.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.