From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568AbbCWM5C (ORCPT ); Mon, 23 Mar 2015 08:57:02 -0400 Received: from mail.rommel.stw.uni-erlangen.de ([131.188.24.4]:44465 "EHLO sheldon.rommel.stw.uni-erlangen.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753544AbbCWM45 (ORCPT ); Mon, 23 Mar 2015 08:56:57 -0400 X-Greylist: delayed 2520 seconds by postgrey-1.27 at vger.kernel.org; Mon, 23 Mar 2015 08:56:56 EDT MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 23 Mar 2015 13:14:50 +0100 From: jake42 To: NeilBrown Cc: Sebastian Reichel , , , , Pavel Machek , , Lee Jones , List for communicating with real GTA04 owners Subject: Re: [Gta04-owner] [PATCH 08/14] =?UTF-8?Q?twl=34=30=33=30=5Fcharg?= =?UTF-8?Q?er=3A=20allow=20max=5Fcurrent=20to=20be=20managed=20via=20sysfs?= =?UTF-8?Q?=2E?= In-Reply-To: <20150322232029.23789.13768.stgit@notabene.brown> References: <20150322231635.23789.70149.stgit@notabene.brown> <20150322232029.23789.13768.stgit@notabene.brown> Message-ID: User-Agent: Roundcube Webmail/0.7.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Neil, some suggestions: On 23.03.2015 00:20, NeilBrown wrote: > From: NeilBrown > diff --git a/Documentation/ABI/testing/sysfs-class-power-twl4030 > b/Documentation/ABI/testing/sysfs-class-power-twl4030 > new file mode 100644 > index 000000000000..06092209d851 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-class-power-twl4030 > @@ -0,0 +1,15 @@ > +What: /sys/class/power_supply/twl4030_ac/max_current > + /sys/class/power_supply/twl4030_usb/max_current > +Description: > + Read/Write limit on current which which may one less which ^^ > + be drawn from the ac (Accessory Charger) or > + USB port. > + > + Value is in micro-Amps. > + > + Value is set automatically to an appropriate > + value when a cable is plugged on unplugged. s/on/or ^^ > + > + Value can the set by writing to the attribute. ^^ be set? > + The change will only persist until the next > + plug event. These event are reported via udev. Regards Jake From mboxrd@z Thu Jan 1 00:00:00 1970 From: jake42 Subject: Re: [Gta04-owner] [PATCH 08/14] =?UTF-8?Q?twl=34=30=33=30=5Fcharg?= =?UTF-8?Q?er=3A=20allow=20max=5Fcurrent=20to=20be=20managed=20via=20sysfs?= =?UTF-8?Q?=2E?= Date: Mon, 23 Mar 2015 13:14:50 +0100 Message-ID: References: <20150322231635.23789.70149.stgit@notabene.brown> <20150322232029.23789.13768.stgit@notabene.brown> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150322232029.23789.13768.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: NeilBrown Cc: Sebastian Reichel , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, inux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pavel Machek , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lee Jones , List for communicating with real GTA04 owners List-Id: linux-api@vger.kernel.org Hello Neil, some suggestions: On 23.03.2015 00:20, NeilBrown wrote: > From: NeilBrown > diff --git a/Documentation/ABI/testing/sysfs-class-power-twl4030 > b/Documentation/ABI/testing/sysfs-class-power-twl4030 > new file mode 100644 > index 000000000000..06092209d851 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-class-power-twl4030 > @@ -0,0 +1,15 @@ > +What: /sys/class/power_supply/twl4030_ac/max_current > + /sys/class/power_supply/twl4030_usb/max_current > +Description: > + Read/Write limit on current which which may one less which ^^ > + be drawn from the ac (Accessory Charger) or > + USB port. > + > + Value is in micro-Amps. > + > + Value is set automatically to an appropriate > + value when a cable is plugged on unplugged. s/on/or ^^ > + > + Value can the set by writing to the attribute. ^^ be set? > + The change will only persist until the next > + plug event. These event are reported via udev. Regards Jake