From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB84C4338F for ; Mon, 26 Jul 2021 13:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DBCC60F45 for ; Mon, 26 Jul 2021 13:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233231AbhGZM2m (ORCPT ); Mon, 26 Jul 2021 08:28:42 -0400 Received: from foss.arm.com ([217.140.110.172]:51660 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232572AbhGZM2j (ORCPT ); Mon, 26 Jul 2021 08:28:39 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E9D9811B3; Mon, 26 Jul 2021 06:09:07 -0700 (PDT) Received: from [10.57.36.146] (unknown [10.57.36.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 27C2E3F70D; Mon, 26 Jul 2021 06:09:06 -0700 (PDT) Subject: Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types To: Joerg Roedel Cc: will@kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, john.garry@huawei.com, dianders@chromium.org References: <04220b3420c2c513490450f37de109182364f235.1626888445.git.robin.murphy@arm.com> From: Robin Murphy Message-ID: Date: Mon, 26 Jul 2021 14:09:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-07-26 13:46, Joerg Roedel wrote: > On Wed, Jul 21, 2021 at 07:20:27PM +0100, Robin Murphy wrote: >> - if (type == IOMMU_DOMAIN_DMA && using_legacy_binding) >> + if ((type & __IOMMU_DOMAIN_DMA_API) && using_legacy_binding) > > Hmm, I wonder whether it is time to introduce helpers for these checks? > > Something like iommu_domain_is_dma() is more readable. Ha, I had exactly that at one point, except I think in the order of iommu_is_dma_domain() :) The end result didn't seem to give enough extra clarity to justify the header churn for me, but I'm happy to be wrong about that if you prefer. Cheers, Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C83C4320E for ; Mon, 26 Jul 2021 13:09:12 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4111E60F37 for ; Mon, 26 Jul 2021 13:09:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4111E60F37 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0A2AB4022F; Mon, 26 Jul 2021 13:09:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fVchvHNBb7fU; Mon, 26 Jul 2021 13:09:11 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 08767400C3; Mon, 26 Jul 2021 13:09:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B2CBAC001A; Mon, 26 Jul 2021 13:09:10 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id E678BC000E for ; Mon, 26 Jul 2021 13:09:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C792D401E3 for ; Mon, 26 Jul 2021 13:09:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 60JZLVeXR7Hl for ; Mon, 26 Jul 2021 13:09:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp4.osuosl.org (Postfix) with ESMTP id BC421401C5 for ; Mon, 26 Jul 2021 13:09:08 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E9D9811B3; Mon, 26 Jul 2021 06:09:07 -0700 (PDT) Received: from [10.57.36.146] (unknown [10.57.36.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 27C2E3F70D; Mon, 26 Jul 2021 06:09:06 -0700 (PDT) Subject: Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types To: Joerg Roedel References: <04220b3420c2c513490450f37de109182364f235.1626888445.git.robin.murphy@arm.com> From: Robin Murphy Message-ID: Date: Mon, 26 Jul 2021 14:09:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Cc: linux-kernel@vger.kernel.org, dianders@chromium.org, iommu@lists.linux-foundation.org, will@kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2021-07-26 13:46, Joerg Roedel wrote: > On Wed, Jul 21, 2021 at 07:20:27PM +0100, Robin Murphy wrote: >> - if (type == IOMMU_DOMAIN_DMA && using_legacy_binding) >> + if ((type & __IOMMU_DOMAIN_DMA_API) && using_legacy_binding) > > Hmm, I wonder whether it is time to introduce helpers for these checks? > > Something like iommu_domain_is_dma() is more readable. Ha, I had exactly that at one point, except I think in the order of iommu_is_dma_domain() :) The end result didn't seem to give enough extra clarity to justify the header churn for me, but I'm happy to be wrong about that if you prefer. Cheers, Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40298C4338F for ; Mon, 26 Jul 2021 13:11:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAB246056C for ; Mon, 26 Jul 2021 13:11:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EAB246056C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BMHfzWgR1L7SuIxDGLFPfeH+2hjcKYgKiQPiRBiZuSs=; b=lew2YP8LuIqobkE8Iq9FZbVpd2 xArB57uF46sBdvOm97jNsQL8EKy2zATvtmGI+mntls5oVzLTifkmic9BwyFDKboDvoeh6HmcH4hwx 5Z2EcVmtHs2glLVU4pWk9hIO+WbOmHL0q6yfZQf2xZE6+B/ZH1ZUnWRhmQTc75L6EE1jBnQAqQPUY qXNlxhJR693d03jVStoeb7iEqzbjQMyfCOkJnH5Bb2PxMuzxR4KaJX223iqBAvM7oqXQRlMd2mTQp lLpKVcm+uUa2biPHBRIWL6IS8tHnYz8uy4b9qI50M6Mqh81XVnbkpn2dStQEDeJqDHPlNJL3EMUxN S3YC55wA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m80M6-00BHEh-80; Mon, 26 Jul 2021 13:09:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m80M1-00BHDs-VG for linux-arm-kernel@lists.infradead.org; Mon, 26 Jul 2021 13:09:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E9D9811B3; Mon, 26 Jul 2021 06:09:07 -0700 (PDT) Received: from [10.57.36.146] (unknown [10.57.36.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 27C2E3F70D; Mon, 26 Jul 2021 06:09:06 -0700 (PDT) Subject: Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types To: Joerg Roedel Cc: will@kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, john.garry@huawei.com, dianders@chromium.org References: <04220b3420c2c513490450f37de109182364f235.1626888445.git.robin.murphy@arm.com> From: Robin Murphy Message-ID: Date: Mon, 26 Jul 2021 14:09:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_060910_095913_16BEB220 X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-07-26 13:46, Joerg Roedel wrote: > On Wed, Jul 21, 2021 at 07:20:27PM +0100, Robin Murphy wrote: >> - if (type == IOMMU_DOMAIN_DMA && using_legacy_binding) >> + if ((type & __IOMMU_DOMAIN_DMA_API) && using_legacy_binding) > > Hmm, I wonder whether it is time to introduce helpers for these checks? > > Something like iommu_domain_is_dma() is more readable. Ha, I had exactly that at one point, except I think in the order of iommu_is_dma_domain() :) The end result didn't seem to give enough extra clarity to justify the header churn for me, but I'm happy to be wrong about that if you prefer. Cheers, Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel