From: "Khem Raj" <raj.khem@gmail.com>
To: Denys Dmytriyenko <denis@denix.org>, richard.purdie@linuxfoundation.org
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2] cryptodev: bump 1 commit past 1.11 to fix 5.9-rc1+
Date: Thu, 10 Sep 2020 21:16:22 -0700 [thread overview]
Message-ID: <a06b8fce-0c33-c6a8-990e-3da09ee673bc@gmail.com> (raw)
In-Reply-To: <20200910195532.GE17660@denix.org>
On 9/10/20 12:55 PM, Denys Dmytriyenko wrote:
> On Thu, Sep 10, 2020 at 08:46:36AM -0700, Khem Raj wrote:
>> On Wed, Sep 9, 2020 at 6:16 PM Denys Dmytriyenko <denis@denix.org> wrote:
>>>
>>> From: Denys Dmytriyenko <denys@ti.com>
>>>
>>> There's one commit on top of 1.11 release that fixes builds against kernel 5.9-rc1+.
>>>
>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>>> ---
>>> v2 - append SRCPV to PV
>>>
>>> meta/recipes-kernel/cryptodev/cryptodev.inc | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-kernel/cryptodev/cryptodev.inc b/meta/recipes-kernel/cryptodev/cryptodev.inc
>>> index 906f4fc..027d636 100644
>>> --- a/meta/recipes-kernel/cryptodev/cryptodev.inc
>>> +++ b/meta/recipes-kernel/cryptodev/cryptodev.inc
>>> @@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>>
>>> SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux \
>>> "
>>> -SRCREV = "2299d39475e91392abd050ea09f2d20feecb4adf"
>>> +SRCREV = "fabe5989a3dc9fba0cd0a40b612247cdde351c01"
>>> +PV .= "+git${SRCPV}"
>>
>> I just saw that this change does not go well with some of
>> meta-freescale changes which uses the inc file paired with PV, so
>> perhaps keeping the version at same PV
>> or creating a single patch is better.
>
> Well, it's unfortunate that it affects some downstream layers, but that never
> stopped changes in OE-Core before - as a maintainer of few downstream layers
> myself, I had to adapt to such changes in the past many-many times...
>
> Anyway, alternative would be to use v1 of the patch.
Richard
yeah lets go with v1
>
>
>> now ends up with.
>>
>> ERROR: ParseError at
>> /mnt/b/yoe/master/sources/meta-freescale/recipes-kernel/cryptodev/cryptodev-qoriq-tests_1.11.bb:2:
>> Could not include required file cryptodev-qoriq-1.11+git${SRCPV}.inc
>>
>>
>>>
>>> S = "${WORKDIR}/git"
>>>
>>> --
>>> 2.7.4
>>>
>>>
>>
prev parent reply other threads:[~2020-09-11 4:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 1:16 [PATCH v2] cryptodev: bump 1 commit past 1.11 to fix 5.9-rc1+ Denys Dmytriyenko
2020-09-10 15:46 ` [OE-core] " Khem Raj
2020-09-10 19:55 ` Denys Dmytriyenko
2020-09-11 4:16 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a06b8fce-0c33-c6a8-990e-3da09ee673bc@gmail.com \
--to=raj.khem@gmail.com \
--cc=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.