All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB
@ 2019-03-07  8:27 Chris Packham
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board Chris Packham
                   ` (12 more replies)
  0 siblings, 13 replies; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:27 UTC (permalink / raw)
  To: u-boot

This is my series to convert the kirkwood platforms to DM_USB.

I've been testing on an old kirkwood eval board which patch 1 adds. I'd
really appreciate some testing on other kirkwood platforms.

Chris Packham (12):
  ARM: kirkwood: add db-88f6281-bp board
  ARM: kirkwood: rename KW_CPU_WIN_BASE to MVEBU_CPU_WIN_BASE
  ARM: kirkwood: remove KW_DEFADR_PCI_IO_REMAP
  ARM: kirkwood: switch to using mvebu mbus
  ARM: kirkwood: remove kw_config_adr_windows
  ARM: kirkwood: enable CONFIG_DM_USB on db-88f6281-bp
  ARM: kirkwood: enable CONFIG_DM_USB for {dream,guru,sheeva}plug
  ARM: kirkwood: enable CONFIG_DM_USB for dns325
  ARM: kirkwood: enable CONFIG_DM_USB for ds109
  ARM: kirkwood: enable CONFIG_DM_USB for goflexhome
  ARM: kirkwood: enable CONFIG_DM_USB for lschlv2 and lsxhl
  ARM: kirkwood: enable CONFIG_DM_USB for nas220

 arch/arm/dts/kirkwood-db-88f6281-spi.dts    |  48 +++++++++
 arch/arm/dts/kirkwood-db-88f6281.dts        |  26 +++++
 arch/arm/dts/kirkwood-db.dtsi               |  94 +++++++++++++++++
 arch/arm/mach-kirkwood/Kconfig              |   4 +
 arch/arm/mach-kirkwood/cpu.c                |  73 ++++---------
 arch/arm/mach-kirkwood/include/mach/cpu.h   |  13 ++-
 arch/arm/mach-kirkwood/include/mach/soc.h   |   2 +-
 arch/arm/mach-mvebu/Makefile                |   1 +
 arch/arm/mach-mvebu/mbus.c                  |   6 ++
 board/Marvell/db-88f6281-bp/Kconfig         |  12 +++
 board/Marvell/db-88f6281-bp/MAINTAINERS     |  10 ++
 board/Marvell/db-88f6281-bp/Makefile        |   3 +
 board/Marvell/db-88f6281-bp/db-88f6281-bp.c | 103 ++++++++++++++++++
 board/Marvell/db-88f6281-bp/kwbimage.cfg    |  36 +++++++
 configs/db-88f6281-bp-nand_defconfig        |  54 ++++++++++
 configs/db-88f6281-bp-spi_defconfig         |  55 ++++++++++
 configs/dns325_defconfig                    |   2 +
 configs/dreamplug_defconfig                 |   2 +
 configs/ds109_defconfig                     |   2 +
 configs/goflexhome_defconfig                |   2 +
 configs/guruplug_defconfig                  |   2 +
 configs/lschlv2_defconfig                   |   2 +
 configs/lsxhl_defconfig                     |   2 +
 configs/nas220_defconfig                    |   2 +
 configs/sheevaplug_defconfig                |   1 +
 include/configs/db-88f6281-bp.h             | 109 ++++++++++++++++++++
 26 files changed, 608 insertions(+), 58 deletions(-)
 create mode 100644 arch/arm/dts/kirkwood-db-88f6281-spi.dts
 create mode 100644 arch/arm/dts/kirkwood-db-88f6281.dts
 create mode 100644 arch/arm/dts/kirkwood-db.dtsi
 create mode 100644 board/Marvell/db-88f6281-bp/Kconfig
 create mode 100644 board/Marvell/db-88f6281-bp/MAINTAINERS
 create mode 100644 board/Marvell/db-88f6281-bp/Makefile
 create mode 100644 board/Marvell/db-88f6281-bp/db-88f6281-bp.c
 create mode 100644 board/Marvell/db-88f6281-bp/kwbimage.cfg
 create mode 100644 configs/db-88f6281-bp-nand_defconfig
 create mode 100644 configs/db-88f6281-bp-spi_defconfig
 create mode 100644 include/configs/db-88f6281-bp.h

-- 
2.21.0

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
@ 2019-03-07  8:27 ` Chris Packham
  2019-03-07  9:33   ` Stefan Roese
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 02/12] ARM: kirkwood: rename KW_CPU_WIN_BASE to MVEBU_CPU_WIN_BASE Chris Packham
                   ` (11 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:27 UTC (permalink / raw)
  To: u-boot

This is Marvell's Kirkwood development board. It has the following
features

 - 512M DDR2
 - 2 PCI connectors
 - 1 x1 PCI-e interface
 - 1 Gigabit Ethernet Port
 - 2 SATA Ports
 - USB 2.0 Interface
 - SDIO
 - 128M NAND Flash
 - 16M SPI Flash

It can be strapped to boot from SPI or NAND so there are two defconfigs
(one per boot media).

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 arch/arm/dts/kirkwood-db-88f6281-spi.dts    |  48 +++++++++
 arch/arm/dts/kirkwood-db-88f6281.dts        |  26 +++++
 arch/arm/dts/kirkwood-db.dtsi               |  94 +++++++++++++++++
 arch/arm/mach-kirkwood/Kconfig              |   4 +
 board/Marvell/db-88f6281-bp/Kconfig         |  12 +++
 board/Marvell/db-88f6281-bp/MAINTAINERS     |  10 ++
 board/Marvell/db-88f6281-bp/Makefile        |   3 +
 board/Marvell/db-88f6281-bp/db-88f6281-bp.c | 103 ++++++++++++++++++
 board/Marvell/db-88f6281-bp/kwbimage.cfg    |  36 +++++++
 configs/db-88f6281-bp-nand_defconfig        |  53 ++++++++++
 configs/db-88f6281-bp-spi_defconfig         |  54 ++++++++++
 include/configs/db-88f6281-bp.h             | 109 ++++++++++++++++++++
 12 files changed, 552 insertions(+)
 create mode 100644 arch/arm/dts/kirkwood-db-88f6281-spi.dts
 create mode 100644 arch/arm/dts/kirkwood-db-88f6281.dts
 create mode 100644 arch/arm/dts/kirkwood-db.dtsi
 create mode 100644 board/Marvell/db-88f6281-bp/Kconfig
 create mode 100644 board/Marvell/db-88f6281-bp/MAINTAINERS
 create mode 100644 board/Marvell/db-88f6281-bp/Makefile
 create mode 100644 board/Marvell/db-88f6281-bp/db-88f6281-bp.c
 create mode 100644 board/Marvell/db-88f6281-bp/kwbimage.cfg
 create mode 100644 configs/db-88f6281-bp-nand_defconfig
 create mode 100644 configs/db-88f6281-bp-spi_defconfig
 create mode 100644 include/configs/db-88f6281-bp.h

diff --git a/arch/arm/dts/kirkwood-db-88f6281-spi.dts b/arch/arm/dts/kirkwood-db-88f6281-spi.dts
new file mode 100644
index 000000000000..50b1b0d4a535
--- /dev/null
+++ b/arch/arm/dts/kirkwood-db-88f6281-spi.dts
@@ -0,0 +1,48 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Marvell DB-88F6281-BP Development Board Setup
+ *
+ * Saeed Bishara <saeed@marvell.com>
+ * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+ *
+ */
+
+/dts-v1/;
+
+#include "kirkwood-db-88f6281.dts"
+
+/ {
+	aliases {
+		spi0 = &spi0;
+	};
+};
+
+&spi0 {
+	status = "okay";
+
+	flash at 0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "st,m25p128", "jedec,spi-nor", "spi-flash";
+		reg = <0>;
+		spi-max-frequency = <50000000>;
+		mode = <0>;
+
+		partition at u-boot {
+			reg = <0x00000000 0x00c00000>;
+			label = "u-boot";
+		};
+		partition at u-boot-env {
+			reg = <0x00c00000 0x00040000>;
+			label = "u-boot-env";
+		};
+		partition at unused {
+			reg = <0x00100000 0x00f00000>;
+			label = "unused";
+		};
+	};
+};
+
+&nand {
+	status = "disabled";
+};
diff --git a/arch/arm/dts/kirkwood-db-88f6281.dts b/arch/arm/dts/kirkwood-db-88f6281.dts
new file mode 100644
index 000000000000..2adb17c955aa
--- /dev/null
+++ b/arch/arm/dts/kirkwood-db-88f6281.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Marvell DB-88F6281-BP Development Board Setup
+ *
+ * Saeed Bishara <saeed@marvell.com>
+ * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+ *
+ */
+
+/dts-v1/;
+
+#include "kirkwood-db.dtsi"
+#include "kirkwood-6281.dtsi"
+
+/ {
+	model = "Marvell DB-88F6281-BP Development Board";
+	compatible = "marvell,db-88f6281-bp", "marvell,kirkwood-88f6281", "marvell,kirkwood";
+};
+
+&pciec {
+        status = "okay";
+};
+
+&pcie0 {
+	status = "okay";
+};
diff --git a/arch/arm/dts/kirkwood-db.dtsi b/arch/arm/dts/kirkwood-db.dtsi
new file mode 100644
index 000000000000..b81d8e8298a3
--- /dev/null
+++ b/arch/arm/dts/kirkwood-db.dtsi
@@ -0,0 +1,94 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Marvell DB-{88F6281,88F6282}-BP Development Board Setup
+ *
+ * Saeed Bishara <saeed@marvell.com>
+ * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+ *
+ * This file contains the definitions that are common between the 6281
+ * and 6282 variants of the Marvell Kirkwood Development Board.
+ */
+
+#include "kirkwood.dtsi"
+
+/ {
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x20000000>; /* 512 MB */
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200n8 earlyprintk";
+		stdout-path = &uart0;
+	};
+
+	aliases {
+		ethernet0 = &eth0;
+		spi0 = &spi0;
+	};
+
+	ocp at f1000000 {
+		pin-controller at 10000 {
+			pmx_sdio_gpios: pmx-sdio-gpios {
+				marvell,pins = "mpp37", "mpp38";
+				marvell,function = "gpio";
+			};
+		};
+
+		serial at 12000 {
+			status = "okay";
+		};
+
+		sata at 80000 {
+			nr-ports = <2>;
+			status = "okay";
+		};
+
+		ehci at 50000 {
+			status = "okay";
+		};
+
+		mvsdio at 90000 {
+			pinctrl-0 = <&pmx_sdio_gpios>;
+			pinctrl-names = "default";
+			wp-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
+			cd-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
+			status = "okay";
+		};
+	};
+};
+
+&nand {
+	chip-delay = <25>;
+	status = "okay";
+
+	partition at 0 {
+		label = "uboot";
+		reg = <0x0 0x100000>;
+	};
+
+	partition at 100000 {
+		label = "uImage";
+		reg = <0x100000 0x400000>;
+	};
+
+	partition at 500000 {
+		label = "root";
+		reg = <0x500000 0x1fb00000>;
+	};
+};
+
+&mdio {
+	status = "okay";
+
+	ethphy0: ethernet-phy at 8 {
+		reg = <8>;
+	};
+};
+
+&eth0 {
+	status = "okay";
+	ethernet0-port at 0 {
+		phy-handle = <&ethphy0>;
+	};
+};
diff --git a/arch/arm/mach-kirkwood/Kconfig b/arch/arm/mach-kirkwood/Kconfig
index 3b860c4f55fe..7c4170399afb 100644
--- a/arch/arm/mach-kirkwood/Kconfig
+++ b/arch/arm/mach-kirkwood/Kconfig
@@ -65,6 +65,9 @@ config TARGET_SBx81LIFKW
 config TARGET_SBx81LIFXCAT
 	bool "Allied Telesis SBx81GP24/SBx81GT24"
 
+config TARGET_DB_88F6281_BP
+	bool "Marvell DB-88F6281-BP"
+
 endchoice
 
 config SYS_SOC
@@ -89,5 +92,6 @@ source "board/Seagate/nas220/Kconfig"
 source "board/zyxel/nsa310s/Kconfig"
 source "board/alliedtelesis/SBx81LIFKW/Kconfig"
 source "board/alliedtelesis/SBx81LIFXCAT/Kconfig"
+source "board/Marvell/db-88f6281-bp/Kconfig"
 
 endif
diff --git a/board/Marvell/db-88f6281-bp/Kconfig b/board/Marvell/db-88f6281-bp/Kconfig
new file mode 100644
index 000000000000..38467399e688
--- /dev/null
+++ b/board/Marvell/db-88f6281-bp/Kconfig
@@ -0,0 +1,12 @@
+if TARGET_DB_88F6281_BP
+
+config SYS_BOARD
+	default "db-88f6281-bp"
+
+config SYS_VENDOR
+	default "Marvell"
+
+config SYS_CONFIG_NAME
+	default "db-88f6281-bp"
+
+endif
diff --git a/board/Marvell/db-88f6281-bp/MAINTAINERS b/board/Marvell/db-88f6281-bp/MAINTAINERS
new file mode 100644
index 000000000000..f31d3be70bae
--- /dev/null
+++ b/board/Marvell/db-88f6281-bp/MAINTAINERS
@@ -0,0 +1,10 @@
+DB_88F6820_AMC BOARD
+M:	Chris Packham <judge.packham@gmail.com>
+S:	Maintained
+F:	arch/arm/dts/kirkwood-db-88f6281.dts
+F:	arch/arm/dts/kirkwood-db-88f6281-spi.dts
+F:	arch/arm/dts/kirkwood-db.dtsi
+F:	board/Marvell/db-88f6281-bp/
+F:	include/configs/db-88f6281-bp.h
+F:	configs/db-88f6281-bp_defconfig
+F:	configs/db-88f6281-bp-spi_defconfig
diff --git a/board/Marvell/db-88f6281-bp/Makefile b/board/Marvell/db-88f6281-bp/Makefile
new file mode 100644
index 000000000000..38ff522ca1c8
--- /dev/null
+++ b/board/Marvell/db-88f6281-bp/Makefile
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0+
+
+obj-y	:= db-88f6281-bp.o
diff --git a/board/Marvell/db-88f6281-bp/db-88f6281-bp.c b/board/Marvell/db-88f6281-bp/db-88f6281-bp.c
new file mode 100644
index 000000000000..b68f2f3c895b
--- /dev/null
+++ b/board/Marvell/db-88f6281-bp/db-88f6281-bp.c
@@ -0,0 +1,103 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include <common.h>
+#include <linux/io.h>
+#include <miiphy.h>
+#include <netdev.h>
+#include <asm/arch/cpu.h>
+#include <asm/arch/soc.h>
+#include <asm/arch/mpp.h>
+#include <asm/arch/gpio.h>
+
+#define DB_88F6281_OE_LOW	~(BIT(7))
+#define DB_88F6281_OE_HIGH	~(BIT(15) | BIT(14) | BIT(13) | BIT(4))
+#define DB_88F6281_OE_VAL_LOW	BIT(7)
+#define DB_88F6281_OE_VAL_HIGH	0
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int board_early_init_f(void)
+{
+	mvebu_config_gpio(DB_88F6281_OE_VAL_LOW,
+			  DB_88F6281_OE_VAL_HIGH,
+			  DB_88F6281_OE_LOW, DB_88F6281_OE_HIGH);
+
+	/* Multi-Purpose Pins Functionality configuration */
+	static const u32 kwmpp_config[] = {
+#ifdef CONFIG_CMD_NAND
+		MPP0_NF_IO2,
+		MPP1_NF_IO3,
+		MPP2_NF_IO4,
+		MPP3_NF_IO5,
+#else
+		MPP0_SPI_SCn,
+		MPP1_SPI_MOSI,
+		MPP2_SPI_SCK,
+		MPP3_SPI_MISO,
+#endif
+		MPP4_NF_IO6,
+		MPP5_NF_IO7,
+		MPP6_SYSRST_OUTn,
+		MPP7_GPO,
+		MPP8_TW_SDA,
+		MPP9_TW_SCK,
+		MPP10_UART0_TXD,
+		MPP11_UART0_RXD,
+		MPP12_SD_CLK,
+		MPP13_SD_CMD,
+		MPP14_SD_D0,
+		MPP15_SD_D1,
+		MPP16_SD_D2,
+		MPP17_SD_D3,
+		MPP18_NF_IO0,
+		MPP19_NF_IO1,
+		MPP20_SATA1_ACTn,
+		MPP21_SATA0_ACTn,
+		MPP22_GPIO,
+		MPP23_GPIO,
+		MPP24_GPIO,
+		MPP25_GPIO,
+		MPP26_GPIO,
+		MPP27_GPIO,
+		MPP28_GPIO,
+		MPP29_GPIO,
+		MPP30_GPIO,
+		MPP31_GPIO,
+		MPP32_GPIO,
+		MPP33_GPIO,
+		MPP34_GPIO,
+		MPP35_GPIO,
+		MPP36_GPIO,
+		MPP37_GPIO,
+		MPP38_GPIO,
+		MPP39_GPIO,
+		MPP40_GPIO,
+		MPP41_GPIO,
+		MPP42_GPIO,
+		MPP43_GPIO,
+		MPP44_GPIO,
+		MPP45_GPIO,
+		MPP46_GPIO,
+		MPP47_GPIO,
+		MPP48_GPIO,
+		MPP49_GPIO,
+		0
+	};
+	kirkwood_mpp_conf(kwmpp_config, NULL);
+
+	return 0;
+}
+
+int board_init(void)
+{
+	gd->bd->bi_boot_params = mvebu_sdram_bar(0) + 0x100;
+
+	return 0;
+}
+
+#ifdef CONFIG_RESET_PHY_R
+/* automatically defined by kirkwood config.h */
+void reset_phy(void)
+{
+}
+#endif
diff --git a/board/Marvell/db-88f6281-bp/kwbimage.cfg b/board/Marvell/db-88f6281-bp/kwbimage.cfg
new file mode 100644
index 000000000000..49a637078682
--- /dev/null
+++ b/board/Marvell/db-88f6281-bp/kwbimage.cfg
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: GPL-2.0+
+
+# Boot Media configurations
+BOOT_FROM	spi	# Boot from SPI flash
+
+DATA 0xd00100e0 0x1b1b1b9b
+DATA 0xd0020134 0xbbbbbbbb
+DATA 0xd0020138 0x00bbbbbb
+DATA 0xd0020154 0x00000200
+DATA 0xd002014c 0x00001c00
+DATA 0xd0020148 0x00000001
+
+DATA 0xd0001400 0x43000c30
+DATA 0xd0001404 0x39543000
+DATA 0xd0001408 0x22125451
+DATA 0xd000140c 0x00000833
+DATA 0xd0001410 0x000000cc
+DATA 0xd0001414 0x00000000
+DATA 0xd0001418 0x00000000
+DATA 0xd000141c 0x00000c52
+DATA 0xd0001420 0x00000044
+DATA 0xd0001424 0x0000f1ff
+DATA 0xd0001428 0x00085520
+DATA 0xd000147c 0x00008552
+DATA 0xd0001504 0x0ffffff1
+DATA 0xd0001508 0x10000000
+DATA 0xd000150c 0x0ffffff5
+DATA 0xd0001514 0x00000000
+DATA 0xd000151c 0x00000000
+DATA 0xd0001494 0x84210000
+DATA 0xd0001498 0x00000000
+DATA 0xd000149c 0x0000f40f
+DATA 0xd0001480 0x00000001
+
+# End of Header extension
+DATA 0x0 0x0
diff --git a/configs/db-88f6281-bp-nand_defconfig b/configs/db-88f6281-bp-nand_defconfig
new file mode 100644
index 000000000000..6360ef5e8280
--- /dev/null
+++ b/configs/db-88f6281-bp-nand_defconfig
@@ -0,0 +1,53 @@
+CONFIG_ARM=y
+CONFIG_SYS_THUMB_BUILD=y
+CONFIG_KIRKWOOD=y
+CONFIG_SYS_TEXT_BASE=0x600000
+CONFIG_TARGET_DB_88F6281_BP=y
+CONFIG_IDENT_STRING="\nMarvell DB-88F6281-BP"
+CONFIG_NR_DRAM_BANKS=2
+# CONFIG_SYS_MALLOC_F is not set
+CONFIG_BOOTDELAY=3
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_BOOTZ=y
+CONFIG_CMD_DM=y
+# CONFIG_CMD_FLASH is not set
+CONFIG_CMD_IDE=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_NAND=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_USB=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_JFFS2=y
+CONFIG_CMD_MTDPARTS=y
+CONFIG_MTDIDS_DEFAULT="nand0=orion_nand"
+CONFIG_MTDPARTS_DEFAULT="mtdparts=orion_nand:512K(uboot),512K(env),4M(kernel),-(rootfs)"
+CONFIG_ISO_PARTITION=y
+CONFIG_OF_CONTROL=y
+CONFIG_DEFAULT_DEVICE_TREE="kirkwood-db-88f6281"
+CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_DM=y
+CONFIG_MVSATA_IDE=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_PHY_MARVELL=y
+CONFIG_DM_ETH=y
+CONFIG_MVGBE=y
+CONFIG_MII=y
+CONFIG_DM_RTC=y
+CONFIG_RTC_MV=y
+CONFIG_SYS_NS16550=y
+CONFIG_SPI=y
+CONFIG_KIRKWOOD_SPI=y
+CONFIG_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_STORAGE=y
+CONFIG_LZMA=y
+CONFIG_LZO=y
diff --git a/configs/db-88f6281-bp-spi_defconfig b/configs/db-88f6281-bp-spi_defconfig
new file mode 100644
index 000000000000..93e125af5b2d
--- /dev/null
+++ b/configs/db-88f6281-bp-spi_defconfig
@@ -0,0 +1,54 @@
+CONFIG_ARM=y
+CONFIG_SYS_THUMB_BUILD=y
+CONFIG_KIRKWOOD=y
+CONFIG_SYS_TEXT_BASE=0x600000
+CONFIG_TARGET_DB_88F6281_BP=y
+CONFIG_IDENT_STRING="\nMarvell DB-88F6281-BP"
+CONFIG_NR_DRAM_BANKS=2
+# CONFIG_SYS_MALLOC_F is not set
+CONFIG_BOOTDELAY=3
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_BOOTZ=y
+CONFIG_CMD_DM=y
+# CONFIG_CMD_FLASH is not set
+CONFIG_CMD_IDE=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_USB=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_JFFS2=y
+CONFIG_CMD_MTDPARTS=y
+CONFIG_MTDIDS_DEFAULT="nand0=orion_nand"
+CONFIG_MTDPARTS_DEFAULT="mtdparts=orion_nand:512K(uboot),512K(env),4M(kernel),-(rootfs)"
+CONFIG_ISO_PARTITION=y
+CONFIG_OF_CONTROL=y
+CONFIG_DEFAULT_DEVICE_TREE="kirkwood-db-88f6281-spi"
+CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_DM=y
+CONFIG_MVSATA_IDE=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_PHY_MARVELL=y
+CONFIG_DM_ETH=y
+CONFIG_MVGBE=y
+CONFIG_MII=y
+CONFIG_DM_RTC=y
+CONFIG_RTC_MV=y
+CONFIG_SYS_NS16550=y
+CONFIG_SPI=y
+CONFIG_DM_SPI=y
+CONFIG_KIRKWOOD_SPI=y
+CONFIG_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_STORAGE=y
+CONFIG_LZMA=y
+CONFIG_LZO=y
diff --git a/include/configs/db-88f6281-bp.h b/include/configs/db-88f6281-bp.h
new file mode 100644
index 000000000000..212983716e96
--- /dev/null
+++ b/include/configs/db-88f6281-bp.h
@@ -0,0 +1,109 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef _CONFIG_DB_88F6281_BP_H
+#define _CONFIG_DB_88F6281_BP_H
+
+/*
+ * High Level Configuration Options (easy to change)
+ */
+#define CONFIG_FEROCEON_88FR131	1	/* CPU Core subversion */
+#define CONFIG_KW88F6281	1	/* SOC Name */
+#define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
+#define CONFIG_SYS_TCLK		166666667
+#define CONFIG_SYS_KWD_CONFIG	$(CONFIG_BOARDDIR)/kwbimage.cfg
+#define CONFIG_BUILD_TARGET	"u-boot.kwb"
+
+/* additions for new ARM relocation support */
+#define CONFIG_SYS_SDRAM_BASE	0x00000000
+
+#define CONFIG_MD5	/* get_random_hex on krikwood needs MD5 support */
+#define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
+#define CONFIG_KIRKWOOD_PCIE_INIT	/* Enable PCIE Port0 */
+#define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */
+#define CONFIG_KIRKWOOD_GPIO	1
+
+/*
+ * NS16550 Configuration
+ */
+#define CONFIG_SYS_NS16550_SERIAL
+#define CONFIG_SYS_NS16550_REG_SIZE	(-4)
+#define CONFIG_SYS_NS16550_CLK		CONFIG_SYS_TCLK
+#define CONFIG_SYS_NS16550_COM1		KW_UART0_BASE
+
+#define CONFIG_SYS_MAX_NAND_DEVICE     1
+/*
+ * Serial Port configuration
+ * The following definitions let you select what serial you want to use
+ * for your console driver.
+ */
+
+#define CONFIG_CONS_INDEX	1	/*Console on UART0 */
+
+/*
+ * For booting Linux, the board info and command line data
+ * have to be in the first 8 MB of memory, since this is
+ * the maximum mapped by the Linux kernel during initialization.
+ */
+#define CONFIG_CMDLINE_TAG	1	/* enable passing of ATAGs */
+#define CONFIG_INITRD_TAG	1	/* enable INITRD tag */
+#define CONFIG_SETUP_MEMORY_TAGS 1	/* enable memory tag */
+
+/*
+ *  Environment variables configurations
+ */
+#define CONFIG_ENV_SPI_BUS		0
+#define CONFIG_ENV_SPI_CS		0
+#define CONFIG_ENV_SPI_MAX_HZ		20000000	/* 20Mhz */
+#define CONFIG_ENV_SPI_MODE		CONFIG_SF_DEFAULT_MODE
+#define CONFIG_ENV_SECT_SIZE		0x40000		/* 256K */
+#define CONFIG_ENV_SIZE			0x01000
+#define CONFIG_ENV_OFFSET		0xC0000
+
+/*
+ * U-Boot bootcode configuration
+ */
+
+#define CONFIG_SYS_MONITOR_LEN		(256 << 10)	/* Reserve 256 kB for monitor */
+#define CONFIG_SYS_MALLOC_LEN		  (4 << 20)	/* Reserve 4.0 MB for malloc */
+
+/*
+ * For booting Linux, the board info and command line data
+ * have to be in the first 8 MB of memory, since this is
+ * the maximum mapped by the Linux kernel during initialization.
+ */
+#define CONFIG_SYS_BOOTMAPSZ		(8 << 20)	/* Initial Mem map for Linux*/
+
+/* size in bytes reserved for initial data */
+
+#include <asm/arch/config.h>
+/* There is no PHY directly connected so don't ask it for link status */
+#undef CONFIG_SYS_FAULT_ECHO_LINK_DOWN
+
+/*
+ * Other required minimal configurations
+ */
+#define CONFIG_ARCH_CPU_INIT	/* call arch_cpu_init() */
+#define CONFIG_SYS_MEMTEST_START 0x00400000	/* 4M */
+#define CONFIG_SYS_MEMTEST_END	0x007fffff	/*(_8M -1) */
+#define CONFIG_SYS_RESET_ADDRESS 0xffff0000	/* Rst Vector Adr */
+
+/*
+ * SDIO/MMC Card Configuration
+ */
+#ifdef CONFIG_CMD_MMC
+#define CONFIG_MVEBU_MMC
+#define CONFIG_SYS_MMC_BASE KW_SDIO_BASE
+#endif /* CONFIG_CMD_MMC */
+
+/*
+ * SATA Driver configuration
+ */
+#ifdef CONFIG_MVSATA_IDE
+#define CONFIG_SYS_ATA_IDE0_OFFSET	MV_SATA_PORT0_OFFSET
+#endif /*CONFIG_MVSATA_IDE*/
+
+#define CONFIG_SYS_LOAD_ADDR  0x1000000      /* default location for tftp and bootm */
+
+#define CONFIG_SYS_DCACHE_OFF
+
+#endif /* _CONFIG_DB_88F6281_BP_H */
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 02/12] ARM: kirkwood: rename KW_CPU_WIN_BASE to MVEBU_CPU_WIN_BASE
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board Chris Packham
@ 2019-03-07  8:27 ` Chris Packham
  2019-03-07 11:30   ` Stefan Roese
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 03/12] ARM: kirkwood: remove KW_DEFADR_PCI_IO_REMAP Chris Packham
                   ` (10 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:27 UTC (permalink / raw)
  To: u-boot

This will allow the kirkwood platforms to use more common code with the
other mvebu SoCs.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 arch/arm/mach-kirkwood/cpu.c              | 2 +-
 arch/arm/mach-kirkwood/include/mach/soc.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c
index 8a065d73aed5..277c699a4f9b 100644
--- a/arch/arm/mach-kirkwood/cpu.c
+++ b/arch/arm/mach-kirkwood/cpu.c
@@ -62,7 +62,7 @@ unsigned int kw_winctrl_calcsize(unsigned int sizeval)
 int kw_config_adr_windows(void)
 {
 	struct kwwin_registers *winregs =
-		(struct kwwin_registers *)KW_CPU_WIN_BASE;
+		(struct kwwin_registers *)MVEBU_CPU_WIN_BASE;
 
 	/* Window 0: PCIE MEM address space */
 	writel(KWCPU_WIN_CTRL_DATA(1024 * 1024 * 256, KWCPU_TARGET_PCIE,
diff --git a/arch/arm/mach-kirkwood/include/mach/soc.h b/arch/arm/mach-kirkwood/include/mach/soc.h
index 227707ae4c95..1d7f2828cd38 100644
--- a/arch/arm/mach-kirkwood/include/mach/soc.h
+++ b/arch/arm/mach-kirkwood/include/mach/soc.h
@@ -31,7 +31,7 @@
 #define KW_RTC_BASE			(KW_REGISTER(0x10300))
 #define KW_NANDF_BASE			(KW_REGISTER(0x10418))
 #define MVEBU_SPI_BASE			(KW_REGISTER(0x10600))
-#define KW_CPU_WIN_BASE			(KW_REGISTER(0x20000))
+#define MVEBU_CPU_WIN_BASE			(KW_REGISTER(0x20000))
 #define KW_CPU_REG_BASE			(KW_REGISTER(0x20100))
 #define MVEBU_TIMER_BASE			(KW_REGISTER(0x20300))
 #define KW_REG_PCIE_BASE		(KW_REGISTER(0x40000))
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 03/12] ARM: kirkwood: remove KW_DEFADR_PCI_IO_REMAP
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board Chris Packham
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 02/12] ARM: kirkwood: rename KW_CPU_WIN_BASE to MVEBU_CPU_WIN_BASE Chris Packham
@ 2019-03-07  8:27 ` Chris Packham
  2019-03-07 11:30   ` Stefan Roese
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 04/12] ARM: kirkwood: switch to using mvebu mbus Chris Packham
                   ` (9 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:27 UTC (permalink / raw)
  To: u-boot

KW_DEFADR_PCI_IO_REMAP has the same value as KW_DEFADR_PCI_IO and is
only used to set up a 1:1 mapping. Remove it and update the mapping to
use KW_DEFADR_PCI_IO.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 arch/arm/mach-kirkwood/cpu.c              | 2 +-
 arch/arm/mach-kirkwood/include/mach/cpu.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c
index 277c699a4f9b..85c7f5903d94 100644
--- a/arch/arm/mach-kirkwood/cpu.c
+++ b/arch/arm/mach-kirkwood/cpu.c
@@ -76,7 +76,7 @@ int kw_config_adr_windows(void)
 	writel(KWCPU_WIN_CTRL_DATA(1024 * 64, KWCPU_TARGET_PCIE,
 		KWCPU_ATTR_PCIE_IO, KWCPU_WIN_ENABLE), &winregs[1].ctrl);
 	writel(KW_DEFADR_PCI_IO, &winregs[1].base);
-	writel(KW_DEFADR_PCI_IO_REMAP, &winregs[1].remap_lo);
+	writel(KW_DEFADR_PCI_IO, &winregs[1].remap_lo);
 	writel(0x0, &winregs[1].remap_hi);
 
 	/* Window 2: NAND Flash address space */
diff --git a/arch/arm/mach-kirkwood/include/mach/cpu.h b/arch/arm/mach-kirkwood/include/mach/cpu.h
index 91d21518d852..c35cace844ae 100644
--- a/arch/arm/mach-kirkwood/include/mach/cpu.h
+++ b/arch/arm/mach-kirkwood/include/mach/cpu.h
@@ -63,7 +63,6 @@ enum kwcpu_attrib {
  */
 #define KW_DEFADR_PCI_MEM	0x90000000
 #define KW_DEFADR_PCI_IO	0xC0000000
-#define KW_DEFADR_PCI_IO_REMAP	0xC0000000
 #define KW_DEFADR_SASRAM	0xC8010000
 #define KW_DEFADR_NANDF		0xD8000000
 #define KW_DEFADR_SPIF		0xE8000000
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 04/12] ARM: kirkwood: switch to using mvebu mbus
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (2 preceding siblings ...)
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 03/12] ARM: kirkwood: remove KW_DEFADR_PCI_IO_REMAP Chris Packham
@ 2019-03-07  8:27 ` Chris Packham
  2019-03-07 11:34   ` Stefan Roese
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 05/12] ARM: kirkwood: remove kw_config_adr_windows Chris Packham
                   ` (8 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:27 UTC (permalink / raw)
  To: u-boot

The mvebu mbus code already had most of the support required for
kirkwood. The only difference is that unlike the other mvebu targets
kirkwood doesn't have a bridge control block so the code related to
managing that needs to be compiled out.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 arch/arm/mach-kirkwood/cpu.c              | 33 ++++++++++++++++++++---
 arch/arm/mach-kirkwood/include/mach/cpu.h | 11 ++++++++
 arch/arm/mach-mvebu/Makefile              |  1 +
 arch/arm/mach-mvebu/mbus.c                |  6 +++++
 4 files changed, 48 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c
index 85c7f5903d94..311c5d50e2f9 100644
--- a/arch/arm/mach-kirkwood/cpu.c
+++ b/arch/arm/mach-kirkwood/cpu.c
@@ -110,6 +110,32 @@ int kw_config_adr_windows(void)
 	return 0;
 }
 
+static struct mbus_win windows[] = {
+	/* Window 0: PCIE MEM address space */
+	{ KW_DEFADR_PCI_MEM, 1024 * 1024 * 256,
+	  KWCPU_TARGET_PCIE, KWCPU_ATTR_PCIE_MEM },
+
+	/* Window 1: PCIE IO address space */
+	{ KW_DEFADR_PCI_IO, 1024 * 64,
+	  KWCPU_TARGET_PCIE, KWCPU_ATTR_PCIE_IO },
+
+	/* Window 2: NAND Flash address space */
+	{ KW_DEFADR_NANDF, 1024 * 1024 * 128,
+	  KWCPU_TARGET_MEMORY, KWCPU_ATTR_NANDFLASH },
+
+	/* Window 3: SPI Flash address space */
+	{ KW_DEFADR_SPIF, 1024 * 1024 * 128,
+	  KWCPU_TARGET_MEMORY, KWCPU_ATTR_SPIFLASH },
+
+	/* Window 4: BOOT Memory address space */
+	{ KW_DEFADR_BOOTROM, 1024 * 1024 * 128,
+	  KWCPU_TARGET_MEMORY, KWCPU_ATTR_BOOTROM },
+
+	/* Window 5: Security SRAM address space */
+	{ KW_DEFADR_SASRAM, 1024 * 64,
+	  KWCPU_TARGET_SASRAM, KWCPU_ATTR_SASRAM },
+};
+
 /*
  * SYSRSTn Duration Counter Support
  *
@@ -221,15 +247,13 @@ int arch_cpu_init(void)
 	struct kwcpu_registers *cpureg =
 		(struct kwcpu_registers *)KW_CPU_REG_BASE;
 
-	/* Linux expects` the internal registers to be at 0xf1000000 */
+	/* Linux expects the internal registers to be at 0xf1000000 */
 	writel(KW_REGS_PHY_BASE, KW_OFFSET_REG);
 
 	/* Enable and invalidate L2 cache in write through mode */
 	writel(readl(&cpureg->l2_cfg) | 0x18, &cpureg->l2_cfg);
 	invalidate_l2_cache();
 
-	kw_config_adr_windows();
-
 #ifdef CONFIG_KIRKWOOD_RGMII_PAD_1V8
 	/*
 	 * Configures the I/O voltage of the pads connected to Egigabit
@@ -295,6 +319,9 @@ int arch_misc_init(void)
 	temp = get_cr();
 	set_cr(temp & ~CR_V);
 
+	/* Configure mbus windows */
+	mvebu_mbus_probe(windows, ARRAY_SIZE(windows));
+
 	/* checks and execute resset to factory event */
 	kw_sysrst_check();
 
diff --git a/arch/arm/mach-kirkwood/include/mach/cpu.h b/arch/arm/mach-kirkwood/include/mach/cpu.h
index c35cace844ae..3d6b15568a8a 100644
--- a/arch/arm/mach-kirkwood/include/mach/cpu.h
+++ b/arch/arm/mach-kirkwood/include/mach/cpu.h
@@ -68,6 +68,13 @@ enum kwcpu_attrib {
 #define KW_DEFADR_SPIF		0xE8000000
 #define KW_DEFADR_BOOTROM	0xF8000000
 
+struct mbus_win {
+	u32 base;
+	u32 size;
+	u8 target;
+	u8 attr;
+};
+
 /*
  * read feroceon/sheeva core extra feature register
  * using co-proc instruction
@@ -134,6 +141,9 @@ struct kwgpio_registers {
 	u32 irq_level;
 };
 
+/* Needed for dynamic (board-specific) mbus configuration */
+extern struct mvebu_mbus_state mbus_state;
+
 /*
  * functions
  */
@@ -141,6 +151,7 @@ unsigned int mvebu_sdram_bar(enum memory_bank bank);
 unsigned int mvebu_sdram_bs(enum memory_bank bank);
 void mvebu_sdram_size_adjust(enum memory_bank bank);
 int kw_config_adr_windows(void);
+int mvebu_mbus_probe(struct mbus_win windows[], int count);
 void mvebu_config_gpio(unsigned int gpp0_oe_val, unsigned int gpp1_oe_val,
 		unsigned int gpp0_oe, unsigned int gpp1_oe);
 int kw_config_mpp(unsigned int mpp0_7, unsigned int mpp8_15,
diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
index ee2eca913484..c0274a6f09aa 100644
--- a/arch/arm/mach-mvebu/Makefile
+++ b/arch/arm/mach-mvebu/Makefile
@@ -14,6 +14,7 @@ ifdef CONFIG_KIRKWOOD
 
 obj-y	= dram.o
 obj-y	+= gpio.o
+obj-y	+= mbus.o
 obj-y	+= timer.o
 
 else # CONFIG_KIRKWOOD
diff --git a/arch/arm/mach-mvebu/mbus.c b/arch/arm/mach-mvebu/mbus.c
index df4c5cb2d718..9b2c57348266 100644
--- a/arch/arm/mach-mvebu/mbus.c
+++ b/arch/arm/mach-mvebu/mbus.c
@@ -405,6 +405,7 @@ int mvebu_mbus_del_window(phys_addr_t base, size_t size)
 	return 0;
 }
 
+#ifndef CONFIG_KIRKWOOD
 static void mvebu_mbus_get_lowest_base(struct mvebu_mbus_state *mbus,
 				       phys_addr_t *base)
 {
@@ -428,7 +429,9 @@ static void mvebu_mbus_get_lowest_base(struct mvebu_mbus_state *mbus,
 			*base = wbase;
 	}
 }
+#endif
 
+#ifndef CONFIG_KIRKWOOD
 static void mvebu_config_mbus_bridge(struct mvebu_mbus_state *mbus)
 {
 	phys_addr_t base;
@@ -451,6 +454,7 @@ static void mvebu_config_mbus_bridge(struct mvebu_mbus_state *mbus)
 	val = (size / (64 << 10)) - 1;
 	writel((val << 16) | 0x1, MBUS_BRIDGE_WIN_CTRL_REG);
 }
+#endif
 
 int mbus_dt_setup_win(struct mvebu_mbus_state *mbus,
 		      u32 base, u32 size, u8 target, u8 attr)
@@ -471,12 +475,14 @@ int mbus_dt_setup_win(struct mvebu_mbus_state *mbus,
 			return -ENOMEM;
 	}
 
+#ifndef CONFIG_KIRKWOOD
 	/*
 	 * Re-configure the mbus bridge registers each time this function
 	 * is called. Since it may get called from the board code in
 	 * later boot stages as well.
 	 */
 	mvebu_config_mbus_bridge(mbus);
+#endif
 
 	return 0;
 }
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 05/12] ARM: kirkwood: remove kw_config_adr_windows
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (3 preceding siblings ...)
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 04/12] ARM: kirkwood: switch to using mvebu mbus Chris Packham
@ 2019-03-07  8:27 ` Chris Packham
  2019-03-07 11:34   ` Stefan Roese
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 06/12] ARM: kirkwood: enable CONFIG_DM_USB on db-88f6281-bp Chris Packham
                   ` (7 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:27 UTC (permalink / raw)
  To: u-boot

Now that kirkwood is using the mvebu mbus this function is no longer
needed.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 arch/arm/mach-kirkwood/cpu.c              | 64 -----------------------
 arch/arm/mach-kirkwood/include/mach/cpu.h |  1 -
 2 files changed, 65 deletions(-)

diff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c
index 311c5d50e2f9..8f8e3003854c 100644
--- a/arch/arm/mach-kirkwood/cpu.c
+++ b/arch/arm/mach-kirkwood/cpu.c
@@ -46,70 +46,6 @@ unsigned int kw_winctrl_calcsize(unsigned int sizeval)
 	return (0x0000ffff & j);
 }
 
-/*
- * kw_config_adr_windows - Configure address Windows
- *
- * There are 8 address windows supported by Kirkwood Soc to addess different
- * devices. Each window can be configured for size, BAR and remap addr
- * Below configuration is standard for most of the cases
- *
- * If remap function not used, remap_lo must be set as base
- *
- * Reference Documentation:
- * Mbus-L to Mbus Bridge Registers Configuration.
- * (Sec 25.1 and 25.3 of Datasheet)
- */
-int kw_config_adr_windows(void)
-{
-	struct kwwin_registers *winregs =
-		(struct kwwin_registers *)MVEBU_CPU_WIN_BASE;
-
-	/* Window 0: PCIE MEM address space */
-	writel(KWCPU_WIN_CTRL_DATA(1024 * 1024 * 256, KWCPU_TARGET_PCIE,
-		KWCPU_ATTR_PCIE_MEM, KWCPU_WIN_ENABLE), &winregs[0].ctrl);
-
-	writel(KW_DEFADR_PCI_MEM, &winregs[0].base);
-	writel(KW_DEFADR_PCI_MEM, &winregs[0].remap_lo);
-	writel(0x0, &winregs[0].remap_hi);
-
-	/* Window 1: PCIE IO address space */
-	writel(KWCPU_WIN_CTRL_DATA(1024 * 64, KWCPU_TARGET_PCIE,
-		KWCPU_ATTR_PCIE_IO, KWCPU_WIN_ENABLE), &winregs[1].ctrl);
-	writel(KW_DEFADR_PCI_IO, &winregs[1].base);
-	writel(KW_DEFADR_PCI_IO, &winregs[1].remap_lo);
-	writel(0x0, &winregs[1].remap_hi);
-
-	/* Window 2: NAND Flash address space */
-	writel(KWCPU_WIN_CTRL_DATA(1024 * 1024 * 128, KWCPU_TARGET_MEMORY,
-		KWCPU_ATTR_NANDFLASH, KWCPU_WIN_ENABLE), &winregs[2].ctrl);
-	writel(KW_DEFADR_NANDF, &winregs[2].base);
-	writel(KW_DEFADR_NANDF, &winregs[2].remap_lo);
-	writel(0x0, &winregs[2].remap_hi);
-
-	/* Window 3: SPI Flash address space */
-	writel(KWCPU_WIN_CTRL_DATA(1024 * 1024 * 128, KWCPU_TARGET_MEMORY,
-		KWCPU_ATTR_SPIFLASH, KWCPU_WIN_ENABLE), &winregs[3].ctrl);
-	writel(KW_DEFADR_SPIF, &winregs[3].base);
-	writel(KW_DEFADR_SPIF, &winregs[3].remap_lo);
-	writel(0x0, &winregs[3].remap_hi);
-
-	/* Window 4: BOOT Memory address space */
-	writel(KWCPU_WIN_CTRL_DATA(1024 * 1024 * 128, KWCPU_TARGET_MEMORY,
-		KWCPU_ATTR_BOOTROM, KWCPU_WIN_ENABLE), &winregs[4].ctrl);
-	writel(KW_DEFADR_BOOTROM, &winregs[4].base);
-
-	/* Window 5: Security SRAM address space */
-	writel(KWCPU_WIN_CTRL_DATA(1024 * 64, KWCPU_TARGET_SASRAM,
-		KWCPU_ATTR_SASRAM, KWCPU_WIN_ENABLE), &winregs[5].ctrl);
-	writel(KW_DEFADR_SASRAM, &winregs[5].base);
-
-	/* Window 6-7: Disabled */
-	writel(KWCPU_WIN_DISABLE, &winregs[6].ctrl);
-	writel(KWCPU_WIN_DISABLE, &winregs[7].ctrl);
-
-	return 0;
-}
-
 static struct mbus_win windows[] = {
 	/* Window 0: PCIE MEM address space */
 	{ KW_DEFADR_PCI_MEM, 1024 * 1024 * 256,
diff --git a/arch/arm/mach-kirkwood/include/mach/cpu.h b/arch/arm/mach-kirkwood/include/mach/cpu.h
index 3d6b15568a8a..ea42182cf9c6 100644
--- a/arch/arm/mach-kirkwood/include/mach/cpu.h
+++ b/arch/arm/mach-kirkwood/include/mach/cpu.h
@@ -150,7 +150,6 @@ extern struct mvebu_mbus_state mbus_state;
 unsigned int mvebu_sdram_bar(enum memory_bank bank);
 unsigned int mvebu_sdram_bs(enum memory_bank bank);
 void mvebu_sdram_size_adjust(enum memory_bank bank);
-int kw_config_adr_windows(void);
 int mvebu_mbus_probe(struct mbus_win windows[], int count);
 void mvebu_config_gpio(unsigned int gpp0_oe_val, unsigned int gpp1_oe_val,
 		unsigned int gpp0_oe, unsigned int gpp1_oe);
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 06/12] ARM: kirkwood: enable CONFIG_DM_USB on db-88f6281-bp
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (4 preceding siblings ...)
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 05/12] ARM: kirkwood: remove kw_config_adr_windows Chris Packham
@ 2019-03-07  8:27 ` Chris Packham
  2019-03-07 11:35   ` Stefan Roese
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 07/12] ARM: kirkwood: enable CONFIG_DM_USB for {dream, guru, sheeva}plug Chris Packham
                   ` (6 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:27 UTC (permalink / raw)
  To: u-boot

Switch to the driver model for USB on the db-88f6281-bp board.
CONFIG_BLK can't be enabled yet because mvebu_mmc.c needs converting.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 configs/db-88f6281-bp-nand_defconfig | 1 +
 configs/db-88f6281-bp-spi_defconfig  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/configs/db-88f6281-bp-nand_defconfig b/configs/db-88f6281-bp-nand_defconfig
index 6360ef5e8280..a7a65df7ee7b 100644
--- a/configs/db-88f6281-bp-nand_defconfig
+++ b/configs/db-88f6281-bp-nand_defconfig
@@ -47,6 +47,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
 CONFIG_KIRKWOOD_SPI=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_LZMA=y
diff --git a/configs/db-88f6281-bp-spi_defconfig b/configs/db-88f6281-bp-spi_defconfig
index 93e125af5b2d..dc4bee2676de 100644
--- a/configs/db-88f6281-bp-spi_defconfig
+++ b/configs/db-88f6281-bp-spi_defconfig
@@ -48,6 +48,7 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_KIRKWOOD_SPI=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_LZMA=y
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 07/12] ARM: kirkwood: enable CONFIG_DM_USB for {dream, guru, sheeva}plug
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (5 preceding siblings ...)
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 06/12] ARM: kirkwood: enable CONFIG_DM_USB on db-88f6281-bp Chris Packham
@ 2019-03-07  8:28 ` Chris Packham
  2019-03-07 11:35   ` Stefan Roese
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 08/12] ARM: kirkwood: enable CONFIG_DM_USB for dns325 Chris Packham
                   ` (5 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:28 UTC (permalink / raw)
  To: u-boot

Enable CONFIG_DM_USB and where possible CONFIG_BLK.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
mvebu_mmc.c hasn't been converted to DM so it's not possible to use
CONFIG_BLK when CONFIG_MMC is enabled.

 configs/dreamplug_defconfig  | 2 ++
 configs/guruplug_defconfig   | 2 ++
 configs/sheevaplug_defconfig | 1 +
 3 files changed, 5 insertions(+)

diff --git a/configs/dreamplug_defconfig b/configs/dreamplug_defconfig
index d3263cf9cd3f..fc99fbda5674 100644
--- a/configs/dreamplug_defconfig
+++ b/configs/dreamplug_defconfig
@@ -25,6 +25,7 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-dreamplug"
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_DM=y
 CONFIG_MVSATA_IDE=y
+CONFIG_BLK=y
 # CONFIG_MMC is not set
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
@@ -38,5 +39,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_KIRKWOOD_SPI=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
diff --git a/configs/guruplug_defconfig b/configs/guruplug_defconfig
index 9998e48ab9c2..8ae7e20bafd9 100644
--- a/configs/guruplug_defconfig
+++ b/configs/guruplug_defconfig
@@ -31,6 +31,7 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-guruplug-server-plus"
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_DM=y
 CONFIG_MVSATA_IDE=y
+CONFIG_BLK=y
 # CONFIG_MMC is not set
 CONFIG_MVGBE=y
 CONFIG_MII=y
@@ -38,6 +39,7 @@ CONFIG_DM_RTC=y
 CONFIG_RTC_MV=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_LZMA=y
diff --git a/configs/sheevaplug_defconfig b/configs/sheevaplug_defconfig
index 04b00cdea9d4..ec527fceb6f5 100644
--- a/configs/sheevaplug_defconfig
+++ b/configs/sheevaplug_defconfig
@@ -39,6 +39,7 @@ CONFIG_DM_RTC=y
 CONFIG_RTC_MV=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_LZMA=y
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 08/12] ARM: kirkwood: enable CONFIG_DM_USB for dns325
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (6 preceding siblings ...)
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 07/12] ARM: kirkwood: enable CONFIG_DM_USB for {dream, guru, sheeva}plug Chris Packham
@ 2019-03-07  8:28 ` Chris Packham
  2019-03-07 11:35   ` Stefan Roese
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 09/12] ARM: kirkwood: enable CONFIG_DM_USB for ds109 Chris Packham
                   ` (4 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:28 UTC (permalink / raw)
  To: u-boot

Enable CONFIG_DM_USB and CONFIG_BLK.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 configs/dns325_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/dns325_defconfig b/configs/dns325_defconfig
index 5a766981603a..ba8b053680b9 100644
--- a/configs/dns325_defconfig
+++ b/configs/dns325_defconfig
@@ -30,6 +30,7 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-dns325"
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_DM=y
 CONFIG_MVSATA_IDE=y
+CONFIG_BLK=y
 # CONFIG_MMC is not set
 CONFIG_MVGBE=y
 CONFIG_MII=y
@@ -37,5 +38,6 @@ CONFIG_DM_RTC=y
 CONFIG_RTC_MV=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 09/12] ARM: kirkwood: enable CONFIG_DM_USB for ds109
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (7 preceding siblings ...)
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 08/12] ARM: kirkwood: enable CONFIG_DM_USB for dns325 Chris Packham
@ 2019-03-07  8:28 ` Chris Packham
  2019-03-07 11:36   ` Stefan Roese
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 10/12] ARM: kirkwood: enable CONFIG_DM_USB for goflexhome Chris Packham
                   ` (3 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:28 UTC (permalink / raw)
  To: u-boot

Enable CONFIG_DM_USB and CONFIG_BLK.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 configs/ds109_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/ds109_defconfig b/configs/ds109_defconfig
index 3e4e71bcbf4e..ce055f6f1608 100644
--- a/configs/ds109_defconfig
+++ b/configs/ds109_defconfig
@@ -20,6 +20,7 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-ds109"
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_DM=y
 CONFIG_MVSATA_IDE=y
+CONFIG_BLK=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_MVTWSI=y
 # CONFIG_MMC is not set
@@ -35,5 +36,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_KIRKWOOD_SPI=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_FS_EXT4=y
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 10/12] ARM: kirkwood: enable CONFIG_DM_USB for goflexhome
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (8 preceding siblings ...)
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 09/12] ARM: kirkwood: enable CONFIG_DM_USB for ds109 Chris Packham
@ 2019-03-07  8:28 ` Chris Packham
  2019-03-07 11:36   ` Stefan Roese
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 11/12] ARM: kirkwood: enable CONFIG_DM_USB for lschlv2 and lsxhl Chris Packham
                   ` (2 subsequent siblings)
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:28 UTC (permalink / raw)
  To: u-boot

Enable CONFIG_DM_USB and CONFIG_BLK.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 configs/goflexhome_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/goflexhome_defconfig b/configs/goflexhome_defconfig
index c04bf0ea5742..568b74fd8306 100644
--- a/configs/goflexhome_defconfig
+++ b/configs/goflexhome_defconfig
@@ -31,6 +31,7 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-goflexnet"
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_DM=y
 CONFIG_MVSATA_IDE=y
+CONFIG_BLK=y
 # CONFIG_MMC is not set
 CONFIG_MVGBE=y
 CONFIG_MII=y
@@ -38,5 +39,6 @@ CONFIG_DM_RTC=y
 CONFIG_RTC_MV=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 11/12] ARM: kirkwood: enable CONFIG_DM_USB for lschlv2 and lsxhl
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (9 preceding siblings ...)
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 10/12] ARM: kirkwood: enable CONFIG_DM_USB for goflexhome Chris Packham
@ 2019-03-07  8:28 ` Chris Packham
  2019-03-07 11:36   ` Stefan Roese
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 12/12] ARM: kirkwood: enable CONFIG_DM_USB for nas220 Chris Packham
  2019-03-08 10:16 ` [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Leigh Brown
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:28 UTC (permalink / raw)
  To: u-boot

Enable CONFIG_DM_USB and CONFIG_BLK.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 configs/lschlv2_defconfig | 2 ++
 configs/lsxhl_defconfig   | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/configs/lschlv2_defconfig b/configs/lschlv2_defconfig
index 8563abc1356b..7dadc3984efb 100644
--- a/configs/lschlv2_defconfig
+++ b/configs/lschlv2_defconfig
@@ -27,6 +27,7 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_MVSATA_IDE=y
+CONFIG_BLK=y
 # CONFIG_MMC is not set
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
@@ -38,4 +39,5 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_KIRKWOOD_SPI=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
diff --git a/configs/lsxhl_defconfig b/configs/lsxhl_defconfig
index c3636060a75c..56379d2668a2 100644
--- a/configs/lsxhl_defconfig
+++ b/configs/lsxhl_defconfig
@@ -27,6 +27,7 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_MVSATA_IDE=y
+CONFIG_BLK=y
 # CONFIG_MMC is not set
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
@@ -38,4 +39,5 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_KIRKWOOD_SPI=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 12/12] ARM: kirkwood: enable CONFIG_DM_USB for nas220
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (10 preceding siblings ...)
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 11/12] ARM: kirkwood: enable CONFIG_DM_USB for lschlv2 and lsxhl Chris Packham
@ 2019-03-07  8:28 ` Chris Packham
  2019-03-07 11:36   ` Stefan Roese
  2019-03-08 10:16 ` [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Leigh Brown
  12 siblings, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-07  8:28 UTC (permalink / raw)
  To: u-boot

Enable CONFIG_DM_USB and CONFIG_BLK.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 configs/nas220_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/nas220_defconfig b/configs/nas220_defconfig
index 6bd308bb8264..a244b8d69168 100644
--- a/configs/nas220_defconfig
+++ b/configs/nas220_defconfig
@@ -31,6 +31,7 @@ CONFIG_DEFAULT_DEVICE_TREE="kirkwood-blackarmor-nas220"
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_DM=y
 CONFIG_MVSATA_IDE=y
+CONFIG_BLK=y
 # CONFIG_MMC is not set
 CONFIG_MVGBE=y
 CONFIG_MII=y
@@ -38,5 +39,6 @@ CONFIG_DM_RTC=y
 CONFIG_RTC_MV=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board Chris Packham
@ 2019-03-07  9:33   ` Stefan Roese
  2019-03-08  6:44     ` Chris Packham
  2019-03-13  7:00     ` Chris Packham
  0 siblings, 2 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07  9:33 UTC (permalink / raw)
  To: u-boot

Hi Chris,

On 07.03.19 09:27, Chris Packham wrote:
> This is Marvell's Kirkwood development board. It has the following
> features
> 
>   - 512M DDR2
>   - 2 PCI connectors
>   - 1 x1 PCI-e interface
>   - 1 Gigabit Ethernet Port
>   - 2 SATA Ports
>   - USB 2.0 Interface
>   - SDIO
>   - 128M NAND Flash
>   - 16M SPI Flash
> 
> It can be strapped to boot from SPI or NAND so there are two defconfigs
> (one per boot media).

Thanks for this board addition. Please find some review comments
below.

> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> 
>   arch/arm/dts/kirkwood-db-88f6281-spi.dts    |  48 +++++++++
>   arch/arm/dts/kirkwood-db-88f6281.dts        |  26 +++++
>   arch/arm/dts/kirkwood-db.dtsi               |  94 +++++++++++++++++
>   arch/arm/mach-kirkwood/Kconfig              |   4 +
>   board/Marvell/db-88f6281-bp/Kconfig         |  12 +++
>   board/Marvell/db-88f6281-bp/MAINTAINERS     |  10 ++
>   board/Marvell/db-88f6281-bp/Makefile        |   3 +
>   board/Marvell/db-88f6281-bp/db-88f6281-bp.c | 103 ++++++++++++++++++
>   board/Marvell/db-88f6281-bp/kwbimage.cfg    |  36 +++++++
>   configs/db-88f6281-bp-nand_defconfig        |  53 ++++++++++
>   configs/db-88f6281-bp-spi_defconfig         |  54 ++++++++++
>   include/configs/db-88f6281-bp.h             | 109 ++++++++++++++++++++
>   12 files changed, 552 insertions(+)
>   create mode 100644 arch/arm/dts/kirkwood-db-88f6281-spi.dts
>   create mode 100644 arch/arm/dts/kirkwood-db-88f6281.dts
>   create mode 100644 arch/arm/dts/kirkwood-db.dtsi
>   create mode 100644 board/Marvell/db-88f6281-bp/Kconfig
>   create mode 100644 board/Marvell/db-88f6281-bp/MAINTAINERS
>   create mode 100644 board/Marvell/db-88f6281-bp/Makefile
>   create mode 100644 board/Marvell/db-88f6281-bp/db-88f6281-bp.c
>   create mode 100644 board/Marvell/db-88f6281-bp/kwbimage.cfg
>   create mode 100644 configs/db-88f6281-bp-nand_defconfig
>   create mode 100644 configs/db-88f6281-bp-spi_defconfig
>   create mode 100644 include/configs/db-88f6281-bp.h
> 
> diff --git a/arch/arm/dts/kirkwood-db-88f6281-spi.dts b/arch/arm/dts/kirkwood-db-88f6281-spi.dts
> new file mode 100644
> index 000000000000..50b1b0d4a535
> --- /dev/null
> +++ b/arch/arm/dts/kirkwood-db-88f6281-spi.dts
> @@ -0,0 +1,48 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Marvell DB-88F6281-BP Development Board Setup
> + *
> + * Saeed Bishara <saeed@marvell.com>
> + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> + *
> + */
> +
> +/dts-v1/;
> +
> +#include "kirkwood-db-88f6281.dts"
> +
> +/ {
> +	aliases {
> +		spi0 = &spi0;
> +	};
> +};
> +
> +&spi0 {
> +	status = "okay";
> +
> +	flash at 0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "st,m25p128", "jedec,spi-nor", "spi-flash";
> +		reg = <0>;
> +		spi-max-frequency = <50000000>;
> +		mode = <0>;
> +
> +		partition at u-boot {
> +			reg = <0x00000000 0x00c00000>;
> +			label = "u-boot";
> +		};
> +		partition at u-boot-env {
> +			reg = <0x00c00000 0x00040000>;
> +			label = "u-boot-env";
> +		};
> +		partition at unused {
> +			reg = <0x00100000 0x00f00000>;
> +			label = "unused";
> +		};
> +	};
> +};
> +
> +&nand {
> +	status = "disabled";
> +};
> diff --git a/arch/arm/dts/kirkwood-db-88f6281.dts b/arch/arm/dts/kirkwood-db-88f6281.dts
> new file mode 100644
> index 000000000000..2adb17c955aa
> --- /dev/null
> +++ b/arch/arm/dts/kirkwood-db-88f6281.dts
> @@ -0,0 +1,26 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Marvell DB-88F6281-BP Development Board Setup
> + *
> + * Saeed Bishara <saeed@marvell.com>
> + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> + *
> + */
> +
> +/dts-v1/;
> +
> +#include "kirkwood-db.dtsi"
> +#include "kirkwood-6281.dtsi"
> +
> +/ {
> +	model = "Marvell DB-88F6281-BP Development Board";
> +	compatible = "marvell,db-88f6281-bp", "marvell,kirkwood-88f6281", "marvell,kirkwood";
> +};
> +
> +&pciec {
> +        status = "okay";
> +};
> +
> +&pcie0 {
> +	status = "okay";
> +};
> diff --git a/arch/arm/dts/kirkwood-db.dtsi b/arch/arm/dts/kirkwood-db.dtsi
> new file mode 100644
> index 000000000000..b81d8e8298a3
> --- /dev/null
> +++ b/arch/arm/dts/kirkwood-db.dtsi
> @@ -0,0 +1,94 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Marvell DB-{88F6281,88F6282}-BP Development Board Setup
> + *
> + * Saeed Bishara <saeed@marvell.com>
> + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> + *
> + * This file contains the definitions that are common between the 6281
> + * and 6282 variants of the Marvell Kirkwood Development Board.
> + */
> +
> +#include "kirkwood.dtsi"
> +
> +/ {
> +	memory {
> +		device_type = "memory";
> +		reg = <0x00000000 0x20000000>; /* 512 MB */
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200n8 earlyprintk";
> +		stdout-path = &uart0;
> +	};
> +
> +	aliases {
> +		ethernet0 = &eth0;
> +		spi0 = &spi0;
> +	};
> +
> +	ocp at f1000000 {
> +		pin-controller at 10000 {
> +			pmx_sdio_gpios: pmx-sdio-gpios {
> +				marvell,pins = "mpp37", "mpp38";
> +				marvell,function = "gpio";
> +			};
> +		};
> +
> +		serial at 12000 {
> +			status = "okay";
> +		};
> +
> +		sata at 80000 {
> +			nr-ports = <2>;
> +			status = "okay";
> +		};
> +
> +		ehci at 50000 {
> +			status = "okay";
> +		};
> +
> +		mvsdio at 90000 {
> +			pinctrl-0 = <&pmx_sdio_gpios>;
> +			pinctrl-names = "default";
> +			wp-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> +			cd-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
> +			status = "okay";
> +		};
> +	};
> +};
> +
> +&nand {
> +	chip-delay = <25>;
> +	status = "okay";
> +
> +	partition at 0 {
> +		label = "uboot";
> +		reg = <0x0 0x100000>;
> +	};
> +
> +	partition at 100000 {
> +		label = "uImage";
> +		reg = <0x100000 0x400000>;
> +	};
> +
> +	partition at 500000 {
> +		label = "root";
> +		reg = <0x500000 0x1fb00000>;
> +	};
> +};
> +
> +&mdio {
> +	status = "okay";
> +
> +	ethphy0: ethernet-phy at 8 {
> +		reg = <8>;
> +	};
> +};
> +
> +&eth0 {
> +	status = "okay";
> +	ethernet0-port at 0 {
> +		phy-handle = <&ethphy0>;
> +	};
> +};
> diff --git a/arch/arm/mach-kirkwood/Kconfig b/arch/arm/mach-kirkwood/Kconfig
> index 3b860c4f55fe..7c4170399afb 100644
> --- a/arch/arm/mach-kirkwood/Kconfig
> +++ b/arch/arm/mach-kirkwood/Kconfig
> @@ -65,6 +65,9 @@ config TARGET_SBx81LIFKW
>   config TARGET_SBx81LIFXCAT
>   	bool "Allied Telesis SBx81GP24/SBx81GT24"
>   
> +config TARGET_DB_88F6281_BP
> +	bool "Marvell DB-88F6281-BP"
> +
>   endchoice
>   
>   config SYS_SOC
> @@ -89,5 +92,6 @@ source "board/Seagate/nas220/Kconfig"
>   source "board/zyxel/nsa310s/Kconfig"
>   source "board/alliedtelesis/SBx81LIFKW/Kconfig"
>   source "board/alliedtelesis/SBx81LIFXCAT/Kconfig"
> +source "board/Marvell/db-88f6281-bp/Kconfig"
>   
>   endif
> diff --git a/board/Marvell/db-88f6281-bp/Kconfig b/board/Marvell/db-88f6281-bp/Kconfig
> new file mode 100644
> index 000000000000..38467399e688
> --- /dev/null
> +++ b/board/Marvell/db-88f6281-bp/Kconfig
> @@ -0,0 +1,12 @@
> +if TARGET_DB_88F6281_BP
> +
> +config SYS_BOARD
> +	default "db-88f6281-bp"
> +
> +config SYS_VENDOR
> +	default "Marvell"
> +
> +config SYS_CONFIG_NAME
> +	default "db-88f6281-bp"
> +
> +endif
> diff --git a/board/Marvell/db-88f6281-bp/MAINTAINERS b/board/Marvell/db-88f6281-bp/MAINTAINERS
> new file mode 100644
> index 000000000000..f31d3be70bae
> --- /dev/null
> +++ b/board/Marvell/db-88f6281-bp/MAINTAINERS
> @@ -0,0 +1,10 @@
> +DB_88F6820_AMC BOARD
> +M:	Chris Packham <judge.packham@gmail.com>
> +S:	Maintained
> +F:	arch/arm/dts/kirkwood-db-88f6281.dts
> +F:	arch/arm/dts/kirkwood-db-88f6281-spi.dts
> +F:	arch/arm/dts/kirkwood-db.dtsi
> +F:	board/Marvell/db-88f6281-bp/
> +F:	include/configs/db-88f6281-bp.h
> +F:	configs/db-88f6281-bp_defconfig
> +F:	configs/db-88f6281-bp-spi_defconfig
> diff --git a/board/Marvell/db-88f6281-bp/Makefile b/board/Marvell/db-88f6281-bp/Makefile
> new file mode 100644
> index 000000000000..38ff522ca1c8
> --- /dev/null
> +++ b/board/Marvell/db-88f6281-bp/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +
> +obj-y	:= db-88f6281-bp.o
> diff --git a/board/Marvell/db-88f6281-bp/db-88f6281-bp.c b/board/Marvell/db-88f6281-bp/db-88f6281-bp.c
> new file mode 100644
> index 000000000000..b68f2f3c895b
> --- /dev/null
> +++ b/board/Marvell/db-88f6281-bp/db-88f6281-bp.c
> @@ -0,0 +1,103 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +
> +#include <common.h>
> +#include <linux/io.h>
> +#include <miiphy.h>
> +#include <netdev.h>
> +#include <asm/arch/cpu.h>
> +#include <asm/arch/soc.h>
> +#include <asm/arch/mpp.h>
> +#include <asm/arch/gpio.h>
> +
> +#define DB_88F6281_OE_LOW	~(BIT(7))
> +#define DB_88F6281_OE_HIGH	~(BIT(15) | BIT(14) | BIT(13) | BIT(4))
> +#define DB_88F6281_OE_VAL_LOW	BIT(7)
> +#define DB_88F6281_OE_VAL_HIGH	0
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +int board_early_init_f(void)
> +{
> +	mvebu_config_gpio(DB_88F6281_OE_VAL_LOW,
> +			  DB_88F6281_OE_VAL_HIGH,
> +			  DB_88F6281_OE_LOW, DB_88F6281_OE_HIGH);
> +
> +	/* Multi-Purpose Pins Functionality configuration */
> +	static const u32 kwmpp_config[] = {
> +#ifdef CONFIG_CMD_NAND
> +		MPP0_NF_IO2,
> +		MPP1_NF_IO3,
> +		MPP2_NF_IO4,
> +		MPP3_NF_IO5,
> +#else
> +		MPP0_SPI_SCn,
> +		MPP1_SPI_MOSI,
> +		MPP2_SPI_SCK,
> +		MPP3_SPI_MISO,
> +#endif
> +		MPP4_NF_IO6,
> +		MPP5_NF_IO7,
> +		MPP6_SYSRST_OUTn,
> +		MPP7_GPO,
> +		MPP8_TW_SDA,
> +		MPP9_TW_SCK,
> +		MPP10_UART0_TXD,
> +		MPP11_UART0_RXD,
> +		MPP12_SD_CLK,
> +		MPP13_SD_CMD,
> +		MPP14_SD_D0,
> +		MPP15_SD_D1,
> +		MPP16_SD_D2,
> +		MPP17_SD_D3,
> +		MPP18_NF_IO0,
> +		MPP19_NF_IO1,
> +		MPP20_SATA1_ACTn,
> +		MPP21_SATA0_ACTn,
> +		MPP22_GPIO,
> +		MPP23_GPIO,
> +		MPP24_GPIO,
> +		MPP25_GPIO,
> +		MPP26_GPIO,
> +		MPP27_GPIO,
> +		MPP28_GPIO,
> +		MPP29_GPIO,
> +		MPP30_GPIO,
> +		MPP31_GPIO,
> +		MPP32_GPIO,
> +		MPP33_GPIO,
> +		MPP34_GPIO,
> +		MPP35_GPIO,
> +		MPP36_GPIO,
> +		MPP37_GPIO,
> +		MPP38_GPIO,
> +		MPP39_GPIO,
> +		MPP40_GPIO,
> +		MPP41_GPIO,
> +		MPP42_GPIO,
> +		MPP43_GPIO,
> +		MPP44_GPIO,
> +		MPP45_GPIO,
> +		MPP46_GPIO,
> +		MPP47_GPIO,
> +		MPP48_GPIO,
> +		MPP49_GPIO,
> +		0
> +	};
> +	kirkwood_mpp_conf(kwmpp_config, NULL);
> +
> +	return 0;
> +}
> +
> +int board_init(void)
> +{
> +	gd->bd->bi_boot_params = mvebu_sdram_bar(0) + 0x100;
> +
> +	return 0;
> +}
> +
> +#ifdef CONFIG_RESET_PHY_R
> +/* automatically defined by kirkwood config.h */
> +void reset_phy(void)
> +{
> +}
> +#endif
> diff --git a/board/Marvell/db-88f6281-bp/kwbimage.cfg b/board/Marvell/db-88f6281-bp/kwbimage.cfg
> new file mode 100644
> index 000000000000..49a637078682
> --- /dev/null
> +++ b/board/Marvell/db-88f6281-bp/kwbimage.cfg
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +
> +# Boot Media configurations
> +BOOT_FROM	spi	# Boot from SPI flash

How is booting from NAND handled? Is the boot device patched
dynamically in the resulting image?

> +
> +DATA 0xd00100e0 0x1b1b1b9b
> +DATA 0xd0020134 0xbbbbbbbb
> +DATA 0xd0020138 0x00bbbbbb
> +DATA 0xd0020154 0x00000200
> +DATA 0xd002014c 0x00001c00
> +DATA 0xd0020148 0x00000001
> +
> +DATA 0xd0001400 0x43000c30
> +DATA 0xd0001404 0x39543000
> +DATA 0xd0001408 0x22125451
> +DATA 0xd000140c 0x00000833
> +DATA 0xd0001410 0x000000cc
> +DATA 0xd0001414 0x00000000
> +DATA 0xd0001418 0x00000000
> +DATA 0xd000141c 0x00000c52
> +DATA 0xd0001420 0x00000044
> +DATA 0xd0001424 0x0000f1ff
> +DATA 0xd0001428 0x00085520
> +DATA 0xd000147c 0x00008552
> +DATA 0xd0001504 0x0ffffff1
> +DATA 0xd0001508 0x10000000
> +DATA 0xd000150c 0x0ffffff5
> +DATA 0xd0001514 0x00000000
> +DATA 0xd000151c 0x00000000
> +DATA 0xd0001494 0x84210000
> +DATA 0xd0001498 0x00000000
> +DATA 0xd000149c 0x0000f40f
> +DATA 0xd0001480 0x00000001
> +
> +# End of Header extension
> +DATA 0x0 0x0
> diff --git a/configs/db-88f6281-bp-nand_defconfig b/configs/db-88f6281-bp-nand_defconfig
> new file mode 100644
> index 000000000000..6360ef5e8280
> --- /dev/null
> +++ b/configs/db-88f6281-bp-nand_defconfig
> @@ -0,0 +1,53 @@
> +CONFIG_ARM=y
> +CONFIG_SYS_THUMB_BUILD=y
> +CONFIG_KIRKWOOD=y
> +CONFIG_SYS_TEXT_BASE=0x600000
> +CONFIG_TARGET_DB_88F6281_BP=y
> +CONFIG_IDENT_STRING="\nMarvell DB-88F6281-BP"
> +CONFIG_NR_DRAM_BANKS=2
> +# CONFIG_SYS_MALLOC_F is not set
> +CONFIG_BOOTDELAY=3
> +# CONFIG_DISPLAY_BOARDINFO is not set
> +CONFIG_HUSH_PARSER=y
> +CONFIG_CMD_BOOTZ=y
> +CONFIG_CMD_DM=y
> +# CONFIG_CMD_FLASH is not set
> +CONFIG_CMD_IDE=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_NAND=y
> +CONFIG_CMD_SF=y
> +CONFIG_CMD_USB=y
> +# CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_DHCP=y
> +CONFIG_CMD_MII=y
> +CONFIG_CMD_PING=y
> +CONFIG_CMD_EXT2=y
> +CONFIG_CMD_EXT4=y
> +CONFIG_CMD_FAT=y
> +CONFIG_CMD_JFFS2=y
> +CONFIG_CMD_MTDPARTS=y
> +CONFIG_MTDIDS_DEFAULT="nand0=orion_nand"
> +CONFIG_MTDPARTS_DEFAULT="mtdparts=orion_nand:512K(uboot),512K(env),4M(kernel),-(rootfs)"
> +CONFIG_ISO_PARTITION=y
> +CONFIG_OF_CONTROL=y
> +CONFIG_DEFAULT_DEVICE_TREE="kirkwood-db-88f6281"
> +CONFIG_ENV_IS_IN_SPI_FLASH=y
> +CONFIG_NET_RANDOM_ETHADDR=y
> +CONFIG_DM=y
> +CONFIG_MVSATA_IDE=y
> +CONFIG_SPI_FLASH=y
> +CONFIG_SPI_FLASH_STMICRO=y
> +CONFIG_PHY_MARVELL=y
> +CONFIG_DM_ETH=y
> +CONFIG_MVGBE=y
> +CONFIG_MII=y
> +CONFIG_DM_RTC=y
> +CONFIG_RTC_MV=y
> +CONFIG_SYS_NS16550=y
> +CONFIG_SPI=y
> +CONFIG_KIRKWOOD_SPI=y
> +CONFIG_USB=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_STORAGE=y
> +CONFIG_LZMA=y
> +CONFIG_LZO=y
> diff --git a/configs/db-88f6281-bp-spi_defconfig b/configs/db-88f6281-bp-spi_defconfig
> new file mode 100644
> index 000000000000..93e125af5b2d
> --- /dev/null
> +++ b/configs/db-88f6281-bp-spi_defconfig
> @@ -0,0 +1,54 @@
> +CONFIG_ARM=y
> +CONFIG_SYS_THUMB_BUILD=y
> +CONFIG_KIRKWOOD=y
> +CONFIG_SYS_TEXT_BASE=0x600000
> +CONFIG_TARGET_DB_88F6281_BP=y
> +CONFIG_IDENT_STRING="\nMarvell DB-88F6281-BP"
> +CONFIG_NR_DRAM_BANKS=2
> +# CONFIG_SYS_MALLOC_F is not set
> +CONFIG_BOOTDELAY=3
> +# CONFIG_DISPLAY_BOARDINFO is not set
> +CONFIG_HUSH_PARSER=y
> +CONFIG_CMD_BOOTZ=y
> +CONFIG_CMD_DM=y
> +# CONFIG_CMD_FLASH is not set
> +CONFIG_CMD_IDE=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_SF=y
> +CONFIG_CMD_USB=y
> +# CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_DHCP=y
> +CONFIG_CMD_MII=y
> +CONFIG_CMD_PING=y
> +CONFIG_CMD_EXT2=y
> +CONFIG_CMD_EXT4=y
> +CONFIG_CMD_FAT=y
> +CONFIG_CMD_JFFS2=y
> +CONFIG_CMD_MTDPARTS=y
> +CONFIG_MTDIDS_DEFAULT="nand0=orion_nand"
> +CONFIG_MTDPARTS_DEFAULT="mtdparts=orion_nand:512K(uboot),512K(env),4M(kernel),-(rootfs)"
> +CONFIG_ISO_PARTITION=y
> +CONFIG_OF_CONTROL=y
> +CONFIG_DEFAULT_DEVICE_TREE="kirkwood-db-88f6281-spi"
> +CONFIG_ENV_IS_IN_SPI_FLASH=y
> +CONFIG_NET_RANDOM_ETHADDR=y
> +CONFIG_DM=y
> +CONFIG_MVSATA_IDE=y
> +CONFIG_DM_SPI_FLASH=y
> +CONFIG_SPI_FLASH=y
> +CONFIG_SPI_FLASH_STMICRO=y
> +CONFIG_PHY_MARVELL=y
> +CONFIG_DM_ETH=y
> +CONFIG_MVGBE=y
> +CONFIG_MII=y
> +CONFIG_DM_RTC=y
> +CONFIG_RTC_MV=y
> +CONFIG_SYS_NS16550=y
> +CONFIG_SPI=y
> +CONFIG_DM_SPI=y
> +CONFIG_KIRKWOOD_SPI=y
> +CONFIG_USB=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_STORAGE=y
> +CONFIG_LZMA=y
> +CONFIG_LZO=y
> diff --git a/include/configs/db-88f6281-bp.h b/include/configs/db-88f6281-bp.h
> new file mode 100644
> index 000000000000..212983716e96
> --- /dev/null
> +++ b/include/configs/db-88f6281-bp.h
> @@ -0,0 +1,109 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +
> +#ifndef _CONFIG_DB_88F6281_BP_H
> +#define _CONFIG_DB_88F6281_BP_H
> +
> +/*
> + * High Level Configuration Options (easy to change)
> + */
> +#define CONFIG_FEROCEON_88FR131	1	/* CPU Core subversion */
> +#define CONFIG_KW88F6281	1	/* SOC Name */
> +#define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
> +#define CONFIG_SYS_TCLK		166666667
> +#define CONFIG_SYS_KWD_CONFIG	$(CONFIG_BOARDDIR)/kwbimage.cfg
> +#define CONFIG_BUILD_TARGET	"u-boot.kwb"
> +
> +/* additions for new ARM relocation support */
> +#define CONFIG_SYS_SDRAM_BASE	0x00000000
> +
> +#define CONFIG_MD5	/* get_random_hex on krikwood needs MD5 support */

s/krikwood/kirkwood

> +#define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
> +#define CONFIG_KIRKWOOD_PCIE_INIT	/* Enable PCIE Port0 */
> +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */
> +#define CONFIG_KIRKWOOD_GPIO	1
> +
> +/*
> + * NS16550 Configuration
> + */
> +#define CONFIG_SYS_NS16550_SERIAL
> +#define CONFIG_SYS_NS16550_REG_SIZE	(-4)
> +#define CONFIG_SYS_NS16550_CLK		CONFIG_SYS_TCLK
> +#define CONFIG_SYS_NS16550_COM1		KW_UART0_BASE

Can't you switch to using DM_SERIAL and use the DT for this
instead?

> +
> +#define CONFIG_SYS_MAX_NAND_DEVICE     1
> +/*
> + * Serial Port configuration
> + * The following definitions let you select what serial you want to use
> + * for your console driver.
> + */
> +
> +#define CONFIG_CONS_INDEX	1	/*Console on UART0 */

Nitpicking: Missing space after '*'.

> +
> +/*
> + * For booting Linux, the board info and command line data
> + * have to be in the first 8 MB of memory, since this is
> + * the maximum mapped by the Linux kernel during initialization.
> + */
> +#define CONFIG_CMDLINE_TAG	1	/* enable passing of ATAGs */
> +#define CONFIG_INITRD_TAG	1	/* enable INITRD tag */
> +#define CONFIG_SETUP_MEMORY_TAGS 1	/* enable memory tag */

Is this still needed for booting a modern kernel?

> +
> +/*
> + *  Environment variables configurations
> + */
> +#define CONFIG_ENV_SPI_BUS		0
> +#define CONFIG_ENV_SPI_CS		0
> +#define CONFIG_ENV_SPI_MAX_HZ		20000000	/* 20Mhz */
> +#define CONFIG_ENV_SPI_MODE		CONFIG_SF_DEFAULT_MODE
> +#define CONFIG_ENV_SECT_SIZE		0x40000		/* 256K */
> +#define CONFIG_ENV_SIZE			0x01000
> +#define CONFIG_ENV_OFFSET		0xC0000
> +
> +/*
> + * U-Boot bootcode configuration
> + */
> +
> +#define CONFIG_SYS_MONITOR_LEN		(256 << 10)	/* Reserve 256 kB for monitor */
> +#define CONFIG_SYS_MALLOC_LEN		  (4 << 20)	/* Reserve 4.0 MB for malloc */
> +
> +/*
> + * For booting Linux, the board info and command line data
> + * have to be in the first 8 MB of memory, since this is
> + * the maximum mapped by the Linux kernel during initialization.
> + */
> +#define CONFIG_SYS_BOOTMAPSZ		(8 << 20)	/* Initial Mem map for Linux*/
> +
> +/* size in bytes reserved for initial data */
> +
> +#include <asm/arch/config.h>
> +/* There is no PHY directly connected so don't ask it for link status */
> +#undef CONFIG_SYS_FAULT_ECHO_LINK_DOWN
> +
> +/*
> + * Other required minimal configurations
> + */
> +#define CONFIG_ARCH_CPU_INIT	/* call arch_cpu_init() */
> +#define CONFIG_SYS_MEMTEST_START 0x00400000	/* 4M */
> +#define CONFIG_SYS_MEMTEST_END	0x007fffff	/*(_8M -1) */

Missing space after '*' and '-'. Please run checkpatch on this
patch.

> +#define CONFIG_SYS_RESET_ADDRESS 0xffff0000	/* Rst Vector Adr */
> +
> +/*
> + * SDIO/MMC Card Configuration
> + */
> +#ifdef CONFIG_CMD_MMC
> +#define CONFIG_MVEBU_MMC
> +#define CONFIG_SYS_MMC_BASE KW_SDIO_BASE
> +#endif /* CONFIG_CMD_MMC */
> +
> +/*
> + * SATA Driver configuration
> + */
> +#ifdef CONFIG_MVSATA_IDE
> +#define CONFIG_SYS_ATA_IDE0_OFFSET	MV_SATA_PORT0_OFFSET
> +#endif /*CONFIG_MVSATA_IDE*/
> +
> +#define CONFIG_SYS_LOAD_ADDR  0x1000000      /* default location for tftp and bootm */
> +
> +#define CONFIG_SYS_DCACHE_OFF

Why is the d-cache disabled?

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 02/12] ARM: kirkwood: rename KW_CPU_WIN_BASE to MVEBU_CPU_WIN_BASE
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 02/12] ARM: kirkwood: rename KW_CPU_WIN_BASE to MVEBU_CPU_WIN_BASE Chris Packham
@ 2019-03-07 11:30   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:30 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:27, Chris Packham wrote:
> This will allow the kirkwood platforms to use more common code with the
> other mvebu SoCs.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 03/12] ARM: kirkwood: remove KW_DEFADR_PCI_IO_REMAP
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 03/12] ARM: kirkwood: remove KW_DEFADR_PCI_IO_REMAP Chris Packham
@ 2019-03-07 11:30   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:30 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:27, Chris Packham wrote:
> KW_DEFADR_PCI_IO_REMAP has the same value as KW_DEFADR_PCI_IO and is
> only used to set up a 1:1 mapping. Remove it and update the mapping to
> use KW_DEFADR_PCI_IO.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 04/12] ARM: kirkwood: switch to using mvebu mbus
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 04/12] ARM: kirkwood: switch to using mvebu mbus Chris Packham
@ 2019-03-07 11:34   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:34 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:27, Chris Packham wrote:
> The mvebu mbus code already had most of the support required for
> kirkwood. The only difference is that unlike the other mvebu targets
> kirkwood doesn't have a bridge control block so the code related to
> managing that needs to be compiled out.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> 
>   arch/arm/mach-kirkwood/cpu.c              | 33 ++++++++++++++++++++---
>   arch/arm/mach-kirkwood/include/mach/cpu.h | 11 ++++++++
>   arch/arm/mach-mvebu/Makefile              |  1 +
>   arch/arm/mach-mvebu/mbus.c                |  6 +++++
>   4 files changed, 48 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c
> index 85c7f5903d94..311c5d50e2f9 100644
> --- a/arch/arm/mach-kirkwood/cpu.c
> +++ b/arch/arm/mach-kirkwood/cpu.c
> @@ -110,6 +110,32 @@ int kw_config_adr_windows(void)
>   	return 0;
>   }
>   
> +static struct mbus_win windows[] = {
> +	/* Window 0: PCIE MEM address space */
> +	{ KW_DEFADR_PCI_MEM, 1024 * 1024 * 256,
> +	  KWCPU_TARGET_PCIE, KWCPU_ATTR_PCIE_MEM },
> +
> +	/* Window 1: PCIE IO address space */
> +	{ KW_DEFADR_PCI_IO, 1024 * 64,
> +	  KWCPU_TARGET_PCIE, KWCPU_ATTR_PCIE_IO },
> +
> +	/* Window 2: NAND Flash address space */
> +	{ KW_DEFADR_NANDF, 1024 * 1024 * 128,
> +	  KWCPU_TARGET_MEMORY, KWCPU_ATTR_NANDFLASH },
> +
> +	/* Window 3: SPI Flash address space */
> +	{ KW_DEFADR_SPIF, 1024 * 1024 * 128,
> +	  KWCPU_TARGET_MEMORY, KWCPU_ATTR_SPIFLASH },
> +
> +	/* Window 4: BOOT Memory address space */
> +	{ KW_DEFADR_BOOTROM, 1024 * 1024 * 128,
> +	  KWCPU_TARGET_MEMORY, KWCPU_ATTR_BOOTROM },
> +
> +	/* Window 5: Security SRAM address space */
> +	{ KW_DEFADR_SASRAM, 1024 * 64,
> +	  KWCPU_TARGET_SASRAM, KWCPU_ATTR_SASRAM },
> +};
> +
>   /*
>    * SYSRSTn Duration Counter Support
>    *
> @@ -221,15 +247,13 @@ int arch_cpu_init(void)
>   	struct kwcpu_registers *cpureg =
>   		(struct kwcpu_registers *)KW_CPU_REG_BASE;
>   
> -	/* Linux expects` the internal registers to be at 0xf1000000 */
> +	/* Linux expects the internal registers to be at 0xf1000000 */
>   	writel(KW_REGS_PHY_BASE, KW_OFFSET_REG);
>   
>   	/* Enable and invalidate L2 cache in write through mode */
>   	writel(readl(&cpureg->l2_cfg) | 0x18, &cpureg->l2_cfg);
>   	invalidate_l2_cache();
>   
> -	kw_config_adr_windows();
> -
>   #ifdef CONFIG_KIRKWOOD_RGMII_PAD_1V8
>   	/*
>   	 * Configures the I/O voltage of the pads connected to Egigabit
> @@ -295,6 +319,9 @@ int arch_misc_init(void)
>   	temp = get_cr();
>   	set_cr(temp & ~CR_V);
>   
> +	/* Configure mbus windows */
> +	mvebu_mbus_probe(windows, ARRAY_SIZE(windows));
> +
>   	/* checks and execute resset to factory event */
>   	kw_sysrst_check();
>   
> diff --git a/arch/arm/mach-kirkwood/include/mach/cpu.h b/arch/arm/mach-kirkwood/include/mach/cpu.h
> index c35cace844ae..3d6b15568a8a 100644
> --- a/arch/arm/mach-kirkwood/include/mach/cpu.h
> +++ b/arch/arm/mach-kirkwood/include/mach/cpu.h
> @@ -68,6 +68,13 @@ enum kwcpu_attrib {
>   #define KW_DEFADR_SPIF		0xE8000000
>   #define KW_DEFADR_BOOTROM	0xF8000000
>   
> +struct mbus_win {
> +	u32 base;
> +	u32 size;
> +	u8 target;
> +	u8 attr;
> +};
> +
>   /*
>    * read feroceon/sheeva core extra feature register
>    * using co-proc instruction
> @@ -134,6 +141,9 @@ struct kwgpio_registers {
>   	u32 irq_level;
>   };
>   
> +/* Needed for dynamic (board-specific) mbus configuration */
> +extern struct mvebu_mbus_state mbus_state;
> +
>   /*
>    * functions
>    */
> @@ -141,6 +151,7 @@ unsigned int mvebu_sdram_bar(enum memory_bank bank);
>   unsigned int mvebu_sdram_bs(enum memory_bank bank);
>   void mvebu_sdram_size_adjust(enum memory_bank bank);
>   int kw_config_adr_windows(void);
> +int mvebu_mbus_probe(struct mbus_win windows[], int count);
>   void mvebu_config_gpio(unsigned int gpp0_oe_val, unsigned int gpp1_oe_val,
>   		unsigned int gpp0_oe, unsigned int gpp1_oe);
>   int kw_config_mpp(unsigned int mpp0_7, unsigned int mpp8_15,
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index ee2eca913484..c0274a6f09aa 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -14,6 +14,7 @@ ifdef CONFIG_KIRKWOOD
>   
>   obj-y	= dram.o
>   obj-y	+= gpio.o
> +obj-y	+= mbus.o
>   obj-y	+= timer.o
>   
>   else # CONFIG_KIRKWOOD
> diff --git a/arch/arm/mach-mvebu/mbus.c b/arch/arm/mach-mvebu/mbus.c
> index df4c5cb2d718..9b2c57348266 100644
> --- a/arch/arm/mach-mvebu/mbus.c
> +++ b/arch/arm/mach-mvebu/mbus.c
> @@ -405,6 +405,7 @@ int mvebu_mbus_del_window(phys_addr_t base, size_t size)
>   	return 0;
>   }
>   
> +#ifndef CONFIG_KIRKWOOD
>   static void mvebu_mbus_get_lowest_base(struct mvebu_mbus_state *mbus,
>   				       phys_addr_t *base)
>   {
> @@ -428,7 +429,9 @@ static void mvebu_mbus_get_lowest_base(struct mvebu_mbus_state *mbus,
>   			*base = wbase;
>   	}
>   }
> +#endif
>   
> +#ifndef CONFIG_KIRKWOOD
>   static void mvebu_config_mbus_bridge(struct mvebu_mbus_state *mbus)
>   {
>   	phys_addr_t base;
> @@ -451,6 +454,7 @@ static void mvebu_config_mbus_bridge(struct mvebu_mbus_state *mbus)
>   	val = (size / (64 << 10)) - 1;
>   	writel((val << 16) | 0x1, MBUS_BRIDGE_WIN_CTRL_REG);
>   }
> +#endif

Can't you combine those two #ifndef's above into one?

Other than that looks good:

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 05/12] ARM: kirkwood: remove kw_config_adr_windows
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 05/12] ARM: kirkwood: remove kw_config_adr_windows Chris Packham
@ 2019-03-07 11:34   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:34 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:27, Chris Packham wrote:
> Now that kirkwood is using the mvebu mbus this function is no longer
> needed.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 06/12] ARM: kirkwood: enable CONFIG_DM_USB on db-88f6281-bp
  2019-03-07  8:27 ` [U-Boot] [PATCH v2 06/12] ARM: kirkwood: enable CONFIG_DM_USB on db-88f6281-bp Chris Packham
@ 2019-03-07 11:35   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:35 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:27, Chris Packham wrote:
> Switch to the driver model for USB on the db-88f6281-bp board.
> CONFIG_BLK can't be enabled yet because mvebu_mmc.c needs converting.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 07/12] ARM: kirkwood: enable CONFIG_DM_USB for {dream, guru, sheeva}plug
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 07/12] ARM: kirkwood: enable CONFIG_DM_USB for {dream, guru, sheeva}plug Chris Packham
@ 2019-03-07 11:35   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:35 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:28, Chris Packham wrote:
> Enable CONFIG_DM_USB and where possible CONFIG_BLK.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> mvebu_mmc.c hasn't been converted to DM so it's not possible to use
> CONFIG_BLK when CONFIG_MMC is enabled.

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 08/12] ARM: kirkwood: enable CONFIG_DM_USB for dns325
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 08/12] ARM: kirkwood: enable CONFIG_DM_USB for dns325 Chris Packham
@ 2019-03-07 11:35   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:35 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:28, Chris Packham wrote:
> Enable CONFIG_DM_USB and CONFIG_BLK.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 09/12] ARM: kirkwood: enable CONFIG_DM_USB for ds109
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 09/12] ARM: kirkwood: enable CONFIG_DM_USB for ds109 Chris Packham
@ 2019-03-07 11:36   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:36 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:28, Chris Packham wrote:
> Enable CONFIG_DM_USB and CONFIG_BLK.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 10/12] ARM: kirkwood: enable CONFIG_DM_USB for goflexhome
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 10/12] ARM: kirkwood: enable CONFIG_DM_USB for goflexhome Chris Packham
@ 2019-03-07 11:36   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:36 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:28, Chris Packham wrote:
> Enable CONFIG_DM_USB and CONFIG_BLK.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 11/12] ARM: kirkwood: enable CONFIG_DM_USB for lschlv2 and lsxhl
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 11/12] ARM: kirkwood: enable CONFIG_DM_USB for lschlv2 and lsxhl Chris Packham
@ 2019-03-07 11:36   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:36 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:28, Chris Packham wrote:
> Enable CONFIG_DM_USB and CONFIG_BLK.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 12/12] ARM: kirkwood: enable CONFIG_DM_USB for nas220
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 12/12] ARM: kirkwood: enable CONFIG_DM_USB for nas220 Chris Packham
@ 2019-03-07 11:36   ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-07 11:36 UTC (permalink / raw)
  To: u-boot

On 07.03.19 09:28, Chris Packham wrote:
> Enable CONFIG_DM_USB and CONFIG_BLK.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board
  2019-03-07  9:33   ` Stefan Roese
@ 2019-03-08  6:44     ` Chris Packham
  2019-03-13  7:00     ` Chris Packham
  1 sibling, 0 replies; 30+ messages in thread
From: Chris Packham @ 2019-03-08  6:44 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 7, 2019 at 10:33 PM Stefan Roese <sr@denx.de> wrote:
>
> Hi Chris,
>
> On 07.03.19 09:27, Chris Packham wrote:
> > This is Marvell's Kirkwood development board. It has the following
> > features
> >
> >   - 512M DDR2
> >   - 2 PCI connectors
> >   - 1 x1 PCI-e interface
> >   - 1 Gigabit Ethernet Port
> >   - 2 SATA Ports
> >   - USB 2.0 Interface
> >   - SDIO
> >   - 128M NAND Flash
> >   - 16M SPI Flash
> >
> > It can be strapped to boot from SPI or NAND so there are two defconfigs
> > (one per boot media).
>
> Thanks for this board addition. Please find some review comments
> below.
>
> >
> > Signed-off-by: Chris Packham <judge.packham@gmail.com>
> > ---
> >
> >   arch/arm/dts/kirkwood-db-88f6281-spi.dts    |  48 +++++++++
> >   arch/arm/dts/kirkwood-db-88f6281.dts        |  26 +++++
> >   arch/arm/dts/kirkwood-db.dtsi               |  94 +++++++++++++++++
> >   arch/arm/mach-kirkwood/Kconfig              |   4 +
> >   board/Marvell/db-88f6281-bp/Kconfig         |  12 +++
> >   board/Marvell/db-88f6281-bp/MAINTAINERS     |  10 ++
> >   board/Marvell/db-88f6281-bp/Makefile        |   3 +
> >   board/Marvell/db-88f6281-bp/db-88f6281-bp.c | 103 ++++++++++++++++++
> >   board/Marvell/db-88f6281-bp/kwbimage.cfg    |  36 +++++++
> >   configs/db-88f6281-bp-nand_defconfig        |  53 ++++++++++
> >   configs/db-88f6281-bp-spi_defconfig         |  54 ++++++++++
> >   include/configs/db-88f6281-bp.h             | 109 ++++++++++++++++++++
> >   12 files changed, 552 insertions(+)
> >   create mode 100644 arch/arm/dts/kirkwood-db-88f6281-spi.dts
> >   create mode 100644 arch/arm/dts/kirkwood-db-88f6281.dts
> >   create mode 100644 arch/arm/dts/kirkwood-db.dtsi
> >   create mode 100644 board/Marvell/db-88f6281-bp/Kconfig
> >   create mode 100644 board/Marvell/db-88f6281-bp/MAINTAINERS
> >   create mode 100644 board/Marvell/db-88f6281-bp/Makefile
> >   create mode 100644 board/Marvell/db-88f6281-bp/db-88f6281-bp.c
> >   create mode 100644 board/Marvell/db-88f6281-bp/kwbimage.cfg
> >   create mode 100644 configs/db-88f6281-bp-nand_defconfig
> >   create mode 100644 configs/db-88f6281-bp-spi_defconfig
> >   create mode 100644 include/configs/db-88f6281-bp.h
> >
> > diff --git a/arch/arm/dts/kirkwood-db-88f6281-spi.dts b/arch/arm/dts/kirkwood-db-88f6281-spi.dts
> > new file mode 100644
> > index 000000000000..50b1b0d4a535
> > --- /dev/null
> > +++ b/arch/arm/dts/kirkwood-db-88f6281-spi.dts
> > @@ -0,0 +1,48 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Marvell DB-88F6281-BP Development Board Setup
> > + *
> > + * Saeed Bishara <saeed@marvell.com>
> > + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > + *
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "kirkwood-db-88f6281.dts"
> > +
> > +/ {
> > +     aliases {
> > +             spi0 = &spi0;
> > +     };
> > +};
> > +
> > +&spi0 {
> > +     status = "okay";
> > +
> > +     flash at 0 {
> > +             #address-cells = <1>;
> > +             #size-cells = <1>;
> > +             compatible = "st,m25p128", "jedec,spi-nor", "spi-flash";
> > +             reg = <0>;
> > +             spi-max-frequency = <50000000>;
> > +             mode = <0>;
> > +
> > +             partition at u-boot {
> > +                     reg = <0x00000000 0x00c00000>;
> > +                     label = "u-boot";
> > +             };
> > +             partition at u-boot-env {
> > +                     reg = <0x00c00000 0x00040000>;
> > +                     label = "u-boot-env";
> > +             };
> > +             partition at unused {
> > +                     reg = <0x00100000 0x00f00000>;
> > +                     label = "unused";
> > +             };
> > +     };
> > +};
> > +
> > +&nand {
> > +     status = "disabled";
> > +};
> > diff --git a/arch/arm/dts/kirkwood-db-88f6281.dts b/arch/arm/dts/kirkwood-db-88f6281.dts
> > new file mode 100644
> > index 000000000000..2adb17c955aa
> > --- /dev/null
> > +++ b/arch/arm/dts/kirkwood-db-88f6281.dts
> > @@ -0,0 +1,26 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Marvell DB-88F6281-BP Development Board Setup
> > + *
> > + * Saeed Bishara <saeed@marvell.com>
> > + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > + *
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "kirkwood-db.dtsi"
> > +#include "kirkwood-6281.dtsi"
> > +
> > +/ {
> > +     model = "Marvell DB-88F6281-BP Development Board";
> > +     compatible = "marvell,db-88f6281-bp", "marvell,kirkwood-88f6281", "marvell,kirkwood";
> > +};
> > +
> > +&pciec {
> > +        status = "okay";
> > +};
> > +
> > +&pcie0 {
> > +     status = "okay";
> > +};
> > diff --git a/arch/arm/dts/kirkwood-db.dtsi b/arch/arm/dts/kirkwood-db.dtsi
> > new file mode 100644
> > index 000000000000..b81d8e8298a3
> > --- /dev/null
> > +++ b/arch/arm/dts/kirkwood-db.dtsi
> > @@ -0,0 +1,94 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Marvell DB-{88F6281,88F6282}-BP Development Board Setup
> > + *
> > + * Saeed Bishara <saeed@marvell.com>
> > + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > + *
> > + * This file contains the definitions that are common between the 6281
> > + * and 6282 variants of the Marvell Kirkwood Development Board.
> > + */
> > +
> > +#include "kirkwood.dtsi"
> > +
> > +/ {
> > +     memory {
> > +             device_type = "memory";
> > +             reg = <0x00000000 0x20000000>; /* 512 MB */
> > +     };
> > +
> > +     chosen {
> > +             bootargs = "console=ttyS0,115200n8 earlyprintk";
> > +             stdout-path = &uart0;
> > +     };
> > +
> > +     aliases {
> > +             ethernet0 = &eth0;
> > +             spi0 = &spi0;
> > +     };
> > +
> > +     ocp at f1000000 {
> > +             pin-controller at 10000 {
> > +                     pmx_sdio_gpios: pmx-sdio-gpios {
> > +                             marvell,pins = "mpp37", "mpp38";
> > +                             marvell,function = "gpio";
> > +                     };
> > +             };
> > +
> > +             serial at 12000 {
> > +                     status = "okay";
> > +             };
> > +
> > +             sata at 80000 {
> > +                     nr-ports = <2>;
> > +                     status = "okay";
> > +             };
> > +
> > +             ehci at 50000 {
> > +                     status = "okay";
> > +             };
> > +
> > +             mvsdio at 90000 {
> > +                     pinctrl-0 = <&pmx_sdio_gpios>;
> > +                     pinctrl-names = "default";
> > +                     wp-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> > +                     cd-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
> > +                     status = "okay";
> > +             };
> > +     };
> > +};
> > +
> > +&nand {
> > +     chip-delay = <25>;
> > +     status = "okay";
> > +
> > +     partition at 0 {
> > +             label = "uboot";
> > +             reg = <0x0 0x100000>;
> > +     };
> > +
> > +     partition at 100000 {
> > +             label = "uImage";
> > +             reg = <0x100000 0x400000>;
> > +     };
> > +
> > +     partition at 500000 {
> > +             label = "root";
> > +             reg = <0x500000 0x1fb00000>;
> > +     };
> > +};
> > +
> > +&mdio {
> > +     status = "okay";
> > +
> > +     ethphy0: ethernet-phy at 8 {
> > +             reg = <8>;
> > +     };
> > +};
> > +
> > +&eth0 {
> > +     status = "okay";
> > +     ethernet0-port at 0 {
> > +             phy-handle = <&ethphy0>;
> > +     };
> > +};
> > diff --git a/arch/arm/mach-kirkwood/Kconfig b/arch/arm/mach-kirkwood/Kconfig
> > index 3b860c4f55fe..7c4170399afb 100644
> > --- a/arch/arm/mach-kirkwood/Kconfig
> > +++ b/arch/arm/mach-kirkwood/Kconfig
> > @@ -65,6 +65,9 @@ config TARGET_SBx81LIFKW
> >   config TARGET_SBx81LIFXCAT
> >       bool "Allied Telesis SBx81GP24/SBx81GT24"
> >
> > +config TARGET_DB_88F6281_BP
> > +     bool "Marvell DB-88F6281-BP"
> > +
> >   endchoice
> >
> >   config SYS_SOC
> > @@ -89,5 +92,6 @@ source "board/Seagate/nas220/Kconfig"
> >   source "board/zyxel/nsa310s/Kconfig"
> >   source "board/alliedtelesis/SBx81LIFKW/Kconfig"
> >   source "board/alliedtelesis/SBx81LIFXCAT/Kconfig"
> > +source "board/Marvell/db-88f6281-bp/Kconfig"
> >
> >   endif
> > diff --git a/board/Marvell/db-88f6281-bp/Kconfig b/board/Marvell/db-88f6281-bp/Kconfig
> > new file mode 100644
> > index 000000000000..38467399e688
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/Kconfig
> > @@ -0,0 +1,12 @@
> > +if TARGET_DB_88F6281_BP
> > +
> > +config SYS_BOARD
> > +     default "db-88f6281-bp"
> > +
> > +config SYS_VENDOR
> > +     default "Marvell"
> > +
> > +config SYS_CONFIG_NAME
> > +     default "db-88f6281-bp"
> > +
> > +endif
> > diff --git a/board/Marvell/db-88f6281-bp/MAINTAINERS b/board/Marvell/db-88f6281-bp/MAINTAINERS
> > new file mode 100644
> > index 000000000000..f31d3be70bae
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/MAINTAINERS
> > @@ -0,0 +1,10 @@
> > +DB_88F6820_AMC BOARD
> > +M:   Chris Packham <judge.packham@gmail.com>
> > +S:   Maintained
> > +F:   arch/arm/dts/kirkwood-db-88f6281.dts
> > +F:   arch/arm/dts/kirkwood-db-88f6281-spi.dts
> > +F:   arch/arm/dts/kirkwood-db.dtsi
> > +F:   board/Marvell/db-88f6281-bp/
> > +F:   include/configs/db-88f6281-bp.h
> > +F:   configs/db-88f6281-bp_defconfig
> > +F:   configs/db-88f6281-bp-spi_defconfig
> > diff --git a/board/Marvell/db-88f6281-bp/Makefile b/board/Marvell/db-88f6281-bp/Makefile
> > new file mode 100644
> > index 000000000000..38ff522ca1c8
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/Makefile
> > @@ -0,0 +1,3 @@
> > +# SPDX-License-Identifier: GPL-2.0+
> > +
> > +obj-y        := db-88f6281-bp.o
> > diff --git a/board/Marvell/db-88f6281-bp/db-88f6281-bp.c b/board/Marvell/db-88f6281-bp/db-88f6281-bp.c
> > new file mode 100644
> > index 000000000000..b68f2f3c895b
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/db-88f6281-bp.c
> > @@ -0,0 +1,103 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +
> > +#include <common.h>
> > +#include <linux/io.h>
> > +#include <miiphy.h>
> > +#include <netdev.h>
> > +#include <asm/arch/cpu.h>
> > +#include <asm/arch/soc.h>
> > +#include <asm/arch/mpp.h>
> > +#include <asm/arch/gpio.h>
> > +
> > +#define DB_88F6281_OE_LOW    ~(BIT(7))
> > +#define DB_88F6281_OE_HIGH   ~(BIT(15) | BIT(14) | BIT(13) | BIT(4))
> > +#define DB_88F6281_OE_VAL_LOW        BIT(7)
> > +#define DB_88F6281_OE_VAL_HIGH       0
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
> > +
> > +int board_early_init_f(void)
> > +{
> > +     mvebu_config_gpio(DB_88F6281_OE_VAL_LOW,
> > +                       DB_88F6281_OE_VAL_HIGH,
> > +                       DB_88F6281_OE_LOW, DB_88F6281_OE_HIGH);
> > +
> > +     /* Multi-Purpose Pins Functionality configuration */
> > +     static const u32 kwmpp_config[] = {
> > +#ifdef CONFIG_CMD_NAND
> > +             MPP0_NF_IO2,
> > +             MPP1_NF_IO3,
> > +             MPP2_NF_IO4,
> > +             MPP3_NF_IO5,
> > +#else
> > +             MPP0_SPI_SCn,
> > +             MPP1_SPI_MOSI,
> > +             MPP2_SPI_SCK,
> > +             MPP3_SPI_MISO,
> > +#endif
> > +             MPP4_NF_IO6,
> > +             MPP5_NF_IO7,
> > +             MPP6_SYSRST_OUTn,
> > +             MPP7_GPO,
> > +             MPP8_TW_SDA,
> > +             MPP9_TW_SCK,
> > +             MPP10_UART0_TXD,
> > +             MPP11_UART0_RXD,
> > +             MPP12_SD_CLK,
> > +             MPP13_SD_CMD,
> > +             MPP14_SD_D0,
> > +             MPP15_SD_D1,
> > +             MPP16_SD_D2,
> > +             MPP17_SD_D3,
> > +             MPP18_NF_IO0,
> > +             MPP19_NF_IO1,
> > +             MPP20_SATA1_ACTn,
> > +             MPP21_SATA0_ACTn,
> > +             MPP22_GPIO,
> > +             MPP23_GPIO,
> > +             MPP24_GPIO,
> > +             MPP25_GPIO,
> > +             MPP26_GPIO,
> > +             MPP27_GPIO,
> > +             MPP28_GPIO,
> > +             MPP29_GPIO,
> > +             MPP30_GPIO,
> > +             MPP31_GPIO,
> > +             MPP32_GPIO,
> > +             MPP33_GPIO,
> > +             MPP34_GPIO,
> > +             MPP35_GPIO,
> > +             MPP36_GPIO,
> > +             MPP37_GPIO,
> > +             MPP38_GPIO,
> > +             MPP39_GPIO,
> > +             MPP40_GPIO,
> > +             MPP41_GPIO,
> > +             MPP42_GPIO,
> > +             MPP43_GPIO,
> > +             MPP44_GPIO,
> > +             MPP45_GPIO,
> > +             MPP46_GPIO,
> > +             MPP47_GPIO,
> > +             MPP48_GPIO,
> > +             MPP49_GPIO,
> > +             0
> > +     };
> > +     kirkwood_mpp_conf(kwmpp_config, NULL);
> > +
> > +     return 0;
> > +}
> > +
> > +int board_init(void)
> > +{
> > +     gd->bd->bi_boot_params = mvebu_sdram_bar(0) + 0x100;
> > +
> > +     return 0;
> > +}
> > +
> > +#ifdef CONFIG_RESET_PHY_R
> > +/* automatically defined by kirkwood config.h */
> > +void reset_phy(void)
> > +{
> > +}
> > +#endif
> > diff --git a/board/Marvell/db-88f6281-bp/kwbimage.cfg b/board/Marvell/db-88f6281-bp/kwbimage.cfg
> > new file mode 100644
> > index 000000000000..49a637078682
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/kwbimage.cfg
> > @@ -0,0 +1,36 @@
> > +# SPDX-License-Identifier: GPL-2.0+
> > +
> > +# Boot Media configurations
> > +BOOT_FROM    spi     # Boot from SPI flash
>
> How is booting from NAND handled? Is the boot device patched
> dynamically in the resulting image?
>

Oops needs a different kwbimage.cfg I'll look at doing something in
the Makefile to avoid repeating the common bits.

> > +
> > +DATA 0xd00100e0 0x1b1b1b9b
> > +DATA 0xd0020134 0xbbbbbbbb
> > +DATA 0xd0020138 0x00bbbbbb
> > +DATA 0xd0020154 0x00000200
> > +DATA 0xd002014c 0x00001c00
> > +DATA 0xd0020148 0x00000001
> > +
> > +DATA 0xd0001400 0x43000c30
> > +DATA 0xd0001404 0x39543000
> > +DATA 0xd0001408 0x22125451
> > +DATA 0xd000140c 0x00000833
> > +DATA 0xd0001410 0x000000cc
> > +DATA 0xd0001414 0x00000000
> > +DATA 0xd0001418 0x00000000
> > +DATA 0xd000141c 0x00000c52
> > +DATA 0xd0001420 0x00000044
> > +DATA 0xd0001424 0x0000f1ff
> > +DATA 0xd0001428 0x00085520
> > +DATA 0xd000147c 0x00008552
> > +DATA 0xd0001504 0x0ffffff1
> > +DATA 0xd0001508 0x10000000
> > +DATA 0xd000150c 0x0ffffff5
> > +DATA 0xd0001514 0x00000000
> > +DATA 0xd000151c 0x00000000
> > +DATA 0xd0001494 0x84210000
> > +DATA 0xd0001498 0x00000000
> > +DATA 0xd000149c 0x0000f40f
> > +DATA 0xd0001480 0x00000001
> > +
> > +# End of Header extension
> > +DATA 0x0 0x0
> > diff --git a/configs/db-88f6281-bp-nand_defconfig b/configs/db-88f6281-bp-nand_defconfig
> > new file mode 100644
> > index 000000000000..6360ef5e8280
> > --- /dev/null
> > +++ b/configs/db-88f6281-bp-nand_defconfig
> > @@ -0,0 +1,53 @@
> > +CONFIG_ARM=y
> > +CONFIG_SYS_THUMB_BUILD=y
> > +CONFIG_KIRKWOOD=y
> > +CONFIG_SYS_TEXT_BASE=0x600000
> > +CONFIG_TARGET_DB_88F6281_BP=y
> > +CONFIG_IDENT_STRING="\nMarvell DB-88F6281-BP"
> > +CONFIG_NR_DRAM_BANKS=2
> > +# CONFIG_SYS_MALLOC_F is not set
> > +CONFIG_BOOTDELAY=3
> > +# CONFIG_DISPLAY_BOARDINFO is not set
> > +CONFIG_HUSH_PARSER=y
> > +CONFIG_CMD_BOOTZ=y
> > +CONFIG_CMD_DM=y
> > +# CONFIG_CMD_FLASH is not set
> > +CONFIG_CMD_IDE=y
> > +CONFIG_CMD_MMC=y
> > +CONFIG_CMD_NAND=y
> > +CONFIG_CMD_SF=y
> > +CONFIG_CMD_USB=y
> > +# CONFIG_CMD_SETEXPR is not set
> > +CONFIG_CMD_DHCP=y
> > +CONFIG_CMD_MII=y
> > +CONFIG_CMD_PING=y
> > +CONFIG_CMD_EXT2=y
> > +CONFIG_CMD_EXT4=y
> > +CONFIG_CMD_FAT=y
> > +CONFIG_CMD_JFFS2=y
> > +CONFIG_CMD_MTDPARTS=y
> > +CONFIG_MTDIDS_DEFAULT="nand0=orion_nand"
> > +CONFIG_MTDPARTS_DEFAULT="mtdparts=orion_nand:512K(uboot),512K(env),4M(kernel),-(rootfs)"
> > +CONFIG_ISO_PARTITION=y
> > +CONFIG_OF_CONTROL=y
> > +CONFIG_DEFAULT_DEVICE_TREE="kirkwood-db-88f6281"
> > +CONFIG_ENV_IS_IN_SPI_FLASH=y
> > +CONFIG_NET_RANDOM_ETHADDR=y
> > +CONFIG_DM=y
> > +CONFIG_MVSATA_IDE=y
> > +CONFIG_SPI_FLASH=y
> > +CONFIG_SPI_FLASH_STMICRO=y
> > +CONFIG_PHY_MARVELL=y
> > +CONFIG_DM_ETH=y
> > +CONFIG_MVGBE=y
> > +CONFIG_MII=y
> > +CONFIG_DM_RTC=y
> > +CONFIG_RTC_MV=y
> > +CONFIG_SYS_NS16550=y
> > +CONFIG_SPI=y
> > +CONFIG_KIRKWOOD_SPI=y
> > +CONFIG_USB=y
> > +CONFIG_USB_EHCI_HCD=y
> > +CONFIG_USB_STORAGE=y
> > +CONFIG_LZMA=y
> > +CONFIG_LZO=y
> > diff --git a/configs/db-88f6281-bp-spi_defconfig b/configs/db-88f6281-bp-spi_defconfig
> > new file mode 100644
> > index 000000000000..93e125af5b2d
> > --- /dev/null
> > +++ b/configs/db-88f6281-bp-spi_defconfig
> > @@ -0,0 +1,54 @@
> > +CONFIG_ARM=y
> > +CONFIG_SYS_THUMB_BUILD=y
> > +CONFIG_KIRKWOOD=y
> > +CONFIG_SYS_TEXT_BASE=0x600000
> > +CONFIG_TARGET_DB_88F6281_BP=y
> > +CONFIG_IDENT_STRING="\nMarvell DB-88F6281-BP"
> > +CONFIG_NR_DRAM_BANKS=2
> > +# CONFIG_SYS_MALLOC_F is not set
> > +CONFIG_BOOTDELAY=3
> > +# CONFIG_DISPLAY_BOARDINFO is not set
> > +CONFIG_HUSH_PARSER=y
> > +CONFIG_CMD_BOOTZ=y
> > +CONFIG_CMD_DM=y
> > +# CONFIG_CMD_FLASH is not set
> > +CONFIG_CMD_IDE=y
> > +CONFIG_CMD_MMC=y
> > +CONFIG_CMD_SF=y
> > +CONFIG_CMD_USB=y
> > +# CONFIG_CMD_SETEXPR is not set
> > +CONFIG_CMD_DHCP=y
> > +CONFIG_CMD_MII=y
> > +CONFIG_CMD_PING=y
> > +CONFIG_CMD_EXT2=y
> > +CONFIG_CMD_EXT4=y
> > +CONFIG_CMD_FAT=y
> > +CONFIG_CMD_JFFS2=y
> > +CONFIG_CMD_MTDPARTS=y
> > +CONFIG_MTDIDS_DEFAULT="nand0=orion_nand"
> > +CONFIG_MTDPARTS_DEFAULT="mtdparts=orion_nand:512K(uboot),512K(env),4M(kernel),-(rootfs)"
> > +CONFIG_ISO_PARTITION=y
> > +CONFIG_OF_CONTROL=y
> > +CONFIG_DEFAULT_DEVICE_TREE="kirkwood-db-88f6281-spi"
> > +CONFIG_ENV_IS_IN_SPI_FLASH=y
> > +CONFIG_NET_RANDOM_ETHADDR=y
> > +CONFIG_DM=y
> > +CONFIG_MVSATA_IDE=y
> > +CONFIG_DM_SPI_FLASH=y
> > +CONFIG_SPI_FLASH=y
> > +CONFIG_SPI_FLASH_STMICRO=y
> > +CONFIG_PHY_MARVELL=y
> > +CONFIG_DM_ETH=y
> > +CONFIG_MVGBE=y
> > +CONFIG_MII=y
> > +CONFIG_DM_RTC=y
> > +CONFIG_RTC_MV=y
> > +CONFIG_SYS_NS16550=y
> > +CONFIG_SPI=y
> > +CONFIG_DM_SPI=y
> > +CONFIG_KIRKWOOD_SPI=y
> > +CONFIG_USB=y
> > +CONFIG_USB_EHCI_HCD=y
> > +CONFIG_USB_STORAGE=y
> > +CONFIG_LZMA=y
> > +CONFIG_LZO=y
> > diff --git a/include/configs/db-88f6281-bp.h b/include/configs/db-88f6281-bp.h
> > new file mode 100644
> > index 000000000000..212983716e96
> > --- /dev/null
> > +++ b/include/configs/db-88f6281-bp.h
> > @@ -0,0 +1,109 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
> > +
> > +#ifndef _CONFIG_DB_88F6281_BP_H
> > +#define _CONFIG_DB_88F6281_BP_H
> > +
> > +/*
> > + * High Level Configuration Options (easy to change)
> > + */
> > +#define CONFIG_FEROCEON_88FR131      1       /* CPU Core subversion */
> > +#define CONFIG_KW88F6281     1       /* SOC Name */
> > +#define CONFIG_SKIP_LOWLEVEL_INIT    /* disable board lowlevel_init */
> > +#define CONFIG_SYS_TCLK              166666667
> > +#define CONFIG_SYS_KWD_CONFIG        $(CONFIG_BOARDDIR)/kwbimage.cfg
> > +#define CONFIG_BUILD_TARGET  "u-boot.kwb"
> > +
> > +/* additions for new ARM relocation support */
> > +#define CONFIG_SYS_SDRAM_BASE        0x00000000
> > +
> > +#define CONFIG_MD5   /* get_random_hex on krikwood needs MD5 support */
>
> s/krikwood/kirkwood
>
> > +#define CONFIG_KIRKWOOD_EGIGA_INIT   /* Enable GbePort0/1 for kernel */
> > +#define CONFIG_KIRKWOOD_PCIE_INIT    /* Enable PCIE Port0 */
> > +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8        /* Set RGMII Pad voltage to 1.8V */
> > +#define CONFIG_KIRKWOOD_GPIO 1
> > +
> > +/*
> > + * NS16550 Configuration
> > + */
> > +#define CONFIG_SYS_NS16550_SERIAL
> > +#define CONFIG_SYS_NS16550_REG_SIZE  (-4)
> > +#define CONFIG_SYS_NS16550_CLK               CONFIG_SYS_TCLK
> > +#define CONFIG_SYS_NS16550_COM1              KW_UART0_BASE
>
> Can't you switch to using DM_SERIAL and use the DT for this
> instead?
>

Will do.

> > +
> > +#define CONFIG_SYS_MAX_NAND_DEVICE     1
> > +/*
> > + * Serial Port configuration
> > + * The following definitions let you select what serial you want to use
> > + * for your console driver.
> > + */
> > +
> > +#define CONFIG_CONS_INDEX    1       /*Console on UART0 */
>
> Nitpicking: Missing space after '*'.
>
> > +
> > +/*
> > + * For booting Linux, the board info and command line data
> > + * have to be in the first 8 MB of memory, since this is
> > + * the maximum mapped by the Linux kernel during initialization.
> > + */
> > +#define CONFIG_CMDLINE_TAG   1       /* enable passing of ATAGs */
> > +#define CONFIG_INITRD_TAG    1       /* enable INITRD tag */
> > +#define CONFIG_SETUP_MEMORY_TAGS 1   /* enable memory tag */
>
> Is this still needed for booting a modern kernel?
>

No probably not. I'll remove it if I can.

> > +
> > +/*
> > + *  Environment variables configurations
> > + */
> > +#define CONFIG_ENV_SPI_BUS           0
> > +#define CONFIG_ENV_SPI_CS            0
> > +#define CONFIG_ENV_SPI_MAX_HZ                20000000        /* 20Mhz */
> > +#define CONFIG_ENV_SPI_MODE          CONFIG_SF_DEFAULT_MODE
> > +#define CONFIG_ENV_SECT_SIZE         0x40000         /* 256K */
> > +#define CONFIG_ENV_SIZE                      0x01000
> > +#define CONFIG_ENV_OFFSET            0xC0000
> > +
> > +/*
> > + * U-Boot bootcode configuration
> > + */
> > +
> > +#define CONFIG_SYS_MONITOR_LEN               (256 << 10)     /* Reserve 256 kB for monitor */
> > +#define CONFIG_SYS_MALLOC_LEN                  (4 << 20)     /* Reserve 4.0 MB for malloc */
> > +
> > +/*
> > + * For booting Linux, the board info and command line data
> > + * have to be in the first 8 MB of memory, since this is
> > + * the maximum mapped by the Linux kernel during initialization.
> > + */
> > +#define CONFIG_SYS_BOOTMAPSZ         (8 << 20)       /* Initial Mem map for Linux*/
> > +
> > +/* size in bytes reserved for initial data */
> > +
> > +#include <asm/arch/config.h>
> > +/* There is no PHY directly connected so don't ask it for link status */
> > +#undef CONFIG_SYS_FAULT_ECHO_LINK_DOWN
> > +
> > +/*
> > + * Other required minimal configurations
> > + */
> > +#define CONFIG_ARCH_CPU_INIT /* call arch_cpu_init() */
> > +#define CONFIG_SYS_MEMTEST_START 0x00400000  /* 4M */
> > +#define CONFIG_SYS_MEMTEST_END       0x007fffff      /*(_8M -1) */
>
> Missing space after '*' and '-'. Please run checkpatch on this
> patch.
>

Pretty sure I did. There was the usual complaints about long lines in
the dts so maybe I just threw the rest out with them.

> > +#define CONFIG_SYS_RESET_ADDRESS 0xffff0000  /* Rst Vector Adr */
> > +
> > +/*
> > + * SDIO/MMC Card Configuration
> > + */
> > +#ifdef CONFIG_CMD_MMC
> > +#define CONFIG_MVEBU_MMC
> > +#define CONFIG_SYS_MMC_BASE KW_SDIO_BASE
> > +#endif /* CONFIG_CMD_MMC */
> > +
> > +/*
> > + * SATA Driver configuration
> > + */
> > +#ifdef CONFIG_MVSATA_IDE
> > +#define CONFIG_SYS_ATA_IDE0_OFFSET   MV_SATA_PORT0_OFFSET
> > +#endif /*CONFIG_MVSATA_IDE*/
> > +
> > +#define CONFIG_SYS_LOAD_ADDR  0x1000000      /* default location for tftp and bootm */
> > +
> > +#define CONFIG_SYS_DCACHE_OFF
>
> Why is the d-cache disabled?
>

http://patchwork.ozlabs.org/patch/1048863/

I've not had time to look into the actual problem but I think all
kirkwood boards are in a state of not being able to do DMA. Without
this and the icache fiddling I can't use the Ethernet port.

> Thanks,
> Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB
  2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
                   ` (11 preceding siblings ...)
  2019-03-07  8:28 ` [U-Boot] [PATCH v2 12/12] ARM: kirkwood: enable CONFIG_DM_USB for nas220 Chris Packham
@ 2019-03-08 10:16 ` Leigh Brown
  2019-03-08 20:56   ` Chris Packham
  12 siblings, 1 reply; 30+ messages in thread
From: Leigh Brown @ 2019-03-08 10:16 UTC (permalink / raw)
  To: u-boot

Hi Chris,

On 2019-03-07 08:27, Chris Packham wrote:
> This is my series to convert the kirkwood platforms to DM_USB.
> 
> I've been testing on an old kirkwood eval board which patch 1 adds. I'd
> really appreciate some testing on other kirkwood platforms.
> 
> Chris Packham (12):
>   ARM: kirkwood: add db-88f6281-bp board
>   ARM: kirkwood: rename KW_CPU_WIN_BASE to MVEBU_CPU_WIN_BASE
>   ARM: kirkwood: remove KW_DEFADR_PCI_IO_REMAP
>   ARM: kirkwood: switch to using mvebu mbus
>   ARM: kirkwood: remove kw_config_adr_windows
>   ARM: kirkwood: enable CONFIG_DM_USB on db-88f6281-bp
>   ARM: kirkwood: enable CONFIG_DM_USB for {dream,guru,sheeva}plug
>   ARM: kirkwood: enable CONFIG_DM_USB for dns325
>   ARM: kirkwood: enable CONFIG_DM_USB for ds109
>   ARM: kirkwood: enable CONFIG_DM_USB for goflexhome
>   ARM: kirkwood: enable CONFIG_DM_USB for lschlv2 and lsxhl
>   ARM: kirkwood: enable CONFIG_DM_USB for nas220
> 
>  arch/arm/dts/kirkwood-db-88f6281-spi.dts    |  48 +++++++++
>  arch/arm/dts/kirkwood-db-88f6281.dts        |  26 +++++
>  arch/arm/dts/kirkwood-db.dtsi               |  94 +++++++++++++++++
>  arch/arm/mach-kirkwood/Kconfig              |   4 +
>  arch/arm/mach-kirkwood/cpu.c                |  73 ++++---------
>  arch/arm/mach-kirkwood/include/mach/cpu.h   |  13 ++-
>  arch/arm/mach-kirkwood/include/mach/soc.h   |   2 +-
>  arch/arm/mach-mvebu/Makefile                |   1 +
>  arch/arm/mach-mvebu/mbus.c                  |   6 ++
>  board/Marvell/db-88f6281-bp/Kconfig         |  12 +++
>  board/Marvell/db-88f6281-bp/MAINTAINERS     |  10 ++
>  board/Marvell/db-88f6281-bp/Makefile        |   3 +
>  board/Marvell/db-88f6281-bp/db-88f6281-bp.c | 103 ++++++++++++++++++
>  board/Marvell/db-88f6281-bp/kwbimage.cfg    |  36 +++++++
>  configs/db-88f6281-bp-nand_defconfig        |  54 ++++++++++
>  configs/db-88f6281-bp-spi_defconfig         |  55 ++++++++++
>  configs/dns325_defconfig                    |   2 +
>  configs/dreamplug_defconfig                 |   2 +
>  configs/ds109_defconfig                     |   2 +
>  configs/goflexhome_defconfig                |   2 +
>  configs/guruplug_defconfig                  |   2 +
>  configs/lschlv2_defconfig                   |   2 +
>  configs/lsxhl_defconfig                     |   2 +
>  configs/nas220_defconfig                    |   2 +
>  configs/sheevaplug_defconfig                |   1 +
>  include/configs/db-88f6281-bp.h             | 109 ++++++++++++++++++++
>  26 files changed, 608 insertions(+), 58 deletions(-)
>  create mode 100644 arch/arm/dts/kirkwood-db-88f6281-spi.dts
>  create mode 100644 arch/arm/dts/kirkwood-db-88f6281.dts
>  create mode 100644 arch/arm/dts/kirkwood-db.dtsi
>  create mode 100644 board/Marvell/db-88f6281-bp/Kconfig
>  create mode 100644 board/Marvell/db-88f6281-bp/MAINTAINERS
>  create mode 100644 board/Marvell/db-88f6281-bp/Makefile
>  create mode 100644 board/Marvell/db-88f6281-bp/db-88f6281-bp.c
>  create mode 100644 board/Marvell/db-88f6281-bp/kwbimage.cfg
>  create mode 100644 configs/db-88f6281-bp-nand_defconfig
>  create mode 100644 configs/db-88f6281-bp-spi_defconfig
>  create mode 100644 include/configs/db-88f6281-bp.h

I have tested your patches on my Dreamplug on top of the SPI patch and 
my patch to fix the cache setup. It looks to be working fine.  It boots 
from the SD card which is connected via USB.  Are there any additional 
tests you recommend?

Tested-by: Leigh Brown <leigh@solinno.co.uk>

   MKIMAGE u-boot.kwb
===================== WARNING ======================
This board does not use CONFIG_DM_SCSI. Please update
the storage controller to use CONFIG_DM_SCSI before the v2019.07 
release.
Failure to update by the deadline may result in board removal.
See doc/driver-model/MIGRATION.txt for more info.
====================================================
   CFGCHK  u-boot.cfg
leigh at dish:/devel/git-trees/dreamplug/u-boot$ tools/kwboot -b u-boot.kwb 
-p -B 115200 -t /dev/ttyUSB0
Sending boot message. Please reboot the target...\
Sending boot image...
   0 % 
[......................................................................]
   2 % 
[......................................................................]
   4 % 
[......................................................................]
   7 % 
[......................................................................]
   9 % 
[......................................................................]
  12 % 
[......................................................................]
  14 % 
[......................................................................]
  16 % 
[......................................................................]
  19 % 
[......................................................................]
  21 % 
[......................................................................]
  24 % 
[......................................................................]
  26 % 
[......................................................................]
  28 % 
[......................................................................]
  31 % 
[......................................................................]
  33 % 
[......................................................................]
  36 % 
[......................................................................]
  38 % 
[......................................................................]
  40 % 
[......................................................................]
  43 % 
[......................................................................]
  45 % 
[......................................................................]
  48 % 
[......................................................................]
  50 % 
[......................................................................]
  52 % 
[......................................................................]
  55 % 
[......................................................................]
  57 % 
[......................................................................]
  59 % 
[......................................................................]
  62 % 
[......................................................................]
  64 % 
[......................................................................]
  67 % 
[......................................................................]
  69 % 
[......................................................................]
  71 % 
[......................................................................]
  74 % 
[......................................................................]
  76 % 
[......................................................................]
  79 % 
[......................................................................]
  81 % 
[......................................................................]
  83 % 
[......................................................................]
  86 % 
[......................................................................]
  88 % 
[......................................................................]
  91 % 
[......................................................................]
  93 % 
[......................................................................]
  95 % 
[......................................................................]
  98 % [.................................................]
[Type Ctrl-\ + c to quit]


U-Boot 2019.04-rc3-00016-gf18b7b2798-dirty (Mar 08 2019 - 08:05:45 
+0000)
Marvell-DreamPlug

SoC:   Kirkwood 88F6281_A1
DRAM:  512 MiB
Loading Environment from SPI Flash... SF: Detected mx25l1606e with page 
size 256 Bytes, erase size 4 KiB, total 2 MiB
OK
In:    serial
Out:   serial
Err:   serial
Net:   egiga0, egiga1
88E1116 Initialized on egiga0
88E1116 Initialized on egiga1
Hit any key to stop autoboot:  0
=> printenv
baudrate=115200
bootargs=console=ttyS0,115200 root=LABEL=dproot rootdelay=2 ro quiet
bootcmd=usb start;run x_load_uimage x_load_dtb x_load_uinitrd 
x_bootm;reset
bootdelay=1
dtb=kirkwood-dreamplug.dtb
eth1addr=F0:AD:4E:00:7B:A8
ethact=egiga0
ethaddr=F0:AD:4E:00:7B:A7
fdtcontroladdr=1fb907c8
filesize=4DBFD3
loaddev=usb 0
stderr=serial
stdin=serial
stdout=serial
uimage=uImage-4.19.0-2-marvell
uinitrd=uInitrd-4.19.0-2-marvell
x_bootm=bootm 0x6000000 0x6600000 0x6400000
x_load_dtb=fatload ${loaddev} 0x6400000 ${dtb}
x_load_uimage=fatload ${loaddev} 0x6000000 ${uimage}
x_load_uinitrd=fatload ${loaddev} 0x6600000 ${uinitrd}

Environment size: 626/4092 bytes
=> usb start
starting USB...
USB0:   USB EHCI 1.00
scanning bus 0 for devices... Device NOT ready
    Request Sense returned 02 3A 00
4 USB Device(s) found
        scanning usb for storage devices... 1 Storage Device(s) found
=> fatls usb 0
             dodgy/
    351132   u-boot.kwb
      9949   kirkwood-dreamplug.dtb
   2038528   uImage-4.19.0-2-marvell
   4015832   uInitrd-4.19.0-2-marvell
   1879928   uImage-4.19.7+
   2746404   uInitrd-4.19.7+

6 file(s), 1 dir(s)

=> boot
2038528 bytes read in 106 ms (18.3 MiB/s)
9949 bytes read in 19 ms (510.7 KiB/s)
4015832 bytes read in 197 ms (19.4 MiB/s)
## Booting kernel from Legacy Image at 06000000 ...
    Image Name:   uImage-4.19.0-2-marvell
    Created:      2019-02-26  14:27:36 UTC
    Image Type:   ARM Linux Kernel Image (uncompressed)
    Data Size:    2038464 Bytes = 1.9 MiB
    Load Address: 00008000
    Entry Point:  00008000
    Verifying Checksum ... OK
## Loading init Ramdisk from Legacy Image at 06600000 ...
    Image Name:   uInitrd-4.19.0-2-marvell
    Created:      2019-02-26  14:28:44 UTC
    Image Type:   ARM Linux RAMDisk Image (uncompressed)
    Data Size:    4015768 Bytes = 3.8 MiB
    Load Address: 00000000
    Entry Point:  00000000
    Verifying Checksum ... OK
## Flattened Device Tree blob at 06400000
    Booting using the fdt blob at 0x6400000
    Loading Kernel Image ... OK
    Loading Ramdisk to 0fc2b000, end 0ffff698 ... OK
    Loading Device Tree to 0fc25000, end 0fc2a6dc ... OK

Starting kernel ...

Regards,

Leigh.

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB
  2019-03-08 10:16 ` [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Leigh Brown
@ 2019-03-08 20:56   ` Chris Packham
  0 siblings, 0 replies; 30+ messages in thread
From: Chris Packham @ 2019-03-08 20:56 UTC (permalink / raw)
  To: u-boot

On Fri, 8 Mar 2019, 11:16 PM Leigh Brown, <leigh@solinno.co.uk> wrote:

> Hi Chris,
>
> On 2019-03-07 08:27, Chris Packham wrote:
> > This is my series to convert the kirkwood platforms to DM_USB.
> >
> > I've been testing on an old kirkwood eval board which patch 1 adds. I'd
> > really appreciate some testing on other kirkwood platforms.
> >
> > Chris Packham (12):
> >   ARM: kirkwood: add db-88f6281-bp board
> >   ARM: kirkwood: rename KW_CPU_WIN_BASE to MVEBU_CPU_WIN_BASE
> >   ARM: kirkwood: remove KW_DEFADR_PCI_IO_REMAP
> >   ARM: kirkwood: switch to using mvebu mbus
> >   ARM: kirkwood: remove kw_config_adr_windows
> >   ARM: kirkwood: enable CONFIG_DM_USB on db-88f6281-bp
> >   ARM: kirkwood: enable CONFIG_DM_USB for {dream,guru,sheeva}plug
> >   ARM: kirkwood: enable CONFIG_DM_USB for dns325
> >   ARM: kirkwood: enable CONFIG_DM_USB for ds109
> >   ARM: kirkwood: enable CONFIG_DM_USB for goflexhome
> >   ARM: kirkwood: enable CONFIG_DM_USB for lschlv2 and lsxhl
> >   ARM: kirkwood: enable CONFIG_DM_USB for nas220
> >
> >  arch/arm/dts/kirkwood-db-88f6281-spi.dts    |  48 +++++++++
> >  arch/arm/dts/kirkwood-db-88f6281.dts        |  26 +++++
> >  arch/arm/dts/kirkwood-db.dtsi               |  94 +++++++++++++++++
> >  arch/arm/mach-kirkwood/Kconfig              |   4 +
> >  arch/arm/mach-kirkwood/cpu.c                |  73 ++++---------
> >  arch/arm/mach-kirkwood/include/mach/cpu.h   |  13 ++-
> >  arch/arm/mach-kirkwood/include/mach/soc.h   |   2 +-
> >  arch/arm/mach-mvebu/Makefile                |   1 +
> >  arch/arm/mach-mvebu/mbus.c                  |   6 ++
> >  board/Marvell/db-88f6281-bp/Kconfig         |  12 +++
> >  board/Marvell/db-88f6281-bp/MAINTAINERS     |  10 ++
> >  board/Marvell/db-88f6281-bp/Makefile        |   3 +
> >  board/Marvell/db-88f6281-bp/db-88f6281-bp.c | 103 ++++++++++++++++++
> >  board/Marvell/db-88f6281-bp/kwbimage.cfg    |  36 +++++++
> >  configs/db-88f6281-bp-nand_defconfig        |  54 ++++++++++
> >  configs/db-88f6281-bp-spi_defconfig         |  55 ++++++++++
> >  configs/dns325_defconfig                    |   2 +
> >  configs/dreamplug_defconfig                 |   2 +
> >  configs/ds109_defconfig                     |   2 +
> >  configs/goflexhome_defconfig                |   2 +
> >  configs/guruplug_defconfig                  |   2 +
> >  configs/lschlv2_defconfig                   |   2 +
> >  configs/lsxhl_defconfig                     |   2 +
> >  configs/nas220_defconfig                    |   2 +
> >  configs/sheevaplug_defconfig                |   1 +
> >  include/configs/db-88f6281-bp.h             | 109 ++++++++++++++++++++
> >  26 files changed, 608 insertions(+), 58 deletions(-)
> >  create mode 100644 arch/arm/dts/kirkwood-db-88f6281-spi.dts
> >  create mode 100644 arch/arm/dts/kirkwood-db-88f6281.dts
> >  create mode 100644 arch/arm/dts/kirkwood-db.dtsi
> >  create mode 100644 board/Marvell/db-88f6281-bp/Kconfig
> >  create mode 100644 board/Marvell/db-88f6281-bp/MAINTAINERS
> >  create mode 100644 board/Marvell/db-88f6281-bp/Makefile
> >  create mode 100644 board/Marvell/db-88f6281-bp/db-88f6281-bp.c
> >  create mode 100644 board/Marvell/db-88f6281-bp/kwbimage.cfg
> >  create mode 100644 configs/db-88f6281-bp-nand_defconfig
> >  create mode 100644 configs/db-88f6281-bp-spi_defconfig
> >  create mode 100644 include/configs/db-88f6281-bp.h
>
> I have tested your patches on my Dreamplug on top of the SPI patch and
> my patch to fix the cache setup. It looks to be working fine.  It boots
> from the SD card which is connected via USB.  Are there any additional
> tests you recommend?
>
> Tested-by: Leigh Brown <leigh@solinno.co.uk>
>

Awesome thanks. If you happen to have a usb Ethernet adapter it'd be good
to try that out but the flash drive is probably enough for the "has this
broken anything" test.


>    MKIMAGE u-boot.kwb
> ===================== WARNING ======================
> This board does not use CONFIG_DM_SCSI. Please update
> the storage controller to use CONFIG_DM_SCSI before the v2019.07
> release.
> Failure to update by the deadline may result in board removal.
> See doc/driver-model/MIGRATION.txt for more info.
> ====================================================
>    CFGCHK  u-boot.cfg
> leigh at dish:/devel/git-trees/dreamplug/u-boot$ tools/kwboot -b u-boot.kwb
> -p -B 115200 -t /dev/ttyUSB0
> Sending boot message. Please reboot the target...\
> Sending boot image...
>    0 %
> [......................................................................]
>    2 %
> [......................................................................]
>    4 %
> [......................................................................]
>    7 %
> [......................................................................]
>    9 %
> [......................................................................]
>   12 %
> [......................................................................]
>   14 %
> [......................................................................]
>   16 %
> [......................................................................]
>   19 %
> [......................................................................]
>   21 %
> [......................................................................]
>   24 %
> [......................................................................]
>   26 %
> [......................................................................]
>   28 %
> [......................................................................]
>   31 %
> [......................................................................]
>   33 %
> [......................................................................]
>   36 %
> [......................................................................]
>   38 %
> [......................................................................]
>   40 %
> [......................................................................]
>   43 %
> [......................................................................]
>   45 %
> [......................................................................]
>   48 %
> [......................................................................]
>   50 %
> [......................................................................]
>   52 %
> [......................................................................]
>   55 %
> [......................................................................]
>   57 %
> [......................................................................]
>   59 %
> [......................................................................]
>   62 %
> [......................................................................]
>   64 %
> [......................................................................]
>   67 %
> [......................................................................]
>   69 %
> [......................................................................]
>   71 %
> [......................................................................]
>   74 %
> [......................................................................]
>   76 %
> [......................................................................]
>   79 %
> [......................................................................]
>   81 %
> [......................................................................]
>   83 %
> [......................................................................]
>   86 %
> [......................................................................]
>   88 %
> [......................................................................]
>   91 %
> [......................................................................]
>   93 %
> [......................................................................]
>   95 %
> [......................................................................]
>   98 % [.................................................]
> [Type Ctrl-\ + c to quit]
>
>
> U-Boot 2019.04-rc3-00016-gf18b7b2798-dirty (Mar 08 2019 - 08:05:45
> +0000)
> Marvell-DreamPlug
>
> SoC:   Kirkwood 88F6281_A1
> DRAM:  512 MiB
> Loading Environment from SPI Flash... SF: Detected mx25l1606e with page
> size 256 Bytes, erase size 4 KiB, total 2 MiB
> OK
> In:    serial
> Out:   serial
> Err:   serial
> Net:   egiga0, egiga1
> 88E1116 Initialized on egiga0
> 88E1116 Initialized on egiga1
> Hit any key to stop autoboot:  0
> => printenv
> baudrate=115200
> bootargs=console=ttyS0,115200 root=LABEL=dproot rootdelay=2 ro quiet
> bootcmd=usb start;run x_load_uimage x_load_dtb x_load_uinitrd
> x_bootm;reset
> bootdelay=1
> dtb=kirkwood-dreamplug.dtb
> eth1addr=F0:AD:4E:00:7B:A8
> ethact=egiga0
> ethaddr=F0:AD:4E:00:7B:A7
> fdtcontroladdr=1fb907c8
> filesize=4DBFD3
> loaddev=usb 0
> stderr=serial
> stdin=serial
> stdout=serial
> uimage=uImage-4.19.0-2-marvell
> uinitrd=uInitrd-4.19.0-2-marvell
> x_bootm=bootm 0x6000000 0x6600000 0x6400000
> x_load_dtb=fatload ${loaddev} 0x6400000 ${dtb}
> x_load_uimage=fatload ${loaddev} 0x6000000 ${uimage}
> x_load_uinitrd=fatload ${loaddev} 0x6600000 ${uinitrd}
>
> Environment size: 626/4092 bytes
> => usb start
> starting USB...
> USB0:   USB EHCI 1.00
> scanning bus 0 for devices... Device NOT ready
>     Request Sense returned 02 3A 00
> 4 USB Device(s) found
>         scanning usb for storage devices... 1 Storage Device(s) found
> => fatls usb 0
>              dodgy/
>     351132   u-boot.kwb
>       9949   kirkwood-dreamplug.dtb
>    2038528   uImage-4.19.0-2-marvell
>    4015832   uInitrd-4.19.0-2-marvell
>    1879928   uImage-4.19.7+
>    2746404   uInitrd-4.19.7+
>
> 6 file(s), 1 dir(s)
>
> => boot
> 2038528 bytes read in 106 ms (18.3 MiB/s)
> 9949 bytes read in 19 ms (510.7 KiB/s)
> 4015832 bytes read in 197 ms (19.4 MiB/s)
> ## Booting kernel from Legacy Image at 06000000 ...
>     Image Name:   uImage-4.19.0-2-marvell
>     Created:      2019-02-26  14:27:36 UTC
>     Image Type:   ARM Linux Kernel Image (uncompressed)
>     Data Size:    2038464 Bytes = 1.9 MiB
>     Load Address: 00008000
>     Entry Point:  00008000
>     Verifying Checksum ... OK
> ## Loading init Ramdisk from Legacy Image at 06600000 ...
>     Image Name:   uInitrd-4.19.0-2-marvell
>     Created:      2019-02-26  14:28:44 UTC
>     Image Type:   ARM Linux RAMDisk Image (uncompressed)
>     Data Size:    4015768 Bytes = 3.8 MiB
>     Load Address: 00000000
>     Entry Point:  00000000
>     Verifying Checksum ... OK
> ## Flattened Device Tree blob at 06400000
>     Booting using the fdt blob at 0x6400000
>     Loading Kernel Image ... OK
>     Loading Ramdisk to 0fc2b000, end 0ffff698 ... OK
>     Loading Device Tree to 0fc25000, end 0fc2a6dc ... OK
>
> Starting kernel ...
>
> Regards,
>
> Leigh.
>

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board
  2019-03-07  9:33   ` Stefan Roese
  2019-03-08  6:44     ` Chris Packham
@ 2019-03-13  7:00     ` Chris Packham
  2019-03-13  7:23       ` Stefan Roese
  1 sibling, 1 reply; 30+ messages in thread
From: Chris Packham @ 2019-03-13  7:00 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 7, 2019 at 10:33 PM Stefan Roese <sr@denx.de> wrote:
>
> Hi Chris,
>
> On 07.03.19 09:27, Chris Packham wrote:
> > This is Marvell's Kirkwood development board. It has the following
> > features
> >
> >   - 512M DDR2
> >   - 2 PCI connectors
> >   - 1 x1 PCI-e interface
> >   - 1 Gigabit Ethernet Port
> >   - 2 SATA Ports
> >   - USB 2.0 Interface
> >   - SDIO
> >   - 128M NAND Flash
> >   - 16M SPI Flash
> >
> > It can be strapped to boot from SPI or NAND so there are two defconfigs
> > (one per boot media).
>
> Thanks for this board addition. Please find some review comments
> below.
>
> >
> > Signed-off-by: Chris Packham <judge.packham@gmail.com>
> > ---
> >
> >   arch/arm/dts/kirkwood-db-88f6281-spi.dts    |  48 +++++++++
> >   arch/arm/dts/kirkwood-db-88f6281.dts        |  26 +++++
> >   arch/arm/dts/kirkwood-db.dtsi               |  94 +++++++++++++++++
> >   arch/arm/mach-kirkwood/Kconfig              |   4 +
> >   board/Marvell/db-88f6281-bp/Kconfig         |  12 +++
> >   board/Marvell/db-88f6281-bp/MAINTAINERS     |  10 ++
> >   board/Marvell/db-88f6281-bp/Makefile        |   3 +
> >   board/Marvell/db-88f6281-bp/db-88f6281-bp.c | 103 ++++++++++++++++++
> >   board/Marvell/db-88f6281-bp/kwbimage.cfg    |  36 +++++++
> >   configs/db-88f6281-bp-nand_defconfig        |  53 ++++++++++
> >   configs/db-88f6281-bp-spi_defconfig         |  54 ++++++++++
> >   include/configs/db-88f6281-bp.h             | 109 ++++++++++++++++++++
> >   12 files changed, 552 insertions(+)
> >   create mode 100644 arch/arm/dts/kirkwood-db-88f6281-spi.dts
> >   create mode 100644 arch/arm/dts/kirkwood-db-88f6281.dts
> >   create mode 100644 arch/arm/dts/kirkwood-db.dtsi
> >   create mode 100644 board/Marvell/db-88f6281-bp/Kconfig
> >   create mode 100644 board/Marvell/db-88f6281-bp/MAINTAINERS
> >   create mode 100644 board/Marvell/db-88f6281-bp/Makefile
> >   create mode 100644 board/Marvell/db-88f6281-bp/db-88f6281-bp.c
> >   create mode 100644 board/Marvell/db-88f6281-bp/kwbimage.cfg
> >   create mode 100644 configs/db-88f6281-bp-nand_defconfig
> >   create mode 100644 configs/db-88f6281-bp-spi_defconfig
> >   create mode 100644 include/configs/db-88f6281-bp.h
> >
> > diff --git a/arch/arm/dts/kirkwood-db-88f6281-spi.dts b/arch/arm/dts/kirkwood-db-88f6281-spi.dts
> > new file mode 100644
> > index 000000000000..50b1b0d4a535
> > --- /dev/null
> > +++ b/arch/arm/dts/kirkwood-db-88f6281-spi.dts
> > @@ -0,0 +1,48 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Marvell DB-88F6281-BP Development Board Setup
> > + *
> > + * Saeed Bishara <saeed@marvell.com>
> > + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > + *
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "kirkwood-db-88f6281.dts"
> > +
> > +/ {
> > +     aliases {
> > +             spi0 = &spi0;
> > +     };
> > +};
> > +
> > +&spi0 {
> > +     status = "okay";
> > +
> > +     flash at 0 {
> > +             #address-cells = <1>;
> > +             #size-cells = <1>;
> > +             compatible = "st,m25p128", "jedec,spi-nor", "spi-flash";
> > +             reg = <0>;
> > +             spi-max-frequency = <50000000>;
> > +             mode = <0>;
> > +
> > +             partition at u-boot {
> > +                     reg = <0x00000000 0x00c00000>;
> > +                     label = "u-boot";
> > +             };
> > +             partition at u-boot-env {
> > +                     reg = <0x00c00000 0x00040000>;
> > +                     label = "u-boot-env";
> > +             };
> > +             partition at unused {
> > +                     reg = <0x00100000 0x00f00000>;
> > +                     label = "unused";
> > +             };
> > +     };
> > +};
> > +
> > +&nand {
> > +     status = "disabled";
> > +};
> > diff --git a/arch/arm/dts/kirkwood-db-88f6281.dts b/arch/arm/dts/kirkwood-db-88f6281.dts
> > new file mode 100644
> > index 000000000000..2adb17c955aa
> > --- /dev/null
> > +++ b/arch/arm/dts/kirkwood-db-88f6281.dts
> > @@ -0,0 +1,26 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Marvell DB-88F6281-BP Development Board Setup
> > + *
> > + * Saeed Bishara <saeed@marvell.com>
> > + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > + *
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "kirkwood-db.dtsi"
> > +#include "kirkwood-6281.dtsi"
> > +
> > +/ {
> > +     model = "Marvell DB-88F6281-BP Development Board";
> > +     compatible = "marvell,db-88f6281-bp", "marvell,kirkwood-88f6281", "marvell,kirkwood";
> > +};
> > +
> > +&pciec {
> > +        status = "okay";
> > +};
> > +
> > +&pcie0 {
> > +     status = "okay";
> > +};
> > diff --git a/arch/arm/dts/kirkwood-db.dtsi b/arch/arm/dts/kirkwood-db.dtsi
> > new file mode 100644
> > index 000000000000..b81d8e8298a3
> > --- /dev/null
> > +++ b/arch/arm/dts/kirkwood-db.dtsi
> > @@ -0,0 +1,94 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Marvell DB-{88F6281,88F6282}-BP Development Board Setup
> > + *
> > + * Saeed Bishara <saeed@marvell.com>
> > + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > + *
> > + * This file contains the definitions that are common between the 6281
> > + * and 6282 variants of the Marvell Kirkwood Development Board.
> > + */
> > +
> > +#include "kirkwood.dtsi"
> > +
> > +/ {
> > +     memory {
> > +             device_type = "memory";
> > +             reg = <0x00000000 0x20000000>; /* 512 MB */
> > +     };
> > +
> > +     chosen {
> > +             bootargs = "console=ttyS0,115200n8 earlyprintk";
> > +             stdout-path = &uart0;
> > +     };
> > +
> > +     aliases {
> > +             ethernet0 = &eth0;
> > +             spi0 = &spi0;
> > +     };
> > +
> > +     ocp at f1000000 {
> > +             pin-controller at 10000 {
> > +                     pmx_sdio_gpios: pmx-sdio-gpios {
> > +                             marvell,pins = "mpp37", "mpp38";
> > +                             marvell,function = "gpio";
> > +                     };
> > +             };
> > +
> > +             serial at 12000 {
> > +                     status = "okay";
> > +             };
> > +
> > +             sata at 80000 {
> > +                     nr-ports = <2>;
> > +                     status = "okay";
> > +             };
> > +
> > +             ehci at 50000 {
> > +                     status = "okay";
> > +             };
> > +
> > +             mvsdio at 90000 {
> > +                     pinctrl-0 = <&pmx_sdio_gpios>;
> > +                     pinctrl-names = "default";
> > +                     wp-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> > +                     cd-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
> > +                     status = "okay";
> > +             };
> > +     };
> > +};
> > +
> > +&nand {
> > +     chip-delay = <25>;
> > +     status = "okay";
> > +
> > +     partition at 0 {
> > +             label = "uboot";
> > +             reg = <0x0 0x100000>;
> > +     };
> > +
> > +     partition at 100000 {
> > +             label = "uImage";
> > +             reg = <0x100000 0x400000>;
> > +     };
> > +
> > +     partition at 500000 {
> > +             label = "root";
> > +             reg = <0x500000 0x1fb00000>;
> > +     };
> > +};
> > +
> > +&mdio {
> > +     status = "okay";
> > +
> > +     ethphy0: ethernet-phy at 8 {
> > +             reg = <8>;
> > +     };
> > +};
> > +
> > +&eth0 {
> > +     status = "okay";
> > +     ethernet0-port at 0 {
> > +             phy-handle = <&ethphy0>;
> > +     };
> > +};
> > diff --git a/arch/arm/mach-kirkwood/Kconfig b/arch/arm/mach-kirkwood/Kconfig
> > index 3b860c4f55fe..7c4170399afb 100644
> > --- a/arch/arm/mach-kirkwood/Kconfig
> > +++ b/arch/arm/mach-kirkwood/Kconfig
> > @@ -65,6 +65,9 @@ config TARGET_SBx81LIFKW
> >   config TARGET_SBx81LIFXCAT
> >       bool "Allied Telesis SBx81GP24/SBx81GT24"
> >
> > +config TARGET_DB_88F6281_BP
> > +     bool "Marvell DB-88F6281-BP"
> > +
> >   endchoice
> >
> >   config SYS_SOC
> > @@ -89,5 +92,6 @@ source "board/Seagate/nas220/Kconfig"
> >   source "board/zyxel/nsa310s/Kconfig"
> >   source "board/alliedtelesis/SBx81LIFKW/Kconfig"
> >   source "board/alliedtelesis/SBx81LIFXCAT/Kconfig"
> > +source "board/Marvell/db-88f6281-bp/Kconfig"
> >
> >   endif
> > diff --git a/board/Marvell/db-88f6281-bp/Kconfig b/board/Marvell/db-88f6281-bp/Kconfig
> > new file mode 100644
> > index 000000000000..38467399e688
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/Kconfig
> > @@ -0,0 +1,12 @@
> > +if TARGET_DB_88F6281_BP
> > +
> > +config SYS_BOARD
> > +     default "db-88f6281-bp"
> > +
> > +config SYS_VENDOR
> > +     default "Marvell"
> > +
> > +config SYS_CONFIG_NAME
> > +     default "db-88f6281-bp"
> > +
> > +endif
> > diff --git a/board/Marvell/db-88f6281-bp/MAINTAINERS b/board/Marvell/db-88f6281-bp/MAINTAINERS
> > new file mode 100644
> > index 000000000000..f31d3be70bae
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/MAINTAINERS
> > @@ -0,0 +1,10 @@
> > +DB_88F6820_AMC BOARD
> > +M:   Chris Packham <judge.packham@gmail.com>
> > +S:   Maintained
> > +F:   arch/arm/dts/kirkwood-db-88f6281.dts
> > +F:   arch/arm/dts/kirkwood-db-88f6281-spi.dts
> > +F:   arch/arm/dts/kirkwood-db.dtsi
> > +F:   board/Marvell/db-88f6281-bp/
> > +F:   include/configs/db-88f6281-bp.h
> > +F:   configs/db-88f6281-bp_defconfig
> > +F:   configs/db-88f6281-bp-spi_defconfig
> > diff --git a/board/Marvell/db-88f6281-bp/Makefile b/board/Marvell/db-88f6281-bp/Makefile
> > new file mode 100644
> > index 000000000000..38ff522ca1c8
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/Makefile
> > @@ -0,0 +1,3 @@
> > +# SPDX-License-Identifier: GPL-2.0+
> > +
> > +obj-y        := db-88f6281-bp.o
> > diff --git a/board/Marvell/db-88f6281-bp/db-88f6281-bp.c b/board/Marvell/db-88f6281-bp/db-88f6281-bp.c
> > new file mode 100644
> > index 000000000000..b68f2f3c895b
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/db-88f6281-bp.c
> > @@ -0,0 +1,103 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +
> > +#include <common.h>
> > +#include <linux/io.h>
> > +#include <miiphy.h>
> > +#include <netdev.h>
> > +#include <asm/arch/cpu.h>
> > +#include <asm/arch/soc.h>
> > +#include <asm/arch/mpp.h>
> > +#include <asm/arch/gpio.h>
> > +
> > +#define DB_88F6281_OE_LOW    ~(BIT(7))
> > +#define DB_88F6281_OE_HIGH   ~(BIT(15) | BIT(14) | BIT(13) | BIT(4))
> > +#define DB_88F6281_OE_VAL_LOW        BIT(7)
> > +#define DB_88F6281_OE_VAL_HIGH       0
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
> > +
> > +int board_early_init_f(void)
> > +{
> > +     mvebu_config_gpio(DB_88F6281_OE_VAL_LOW,
> > +                       DB_88F6281_OE_VAL_HIGH,
> > +                       DB_88F6281_OE_LOW, DB_88F6281_OE_HIGH);
> > +
> > +     /* Multi-Purpose Pins Functionality configuration */
> > +     static const u32 kwmpp_config[] = {
> > +#ifdef CONFIG_CMD_NAND
> > +             MPP0_NF_IO2,
> > +             MPP1_NF_IO3,
> > +             MPP2_NF_IO4,
> > +             MPP3_NF_IO5,
> > +#else
> > +             MPP0_SPI_SCn,
> > +             MPP1_SPI_MOSI,
> > +             MPP2_SPI_SCK,
> > +             MPP3_SPI_MISO,
> > +#endif
> > +             MPP4_NF_IO6,
> > +             MPP5_NF_IO7,
> > +             MPP6_SYSRST_OUTn,
> > +             MPP7_GPO,
> > +             MPP8_TW_SDA,
> > +             MPP9_TW_SCK,
> > +             MPP10_UART0_TXD,
> > +             MPP11_UART0_RXD,
> > +             MPP12_SD_CLK,
> > +             MPP13_SD_CMD,
> > +             MPP14_SD_D0,
> > +             MPP15_SD_D1,
> > +             MPP16_SD_D2,
> > +             MPP17_SD_D3,
> > +             MPP18_NF_IO0,
> > +             MPP19_NF_IO1,
> > +             MPP20_SATA1_ACTn,
> > +             MPP21_SATA0_ACTn,
> > +             MPP22_GPIO,
> > +             MPP23_GPIO,
> > +             MPP24_GPIO,
> > +             MPP25_GPIO,
> > +             MPP26_GPIO,
> > +             MPP27_GPIO,
> > +             MPP28_GPIO,
> > +             MPP29_GPIO,
> > +             MPP30_GPIO,
> > +             MPP31_GPIO,
> > +             MPP32_GPIO,
> > +             MPP33_GPIO,
> > +             MPP34_GPIO,
> > +             MPP35_GPIO,
> > +             MPP36_GPIO,
> > +             MPP37_GPIO,
> > +             MPP38_GPIO,
> > +             MPP39_GPIO,
> > +             MPP40_GPIO,
> > +             MPP41_GPIO,
> > +             MPP42_GPIO,
> > +             MPP43_GPIO,
> > +             MPP44_GPIO,
> > +             MPP45_GPIO,
> > +             MPP46_GPIO,
> > +             MPP47_GPIO,
> > +             MPP48_GPIO,
> > +             MPP49_GPIO,
> > +             0
> > +     };
> > +     kirkwood_mpp_conf(kwmpp_config, NULL);
> > +
> > +     return 0;
> > +}
> > +
> > +int board_init(void)
> > +{
> > +     gd->bd->bi_boot_params = mvebu_sdram_bar(0) + 0x100;
> > +
> > +     return 0;
> > +}
> > +
> > +#ifdef CONFIG_RESET_PHY_R
> > +/* automatically defined by kirkwood config.h */
> > +void reset_phy(void)
> > +{
> > +}
> > +#endif
> > diff --git a/board/Marvell/db-88f6281-bp/kwbimage.cfg b/board/Marvell/db-88f6281-bp/kwbimage.cfg
> > new file mode 100644
> > index 000000000000..49a637078682
> > --- /dev/null
> > +++ b/board/Marvell/db-88f6281-bp/kwbimage.cfg
> > @@ -0,0 +1,36 @@
> > +# SPDX-License-Identifier: GPL-2.0+
> > +
> > +# Boot Media configurations
> > +BOOT_FROM    spi     # Boot from SPI flash
>
> How is booting from NAND handled? Is the boot device patched
> dynamically in the resulting image?
>
> > +
> > +DATA 0xd00100e0 0x1b1b1b9b
> > +DATA 0xd0020134 0xbbbbbbbb
> > +DATA 0xd0020138 0x00bbbbbb
> > +DATA 0xd0020154 0x00000200
> > +DATA 0xd002014c 0x00001c00
> > +DATA 0xd0020148 0x00000001
> > +
> > +DATA 0xd0001400 0x43000c30
> > +DATA 0xd0001404 0x39543000
> > +DATA 0xd0001408 0x22125451
> > +DATA 0xd000140c 0x00000833
> > +DATA 0xd0001410 0x000000cc
> > +DATA 0xd0001414 0x00000000
> > +DATA 0xd0001418 0x00000000
> > +DATA 0xd000141c 0x00000c52
> > +DATA 0xd0001420 0x00000044
> > +DATA 0xd0001424 0x0000f1ff
> > +DATA 0xd0001428 0x00085520
> > +DATA 0xd000147c 0x00008552
> > +DATA 0xd0001504 0x0ffffff1
> > +DATA 0xd0001508 0x10000000
> > +DATA 0xd000150c 0x0ffffff5
> > +DATA 0xd0001514 0x00000000
> > +DATA 0xd000151c 0x00000000
> > +DATA 0xd0001494 0x84210000
> > +DATA 0xd0001498 0x00000000
> > +DATA 0xd000149c 0x0000f40f
> > +DATA 0xd0001480 0x00000001
> > +
> > +# End of Header extension
> > +DATA 0x0 0x0
> > diff --git a/configs/db-88f6281-bp-nand_defconfig b/configs/db-88f6281-bp-nand_defconfig
> > new file mode 100644
> > index 000000000000..6360ef5e8280
> > --- /dev/null
> > +++ b/configs/db-88f6281-bp-nand_defconfig
> > @@ -0,0 +1,53 @@
> > +CONFIG_ARM=y
> > +CONFIG_SYS_THUMB_BUILD=y
> > +CONFIG_KIRKWOOD=y
> > +CONFIG_SYS_TEXT_BASE=0x600000
> > +CONFIG_TARGET_DB_88F6281_BP=y
> > +CONFIG_IDENT_STRING="\nMarvell DB-88F6281-BP"
> > +CONFIG_NR_DRAM_BANKS=2
> > +# CONFIG_SYS_MALLOC_F is not set
> > +CONFIG_BOOTDELAY=3
> > +# CONFIG_DISPLAY_BOARDINFO is not set
> > +CONFIG_HUSH_PARSER=y
> > +CONFIG_CMD_BOOTZ=y
> > +CONFIG_CMD_DM=y
> > +# CONFIG_CMD_FLASH is not set
> > +CONFIG_CMD_IDE=y
> > +CONFIG_CMD_MMC=y
> > +CONFIG_CMD_NAND=y
> > +CONFIG_CMD_SF=y
> > +CONFIG_CMD_USB=y
> > +# CONFIG_CMD_SETEXPR is not set
> > +CONFIG_CMD_DHCP=y
> > +CONFIG_CMD_MII=y
> > +CONFIG_CMD_PING=y
> > +CONFIG_CMD_EXT2=y
> > +CONFIG_CMD_EXT4=y
> > +CONFIG_CMD_FAT=y
> > +CONFIG_CMD_JFFS2=y
> > +CONFIG_CMD_MTDPARTS=y
> > +CONFIG_MTDIDS_DEFAULT="nand0=orion_nand"
> > +CONFIG_MTDPARTS_DEFAULT="mtdparts=orion_nand:512K(uboot),512K(env),4M(kernel),-(rootfs)"
> > +CONFIG_ISO_PARTITION=y
> > +CONFIG_OF_CONTROL=y
> > +CONFIG_DEFAULT_DEVICE_TREE="kirkwood-db-88f6281"
> > +CONFIG_ENV_IS_IN_SPI_FLASH=y
> > +CONFIG_NET_RANDOM_ETHADDR=y
> > +CONFIG_DM=y
> > +CONFIG_MVSATA_IDE=y
> > +CONFIG_SPI_FLASH=y
> > +CONFIG_SPI_FLASH_STMICRO=y
> > +CONFIG_PHY_MARVELL=y
> > +CONFIG_DM_ETH=y
> > +CONFIG_MVGBE=y
> > +CONFIG_MII=y
> > +CONFIG_DM_RTC=y
> > +CONFIG_RTC_MV=y
> > +CONFIG_SYS_NS16550=y
> > +CONFIG_SPI=y
> > +CONFIG_KIRKWOOD_SPI=y
> > +CONFIG_USB=y
> > +CONFIG_USB_EHCI_HCD=y
> > +CONFIG_USB_STORAGE=y
> > +CONFIG_LZMA=y
> > +CONFIG_LZO=y
> > diff --git a/configs/db-88f6281-bp-spi_defconfig b/configs/db-88f6281-bp-spi_defconfig
> > new file mode 100644
> > index 000000000000..93e125af5b2d
> > --- /dev/null
> > +++ b/configs/db-88f6281-bp-spi_defconfig
> > @@ -0,0 +1,54 @@
> > +CONFIG_ARM=y
> > +CONFIG_SYS_THUMB_BUILD=y
> > +CONFIG_KIRKWOOD=y
> > +CONFIG_SYS_TEXT_BASE=0x600000
> > +CONFIG_TARGET_DB_88F6281_BP=y
> > +CONFIG_IDENT_STRING="\nMarvell DB-88F6281-BP"
> > +CONFIG_NR_DRAM_BANKS=2
> > +# CONFIG_SYS_MALLOC_F is not set
> > +CONFIG_BOOTDELAY=3
> > +# CONFIG_DISPLAY_BOARDINFO is not set
> > +CONFIG_HUSH_PARSER=y
> > +CONFIG_CMD_BOOTZ=y
> > +CONFIG_CMD_DM=y
> > +# CONFIG_CMD_FLASH is not set
> > +CONFIG_CMD_IDE=y
> > +CONFIG_CMD_MMC=y
> > +CONFIG_CMD_SF=y
> > +CONFIG_CMD_USB=y
> > +# CONFIG_CMD_SETEXPR is not set
> > +CONFIG_CMD_DHCP=y
> > +CONFIG_CMD_MII=y
> > +CONFIG_CMD_PING=y
> > +CONFIG_CMD_EXT2=y
> > +CONFIG_CMD_EXT4=y
> > +CONFIG_CMD_FAT=y
> > +CONFIG_CMD_JFFS2=y
> > +CONFIG_CMD_MTDPARTS=y
> > +CONFIG_MTDIDS_DEFAULT="nand0=orion_nand"
> > +CONFIG_MTDPARTS_DEFAULT="mtdparts=orion_nand:512K(uboot),512K(env),4M(kernel),-(rootfs)"
> > +CONFIG_ISO_PARTITION=y
> > +CONFIG_OF_CONTROL=y
> > +CONFIG_DEFAULT_DEVICE_TREE="kirkwood-db-88f6281-spi"
> > +CONFIG_ENV_IS_IN_SPI_FLASH=y
> > +CONFIG_NET_RANDOM_ETHADDR=y
> > +CONFIG_DM=y
> > +CONFIG_MVSATA_IDE=y
> > +CONFIG_DM_SPI_FLASH=y
> > +CONFIG_SPI_FLASH=y
> > +CONFIG_SPI_FLASH_STMICRO=y
> > +CONFIG_PHY_MARVELL=y
> > +CONFIG_DM_ETH=y
> > +CONFIG_MVGBE=y
> > +CONFIG_MII=y
> > +CONFIG_DM_RTC=y
> > +CONFIG_RTC_MV=y
> > +CONFIG_SYS_NS16550=y
> > +CONFIG_SPI=y
> > +CONFIG_DM_SPI=y
> > +CONFIG_KIRKWOOD_SPI=y
> > +CONFIG_USB=y
> > +CONFIG_USB_EHCI_HCD=y
> > +CONFIG_USB_STORAGE=y
> > +CONFIG_LZMA=y
> > +CONFIG_LZO=y
> > diff --git a/include/configs/db-88f6281-bp.h b/include/configs/db-88f6281-bp.h
> > new file mode 100644
> > index 000000000000..212983716e96
> > --- /dev/null
> > +++ b/include/configs/db-88f6281-bp.h
> > @@ -0,0 +1,109 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
> > +
> > +#ifndef _CONFIG_DB_88F6281_BP_H
> > +#define _CONFIG_DB_88F6281_BP_H
> > +
> > +/*
> > + * High Level Configuration Options (easy to change)
> > + */
> > +#define CONFIG_FEROCEON_88FR131      1       /* CPU Core subversion */
> > +#define CONFIG_KW88F6281     1       /* SOC Name */
> > +#define CONFIG_SKIP_LOWLEVEL_INIT    /* disable board lowlevel_init */
> > +#define CONFIG_SYS_TCLK              166666667
> > +#define CONFIG_SYS_KWD_CONFIG        $(CONFIG_BOARDDIR)/kwbimage.cfg
> > +#define CONFIG_BUILD_TARGET  "u-boot.kwb"
> > +
> > +/* additions for new ARM relocation support */
> > +#define CONFIG_SYS_SDRAM_BASE        0x00000000
> > +
> > +#define CONFIG_MD5   /* get_random_hex on krikwood needs MD5 support */
>
> s/krikwood/kirkwood
>
> > +#define CONFIG_KIRKWOOD_EGIGA_INIT   /* Enable GbePort0/1 for kernel */
> > +#define CONFIG_KIRKWOOD_PCIE_INIT    /* Enable PCIE Port0 */
> > +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8        /* Set RGMII Pad voltage to 1.8V */
> > +#define CONFIG_KIRKWOOD_GPIO 1
> > +
> > +/*
> > + * NS16550 Configuration
> > + */
> > +#define CONFIG_SYS_NS16550_SERIAL
> > +#define CONFIG_SYS_NS16550_REG_SIZE  (-4)
> > +#define CONFIG_SYS_NS16550_CLK               CONFIG_SYS_TCLK
> > +#define CONFIG_SYS_NS16550_COM1              KW_UART0_BASE
>
> Can't you switch to using DM_SERIAL and use the DT for this
> instead?
>

This is proving harder than anticipated. DM_SERIAL needs SYS_MALLOC_F.
Kirkwood doesn't currently have this enabled and doing so blows our
the initial stack space. I've attempted to get this going but still
running into issues. For now I will probably send v2 without this
change.

> > +
> > +#define CONFIG_SYS_MAX_NAND_DEVICE     1
> > +/*
> > + * Serial Port configuration
> > + * The following definitions let you select what serial you want to use
> > + * for your console driver.
> > + */
> > +
> > +#define CONFIG_CONS_INDEX    1       /*Console on UART0 */
>
> Nitpicking: Missing space after '*'.
>
> > +
> > +/*
> > + * For booting Linux, the board info and command line data
> > + * have to be in the first 8 MB of memory, since this is
> > + * the maximum mapped by the Linux kernel during initialization.
> > + */
> > +#define CONFIG_CMDLINE_TAG   1       /* enable passing of ATAGs */
> > +#define CONFIG_INITRD_TAG    1       /* enable INITRD tag */
> > +#define CONFIG_SETUP_MEMORY_TAGS 1   /* enable memory tag */
>
> Is this still needed for booting a modern kernel?
>
> > +
> > +/*
> > + *  Environment variables configurations
> > + */
> > +#define CONFIG_ENV_SPI_BUS           0
> > +#define CONFIG_ENV_SPI_CS            0
> > +#define CONFIG_ENV_SPI_MAX_HZ                20000000        /* 20Mhz */
> > +#define CONFIG_ENV_SPI_MODE          CONFIG_SF_DEFAULT_MODE
> > +#define CONFIG_ENV_SECT_SIZE         0x40000         /* 256K */
> > +#define CONFIG_ENV_SIZE                      0x01000
> > +#define CONFIG_ENV_OFFSET            0xC0000
> > +
> > +/*
> > + * U-Boot bootcode configuration
> > + */
> > +
> > +#define CONFIG_SYS_MONITOR_LEN               (256 << 10)     /* Reserve 256 kB for monitor */
> > +#define CONFIG_SYS_MALLOC_LEN                  (4 << 20)     /* Reserve 4.0 MB for malloc */
> > +
> > +/*
> > + * For booting Linux, the board info and command line data
> > + * have to be in the first 8 MB of memory, since this is
> > + * the maximum mapped by the Linux kernel during initialization.
> > + */
> > +#define CONFIG_SYS_BOOTMAPSZ         (8 << 20)       /* Initial Mem map for Linux*/
> > +
> > +/* size in bytes reserved for initial data */
> > +
> > +#include <asm/arch/config.h>
> > +/* There is no PHY directly connected so don't ask it for link status */
> > +#undef CONFIG_SYS_FAULT_ECHO_LINK_DOWN
> > +
> > +/*
> > + * Other required minimal configurations
> > + */
> > +#define CONFIG_ARCH_CPU_INIT /* call arch_cpu_init() */
> > +#define CONFIG_SYS_MEMTEST_START 0x00400000  /* 4M */
> > +#define CONFIG_SYS_MEMTEST_END       0x007fffff      /*(_8M -1) */
>
> Missing space after '*' and '-'. Please run checkpatch on this
> patch.
>
> > +#define CONFIG_SYS_RESET_ADDRESS 0xffff0000  /* Rst Vector Adr */
> > +
> > +/*
> > + * SDIO/MMC Card Configuration
> > + */
> > +#ifdef CONFIG_CMD_MMC
> > +#define CONFIG_MVEBU_MMC
> > +#define CONFIG_SYS_MMC_BASE KW_SDIO_BASE
> > +#endif /* CONFIG_CMD_MMC */
> > +
> > +/*
> > + * SATA Driver configuration
> > + */
> > +#ifdef CONFIG_MVSATA_IDE
> > +#define CONFIG_SYS_ATA_IDE0_OFFSET   MV_SATA_PORT0_OFFSET
> > +#endif /*CONFIG_MVSATA_IDE*/
> > +
> > +#define CONFIG_SYS_LOAD_ADDR  0x1000000      /* default location for tftp and bootm */
> > +
> > +#define CONFIG_SYS_DCACHE_OFF
>
> Why is the d-cache disabled?
>
> Thanks,
> Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board
  2019-03-13  7:00     ` Chris Packham
@ 2019-03-13  7:23       ` Stefan Roese
  0 siblings, 0 replies; 30+ messages in thread
From: Stefan Roese @ 2019-03-13  7:23 UTC (permalink / raw)
  To: u-boot

Hi Chris,

On 13.03.19 08:00, Chris Packham wrote:

<snip>

>>> +/*
>>> + * NS16550 Configuration
>>> + */
>>> +#define CONFIG_SYS_NS16550_SERIAL
>>> +#define CONFIG_SYS_NS16550_REG_SIZE  (-4)
>>> +#define CONFIG_SYS_NS16550_CLK               CONFIG_SYS_TCLK
>>> +#define CONFIG_SYS_NS16550_COM1              KW_UART0_BASE
>>
>> Can't you switch to using DM_SERIAL and use the DT for this
>> instead?
>>
> 
> This is proving harder than anticipated. DM_SERIAL needs SYS_MALLOC_F.
> Kirkwood doesn't currently have this enabled and doing so blows our
> the initial stack space. I've attempted to get this going but still
> running into issues. For now I will probably send v2 without this
> change.

Sure, please go ahead without the DM_SERIAL stuff for now. We can
definitely fix this in a follow-up patch. I just wanted to point
this out, as I stumbled over it while reviewing.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 30+ messages in thread
end of thread, other threads:[~2019-03-13  7:23 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07  8:27 [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Chris Packham
2019-03-07  8:27 ` [U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board Chris Packham
2019-03-07  9:33   ` Stefan Roese
2019-03-08  6:44     ` Chris Packham
2019-03-13  7:00     ` Chris Packham
2019-03-13  7:23       ` Stefan Roese
2019-03-07  8:27 ` [U-Boot] [PATCH v2 02/12] ARM: kirkwood: rename KW_CPU_WIN_BASE to MVEBU_CPU_WIN_BASE Chris Packham
2019-03-07 11:30   ` Stefan Roese
2019-03-07  8:27 ` [U-Boot] [PATCH v2 03/12] ARM: kirkwood: remove KW_DEFADR_PCI_IO_REMAP Chris Packham
2019-03-07 11:30   ` Stefan Roese
2019-03-07  8:27 ` [U-Boot] [PATCH v2 04/12] ARM: kirkwood: switch to using mvebu mbus Chris Packham
2019-03-07 11:34   ` Stefan Roese
2019-03-07  8:27 ` [U-Boot] [PATCH v2 05/12] ARM: kirkwood: remove kw_config_adr_windows Chris Packham
2019-03-07 11:34   ` Stefan Roese
2019-03-07  8:27 ` [U-Boot] [PATCH v2 06/12] ARM: kirkwood: enable CONFIG_DM_USB on db-88f6281-bp Chris Packham
2019-03-07 11:35   ` Stefan Roese
2019-03-07  8:28 ` [U-Boot] [PATCH v2 07/12] ARM: kirkwood: enable CONFIG_DM_USB for {dream, guru, sheeva}plug Chris Packham
2019-03-07 11:35   ` Stefan Roese
2019-03-07  8:28 ` [U-Boot] [PATCH v2 08/12] ARM: kirkwood: enable CONFIG_DM_USB for dns325 Chris Packham
2019-03-07 11:35   ` Stefan Roese
2019-03-07  8:28 ` [U-Boot] [PATCH v2 09/12] ARM: kirkwood: enable CONFIG_DM_USB for ds109 Chris Packham
2019-03-07 11:36   ` Stefan Roese
2019-03-07  8:28 ` [U-Boot] [PATCH v2 10/12] ARM: kirkwood: enable CONFIG_DM_USB for goflexhome Chris Packham
2019-03-07 11:36   ` Stefan Roese
2019-03-07  8:28 ` [U-Boot] [PATCH v2 11/12] ARM: kirkwood: enable CONFIG_DM_USB for lschlv2 and lsxhl Chris Packham
2019-03-07 11:36   ` Stefan Roese
2019-03-07  8:28 ` [U-Boot] [PATCH v2 12/12] ARM: kirkwood: enable CONFIG_DM_USB for nas220 Chris Packham
2019-03-07 11:36   ` Stefan Roese
2019-03-08 10:16 ` [U-Boot] [PATCH v2 00/12] ARM: kirkwood: migrate to DM_USB Leigh Brown
2019-03-08 20:56   ` Chris Packham

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.