From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF37CC433F5 for ; Mon, 25 Oct 2021 15:44:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6AC660F92 for ; Mon, 25 Oct 2021 15:44:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6AC660F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 35E8280F1A; Mon, 25 Oct 2021 17:44:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="H9gktRbf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2990280F1A; Mon, 25 Oct 2021 17:44:21 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1761D80F0E for ; Mon, 25 Oct 2021 17:44:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 60B4D3F332 for ; Mon, 25 Oct 2021 15:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1635176655; bh=emOiry6oG5Z7UnG3xDbrI6Ig21/gUHeD5qBf7OLKAGk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H9gktRbfxg5GEacqOAj5tMGuf1kuyhjRnD6GJ30nFRBy3L2/6zNnukLb1LX/NxYil kTF3MAiPDrHw6CsKsGVg0zgCStUsBRK3TezmBTOqmHCMIBc7SiL1roHH10f/6LVjfn Mf8jzDG7oN58x481meJY89v6SlA5zEC6y/KDMq/LU9xUchXLBgy9e6cC7sijQJgLZX 40WnAQXRp+J2ZycxEBdAk4HxBqP2ZNIIp6jrpMuxcKwNUiVK1K77bZ+UfR7WP0QLZa Qio69d3BH3ToOp1MkKurLWpFowFKwO+/f46EJATvjBcPRITdkfZwiQWzn+7tpsMmT4 2Me0m+i2ketwQ== Received: by mail-wr1-f69.google.com with SMTP id j5-20020adff005000000b001687ffb17abso1833835wro.3 for ; Mon, 25 Oct 2021 08:44:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=emOiry6oG5Z7UnG3xDbrI6Ig21/gUHeD5qBf7OLKAGk=; b=6U7p3r3X7lXXeIcAUxHgMt2tsbhOcGdGHlathlvj8S/asWOQ8FI/iUMBdcYtRzV81o N5OgfBkGDrqf2E41qdyrIjwmPvCi32lgsp4lual+p5jB6/CipDsy6whHX9g/Zyvj/3Ws d4FPiBUSoc1GWpDOOAixDBXm1kouIis+AEHP9nBGzMJYkac+8UNPT2lwFeMSmZvd3PP7 rg0rgnJw80qTjopJJE39tugqpOfCCBFDyaZf0cA4H8ngyV/YY84CpgUjaKmprtdAOkGz SCE/lji89psHEgo8Vysqvt0z1kPP7Xlm7y0KKIedHw6ktqZ43kUhD2xYowOWc5god2oj vCzA== X-Gm-Message-State: AOAM532dfpBD2rozBHTDNbhikUbsLXp/Bp5kUVDUZrZDY/OfpQGUX1Yg ivToNCnGVRNz7uAwoXRQPLgvZtg7EjzEaG2B6y8a/rENvYpsdg5Ok3xOGl6hHMjl0dfxnCh7SJj 2cgETNW6F+wcfx48eXrGx+9Dl++64Wms= X-Received: by 2002:a1c:f31a:: with SMTP id q26mr21027075wmq.148.1635176655105; Mon, 25 Oct 2021 08:44:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwM4swU3JOAsx9OSZVKYy509AeO/23Yi/pjMDyuMkL9bgry/K9Qjx35xom6BKAPTBAphgBorg== X-Received: by 2002:a1c:f31a:: with SMTP id q26mr21027054wmq.148.1635176654924; Mon, 25 Oct 2021 08:44:14 -0700 (PDT) Received: from [192.168.123.55] (ip-88-152-144-157.hsi03.unitymediagroup.de. [88.152.144.157]) by smtp.gmail.com with ESMTPSA id z6sm21162911wmp.1.2021.10.25.08.44.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 08:44:14 -0700 (PDT) Message-ID: Date: Mon, 25 Oct 2021 17:44:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH 1/1] blk: simplify blk_get_devnum_by_typename() Content-Language: en-US To: Simon Glass Cc: Patrick Delaunay , Ilias Apalodimas , U-Boot Mailing List , Tom Rini References: <20211023140647.7661-1-heinrich.schuchardt@canonical.com> <81777666-a5e1-b32b-b41e-70d894a44b94@canonical.com> From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 10/25/21 17:18, Simon Glass wrote: > Hi Heinrich, > > On Mon, 25 Oct 2021 at 02:00, Heinrich Schuchardt > wrote: >> >> On 10/25/21 09:54, Heinrich Schuchardt wrote: >>> On 10/24/21 21:54, Simon Glass wrote: >>>> Hi Heinrich, >>>> >>>> On Sat, 23 Oct 2021 at 08:06, Heinrich Schuchardt >>>> wrote: >>>>> >>>>> The block descriptor contains the if_type. There is no need to first >>>>> look >>>>> up the uclass for the if_type and then to check the parent device's >>>>> uclass >>>>> to know if the device has the correct if_type. >>>>> >>>>> Signed-off-by: Heinrich Schuchardt >>>>> --- >>>>> drivers/block/blk-uclass.c | 35 +---------------------------------- >>>>> 1 file changed, 1 insertion(+), 34 deletions(-) >>>> >>>> This seems to be heading in the wrong direction though. >>>> >>>> The IF_TYPE should really go away and be replaced with the UCLASS ID, >>>> I think. >>>> >>>> At present we have lots of calls to blk_create_device_f() which >>>> specify the type. I think we should drop the IF_TYPE_.. arg to that >>>> function and have it figured out from the uclass, in the interim. >>>> >>>> But why do we need IF_TYPE now? >>> >>> I admit that this patch is just an intermediate step. >>> >>> We can replace IF_TYPE by ULASS ID once SPL block devices are always >>> using the driver model. Have we reached this point yet? I have not seen >>> drivers/block/blk_legacy.c being deleted. >> >> qemu_malta64, qemu_malta64el, qemu_malta, qemu_maltael are examples of >> defconfigs requiring drivers/block/blk_legacy.c > > Yes, we seem to have BLK on only for MMC and USB, but malta64 (for > example) uses IDE. > > The problem seems to be HAVE_BLOCK_DEVICE which should not be used. > > +Tom Rini > > Should we remove HAVE_BLOCK_DEVICE at this point, or make it depend on BROKEN? > >> >> Best regards >> >> Heinrich >> >>> >>> Removing if_type_uclass_id[] is anyway on the right path. > > Are you sure? Instead, could we use the uclass ID in more places? Yes, you want to get rid of if_type. This means the table will become obsolete. Once the legacy drivers are removed we can replace all occurrences of if_type by uclass_id. That uclass_id we should not take from blk_desc but from udevice. Best regards Heinrich > > Regards, > Simon >