From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAF2DECAAD8 for ; Fri, 16 Sep 2022 08:56:13 +0000 (UTC) Received: from localhost ([::1]:58752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ78u-0002Yu-OG for qemu-devel@archiver.kernel.org; Fri, 16 Sep 2022 04:56:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ6wR-00019G-Q7; Fri, 16 Sep 2022 04:43:20 -0400 Received: from forwardcorp1j.mail.yandex.net ([2a02:6b8:0:1619::183]:35310) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ6wN-0004DO-J3; Fri, 16 Sep 2022 04:43:17 -0400 Received: from vla5-b2806cb321eb.qloud-c.yandex.net (vla5-b2806cb321eb.qloud-c.yandex.net [IPv6:2a02:6b8:c18:3e0d:0:640:b280:6cb3]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id D7A7F2E09A3; Fri, 16 Sep 2022 11:42:54 +0300 (MSK) Received: from [IPV6:2a02:6b8:b081:b709::1:2b] (unknown [2a02:6b8:b081:b709::1:2b]) by vla5-b2806cb321eb.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id JYPRhRddvx-gsO4hLeW; Fri, 16 Sep 2022 11:42:54 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1663317774; bh=094pGJJwVzcP0q+jyAM87qMbcq3CZW2i7iv23qNACvo=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=jYyiJVZhtmiNnZ3kQ39ZQsORCnzDvq091+u6KMnABjJQu9nmNULFctsOooSehmMZm W+1NuTNFSXqj2SJKKMdWjF0p1RAhqwj00p+RLNvdqlVCSJXlviOPwjzaRYSCC+IQMu qwxBbDRpkCmdjm/gax7ZZDay1gijgGi/JvIectVg= Authentication-Results: vla5-b2806cb321eb.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru Message-ID: Date: Fri, 16 Sep 2022 11:42:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 12/27] qapi job: Elide redundant has_FOO in generated C Content-Language: en-US To: Markus Armbruster , qemu-devel@nongnu.org Cc: michael.roth@amd.com, jsnow@redhat.com, eblake@redhat.com, qemu-block@nongnu.org References: <20220915204317.3766007-1-armbru@redhat.com> <20220915204317.3766007-13-armbru@redhat.com> From: Vladimir Sementsov-Ogievskiy In-Reply-To: <20220915204317.3766007-13-armbru@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a02:6b8:0:1619::183; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1j.mail.yandex.net X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.816, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/15/22 23:43, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by step. This is the step for qapi/job.json. > > Said commit explains the transformation in more detail. The invariant > violations mentioned there do not occur here. > > Cc: John Snow > Cc: Vladimir Sementsov-Ogievskiy > Cc:qemu-block@nongnu.org > Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir