From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v6 4/5] iFPGA: add meson build Date: Thu, 3 May 2018 14:43:16 +0530 Message-ID: References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com> <1524735793-37302-1-git-send-email-rosen.xu@intel.com> <1524735793-37302-5-git-send-email-rosen.xu@intel.com> <00c327e5-4032-1274-a523-94bec7054065@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "Doherty, Declan" , "Richardson, Bruce" , "Ananyev, Konstantin" , "Wu, Hao" , "gaetan.rivet@6wind.com" To: "Zhang, Tianfei" , "Xu, Rosen" , "dev@dpdk.org" , "Yigit, Ferruh" Return-path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01hn0220.outbound.protection.outlook.com [104.47.1.220]) by dpdk.org (Postfix) with ESMTP id 19E0C20BD for ; Thu, 3 May 2018 10:57:07 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wednesday 02 May 2018 07:06 PM, Zhang, Tianfei wrote: > >> -----Original Message----- >> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com] >> Sent: Wednesday, May 2, 2018 5:47 PM >> To: Xu, Rosen ; dev@dpdk.org; Yigit, Ferruh >> >> Cc: Doherty, Declan ; Richardson, Bruce >> ; Ananyev, Konstantin >> ; Zhang, Tianfei ; >> Wu, Hao ; gaetan.rivet@6wind.com >> Subject: Re: [dpdk-dev] [PATCH v6 4/5] iFPGA: add meson build >> >> On Thursday 26 April 2018 03:13 PM, Xu, Rosen wrote: >>> From: Figo Zhang >>> >>> add meson build support for iFPGA driver. >>> >>> Signed-off-by: Figo Zhang >>> --- >>> drivers/meson.build | 3 ++- >>> drivers/raw/ifpga_rawdev/base/meson.build | 34 >> +++++++++++++++++++++++++++++++ >>> drivers/raw/ifpga_rawdev/meson.build | 13 ++++++++++++ >>> drivers/raw/meson.build | 6 ++++++ >>> 4 files changed, 55 insertions(+), 1 deletion(-) >>> create mode 100644 drivers/raw/ifpga_rawdev/base/meson.build >>> create mode 100644 drivers/raw/ifpga_rawdev/meson.build >>> create mode 100644 drivers/raw/meson.build >>> >>> diff --git a/drivers/meson.build b/drivers/meson.build index >>> b146f09..b7fc0d6 100644 >>> --- a/drivers/meson.build >>> +++ b/drivers/meson.build >>> @@ -7,7 +7,8 @@ driver_classes = ['common', >>> 'mempool', # depends on common and bus. >>> 'net', # depends on common, bus and mempool. >>> 'crypto', # depends on common, bus and mempool (net >> in future). >>> - 'event'] # depends on common, bus, mempool and net. >>> + 'event', # depends on common, bus, mempool and net. >>> + 'raw'] >>> >>> foreach class:driver_classes >>> drivers = [] >> >> [...] >> >>> diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build new >>> file mode 100644 index 0000000..410f908 >>> --- /dev/null >>> +++ b/drivers/raw/meson.build >>> @@ -0,0 +1,6 @@ >>> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel >>> +Corporation >>> + >>> +drivers = ['ifpga_rawdev'] >>> +config_flag_fmt = 'RTE_LIBRTE_@0@_PMD' >>> +driver_name_fmt = 'rte_@0@' >>> >> >> Just a heads-up for Thomas/Ferruh: Either this or patches from Nipun [1] >> would conflict here as drivers/raw/meson.build is being introduced by both. >> >> [1] http://dpdk.org/ml/archives/dev/2018-April/098827.html > > Thomas and Ferruh's patch has merged into mainline? > We will rebase to latest master branch and send the V7 patches soon. > In the weekly call, it was decided that qdma patches are almost ready. So, can you rebase your patches over that? You will have to remove the drivers/raw/meson.build and add your entry into the one added by qdma driver [1]. You might have to wait for a couple of days. [1] http://dpdk.org/ml/archives/dev/2018-May/099836.html