From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E9A7C433F5 for ; Wed, 11 May 2022 08:21:48 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.326584.549133 (Exim 4.92) (envelope-from ) id 1nohbB-00031a-Ce; Wed, 11 May 2022 08:21:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326584.549133; Wed, 11 May 2022 08:21:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohbB-00031T-9p; Wed, 11 May 2022 08:21:33 +0000 Received: by outflank-mailman (input) for mailman id 326584; Wed, 11 May 2022 08:21:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohb9-000310-L1 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 08:21:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohb7-0001v5-DZ; Wed, 11 May 2022 08:21:29 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nohb7-00026r-6i; Wed, 11 May 2022 08:21:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=cVuT8BsUmJCkpTwqIIBhTI5zdEZNHzUDxqOAo5Nra78=; b=uSn4LTxTdLWRY3sLQUzuo8UBPW qH0Rf2ez0CRe+WbempgARnDJRtHALah2Hi0wszEhbVm3ZX5QJqc6MqfOUAmzdpxYEe291KExEH3NK mlfaUsagmYg6WvaZvQQ6d3hq3XRuO6MBbw+nwM6QAql0b8y+59hEL8TxuJSO0E+1En68=; Message-ID: Date: Wed, 11 May 2022 09:21:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap To: Stefano Stabellini Cc: Andrew Cooper , Lin Liu , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Bertrand Marquis References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <00d82608-9430-6b20-26b5-207c62358179@srcf.net> <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> <2f5b0e01-2214-6150-bef2-e4f92cebd6ef@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 11/05/2022 04:12, Stefano Stabellini wrote: > Alternatively, I also think that taking this patch as is without > alignment fix (either using be16_to_cpu or be16_to_cpup) is fine. The > alignment could be fixed afterwards. The key is that I think it should > be one of the maintainers to write the follow-up fix. Both of you are > very fast coders and would certainly finish the patch before finishing > the explanation on what needs to be done, which then would need to be > understood and implemented by the contributor (opportunity for > misunderstandings), and verified again by the reviewer on v2. That would > take an order of magnitude more of collective time and effort. I am happy to write a follow-up patch so long be16_to_cpup() (& co) are kept (because this is where I want to fix this issue so it is done for everyone). Cheers, -- Julien Grall