From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AFC0C761AF for ; Mon, 27 Mar 2023 13:02:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232547AbjC0NC4 (ORCPT ); Mon, 27 Mar 2023 09:02:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232542AbjC0NCw (ORCPT ); Mon, 27 Mar 2023 09:02:52 -0400 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AED2CD; Mon, 27 Mar 2023 06:02:32 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 01DFD582160; Mon, 27 Mar 2023 09:02:29 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 27 Mar 2023 09:02:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=Y61mr9XUfXVFhUlJdoF8OWNZ1qM6LGTHSqUwPXey+5SLhbXuszz IX4F35TzFt8tNJqu3TdHQy42BVXRNe3bcFUV8/zj9nSivnmtuzQXp6yIK2l3HJtv arNn0qdsSFaxnf2jpGCdO42ZY/Yo7maZ9JJxQnYT9zQ6fDNdG0CMXLPJSTiBiuYc DxowTYLJD3TZAMG+gAP8IaltLqnFWdByE0RMezkwvVUj8PXoa7+fgC1mMOdcybmk FOSp8xBGb8i1lrklfr+C8l8mm7z3rZwyVo/iOqMqn8kIsrxCMYlMByaiI+EkJOfO AksZxvdJBavSBPl8RAWIMzvbBRTXG6xIPuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=S8t3E1mZSSbesGBfIrPg8iez5iynYZ434j4/P/C+PFUpzIj6OWt K13vVMOr45Pq/x54idE06yYJdGJHsAgbut8cysdL7NSE20F2ZB97nGf6sGl0XtnJ 9XT1e/v2R2VMawWFs9cAUtCqiZnEUzvQi5oNF6VrsD0uvg+IwkaMgefkI++oVxUX P6oUU+TSxGqMMY77icyCim+29Cz39zEK5CEbEi/5s9/A6kWKWjnkM9cNn+OZr9OG +PTT8iBaVt9Y7UzKaNo9juS2P9bsmSmnzuVEEp99tvwuhj8CNT8gHrMIM+y46L5g RgKT+E9GeicOtbPmieJjqHY7nt82g7IMpvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegfeejhedvledvffeijeeijeeivddvhfeliedvleevheejleetgedukedt gfejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 75C74B60086; Mon, 27 Mar 2023 09:02:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-236-g06c0f70e43-fm-20230313.001-g06c0f70e Mime-Version: 1.0 Message-Id: In-Reply-To: <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> References: <20230327121317.4081816-1-arnd@kernel.org> <20230327121317.4081816-7-arnd@kernel.org> <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> Date: Mon, 27 Mar 2023 15:02:04 +0200 From: "Arnd Bergmann" To: "Christophe Leroy" , "Arnd Bergmann" , "linux-kernel@vger.kernel.org" Cc: "Vineet Gupta" , "Russell King" , "Neil Armstrong" , "Linus Walleij" , "Catalin Marinas" , "Will Deacon" , guoren , "Brian Cain" , "Geert Uytterhoeven" , "Michal Simek" , "Thomas Bogendoerfer" , "Dinh Nguyen" , "Stafford Horne" , "Helge Deller" , "Michael Ellerman" , "Paul Walmsley" , "Palmer Dabbelt" , "Rich Felker" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Max Filippov" , "Christoph Hellwig" , "Robin Murphy" , "Lad, Prabhakar" , "Conor.Dooley" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-oxnas@groups.io" , "linux-csky@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linux-openrisc@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" Subject: Re: [PATCH 06/21] powerpc: dma-mapping: minimize for_cpu flushing Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Mon, Mar 27, 2023, at 14:56, Christophe Leroy wrote: > Le 27/03/2023 =C3=A0 14:13, Arnd Bergmann a =C3=A9crit=C2=A0: >> From: Arnd Bergmann >>=20 >> The powerpc dma_sync_*_for_cpu() variants do more flushes than on oth= er >> architectures. Reduce it to what everyone else does: >>=20 >> - No flush is needed after data has been sent to a device >>=20 >> - When data has been received from a device, the cache only needs to >> be invalidated to clear out cache lines that were speculatively >> prefetched. >>=20 >> In particular, the second flushing of partial cache lines of bidirect= ional >> buffers is actively harmful -- if a single cache line is written by b= oth >> the CPU and the device, flushing it again does not maintain coherency >> but instead overwrite the data that was just received from the device. > > Hum ..... Who is right ? > > That behaviour was introduced by commit 03d70617b8a7 ("powerpc: Preven= t=20 > memory corruption due to cache invalidation of unaligned DMA buffer") > > I think your commit log should explain why that commit was wrong, and=20 > maybe say that your patch is a revert of that commit ? Ok, I'll try to explain this better. To clarify here: the __dma_sync() function in commit 03d70617b8a7 is used both before and after a DMA, but my patch 05/21 splits this in two, and patch 06/21 only changes the part that gets called after the DMA-from-device but leaves the part before DMA-from-device unchanged, which Andrew's patch addressed. As I mentioned in the cover letter, it is still unclear whether we want to consider this the expected behavior as the documentation seems unclear, but my series does not attempt to answer that question. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07164C7619A for ; Mon, 27 Mar 2023 13:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=foINxHA1nBKViHuY9q6EMYcI/PyWa1+M4nTKsseHmgA=; b=aPvZ0Mpd7rDdFJ Ya2vdH20j9TvXaCO/a0O8eqkprr7iEg84poAQFHlJUPMNJWeFWF/EKio1Uw2+XPKKw1oQyF9pDyOM ow6aHajiraWflL6EPIcpGGrDYLxgb+DwPCELJpKNqvqEP9EdLdT/CsAecbtPE9LcW8uwYmnW+osfV yoZtcnbcEVPC9QJfbXt3vDZt7YPloOu1JTUjCsPxz3T2XbbNH/I54X2/oQ9djA/exlTBUNXgSiSxv k7Y2YaOL4aUwYdvI01/uJduaVfJJvBe/cz39nmT6wbCvCLJGIWhGNrwuvuO6qfn05w4KZAsSEhRDV 27zdtgKrL3vcuTnCzo6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgmUl-00B2u4-29; Mon, 27 Mar 2023 13:02:43 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgmUe-00B2ok-0y; Mon, 27 Mar 2023 13:02:40 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 01DFD582160; Mon, 27 Mar 2023 09:02:29 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 27 Mar 2023 09:02:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=Y61mr9XUfXVFhUlJdoF8OWNZ1qM6LGTHSqUwPXey+5SLhbXuszz IX4F35TzFt8tNJqu3TdHQy42BVXRNe3bcFUV8/zj9nSivnmtuzQXp6yIK2l3HJtv arNn0qdsSFaxnf2jpGCdO42ZY/Yo7maZ9JJxQnYT9zQ6fDNdG0CMXLPJSTiBiuYc DxowTYLJD3TZAMG+gAP8IaltLqnFWdByE0RMezkwvVUj8PXoa7+fgC1mMOdcybmk FOSp8xBGb8i1lrklfr+C8l8mm7z3rZwyVo/iOqMqn8kIsrxCMYlMByaiI+EkJOfO AksZxvdJBavSBPl8RAWIMzvbBRTXG6xIPuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=S8t3E1mZSSbesGBfIrPg8iez5iynYZ434j4/P/C+PFUpzIj6OWt K13vVMOr45Pq/x54idE06yYJdGJHsAgbut8cysdL7NSE20F2ZB97nGf6sGl0XtnJ 9XT1e/v2R2VMawWFs9cAUtCqiZnEUzvQi5oNF6VrsD0uvg+IwkaMgefkI++oVxUX P6oUU+TSxGqMMY77icyCim+29Cz39zEK5CEbEi/5s9/A6kWKWjnkM9cNn+OZr9OG +PTT8iBaVt9Y7UzKaNo9juS2P9bsmSmnzuVEEp99tvwuhj8CNT8gHrMIM+y46L5g RgKT+E9GeicOtbPmieJjqHY7nt82g7IMpvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegfeejhedvledvffeijeeijeeivddvhfeliedvleevheejleetgedukedt gfejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 75C74B60086; Mon, 27 Mar 2023 09:02:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-236-g06c0f70e43-fm-20230313.001-g06c0f70e Mime-Version: 1.0 Message-Id: In-Reply-To: <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> References: <20230327121317.4081816-1-arnd@kernel.org> <20230327121317.4081816-7-arnd@kernel.org> <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> Date: Mon, 27 Mar 2023 15:02:04 +0200 From: "Arnd Bergmann" To: "Christophe Leroy" , "Arnd Bergmann" , "linux-kernel@vger.kernel.org" Cc: "Vineet Gupta" , "Russell King" , "Neil Armstrong" , "Linus Walleij" , "Catalin Marinas" , "Will Deacon" , guoren , "Brian Cain" , "Geert Uytterhoeven" , "Michal Simek" , "Thomas Bogendoerfer" , "Dinh Nguyen" , "Stafford Horne" , "Helge Deller" , "Michael Ellerman" , "Paul Walmsley" , "Palmer Dabbelt" , "Rich Felker" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Max Filippov" , "Christoph Hellwig" , "Robin Murphy" , "Lad, Prabhakar" , "Conor.Dooley" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-oxnas@groups.io" , "linux-csky@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linux-openrisc@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" Subject: Re: [PATCH 06/21] powerpc: dma-mapping: minimize for_cpu flushing X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230327_060237_112206_912B4D7C X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMjcsIDIwMjMsIGF0IDE0OjU2LCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgo+ IExlIDI3LzAzLzIwMjMgw6AgMTQ6MTMsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPj4gRnJv bTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPj4gCj4+IFRoZSBwb3dlcnBjIGRtYV9z eW5jXypfZm9yX2NwdSgpIHZhcmlhbnRzIGRvIG1vcmUgZmx1c2hlcyB0aGFuIG9uIG90aGVyCj4+ IGFyY2hpdGVjdHVyZXMuIFJlZHVjZSBpdCB0byB3aGF0IGV2ZXJ5b25lIGVsc2UgZG9lczoKPj4g Cj4+ICAgLSBObyBmbHVzaCBpcyBuZWVkZWQgYWZ0ZXIgZGF0YSBoYXMgYmVlbiBzZW50IHRvIGEg ZGV2aWNlCj4+IAo+PiAgIC0gV2hlbiBkYXRhIGhhcyBiZWVuIHJlY2VpdmVkIGZyb20gYSBkZXZp Y2UsIHRoZSBjYWNoZSBvbmx5IG5lZWRzIHRvCj4+ICAgICBiZSBpbnZhbGlkYXRlZCB0byBjbGVh ciBvdXQgY2FjaGUgbGluZXMgdGhhdCB3ZXJlIHNwZWN1bGF0aXZlbHkKPj4gICAgIHByZWZldGNo ZWQuCj4+IAo+PiBJbiBwYXJ0aWN1bGFyLCB0aGUgc2Vjb25kIGZsdXNoaW5nIG9mIHBhcnRpYWwg Y2FjaGUgbGluZXMgb2YgYmlkaXJlY3Rpb25hbAo+PiBidWZmZXJzIGlzIGFjdGl2ZWx5IGhhcm1m dWwgLS0gaWYgYSBzaW5nbGUgY2FjaGUgbGluZSBpcyB3cml0dGVuIGJ5IGJvdGgKPj4gdGhlIENQ VSBhbmQgdGhlIGRldmljZSwgZmx1c2hpbmcgaXQgYWdhaW4gZG9lcyBub3QgbWFpbnRhaW4gY29o ZXJlbmN5Cj4+IGJ1dCBpbnN0ZWFkIG92ZXJ3cml0ZSB0aGUgZGF0YSB0aGF0IHdhcyBqdXN0IHJl Y2VpdmVkIGZyb20gdGhlIGRldmljZS4KPgo+IEh1bSAuLi4uLiBXaG8gaXMgcmlnaHQgPwo+Cj4g VGhhdCBiZWhhdmlvdXIgd2FzIGludHJvZHVjZWQgYnkgY29tbWl0IDAzZDcwNjE3YjhhNyAoInBv d2VycGM6IFByZXZlbnQgCj4gbWVtb3J5IGNvcnJ1cHRpb24gZHVlIHRvIGNhY2hlIGludmFsaWRh dGlvbiBvZiB1bmFsaWduZWQgRE1BIGJ1ZmZlciIpCj4KPiBJIHRoaW5rIHlvdXIgY29tbWl0IGxv ZyBzaG91bGQgZXhwbGFpbiB3aHkgdGhhdCBjb21taXQgd2FzIHdyb25nLCBhbmQgCj4gbWF5YmUg c2F5IHRoYXQgeW91ciBwYXRjaCBpcyBhIHJldmVydCBvZiB0aGF0IGNvbW1pdCA/CgpPaywgSSds bCB0cnkgdG8gZXhwbGFpbiB0aGlzIGJldHRlci4gVG8gY2xhcmlmeSBoZXJlOiB0aGUgX19kbWFf c3luYygpCmZ1bmN0aW9uIGluIGNvbW1pdCAwM2Q3MDYxN2I4YTcgaXMgdXNlZCBib3RoIGJlZm9y ZSBhbmQgYWZ0ZXIgYSBETUEsCmJ1dCBteSBwYXRjaCAwNS8yMSBzcGxpdHMgdGhpcyBpbiB0d28s IGFuZCBwYXRjaCAwNi8yMSBvbmx5IGNoYW5nZXMKdGhlIHBhcnQgdGhhdCBnZXRzIGNhbGxlZCBh ZnRlciB0aGUgRE1BLWZyb20tZGV2aWNlIGJ1dCBsZWF2ZXMgdGhlCnBhcnQgYmVmb3JlIERNQS1m cm9tLWRldmljZSB1bmNoYW5nZWQsIHdoaWNoIEFuZHJldydzIHBhdGNoCmFkZHJlc3NlZC4KCkFz IEkgbWVudGlvbmVkIGluIHRoZSBjb3ZlciBsZXR0ZXIsIGl0IGlzIHN0aWxsIHVuY2xlYXIgd2hl dGhlcgp3ZSB3YW50IHRvIGNvbnNpZGVyIHRoaXMgdGhlIGV4cGVjdGVkIGJlaGF2aW9yIGFzIHRo ZSBkb2N1bWVudGF0aW9uCnNlZW1zIHVuY2xlYXIsIGJ1dCBteSBzZXJpZXMgZG9lcyBub3QgYXR0 ZW1wdCB0byBhbnN3ZXIgdGhhdApxdWVzdGlvbi4KCiAgICAgQXJuZAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0 CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F401C76195 for ; Mon, 27 Mar 2023 13:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a3ypSwu1uP3QouMJ+boN1m51drw2rBYbnLKv/Zvbx2k=; b=MbFAhWHmM7mAEE tH8TxznjKoZqSxtJFimMhIDhH+OiCXLZ8gmP80onLKqJDGgc5+D2Pp2n+eIokCHQ+FN3yQR7gh0D2 FQQ6nUBoS5h+3sIHeBdwad6BgYCGMB7GvRGkvAHNcVMa9w0gz1bP56QH62kmrdSX6j/LtSi37g1oV b9ScEBFuBZVYFhRy/J/SYe7NkXmT72Zm75IuFkW/s6K/VVn9i7h8FMv1XAP6iVWQ0o5lfreMQEQsK l7SMZEna4UjbSp7bsIMBhXP6Ue10n293U4Zfhcb1iGDMXWpDq5tJMsmho/90E3DhJeh+Wf/p8P1zN xBvy8DKrImZSV2Ldk3PA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgmUm-00B2ui-0T; Mon, 27 Mar 2023 13:02:44 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgmUe-00B2ok-0y; Mon, 27 Mar 2023 13:02:40 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 01DFD582160; Mon, 27 Mar 2023 09:02:29 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 27 Mar 2023 09:02:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=Y61mr9XUfXVFhUlJdoF8OWNZ1qM6LGTHSqUwPXey+5SLhbXuszz IX4F35TzFt8tNJqu3TdHQy42BVXRNe3bcFUV8/zj9nSivnmtuzQXp6yIK2l3HJtv arNn0qdsSFaxnf2jpGCdO42ZY/Yo7maZ9JJxQnYT9zQ6fDNdG0CMXLPJSTiBiuYc DxowTYLJD3TZAMG+gAP8IaltLqnFWdByE0RMezkwvVUj8PXoa7+fgC1mMOdcybmk FOSp8xBGb8i1lrklfr+C8l8mm7z3rZwyVo/iOqMqn8kIsrxCMYlMByaiI+EkJOfO AksZxvdJBavSBPl8RAWIMzvbBRTXG6xIPuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=S8t3E1mZSSbesGBfIrPg8iez5iynYZ434j4/P/C+PFUpzIj6OWt K13vVMOr45Pq/x54idE06yYJdGJHsAgbut8cysdL7NSE20F2ZB97nGf6sGl0XtnJ 9XT1e/v2R2VMawWFs9cAUtCqiZnEUzvQi5oNF6VrsD0uvg+IwkaMgefkI++oVxUX P6oUU+TSxGqMMY77icyCim+29Cz39zEK5CEbEi/5s9/A6kWKWjnkM9cNn+OZr9OG +PTT8iBaVt9Y7UzKaNo9juS2P9bsmSmnzuVEEp99tvwuhj8CNT8gHrMIM+y46L5g RgKT+E9GeicOtbPmieJjqHY7nt82g7IMpvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegfeejhedvledvffeijeeijeeivddvhfeliedvleevheejleetgedukedt gfejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 75C74B60086; Mon, 27 Mar 2023 09:02:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-236-g06c0f70e43-fm-20230313.001-g06c0f70e Mime-Version: 1.0 Message-Id: In-Reply-To: <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> References: <20230327121317.4081816-1-arnd@kernel.org> <20230327121317.4081816-7-arnd@kernel.org> <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> Date: Mon, 27 Mar 2023 15:02:04 +0200 From: "Arnd Bergmann" To: "Christophe Leroy" , "Arnd Bergmann" , "linux-kernel@vger.kernel.org" Cc: "Vineet Gupta" , "Russell King" , "Neil Armstrong" , "Linus Walleij" , "Catalin Marinas" , "Will Deacon" , guoren , "Brian Cain" , "Geert Uytterhoeven" , "Michal Simek" , "Thomas Bogendoerfer" , "Dinh Nguyen" , "Stafford Horne" , "Helge Deller" , "Michael Ellerman" , "Paul Walmsley" , "Palmer Dabbelt" , "Rich Felker" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Max Filippov" , "Christoph Hellwig" , "Robin Murphy" , "Lad, Prabhakar" , "Conor.Dooley" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-oxnas@groups.io" , "linux-csky@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linux-openrisc@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" Subject: Re: [PATCH 06/21] powerpc: dma-mapping: minimize for_cpu flushing X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230327_060237_112206_912B4D7C X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMjcsIDIwMjMsIGF0IDE0OjU2LCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgo+ IExlIDI3LzAzLzIwMjMgw6AgMTQ6MTMsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPj4gRnJv bTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPj4gCj4+IFRoZSBwb3dlcnBjIGRtYV9z eW5jXypfZm9yX2NwdSgpIHZhcmlhbnRzIGRvIG1vcmUgZmx1c2hlcyB0aGFuIG9uIG90aGVyCj4+ IGFyY2hpdGVjdHVyZXMuIFJlZHVjZSBpdCB0byB3aGF0IGV2ZXJ5b25lIGVsc2UgZG9lczoKPj4g Cj4+ICAgLSBObyBmbHVzaCBpcyBuZWVkZWQgYWZ0ZXIgZGF0YSBoYXMgYmVlbiBzZW50IHRvIGEg ZGV2aWNlCj4+IAo+PiAgIC0gV2hlbiBkYXRhIGhhcyBiZWVuIHJlY2VpdmVkIGZyb20gYSBkZXZp Y2UsIHRoZSBjYWNoZSBvbmx5IG5lZWRzIHRvCj4+ICAgICBiZSBpbnZhbGlkYXRlZCB0byBjbGVh ciBvdXQgY2FjaGUgbGluZXMgdGhhdCB3ZXJlIHNwZWN1bGF0aXZlbHkKPj4gICAgIHByZWZldGNo ZWQuCj4+IAo+PiBJbiBwYXJ0aWN1bGFyLCB0aGUgc2Vjb25kIGZsdXNoaW5nIG9mIHBhcnRpYWwg Y2FjaGUgbGluZXMgb2YgYmlkaXJlY3Rpb25hbAo+PiBidWZmZXJzIGlzIGFjdGl2ZWx5IGhhcm1m dWwgLS0gaWYgYSBzaW5nbGUgY2FjaGUgbGluZSBpcyB3cml0dGVuIGJ5IGJvdGgKPj4gdGhlIENQ VSBhbmQgdGhlIGRldmljZSwgZmx1c2hpbmcgaXQgYWdhaW4gZG9lcyBub3QgbWFpbnRhaW4gY29o ZXJlbmN5Cj4+IGJ1dCBpbnN0ZWFkIG92ZXJ3cml0ZSB0aGUgZGF0YSB0aGF0IHdhcyBqdXN0IHJl Y2VpdmVkIGZyb20gdGhlIGRldmljZS4KPgo+IEh1bSAuLi4uLiBXaG8gaXMgcmlnaHQgPwo+Cj4g VGhhdCBiZWhhdmlvdXIgd2FzIGludHJvZHVjZWQgYnkgY29tbWl0IDAzZDcwNjE3YjhhNyAoInBv d2VycGM6IFByZXZlbnQgCj4gbWVtb3J5IGNvcnJ1cHRpb24gZHVlIHRvIGNhY2hlIGludmFsaWRh dGlvbiBvZiB1bmFsaWduZWQgRE1BIGJ1ZmZlciIpCj4KPiBJIHRoaW5rIHlvdXIgY29tbWl0IGxv ZyBzaG91bGQgZXhwbGFpbiB3aHkgdGhhdCBjb21taXQgd2FzIHdyb25nLCBhbmQgCj4gbWF5YmUg c2F5IHRoYXQgeW91ciBwYXRjaCBpcyBhIHJldmVydCBvZiB0aGF0IGNvbW1pdCA/CgpPaywgSSds bCB0cnkgdG8gZXhwbGFpbiB0aGlzIGJldHRlci4gVG8gY2xhcmlmeSBoZXJlOiB0aGUgX19kbWFf c3luYygpCmZ1bmN0aW9uIGluIGNvbW1pdCAwM2Q3MDYxN2I4YTcgaXMgdXNlZCBib3RoIGJlZm9y ZSBhbmQgYWZ0ZXIgYSBETUEsCmJ1dCBteSBwYXRjaCAwNS8yMSBzcGxpdHMgdGhpcyBpbiB0d28s IGFuZCBwYXRjaCAwNi8yMSBvbmx5IGNoYW5nZXMKdGhlIHBhcnQgdGhhdCBnZXRzIGNhbGxlZCBh ZnRlciB0aGUgRE1BLWZyb20tZGV2aWNlIGJ1dCBsZWF2ZXMgdGhlCnBhcnQgYmVmb3JlIERNQS1m cm9tLWRldmljZSB1bmNoYW5nZWQsIHdoaWNoIEFuZHJldydzIHBhdGNoCmFkZHJlc3NlZC4KCkFz IEkgbWVudGlvbmVkIGluIHRoZSBjb3ZlciBsZXR0ZXIsIGl0IGlzIHN0aWxsIHVuY2xlYXIgd2hl dGhlcgp3ZSB3YW50IHRvIGNvbnNpZGVyIHRoaXMgdGhlIGV4cGVjdGVkIGJlaGF2aW9yIGFzIHRo ZSBkb2N1bWVudGF0aW9uCnNlZW1zIHVuY2xlYXIsIGJ1dCBteSBzZXJpZXMgZG9lcyBub3QgYXR0 ZW1wdCB0byBhbnN3ZXIgdGhhdApxdWVzdGlvbi4KCiAgICAgQXJuZAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtc25wcy1hcmMgbWFpbGluZyBs aXN0CmxpbnV4LXNucHMtYXJjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1zbnBzLWFyYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 382BAC7619A for ; Mon, 27 Mar 2023 13:03:37 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PlY0R5Kd9z3bg5 for ; Tue, 28 Mar 2023 00:03:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm1 header.b=Y61mr9XU; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=S8t3E1mZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arndb.de (client-ip=66.111.4.224; helo=new2-smtp.messagingengine.com; envelope-from=arnd@arndb.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm1 header.b=Y61mr9XU; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=S8t3E1mZ; dkim-atps=neutral Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PlXzG42JDz2xZp for ; Tue, 28 Mar 2023 00:02:33 +1100 (AEDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 01DFD582160; Mon, 27 Mar 2023 09:02:29 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 27 Mar 2023 09:02:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=Y61mr9XUfXVFhUlJdoF8OWNZ1qM6LGTHSqUwPXey+5SLhbXuszz IX4F35TzFt8tNJqu3TdHQy42BVXRNe3bcFUV8/zj9nSivnmtuzQXp6yIK2l3HJtv arNn0qdsSFaxnf2jpGCdO42ZY/Yo7maZ9JJxQnYT9zQ6fDNdG0CMXLPJSTiBiuYc DxowTYLJD3TZAMG+gAP8IaltLqnFWdByE0RMezkwvVUj8PXoa7+fgC1mMOdcybmk FOSp8xBGb8i1lrklfr+C8l8mm7z3rZwyVo/iOqMqn8kIsrxCMYlMByaiI+EkJOfO AksZxvdJBavSBPl8RAWIMzvbBRTXG6xIPuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=S8t3E1mZSSbesGBfIrPg8iez5iynYZ434j4/P/C+PFUpzIj6OWt K13vVMOr45Pq/x54idE06yYJdGJHsAgbut8cysdL7NSE20F2ZB97nGf6sGl0XtnJ 9XT1e/v2R2VMawWFs9cAUtCqiZnEUzvQi5oNF6VrsD0uvg+IwkaMgefkI++oVxUX P6oUU+TSxGqMMY77icyCim+29Cz39zEK5CEbEi/5s9/A6kWKWjnkM9cNn+OZr9OG +PTT8iBaVt9Y7UzKaNo9juS2P9bsmSmnzuVEEp99tvwuhj8CNT8gHrMIM+y46L5g RgKT+E9GeicOtbPmieJjqHY7nt82g7IMpvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegfeejhedvledvffeijeeijeeivddvhfeliedvleevheejleetgedukedt gfejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 75C74B60086; Mon, 27 Mar 2023 09:02:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-236-g06c0f70e43-fm-20230313.001-g06c0f70e Mime-Version: 1.0 Message-Id: In-Reply-To: <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> References: <20230327121317.4081816-1-arnd@kernel.org> <20230327121317.4081816-7-arnd@kernel.org> <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> Date: Mon, 27 Mar 2023 15:02:04 +0200 From: "Arnd Bergmann" To: "Christophe Leroy" , "Arnd Bergmann" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 06/21] powerpc: dma-mapping: minimize for_cpu flushing Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , "linux-sh@vger.kernel.org" , Catalin Marinas , Linus Walleij , John Paul Adrian Glaubitz , Max Filippov , "Conor.Dooley" , guoren , "sparclinux@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Will Deacon , Christoph Hellwig , Helge Deller , Russell King , "linux-csky@vger.kernel.org" , Geert Uytterhoeven , Vineet Gupta , "linux-snps-arc@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , Brian Cain , "Lad, Prabhakar" , "linux-m68k@lists.linux-m68k.org" , Paul Walmsley , Stafford Horne , "linux-arm-kernel@lists.infradead.org" , Neil Armstrong , Michal Simek , Thomas Bogendoerfer , "linux-parisc@vger.kernel.org" , "linux-openrisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-mips@vger.kernel.org" , Dinh Nguyen , Palmer Dabbelt , "linux-hexagon@vger.kernel.org" , "linux-oxnas@groups.io" , Robin Murphy , "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 27, 2023, at 14:56, Christophe Leroy wrote: > Le 27/03/2023 =C3=A0 14:13, Arnd Bergmann a =C3=A9crit=C2=A0: >> From: Arnd Bergmann >>=20 >> The powerpc dma_sync_*_for_cpu() variants do more flushes than on oth= er >> architectures. Reduce it to what everyone else does: >>=20 >> - No flush is needed after data has been sent to a device >>=20 >> - When data has been received from a device, the cache only needs to >> be invalidated to clear out cache lines that were speculatively >> prefetched. >>=20 >> In particular, the second flushing of partial cache lines of bidirect= ional >> buffers is actively harmful -- if a single cache line is written by b= oth >> the CPU and the device, flushing it again does not maintain coherency >> but instead overwrite the data that was just received from the device. > > Hum ..... Who is right ? > > That behaviour was introduced by commit 03d70617b8a7 ("powerpc: Preven= t=20 > memory corruption due to cache invalidation of unaligned DMA buffer") > > I think your commit log should explain why that commit was wrong, and=20 > maybe say that your patch is a revert of that commit ? Ok, I'll try to explain this better. To clarify here: the __dma_sync() function in commit 03d70617b8a7 is used both before and after a DMA, but my patch 05/21 splits this in two, and patch 06/21 only changes the part that gets called after the DMA-from-device but leaves the part before DMA-from-device unchanged, which Andrew's patch addressed. As I mentioned in the cover letter, it is still unclear whether we want to consider this the expected behavior as the documentation seems unclear, but my series does not attempt to answer that question. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 652F2C7619A for ; Mon, 27 Mar 2023 13:03:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vmaH5EgsKQItySvFeID8Sa1SymCHrHCCGavGk1gBZWI=; b=Lpl2De32zrxlQ2 wYhqbtWTwg+8KaQaMF3VQj8K7m6NeTjlYwwZgb3j7eF1zNdBwd8DjJxZMNl9w1zredymQ9Nx5gVOZ NuTAHlzQ4igURo+PBxecoHMUj4ALk4sk4ZdzSiq1O34BvcXx7Lc0CUkrpAtycIzpSPvZSPeQ+OSS0 6ZS8bTWGn+vLKspyh35m4jy3IDbm+29Sj9azjk/gJPyHcy8NswmriaNlWHKipG2yM/W8SuBrxJGCV vdx0646AZB/qz6nrU1DW1yEnMRXLynslPXpvRGucLvq6txnR0gvoXHi4D9HT/RYgQzmv0xUK1hxDp wuRmwuJfcKx/je71UuWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgmUk-00B2tX-2M; Mon, 27 Mar 2023 13:02:42 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgmUe-00B2ok-0y; Mon, 27 Mar 2023 13:02:40 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 01DFD582160; Mon, 27 Mar 2023 09:02:29 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 27 Mar 2023 09:02:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=Y61mr9XUfXVFhUlJdoF8OWNZ1qM6LGTHSqUwPXey+5SLhbXuszz IX4F35TzFt8tNJqu3TdHQy42BVXRNe3bcFUV8/zj9nSivnmtuzQXp6yIK2l3HJtv arNn0qdsSFaxnf2jpGCdO42ZY/Yo7maZ9JJxQnYT9zQ6fDNdG0CMXLPJSTiBiuYc DxowTYLJD3TZAMG+gAP8IaltLqnFWdByE0RMezkwvVUj8PXoa7+fgC1mMOdcybmk FOSp8xBGb8i1lrklfr+C8l8mm7z3rZwyVo/iOqMqn8kIsrxCMYlMByaiI+EkJOfO AksZxvdJBavSBPl8RAWIMzvbBRTXG6xIPuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=S8t3E1mZSSbesGBfIrPg8iez5iynYZ434j4/P/C+PFUpzIj6OWt K13vVMOr45Pq/x54idE06yYJdGJHsAgbut8cysdL7NSE20F2ZB97nGf6sGl0XtnJ 9XT1e/v2R2VMawWFs9cAUtCqiZnEUzvQi5oNF6VrsD0uvg+IwkaMgefkI++oVxUX P6oUU+TSxGqMMY77icyCim+29Cz39zEK5CEbEi/5s9/A6kWKWjnkM9cNn+OZr9OG +PTT8iBaVt9Y7UzKaNo9juS2P9bsmSmnzuVEEp99tvwuhj8CNT8gHrMIM+y46L5g RgKT+E9GeicOtbPmieJjqHY7nt82g7IMpvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegfeejhedvledvffeijeeijeeivddvhfeliedvleevheejleetgedukedt gfejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 75C74B60086; Mon, 27 Mar 2023 09:02:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-236-g06c0f70e43-fm-20230313.001-g06c0f70e Mime-Version: 1.0 Message-Id: In-Reply-To: <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> References: <20230327121317.4081816-1-arnd@kernel.org> <20230327121317.4081816-7-arnd@kernel.org> <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> Date: Mon, 27 Mar 2023 15:02:04 +0200 From: "Arnd Bergmann" To: "Christophe Leroy" , "Arnd Bergmann" , "linux-kernel@vger.kernel.org" Cc: "Vineet Gupta" , "Russell King" , "Neil Armstrong" , "Linus Walleij" , "Catalin Marinas" , "Will Deacon" , guoren , "Brian Cain" , "Geert Uytterhoeven" , "Michal Simek" , "Thomas Bogendoerfer" , "Dinh Nguyen" , "Stafford Horne" , "Helge Deller" , "Michael Ellerman" , "Paul Walmsley" , "Palmer Dabbelt" , "Rich Felker" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Max Filippov" , "Christoph Hellwig" , "Robin Murphy" , "Lad, Prabhakar" , "Conor.Dooley" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-oxnas@groups.io" , "linux-csky@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linux-openrisc@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" Subject: Re: [PATCH 06/21] powerpc: dma-mapping: minimize for_cpu flushing X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230327_060237_112206_912B4D7C X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMjcsIDIwMjMsIGF0IDE0OjU2LCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgo+ IExlIDI3LzAzLzIwMjMgw6AgMTQ6MTMsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPj4gRnJv bTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPj4gCj4+IFRoZSBwb3dlcnBjIGRtYV9z eW5jXypfZm9yX2NwdSgpIHZhcmlhbnRzIGRvIG1vcmUgZmx1c2hlcyB0aGFuIG9uIG90aGVyCj4+ IGFyY2hpdGVjdHVyZXMuIFJlZHVjZSBpdCB0byB3aGF0IGV2ZXJ5b25lIGVsc2UgZG9lczoKPj4g Cj4+ICAgLSBObyBmbHVzaCBpcyBuZWVkZWQgYWZ0ZXIgZGF0YSBoYXMgYmVlbiBzZW50IHRvIGEg ZGV2aWNlCj4+IAo+PiAgIC0gV2hlbiBkYXRhIGhhcyBiZWVuIHJlY2VpdmVkIGZyb20gYSBkZXZp Y2UsIHRoZSBjYWNoZSBvbmx5IG5lZWRzIHRvCj4+ICAgICBiZSBpbnZhbGlkYXRlZCB0byBjbGVh ciBvdXQgY2FjaGUgbGluZXMgdGhhdCB3ZXJlIHNwZWN1bGF0aXZlbHkKPj4gICAgIHByZWZldGNo ZWQuCj4+IAo+PiBJbiBwYXJ0aWN1bGFyLCB0aGUgc2Vjb25kIGZsdXNoaW5nIG9mIHBhcnRpYWwg Y2FjaGUgbGluZXMgb2YgYmlkaXJlY3Rpb25hbAo+PiBidWZmZXJzIGlzIGFjdGl2ZWx5IGhhcm1m dWwgLS0gaWYgYSBzaW5nbGUgY2FjaGUgbGluZSBpcyB3cml0dGVuIGJ5IGJvdGgKPj4gdGhlIENQ VSBhbmQgdGhlIGRldmljZSwgZmx1c2hpbmcgaXQgYWdhaW4gZG9lcyBub3QgbWFpbnRhaW4gY29o ZXJlbmN5Cj4+IGJ1dCBpbnN0ZWFkIG92ZXJ3cml0ZSB0aGUgZGF0YSB0aGF0IHdhcyBqdXN0IHJl Y2VpdmVkIGZyb20gdGhlIGRldmljZS4KPgo+IEh1bSAuLi4uLiBXaG8gaXMgcmlnaHQgPwo+Cj4g VGhhdCBiZWhhdmlvdXIgd2FzIGludHJvZHVjZWQgYnkgY29tbWl0IDAzZDcwNjE3YjhhNyAoInBv d2VycGM6IFByZXZlbnQgCj4gbWVtb3J5IGNvcnJ1cHRpb24gZHVlIHRvIGNhY2hlIGludmFsaWRh dGlvbiBvZiB1bmFsaWduZWQgRE1BIGJ1ZmZlciIpCj4KPiBJIHRoaW5rIHlvdXIgY29tbWl0IGxv ZyBzaG91bGQgZXhwbGFpbiB3aHkgdGhhdCBjb21taXQgd2FzIHdyb25nLCBhbmQgCj4gbWF5YmUg c2F5IHRoYXQgeW91ciBwYXRjaCBpcyBhIHJldmVydCBvZiB0aGF0IGNvbW1pdCA/CgpPaywgSSds bCB0cnkgdG8gZXhwbGFpbiB0aGlzIGJldHRlci4gVG8gY2xhcmlmeSBoZXJlOiB0aGUgX19kbWFf c3luYygpCmZ1bmN0aW9uIGluIGNvbW1pdCAwM2Q3MDYxN2I4YTcgaXMgdXNlZCBib3RoIGJlZm9y ZSBhbmQgYWZ0ZXIgYSBETUEsCmJ1dCBteSBwYXRjaCAwNS8yMSBzcGxpdHMgdGhpcyBpbiB0d28s IGFuZCBwYXRjaCAwNi8yMSBvbmx5IGNoYW5nZXMKdGhlIHBhcnQgdGhhdCBnZXRzIGNhbGxlZCBh ZnRlciB0aGUgRE1BLWZyb20tZGV2aWNlIGJ1dCBsZWF2ZXMgdGhlCnBhcnQgYmVmb3JlIERNQS1m cm9tLWRldmljZSB1bmNoYW5nZWQsIHdoaWNoIEFuZHJldydzIHBhdGNoCmFkZHJlc3NlZC4KCkFz IEkgbWVudGlvbmVkIGluIHRoZSBjb3ZlciBsZXR0ZXIsIGl0IGlzIHN0aWxsIHVuY2xlYXIgd2hl dGhlcgp3ZSB3YW50IHRvIGNvbnNpZGVyIHRoaXMgdGhlIGV4cGVjdGVkIGJlaGF2aW9yIGFzIHRo ZSBkb2N1bWVudGF0aW9uCnNlZW1zIHVuY2xlYXIsIGJ1dCBteSBzZXJpZXMgZG9lcyBub3QgYXR0 ZW1wdCB0byBhbnN3ZXIgdGhhdApxdWVzdGlvbi4KCiAgICAgQXJuZAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Arnd Bergmann" Subject: Re: [PATCH 06/21] powerpc: dma-mapping: minimize for_cpu flushing Date: Mon, 27 Mar 2023 15:02:04 +0200 Message-ID: References: <20230327121317.4081816-1-arnd@kernel.org> <20230327121317.4081816-7-arnd@kernel.org> <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=foINxHA1nBKViHuY9q6EMYcI/PyWa1+M4nTKsseHmgA=; b=aPvZ0Mpd7rDdFJ Ya2vdH20j9TvXaCO/a0O8eqkprr7iEg84poAQFHlJUPMNJWeFWF/EKio1Uw2+XPKKw1oQyF9pDyOM ow6aHajiraWflL6EPIcpGGrDYLxgb+DwPCELJpKNqvqEP9EdLdT/CsAecbtPE9LcW8uwYmnW+osfV yoZtcnbcEVPC9QJfbXt3vDZt7YPloOu1JTUjCsPxz3T2XbbNH/I54X2/oQ9djA/exlTBUNXgSiSxv k7Y2YaOL4aUwYdvI01/uJduaVfJJvBe/cz39nmT6wbCvCLJGIWhGNrwuvuO6qfn05w4KZAsSEhRDV 27zdtgKrL3vcuTnCzo6g==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=Y61mr9XUfXVFhUlJdoF8OWNZ1qM6LGTHSqUwPXey+5SLhbXuszz IX4F35TzFt8tNJqu3TdHQy42BVXRNe3bcFUV8/zj9nSivnmtuzQXp6yIK2l3HJtv arNn0qdsSFaxnf2jpGCdO42ZY/Yo7maZ9JJxQnYT9zQ6fDNdG0CMXLPJSTiBiuYc DxowTYLJD3TZAMG+gAP8IaltLqnFWdByE0RMezkwvVUj8PXoa7+fgC1mMOdcybmk FOSp8xBGb8i1lrklfr+C8l8mm7z3rZwyVo/iOqMqn8kIsrxCMYlMByaiI+EkJOfO AksZxvdJBavSBPl8RAWIMzvbBRTXG6xIPuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679922148; x=1679929348; bh=C0t+VBsIdNHlcZByrnG5NPOW3/HDBRin4l1 1iuQ2qiw=; b=S8t3E1mZSSbesGBfIrPg8iez5iynYZ434j4/P/C+PFUpzIj6OWt K13vVMOr45Pq/x54idE06yYJdGJHsAgbut8cysdL7NSE20F2ZB97nGf6sGl0XtnJ 9XT1e/v2R2VMawWFs9cAUtCqiZnEUzvQi5oNF6VrsD0uvg+IwkaMgefkI++oVxUX P6oUU+TSxGqMMY77icyCim+29Cz39zEK5CEbEi/5s9/A6kWKWjnkM9cNn+OZr9OG +PTT8iBaVt9Y7UzKaNo9juS2P9bsmSmnzuVEEp99tvwuhj8CNT8gHrMIM+y46L5g RgKT+E9GeicOtbPmieJjqHY7nt82g7IMpvg== In-Reply-To: <52eef604-085e-acf9-f3ee-41ba9d8441d2@csgroup.eu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org To: Christophe Leroy , Arnd Bergmann , "linux-kernel@vger.kernel.org" Cc: Vineet Gupta , Russell King , Neil Armstrong , Linus Walleij , Catalin Marinas , Will Deacon , guoren , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Stafford Horne , Helge Deller , Michael Ellerman , Paul Walmsley , Palmer Dabbelt , Rich Felker , John Paul Adrian Glaubitz , "David S . Miller" , Max Filippov , Christoph Hellwig , Robin T24gTW9uLCBNYXIgMjcsIDIwMjMsIGF0IDE0OjU2LCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgo+ IExlIDI3LzAzLzIwMjMgw6AgMTQ6MTMsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPj4gRnJv bTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPj4gCj4+IFRoZSBwb3dlcnBjIGRtYV9z eW5jXypfZm9yX2NwdSgpIHZhcmlhbnRzIGRvIG1vcmUgZmx1c2hlcyB0aGFuIG9uIG90aGVyCj4+ IGFyY2hpdGVjdHVyZXMuIFJlZHVjZSBpdCB0byB3aGF0IGV2ZXJ5b25lIGVsc2UgZG9lczoKPj4g Cj4+ICAgLSBObyBmbHVzaCBpcyBuZWVkZWQgYWZ0ZXIgZGF0YSBoYXMgYmVlbiBzZW50IHRvIGEg ZGV2aWNlCj4+IAo+PiAgIC0gV2hlbiBkYXRhIGhhcyBiZWVuIHJlY2VpdmVkIGZyb20gYSBkZXZp Y2UsIHRoZSBjYWNoZSBvbmx5IG5lZWRzIHRvCj4+ICAgICBiZSBpbnZhbGlkYXRlZCB0byBjbGVh ciBvdXQgY2FjaGUgbGluZXMgdGhhdCB3ZXJlIHNwZWN1bGF0aXZlbHkKPj4gICAgIHByZWZldGNo ZWQuCj4+IAo+PiBJbiBwYXJ0aWN1bGFyLCB0aGUgc2Vjb25kIGZsdXNoaW5nIG9mIHBhcnRpYWwg Y2FjaGUgbGluZXMgb2YgYmlkaXJlY3Rpb25hbAo+PiBidWZmZXJzIGlzIGFjdGl2ZWx5IGhhcm1m dWwgLS0gaWYgYSBzaW5nbGUgY2FjaGUgbGluZSBpcyB3cml0dGVuIGJ5IGJvdGgKPj4gdGhlIENQ VSBhbmQgdGhlIGRldmljZSwgZmx1c2hpbmcgaXQgYWdhaW4gZG9lcyBub3QgbWFpbnRhaW4gY29o ZXJlbmN5Cj4+IGJ1dCBpbnN0ZWFkIG92ZXJ3cml0ZSB0aGUgZGF0YSB0aGF0IHdhcyBqdXN0IHJl Y2VpdmVkIGZyb20gdGhlIGRldmljZS4KPgo+IEh1bSAuLi4uLiBXaG8gaXMgcmlnaHQgPwo+Cj4g VGhhdCBiZWhhdmlvdXIgd2FzIGludHJvZHVjZWQgYnkgY29tbWl0IDAzZDcwNjE3YjhhNyAoInBv d2VycGM6IFByZXZlbnQgCj4gbWVtb3J5IGNvcnJ1cHRpb24gZHVlIHRvIGNhY2hlIGludmFsaWRh dGlvbiBvZiB1bmFsaWduZWQgRE1BIGJ1ZmZlciIpCj4KPiBJIHRoaW5rIHlvdXIgY29tbWl0IGxv ZyBzaG91bGQgZXhwbGFpbiB3aHkgdGhhdCBjb21taXQgd2FzIHdyb25nLCBhbmQgCj4gbWF5YmUg c2F5IHRoYXQgeW91ciBwYXRjaCBpcyBhIHJldmVydCBvZiB0aGF0IGNvbW1pdCA/CgpPaywgSSds bCB0cnkgdG8gZXhwbGFpbiB0aGlzIGJldHRlci4gVG8gY2xhcmlmeSBoZXJlOiB0aGUgX19kbWFf c3luYygpCmZ1bmN0aW9uIGluIGNvbW1pdCAwM2Q3MDYxN2I4YTcgaXMgdXNlZCBib3RoIGJlZm9y ZSBhbmQgYWZ0ZXIgYSBETUEsCmJ1dCBteSBwYXRjaCAwNS8yMSBzcGxpdHMgdGhpcyBpbiB0d28s IGFuZCBwYXRjaCAwNi8yMSBvbmx5IGNoYW5nZXMKdGhlIHBhcnQgdGhhdCBnZXRzIGNhbGxlZCBh ZnRlciB0aGUgRE1BLWZyb20tZGV2aWNlIGJ1dCBsZWF2ZXMgdGhlCnBhcnQgYmVmb3JlIERNQS1m cm9tLWRldmljZSB1bmNoYW5nZWQsIHdoaWNoIEFuZHJldydzIHBhdGNoCmFkZHJlc3NlZC4KCkFz IEkgbWVudGlvbmVkIGluIHRoZSBjb3ZlciBsZXR0ZXIsIGl0IGlzIHN0aWxsIHVuY2xlYXIgd2hl dGhlcgp3ZSB3YW50IHRvIGNvbnNpZGVyIHRoaXMgdGhlIGV4cGVjdGVkIGJlaGF2aW9yIGFzIHRo ZSBkb2N1bWVudGF0aW9uCnNlZW1zIHVuY2xlYXIsIGJ1dCBteSBzZXJpZXMgZG9lcyBub3QgYXR0 ZW1wdCB0byBhbnN3ZXIgdGhhdApxdWVzdGlvbi4KCiAgICAgQXJuZAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0 CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=