Re: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov

From: "Koenig, Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>
To: "Tao, Yintian" <Yintian.Tao-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov
Date: Tue, 4 Jun 2019 15:22:00 +0000	[thread overview]
Message-ID: <a0c24c05-6bca-ee5c-75bf-672f27abdb33@amd.com> (raw)
In-Reply-To: <MN2PR12MB3039F0DD22910F40A6674546E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>

[-- Attachment #1.1: Type: text/plain, Size: 1835 bytes --]

Am 04.06.19 um 17:16 schrieb Tao, Yintian:

Hi  Christian

But when amdgpu driver is unloading, it will call this function.

And driver unloading is an legal case under SR-IOV.

Do you mean PCIe device removal indicates the unplug the real device?

Yes, exactly and that is not supported.

Sounds like the error message is then on the wrong place.

Christian.

Best Regards

Yitnian Tao

________________________________
发件人: Christian König <ckoenig.leichtzumerken@gmail.com><mailto:ckoenig.leichtzumerken@gmail.com>
发送时间: 2019年6月4日 21:57:37
收件人: Tao, Yintian; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
主题: Re: [PATCH] drm/amdgpu: no need fbcon under sriov

Am 04.06.19 um 15:43 schrieb Yintian Tao:
> Under Sriov, there is no need of the support for fbcon.

NAK, that error message is not related to fbcon but means that PCIe
device removal is not supported.

Christian.

>
> Signed-off-by: Yintian Tao <yttao@amd.com><mailto:yttao@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 1f38d6f..28d095b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev)
>   {
>        struct drm_device *dev = pci_get_drvdata(pdev);
>
> -     DRM_ERROR("Device removal is currently not supported outside of fbcon\n");
> +     if (!amdgpu_sriov_vf(adev))
> +             DRM_ERROR("Device removal is currently not supported outside of fbcon\n");
>        drm_dev_unplug(dev);
>        drm_dev_put(dev);
>        pci_disable_device(pdev);

[-- Attachment #1.2: Type: text/html, Size: 4132 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx