From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA77DC2BA83 for ; Fri, 14 Feb 2020 18:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86795222C2 for ; Fri, 14 Feb 2020 18:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393474AbgBNSNW (ORCPT ); Fri, 14 Feb 2020 13:13:22 -0500 Received: from foss.arm.com ([217.140.110.172]:42788 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393441AbgBNSNT (ORCPT ); Fri, 14 Feb 2020 13:13:19 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D5F6328; Fri, 14 Feb 2020 10:13:19 -0800 (PST) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B62A53F68E; Fri, 14 Feb 2020 10:13:16 -0800 (PST) Subject: Re: [PATCH v7 11/11] arm64: scs: add shadow stacks for SDEI To: Sami Tolvanen Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Mark Rutland , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML References: <20191018161033.261971-1-samitolvanen@google.com> <20200128184934.77625-1-samitolvanen@google.com> <20200128184934.77625-12-samitolvanen@google.com> From: James Morse Message-ID: Date: Fri, 14 Feb 2020 18:13:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sami, On 12/02/2020 20:59, Sami Tolvanen wrote: > On Tue, Feb 11, 2020 at 5:57 AM James Morse wrote: >> On 28/01/2020 18:49, Sami Tolvanen wrote: >>> This change adds per-CPU shadow call stacks for the SDEI handler. >>> Similarly to how the kernel stacks are handled, we add separate shadow >>> stacks for normal and critical events. >> >> Reviewed-by: James Morse >> Tested-by: James Morse >>> diff --git a/arch/arm64/kernel/scs.c b/arch/arm64/kernel/scs.c >>> index eaadf5430baa..dddb7c56518b 100644 >>> --- a/arch/arm64/kernel/scs.c >>> +++ b/arch/arm64/kernel/scs.c >> >>> +static int scs_alloc_percpu(unsigned long * __percpu *ptr, int cpu) >>> +{ >>> + unsigned long *p; >>> + >>> + p = __vmalloc_node_range(PAGE_SIZE, SCS_SIZE, >>> + VMALLOC_START, VMALLOC_END, >>> + GFP_SCS, PAGE_KERNEL, >>> + 0, cpu_to_node(cpu), >>> + __builtin_return_address(0)); >> >> (What makes this arch specific? arm64 has its own calls like this for the regular vmap >> stacks because it plays tricks with the alignment. Here the alignment requirement comes >> from the core SCS code... Would another architecture implement these >> scs_alloc_percpu()/scs_free_percpu() differently?) > > You are correct, these aren't necessarily specific to arm64. However, > right now, we are not allocating per-CPU shadow stacks anywhere else, > so this was a natural place for the helper functions. Fair enough, > Would you prefer me to move these to kernel/scs.c instead? I have no preference, as long as they don't get duplicated later! Thanks, James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F40A8C2BA83 for ; Fri, 14 Feb 2020 18:13:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5529222C2 for ; Fri, 14 Feb 2020 18:13:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mnAZal1d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5529222C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e4DH5uFJ3WXGG3sYZEwp7Iy+mpRHuBvLej3V0wFYg2E=; b=mnAZal1dWCZpfV CPmrgm5fu2geZMBmX6Y5PXYM9Xukr0DZRAKea/QAaNSCik0/YRcclH+/S7xmUxKjEZKjJvDI3mQcw 0dvZl6S0WWUk5ZZgLTOUBpU4NbG/j8Cl8ixkbI0eSmtu8wO7CipMxUJeVFjoDGo72mrh//BEJnguJ o2cEvSeDc2BwXdmIbNlDP8KfnliFHfPEfRSRs6++rcd3ufJJ6Zq7wLWVjeX9LNDBm5c2daBA9tC23 JAsCEMYGpzxvsdd9V0djlZ3UYfpypojAZHii4ofMX2yMMVceYrhErCLpK/dnOXu3BYp+dOiXhOK81 kKHFQCzdwEJ1MQcLJwmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2fSy-0000jT-Un; Fri, 14 Feb 2020 18:13:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2fSu-0000hr-BO for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2020 18:13:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D5F6328; Fri, 14 Feb 2020 10:13:19 -0800 (PST) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B62A53F68E; Fri, 14 Feb 2020 10:13:16 -0800 (PST) Subject: Re: [PATCH v7 11/11] arm64: scs: add shadow stacks for SDEI To: Sami Tolvanen References: <20191018161033.261971-1-samitolvanen@google.com> <20200128184934.77625-1-samitolvanen@google.com> <20200128184934.77625-12-samitolvanen@google.com> From: James Morse Message-ID: Date: Fri, 14 Feb 2020 18:13:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_101324_434558_5BF222F0 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , clang-built-linux , Masami Hiramatsu , Marc Zyngier , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sami, On 12/02/2020 20:59, Sami Tolvanen wrote: > On Tue, Feb 11, 2020 at 5:57 AM James Morse wrote: >> On 28/01/2020 18:49, Sami Tolvanen wrote: >>> This change adds per-CPU shadow call stacks for the SDEI handler. >>> Similarly to how the kernel stacks are handled, we add separate shadow >>> stacks for normal and critical events. >> >> Reviewed-by: James Morse >> Tested-by: James Morse >>> diff --git a/arch/arm64/kernel/scs.c b/arch/arm64/kernel/scs.c >>> index eaadf5430baa..dddb7c56518b 100644 >>> --- a/arch/arm64/kernel/scs.c >>> +++ b/arch/arm64/kernel/scs.c >> >>> +static int scs_alloc_percpu(unsigned long * __percpu *ptr, int cpu) >>> +{ >>> + unsigned long *p; >>> + >>> + p = __vmalloc_node_range(PAGE_SIZE, SCS_SIZE, >>> + VMALLOC_START, VMALLOC_END, >>> + GFP_SCS, PAGE_KERNEL, >>> + 0, cpu_to_node(cpu), >>> + __builtin_return_address(0)); >> >> (What makes this arch specific? arm64 has its own calls like this for the regular vmap >> stacks because it plays tricks with the alignment. Here the alignment requirement comes >> from the core SCS code... Would another architecture implement these >> scs_alloc_percpu()/scs_free_percpu() differently?) > > You are correct, these aren't necessarily specific to arm64. However, > right now, we are not allocating per-CPU shadow stacks anywhere else, > so this was a natural place for the helper functions. Fair enough, > Would you prefer me to move these to kernel/scs.c instead? I have no preference, as long as they don't get duplicated later! Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel