From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 20/20] bus/fslmc: add function to map any
	addr via VFIO
Date: Tue, 8 Jan 2019 14:10:07 +0000
Message-ID: <a0cbed6e-3dec-f352-9bd8-78e9fdc26b6f@intel.com>
References: <20181227062233.30781-1-hemant.agrawal@nxp.com>
 <20181227062233.30781-21-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>,
 Pankaj Chauhan <pankaj.chauhan@nxp.com>, "M.h. Lian" <minghuan.lian@nxp.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 26C541B205
 for <dev@dpdk.org>; Tue,  8 Jan 2019 15:10:10 +0100 (CET)
In-Reply-To: <20181227062233.30781-21-hemant.agrawal@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/27/2018 6:23 AM, Hemant Agrawal wrote:
> From: Pankaj Chauhan <pankaj.chauhan@nxp.com>
> 
> This is required to map any accelerator memory
> and PCI address to VFIO using QDMA.
> 
> Signed-off-by: Minghuan Lian <Minghuan.Lian@nxp.com>
> Signed-off-by: Pankaj Chauhan <pankaj.chauhan@nxp.com>

This requires either sign-off or ack from 'bus/fslmc' maintainers, which are:
	M: Hemant Agrawal <hemant.agrawal@nxp.com>



	M: Shreyansh Jain <shreyansh.jain@nxp.com>

I think Hemant sending the patchset implies that this has been reviewed by him
but this information get lost in git, so better to explicitly provide review/ack
tags whenever appropriate.

<...>

> +	printf("PCIe vfio map 0x%llx:0x%llx, size 0x%llx\n", dma_map.vaddr,
> +		dma_map.iova, dma_map.size);

This is causing build error [1], but why at first place using 'printf()' instead
of logging macros?

[1]
.../drivers/bus/fslmc/fslmc_vfio.c: In function ‘rte_fslmc_vfio_mem_dmamap’:
.../drivers/bus/fslmc/fslmc_vfio.c:376:29: error: format ‘%llx’ expects argument
of type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka ‘long
unsigned int’} [-Werror=format=]
  printf("PCIe vfio map 0x%llx:0x%llx, size 0x%llx\n", dma_map.vaddr,
                          ~~~^                         ~~~~~~~~~~~~~
                          %lx

<...>

> +DPDK_19.02 {
> +	global:
> +
> +	rte_fslmc_vfio_mem_dmamap;

Is this need to be an API? Who is the consumer of this API, I don't see anyone
calls this function?