From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B786DC33CAC for ; Thu, 6 Feb 2020 15:37:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 831CA21741 for ; Thu, 6 Feb 2020 15:37:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ABEnC70i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 831CA21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izjDA-00066F-Ol for qemu-devel@archiver.kernel.org; Thu, 06 Feb 2020 10:37:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42125) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izjBz-00056u-Sn for qemu-devel@nongnu.org; Thu, 06 Feb 2020 10:35:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izjBy-0007dc-OM for qemu-devel@nongnu.org; Thu, 06 Feb 2020 10:35:47 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:49635 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1izjBy-0007Yw-Iu for qemu-devel@nongnu.org; Thu, 06 Feb 2020 10:35:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581003345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=PE4W5T5M9IK3YQX0vUlv8UhTqQgvW261j69LejMCNZI=; b=ABEnC70iHA43W0Kcqr41sPUlttnizZ+b6dAFGzUiVeDTlO5/pcJPkT32ae87t07hZAFEYT 2q9xDdCrBV4PWrZ8SN4U01LwnTG4muFS6leqzwJAQD5oxofbchGv34Lkkr8sBCWUyGZW6/ QcoB8GDo05iQ5aVN5wc8Nd8rqo9N2O0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-2oysRtsDOj-t5nZE2v02LA-1; Thu, 06 Feb 2020 10:35:42 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 58BAA107B767; Thu, 6 Feb 2020 15:35:41 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-151.ams2.redhat.com [10.36.116.151]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0A9948; Thu, 6 Feb 2020 15:35:34 +0000 (UTC) Subject: Re: [PATCH v2 26/29] tests/acceptance/boot_linux_console: Do not use VGA on Clipper machine To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Denis Plotnikov , qemu-devel@nongnu.org References: <20200129212345.20547-1-philmd@redhat.com> <20200129212345.20547-27-philmd@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: Date: Thu, 6 Feb 2020 16:35:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200129212345.20547-27-philmd@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: 2oysRtsDOj-t5nZE2v02LA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 29/01/2020 22.23, Philippe Mathieu-Daud=C3=A9 wrote: > As we only read the serial console, we don't need to force a > VGA display. This fixes when running a binary built with > --without-default-devices: >=20 > ERROR: qemu-system-alpha: standard VGA not available >=20 > We also need the '-nodefaults' argument to avoid: >=20 > ERROR: qemu-system-alpha: Unsupported NIC model: e1000 >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > tests/acceptance/boot_linux_console.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/bo= ot_linux_console.py > index e40b84651b..7d6065828c 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -519,7 +519,7 @@ class BootLinuxConsole(Test): > =20 > self.vm.set_console() > kernel_command_line =3D self.KERNEL_COMMON_COMMAND_LINE + 'conso= le=3DttyS0' > - self.vm.add_args('-vga', 'std', > + self.vm.add_args('-nodefaults', > '-kernel', uncompressed_kernel, > '-append', kernel_command_line) > self.vm.launch() Reviewed-by: Thomas Huth