All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: f4bug@amsat.org
Subject: Re: [PATCH v2] meson.build: expose TCG cross compiler information in summary
Date: Tue, 16 Feb 2021 11:49:33 +0100	[thread overview]
Message-ID: <a0db0e73-debc-a712-570b-cc38278884f2@redhat.com> (raw)
In-Reply-To: <20210216102522.6279-1-alex.bennee@linaro.org>

On 16/02/21 11:25, Alex Bennée wrote:
> Blink and you miss the cross TCG compiler stuff so lets display it
> with the rest of the compiler information.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> ---
> v2
>    - use target_dirs/fs.exists() instead of find

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Using $(wildcard) could be better than TARGET_DIRS in 
tests/Makefile.include, too, something like this:

diff --git a/tests/Makefile.include b/tests/Makefile.include
index d34254fb29..7203243b08 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -41,7 +41,7 @@ SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \
  SPEED = quick

  # Build up our target list from the filtered list of ninja targets
-TARGETS=$(patsubst libqemu-%.fa, %, $(filter libqemu-%.fa, 
$(ninja-targets)))
+TARGETS=$(patsubst tests/tcg/config-%.mak, %, $(wildcard 
tests/tcg/config-target.mak))

  # Per guest TCG tests
  BUILD_TCG_TARGET_RULES=$(patsubst %,build-tcg-tests-%, $(TARGETS))
@@ -49,7 +49,7 @@ CLEAN_TCG_TARGET_RULES=$(patsubst %,clean-tcg-tests-%, 
$(TARGETS))
  RUN_TCG_TARGET_RULES=$(patsubst %,run-tcg-tests-%, $(TARGETS))

  # Probe for the Docker Builds needed for each build
-$(foreach PROBE_TARGET,$(TARGET_DIRS), 				\
+$(foreach PROBE_TARGET,$(TARGETS), 				\
  	$(eval -include $(SRC_PATH)/tests/tcg/Makefile.prereqs))

  $(BUILD_TCG_TARGET_RULES): build-tcg-tests-%: $(if 
$(CONFIG_PLUGIN),test-plugins)


I'll test it and send it out.

Paolo



  parent reply	other threads:[~2021-02-16 10:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 10:25 [PATCH v2] meson.build: expose TCG cross compiler information in summary Alex Bennée
2021-02-16 10:43 ` Philippe Mathieu-Daudé
2021-02-16 10:44   ` Philippe Mathieu-Daudé
2021-02-16 10:49 ` Paolo Bonzini [this message]
2021-02-16 10:57   ` Philippe Mathieu-Daudé
2021-02-16 11:07     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0db0e73-debc-a712-570b-cc38278884f2@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.