All of lore.kernel.org
 help / color / mirror / Atom feed
From: richard.purdie@linuxfoundation.org
To: Jason Andryuk <jandryuk@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: Mis-generation of shell script (run.do_install)?
Date: Mon, 17 Dec 2018 14:44:47 +0000	[thread overview]
Message-ID: <a0e331f39da396ea39ea37539f6c1ea193b055b1.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAKf6xpt_RoLVg3ou2zKL2g=0GsjDXpCk73q83pmb4Reer9YgdA@mail.gmail.com>

On Sat, 2018-12-15 at 20:19 -0500, Jason Andryuk wrote:
> As far as I can tell, pysh is working properly - it's just the
> bb_codeparser.dat which is returning the incorrect shellCacheLine
> entry.  It seems like I have an md5 collision between a pyro core2-64
> binutils do_install and core2-32 python-async distutils_do_install in
> the shellCacheLine.  python-async's entry got in first, so that's why
> binutils run.do_install doesn't include autotools_do_install - the
> shellCacheLine `execs` entry doesn't include it.  Or somehow the
> `bb_codeparser.dat` file was corrupted to have an incorrect `execs`
> for the binutils do_install hash.

That is rather worrying. Looking at the known issues with md5, I can
see how this could happen though.

I think this means we need to switch to a better hash mechanism. I've
sent a patch changing this to sha256 on the bitbake list.

We also probably need to change over the code in siggen for the sstate
hashes too but one step at a time...

Cheers,

Richard



  reply	other threads:[~2018-12-17 14:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 13:42 Mis-generation of shell script (run.do_install)? Jason Andryuk
2018-12-11 15:02 ` Richard Purdie
2018-12-14 19:30   ` Jason Andryuk
2018-12-15 10:51     ` richard.purdie
2018-12-16  1:19       ` Jason Andryuk
2018-12-17 14:44         ` richard.purdie [this message]
2018-12-17 20:21           ` Andre McCurdy
2018-12-17 21:24             ` richard.purdie
2018-12-18 17:45               ` Jason Andryuk
2019-01-08 18:26                 ` richard.purdie
2019-01-16 13:55                   ` Jason Andryuk
2019-01-16 14:02                     ` Richard Purdie
2019-01-16 20:20                       ` Jason Andryuk
2019-01-16 20:28                         ` Richard Purdie
2019-01-17 17:10                           ` Jason Andryuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0e331f39da396ea39ea37539f6c1ea193b055b1.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jandryuk@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.