From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCHv5 06/14] remoteproc/omap: Initialize and assign reserved memory node References: <20200116135332.7819-1-t-kristo@ti.com> <20200116135332.7819-7-t-kristo@ti.com> <249c293c-6a23-165f-1df5-4859ee47658a@ti.com> <37db5d57-b1cd-1cec-2c9b-31c49e3bdc10@ti.com> From: "Andrew F. Davis" Message-ID: Date: Thu, 30 Jan 2020 14:20:31 -0500 MIME-Version: 1.0 In-Reply-To: <37db5d57-b1cd-1cec-2c9b-31c49e3bdc10@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit To: Tero Kristo , bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, s-anna@ti.com, linux-omap@vger.kernel.org List-ID: On 1/30/20 2:18 PM, Tero Kristo wrote: > On 30/01/2020 20:11, Andrew F. Davis wrote: >> On 1/16/20 8:53 AM, Tero Kristo wrote: >>> From: Suman Anna >>> >>> The reserved memory nodes are not assigned to platform devices by >>> default in the driver core to avoid the lookup for every platform >>> device and incur a penalty as the real users are expected to be >>> only a few devices. >>> >>> OMAP remoteproc devices fall into the above category and the OMAP >>> remoteproc driver _requires_ specific CMA pools to be assigned >>> for each device at the moment to align on the location of the >>> vrings and vring buffers in the RTOS-side firmware images. So, >> >> >> Same comment as before, this is a firmware issue for only some firmwares >> that do not handle being assigned vring locations correctly and instead >> hard-code them. > > I believe we discussed this topic in length in previous version but > there was no conclusion on it. > > The commit desc might be a bit misleading, we are not actually forced to > use specific CMA buffers, as we use IOMMU to map these to device > addresses. For example IPU1/IPU2 use internally exact same memory > addresses, iommu is used to map these to specific CMA buffer. > > CMA buffers are mostly used so that we get aligned large chunk of memory > which can be mapped properly with the limited IOMMU OMAP family of chips > have. Not sure if there is any sane way to get this done in any other > manner. > Why not use the default CMA area? Andrew > -Tero > >> >> This is not a requirement of the remote processor itself and so it >> should not fail to probe if a specific memory carveout isn't given. >> >> >>> use the of_reserved_mem_device_init/release() API appropriately >>> to assign the corresponding reserved memory region to the OMAP >>> remoteproc device. Note that only one region per device is >>> allowed by the framework. >>> >>> Signed-off-by: Suman Anna >>> Signed-off-by: Tero Kristo >>> Reviewed-by: Bjorn Andersson >>> --- >>> v5: no changes >>> >>>   drivers/remoteproc/omap_remoteproc.c | 12 +++++++++++- >>>   1 file changed, 11 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/remoteproc/omap_remoteproc.c >>> b/drivers/remoteproc/omap_remoteproc.c >>> index 0846839b2c97..194303b860b2 100644 >>> --- a/drivers/remoteproc/omap_remoteproc.c >>> +++ b/drivers/remoteproc/omap_remoteproc.c >>> @@ -17,6 +17,7 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>>   #include >>>   #include >>>   #include >>> @@ -480,14 +481,22 @@ static int omap_rproc_probe(struct >>> platform_device *pdev) >>>       if (ret) >>>           goto free_rproc; >>>   +    ret = of_reserved_mem_device_init(&pdev->dev); >>> +    if (ret) { >>> +        dev_err(&pdev->dev, "device does not have specific CMA >>> pool\n"); >>> +        goto free_rproc; >>> +    } >>> + >>>       platform_set_drvdata(pdev, rproc); >>>         ret = rproc_add(rproc); >>>       if (ret) >>> -        goto free_rproc; >>> +        goto release_mem; >>>         return 0; >>>   +release_mem: >>> +    of_reserved_mem_device_release(&pdev->dev); >>>   free_rproc: >>>       rproc_free(rproc); >>>       return ret; >>> @@ -499,6 +508,7 @@ static int omap_rproc_remove(struct >>> platform_device *pdev) >>>         rproc_del(rproc); >>>       rproc_free(rproc); >>> +    of_reserved_mem_device_release(&pdev->dev); >>>         return 0; >>>   } >>> > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F27F1C2D0DB for ; Thu, 30 Jan 2020 19:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C910E20708 for ; Thu, 30 Jan 2020 19:20:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="iL6rs2LP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbgA3TUh (ORCPT ); Thu, 30 Jan 2020 14:20:37 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:57146 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727758AbgA3TUe (ORCPT ); Thu, 30 Jan 2020 14:20:34 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 00UJKX9F022401; Thu, 30 Jan 2020 13:20:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1580412033; bh=J2BkUUYFPqKxH/QQInFALmsEOVsQkQXSQAa1S4XFWVA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=iL6rs2LPbVdJDn+B6grxVLHAofbHJwuQVv3ZZs1nz+1/VbMyglofh3hNxLymKzV6c pr024z2BJBkdHFA/ve8bQ5E4Le2OKCaIKHjL+qmKF9e2dyGqZNFiStgZsOWVBAnIB/ IN7IdI2KI4RHYEfQdsZGl9RGD9xHY4hSItEQx4aE= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 00UJKXBK089542 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Jan 2020 13:20:33 -0600 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 30 Jan 2020 13:20:33 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 30 Jan 2020 13:20:32 -0600 Received: from [10.250.70.160] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 00UJKV1r057455; Thu, 30 Jan 2020 13:20:31 -0600 Subject: Re: [PATCHv5 06/14] remoteproc/omap: Initialize and assign reserved memory node To: Tero Kristo , , , CC: , , , References: <20200116135332.7819-1-t-kristo@ti.com> <20200116135332.7819-7-t-kristo@ti.com> <249c293c-6a23-165f-1df5-4859ee47658a@ti.com> <37db5d57-b1cd-1cec-2c9b-31c49e3bdc10@ti.com> From: "Andrew F. Davis" Message-ID: Date: Thu, 30 Jan 2020 14:20:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <37db5d57-b1cd-1cec-2c9b-31c49e3bdc10@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/30/20 2:18 PM, Tero Kristo wrote: > On 30/01/2020 20:11, Andrew F. Davis wrote: >> On 1/16/20 8:53 AM, Tero Kristo wrote: >>> From: Suman Anna >>> >>> The reserved memory nodes are not assigned to platform devices by >>> default in the driver core to avoid the lookup for every platform >>> device and incur a penalty as the real users are expected to be >>> only a few devices. >>> >>> OMAP remoteproc devices fall into the above category and the OMAP >>> remoteproc driver _requires_ specific CMA pools to be assigned >>> for each device at the moment to align on the location of the >>> vrings and vring buffers in the RTOS-side firmware images. So, >> >> >> Same comment as before, this is a firmware issue for only some firmwares >> that do not handle being assigned vring locations correctly and instead >> hard-code them. > > I believe we discussed this topic in length in previous version but > there was no conclusion on it. > > The commit desc might be a bit misleading, we are not actually forced to > use specific CMA buffers, as we use IOMMU to map these to device > addresses. For example IPU1/IPU2 use internally exact same memory > addresses, iommu is used to map these to specific CMA buffer. > > CMA buffers are mostly used so that we get aligned large chunk of memory > which can be mapped properly with the limited IOMMU OMAP family of chips > have. Not sure if there is any sane way to get this done in any other > manner. > Why not use the default CMA area? Andrew > -Tero > >> >> This is not a requirement of the remote processor itself and so it >> should not fail to probe if a specific memory carveout isn't given. >> >> >>> use the of_reserved_mem_device_init/release() API appropriately >>> to assign the corresponding reserved memory region to the OMAP >>> remoteproc device. Note that only one region per device is >>> allowed by the framework. >>> >>> Signed-off-by: Suman Anna >>> Signed-off-by: Tero Kristo >>> Reviewed-by: Bjorn Andersson >>> --- >>> v5: no changes >>> >>>   drivers/remoteproc/omap_remoteproc.c | 12 +++++++++++- >>>   1 file changed, 11 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/remoteproc/omap_remoteproc.c >>> b/drivers/remoteproc/omap_remoteproc.c >>> index 0846839b2c97..194303b860b2 100644 >>> --- a/drivers/remoteproc/omap_remoteproc.c >>> +++ b/drivers/remoteproc/omap_remoteproc.c >>> @@ -17,6 +17,7 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>>   #include >>>   #include >>>   #include >>> @@ -480,14 +481,22 @@ static int omap_rproc_probe(struct >>> platform_device *pdev) >>>       if (ret) >>>           goto free_rproc; >>>   +    ret = of_reserved_mem_device_init(&pdev->dev); >>> +    if (ret) { >>> +        dev_err(&pdev->dev, "device does not have specific CMA >>> pool\n"); >>> +        goto free_rproc; >>> +    } >>> + >>>       platform_set_drvdata(pdev, rproc); >>>         ret = rproc_add(rproc); >>>       if (ret) >>> -        goto free_rproc; >>> +        goto release_mem; >>>         return 0; >>>   +release_mem: >>> +    of_reserved_mem_device_release(&pdev->dev); >>>   free_rproc: >>>       rproc_free(rproc); >>>       return ret; >>> @@ -499,6 +508,7 @@ static int omap_rproc_remove(struct >>> platform_device *pdev) >>>         rproc_del(rproc); >>>       rproc_free(rproc); >>> +    of_reserved_mem_device_release(&pdev->dev); >>>         return 0; >>>   } >>> > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki