From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752649AbeDSMlc (ORCPT ); Thu, 19 Apr 2018 08:41:32 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:25014 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbeDSMla (ORCPT ); Thu, 19 Apr 2018 08:41:30 -0400 From: Philippe CORNU To: Laurent Pinchart CC: Mark Rutland , "devicetree@vger.kernel.org" , Alexandre TORGUE , David Airlie , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Yannick FERTRE , Rob Herring Subject: Re: [PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Thread-Topic: [PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Thread-Index: AQHT17YD8tnOVv8280mJzub+yGd3ZKQHsV4AgAAbjwCAABmOAA== Date: Thu, 19 Apr 2018 12:41:20 +0000 Message-ID: References: <20180410051927.8268-1-philippe.cornu@st.com> <20599695.GSkeUvMnvx@avalon> <1733412.i2Wslp7VkI@avalon> In-Reply-To: <1733412.i2Wslp7VkI@avalon> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.116] Content-Type: text/plain; charset="utf-8" Content-ID: <63B4169087856944A9896EBD4F7B6F5A@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-19_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w3JCfdfs028504 Hi Laurent, On 04/19/2018 01:09 PM, Laurent Pinchart wrote: > Hi Philippe, > > On Thursday, 19 April 2018 12:31:15 EEST Philippe CORNU wrote: >> On 04/19/2018 10:11 AM, Laurent Pinchart wrote: >>> On Tuesday, 10 April 2018 08:19:26 EEST Philippe Cornu wrote: >>> >>>> Add the 3 optional power supplies using the exact description >>>> found in the document named >>>> "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". >>>> >>>> Signed-off-by: Philippe Cornu >>>> --- >>>> >>>> Documentation/devicetree/bindings/display/bridge/sii902x.txt | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/display/bridge/sii902x.txt >>>> b/Documentation/devicetree/bindings/display/bridge/sii902x.txt index >>>> 56a3e68ccb80..cf53678fe574 100644 >>>> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt >>>> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt >>>> @@ -8,6 +8,9 @@ Optional properties: >>>> - interrupts-extended or interrupt-parent + interrupts: describe >>>> the interrupt line used to inform the host about hotplug events. >>>> - reset-gpios: OF device-tree gpio specification for RST_N pin. >>>> + - iovcc-supply: I/O supply voltage (1.8V or 3.3V, host-dependent). >>>> + - avcc12-supply: TMDS analog supply voltage (1.2V). >>>> + - cvcc12-supply: Digital core supply voltage (1.2V). >>> >>> It seems that the AVCC12 and CVCC12 power supplies are usually derived >>> from the same source. How about starting with one DT property for both, >>> and adding a second one later if needed ? >> >> Well, I do not know what is the best. Here I took the description from >> the documentation, and to allow all possible board configurations, I >> added these supplies as "optional" properties: if there is only one 1v2 >> regulator on the board, the dt will contain only avcc12 or cvcc12 and >> everything will work fine (we will have a dummy regulator for the >> missing optional 1v2 reg), if both regulators are there for any reasons >> (stability, noise, whatever...) then both entries will be in the dt. >> >> If you confirm you prefer a single 1v2 supply (named for instance >> "vcc12-supply") then I will do :-) > > Please see https://lists.freedesktop.org/archives/dri-devel/2018-April/ > 172400.html (and the messages that lead to it) and https:// > lists.freedesktop.org/archives/dri-devel/2018-March/170763.html. > Thanks for this discussion thread. On my side, I found "CVCC12 and AVCC12 can be derived from the same power source" written with a small font (august 2016 datasheet p13) so then your advice is clearly what we have to do :-) I will add this info in v2 too. Thank you, Philippe :-) >>>> Optional subnodes: >>>> - video input: this subnode can contain a video input port node > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philippe CORNU Subject: Re: [PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Thu, 19 Apr 2018 12:41:20 +0000 Message-ID: References: <20180410051927.8268-1-philippe.cornu@st.com> <20599695.GSkeUvMnvx@avalon> <1733412.i2Wslp7VkI@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1733412.i2Wslp7VkI@avalon> Content-Language: en-US Content-ID: <63B4169087856944A9896EBD4F7B6F5A@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Mark Rutland , "devicetree@vger.kernel.org" , Alexandre TORGUE , David Airlie , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Yannick FERTRE , Rob Herring List-Id: devicetree@vger.kernel.org SGkgTGF1cmVudCwNCg0KDQpPbiAwNC8xOS8yMDE4IDAxOjA5IFBNLCBMYXVyZW50IFBpbmNoYXJ0 IHdyb3RlOg0KPiBIaSBQaGlsaXBwZSwNCj4gDQo+IE9uIFRodXJzZGF5LCAxOSBBcHJpbCAyMDE4 IDEyOjMxOjE1IEVFU1QgUGhpbGlwcGUgQ09STlUgd3JvdGU6DQo+PiBPbiAwNC8xOS8yMDE4IDEw OjExIEFNLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOg0KPj4+IE9uIFR1ZXNkYXksIDEwIEFwcmls IDIwMTggMDg6MTk6MjYgRUVTVCBQaGlsaXBwZSBDb3JudSB3cm90ZToNCj4+Pg0KPj4+PiBBZGQg dGhlIDMgb3B0aW9uYWwgcG93ZXIgc3VwcGxpZXMgdXNpbmcgdGhlIGV4YWN0IGRlc2NyaXB0aW9u DQo+Pj4+IGZvdW5kIGluIHRoZSBkb2N1bWVudCBuYW1lZA0KPj4+PiAiU2lJOTAyMkEvU2lJOTAy NEEgSERNSSBUcmFuc21pdHRlciBEYXRhIFNoZWV0IChBdWd1c3QgMjAxNikiLg0KPj4+Pg0KPj4+ PiBTaWduZWQtb2ZmLWJ5OiBQaGlsaXBwZSBDb3JudSA8cGhpbGlwcGUuY29ybnVAc3QuY29tPg0K Pj4+PiAtLS0NCj4+Pj4NCj4+Pj4gICAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2Rpc3BsYXkvYnJpZGdlL3NpaTkwMngudHh0IHwgMyArKysNCj4+Pj4gICAgMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKQ0KPj4+Pg0KPj4+PiBkaWZmIC0tZ2l0DQo+Pj4+IGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3NpaTkwMngudHh0DQo+ Pj4+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3Np aTkwMngudHh0IGluZGV4DQo+Pj4+IDU2YTNlNjhjY2I4MC4uY2Y1MzY3OGZlNTc0IDEwMDY0NA0K Pj4+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlk Z2Uvc2lpOTAyeC50eHQNCj4+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2Rpc3BsYXkvYnJpZGdlL3NpaTkwMngudHh0DQo+Pj4+IEBAIC04LDYgKzgsOSBAQCBPcHRp b25hbCBwcm9wZXJ0aWVzOg0KPj4+PiAgICAJLSBpbnRlcnJ1cHRzLWV4dGVuZGVkIG9yIGludGVy cnVwdC1wYXJlbnQgKyBpbnRlcnJ1cHRzOiBkZXNjcmliZQ0KPj4+PiAgICAJICB0aGUgaW50ZXJy dXB0IGxpbmUgdXNlZCB0byBpbmZvcm0gdGhlIGhvc3QgYWJvdXQgaG90cGx1ZyBldmVudHMuDQo+ Pj4+ICAgIAktIHJlc2V0LWdwaW9zOiBPRiBkZXZpY2UtdHJlZSBncGlvIHNwZWNpZmljYXRpb24g Zm9yIFJTVF9OIHBpbi4NCj4+Pj4gKwktIGlvdmNjLXN1cHBseTogSS9PIHN1cHBseSB2b2x0YWdl ICgxLjhWIG9yIDMuM1YsIGhvc3QtZGVwZW5kZW50KS4NCj4+Pj4gKwktIGF2Y2MxMi1zdXBwbHk6 IFRNRFMgYW5hbG9nIHN1cHBseSB2b2x0YWdlICgxLjJWKS4NCj4+Pj4gKwktIGN2Y2MxMi1zdXBw bHk6IERpZ2l0YWwgY29yZSBzdXBwbHkgdm9sdGFnZSAoMS4yVikuDQo+Pj4NCj4+PiBJdCBzZWVt cyB0aGF0IHRoZSBBVkNDMTIgYW5kIENWQ0MxMiBwb3dlciBzdXBwbGllcyBhcmUgdXN1YWxseSBk ZXJpdmVkDQo+Pj4gZnJvbSB0aGUgc2FtZSBzb3VyY2UuIEhvdyBhYm91dCBzdGFydGluZyB3aXRo IG9uZSBEVCBwcm9wZXJ0eSBmb3IgYm90aCwNCj4+PiBhbmQgYWRkaW5nIGEgc2Vjb25kIG9uZSBs YXRlciBpZiBuZWVkZWQgPw0KPj4NCj4+IFdlbGwsIEkgZG8gbm90IGtub3cgd2hhdCBpcyB0aGUg YmVzdC4gSGVyZSBJIHRvb2sgdGhlIGRlc2NyaXB0aW9uIGZyb20NCj4+IHRoZSBkb2N1bWVudGF0 aW9uLCBhbmQgdG8gYWxsb3cgYWxsIHBvc3NpYmxlIGJvYXJkIGNvbmZpZ3VyYXRpb25zLCBJDQo+ PiBhZGRlZCB0aGVzZSBzdXBwbGllcyBhcyAib3B0aW9uYWwiIHByb3BlcnRpZXM6IGlmIHRoZXJl IGlzIG9ubHkgb25lIDF2Mg0KPj4gcmVndWxhdG9yIG9uIHRoZSBib2FyZCwgdGhlIGR0IHdpbGwg Y29udGFpbiBvbmx5IGF2Y2MxMiBvciBjdmNjMTIgYW5kDQo+PiBldmVyeXRoaW5nIHdpbGwgd29y ayBmaW5lICh3ZSB3aWxsIGhhdmUgYSBkdW1teSByZWd1bGF0b3IgZm9yIHRoZQ0KPj4gbWlzc2lu ZyBvcHRpb25hbCAxdjIgcmVnKSwgaWYgYm90aCByZWd1bGF0b3JzIGFyZSB0aGVyZSBmb3IgYW55 IHJlYXNvbnMNCj4+IChzdGFiaWxpdHksIG5vaXNlLCB3aGF0ZXZlci4uLikgdGhlbiBib3RoIGVu dHJpZXMgd2lsbCBiZSBpbiB0aGUgZHQuDQo+Pg0KPj4gSWYgeW91IGNvbmZpcm0geW91IHByZWZl ciBhIHNpbmdsZSAxdjIgc3VwcGx5IChuYW1lZCBmb3IgaW5zdGFuY2UNCj4+ICJ2Y2MxMi1zdXBw bHkiKSB0aGVuIEkgd2lsbCBkbyA6LSkNCj4gDQo+IFBsZWFzZSBzZWUgaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTgtQXByaWwvDQo+IDE3MjQwMC5o dG1sIChhbmQgdGhlIG1lc3NhZ2VzIHRoYXQgbGVhZCB0byBpdCkgYW5kIGh0dHBzOi8vDQo+IGxp c3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwvMjAxOC1NYXJjaC8xNzA3NjMu aHRtbC4NCj4gDQoNClRoYW5rcyBmb3IgdGhpcyBkaXNjdXNzaW9uIHRocmVhZC4NCg0KT24gbXkg c2lkZSwgSSBmb3VuZCAiQ1ZDQzEyIGFuZCBBVkNDMTIgY2FuIGJlIGRlcml2ZWQgZnJvbSB0aGUg c2FtZSANCnBvd2VyIHNvdXJjZSIgd3JpdHRlbiB3aXRoIGEgc21hbGwgZm9udCAoYXVndXN0IDIw MTYgZGF0YXNoZWV0IHAxMykgc28gDQp0aGVuIHlvdXIgYWR2aWNlIGlzIGNsZWFybHkgd2hhdCB3 ZSBoYXZlIHRvIGRvIDotKQ0KSSB3aWxsIGFkZCB0aGlzIGluZm8gaW4gdjIgdG9vLg0KVGhhbmsg eW91LA0KUGhpbGlwcGUgOi0pDQoNCj4+Pj4gICAgT3B0aW9uYWwgc3Vibm9kZXM6DQo+Pj4+ICAg IAktIHZpZGVvIGlucHV0OiB0aGlzIHN1Ym5vZGUgY2FuIGNvbnRhaW4gYSB2aWRlbyBpbnB1dCBw b3J0IG5vZGUNCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=