From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933563AbcHJSQy (ORCPT ); Wed, 10 Aug 2016 14:16:54 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:39376 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933151AbcHJSQv (ORCPT ); Wed, 10 Aug 2016 14:16:51 -0400 Subject: Re: [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear To: Shuah Khan , inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com References: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Javier Martinez Canillas Message-ID: Date: Wed, 10 Aug 2016 13:37:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Shuah, On 08/08/2016 07:48 PM, Shuah Khan wrote: > Fix unsupported GEM memory type error message to include the memory type > information. > > Signed-off-by: Shuah Khan > --- > Changes since v1: > -- Comment changed to read clearly > > drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c > index e016640..40ce841 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c > @@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev, > flags = exynos_gem->flags; > > /* > - * without iommu support, not support physically non-continuous memory > - * for framebuffer. > + * Physically non-contiguous memory type for framebuffer is not > + * supported without IOMMU. > */ > if (IS_NONCONTIG_BUFFER(flags)) { > - DRM_ERROR("cannot use this gem memory type for fb.\n"); > + DRM_ERROR("Non-contiguous GEM memory is not supported.\n"); > return -EINVAL; > } > > Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear Date: Wed, 10 Aug 2016 13:37:53 -0400 Message-ID: References: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shuah Khan , inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org SGVsbG8gU2h1YWgsCgpPbiAwOC8wOC8yMDE2IDA3OjQ4IFBNLCBTaHVhaCBLaGFuIHdyb3RlOgo+ IEZpeCB1bnN1cHBvcnRlZCBHRU0gbWVtb3J5IHR5cGUgZXJyb3IgbWVzc2FnZSB0byBpbmNsdWRl IHRoZSBtZW1vcnkgdHlwZQo+IGluZm9ybWF0aW9uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFNodWFo IEtoYW4gPHNodWFoa2hAb3NnLnNhbXN1bmcuY29tPgo+IC0tLQo+IENoYW5nZXMgc2luY2UgdjE6 Cj4gLS0gQ29tbWVudCBjaGFuZ2VkIHRvIHJlYWQgY2xlYXJseQo+IAo+ICBkcml2ZXJzL2dwdS9k cm0vZXh5bm9zL2V4eW5vc19kcm1fZmIuYyB8IDYgKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAz IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9mYi5jIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9l eHlub3NfZHJtX2ZiLmMKPiBpbmRleCBlMDE2NjQwLi40MGNlODQxIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9mYi5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2V4eW5vcy9leHlub3NfZHJtX2ZiLmMKPiBAQCAtNTUsMTEgKzU1LDExIEBAIHN0YXRpYyBp bnQgY2hlY2tfZmJfZ2VtX21lbW9yeV90eXBlKHN0cnVjdCBkcm1fZGV2aWNlICpkcm1fZGV2LAo+ ICAJZmxhZ3MgPSBleHlub3NfZ2VtLT5mbGFnczsKPiAgCj4gIAkvKgo+IC0JICogd2l0aG91dCBp b21tdSBzdXBwb3J0LCBub3Qgc3VwcG9ydCBwaHlzaWNhbGx5IG5vbi1jb250aW51b3VzIG1lbW9y eQo+IC0JICogZm9yIGZyYW1lYnVmZmVyLgo+ICsJICogUGh5c2ljYWxseSBub24tY29udGlndW91 cyBtZW1vcnkgdHlwZSBmb3IgZnJhbWVidWZmZXIgaXMgbm90Cj4gKwkgKiBzdXBwb3J0ZWQgd2l0 aG91dCBJT01NVS4KPiAgCSAqLwo+ICAJaWYgKElTX05PTkNPTlRJR19CVUZGRVIoZmxhZ3MpKSB7 Cj4gLQkJRFJNX0VSUk9SKCJjYW5ub3QgdXNlIHRoaXMgZ2VtIG1lbW9yeSB0eXBlIGZvciBmYi5c biIpOwo+ICsJCURSTV9FUlJPUigiTm9uLWNvbnRpZ3VvdXMgR0VNIG1lbW9yeSBpcyBub3Qgc3Vw cG9ydGVkLlxuIik7Cj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gIAo+IAoKUGF0Y2ggbG9v a3MgZ29vZCB0byBtZS4KClJldmlld2VkLWJ5OiBKYXZpZXIgTWFydGluZXogQ2FuaWxsYXMgPGph dmllckBvc2cuc2Ftc3VuZy5jb20+CgpCZXN0IHJlZ2FyZHMsCi0tIApKYXZpZXIgTWFydGluZXog Q2FuaWxsYXMKT3BlbiBTb3VyY2UgR3JvdXAKU2Ftc3VuZyBSZXNlYXJjaCBBbWVyaWNhCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Wed, 10 Aug 2016 13:37:53 -0400 Subject: [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear In-Reply-To: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com> References: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Shuah, On 08/08/2016 07:48 PM, Shuah Khan wrote: > Fix unsupported GEM memory type error message to include the memory type > information. > > Signed-off-by: Shuah Khan > --- > Changes since v1: > -- Comment changed to read clearly > > drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c > index e016640..40ce841 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c > @@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev, > flags = exynos_gem->flags; > > /* > - * without iommu support, not support physically non-continuous memory > - * for framebuffer. > + * Physically non-contiguous memory type for framebuffer is not > + * supported without IOMMU. > */ > if (IS_NONCONTIG_BUFFER(flags)) { > - DRM_ERROR("cannot use this gem memory type for fb.\n"); > + DRM_ERROR("Non-contiguous GEM memory is not supported.\n"); > return -EINVAL; > } > > Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America