All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Cc: fabrizio.castro@bp.renesas.com,
	boris.brezillon@free-electrons.com, Songjun.Wu@atmel.com,
	peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	laurent.pinchart@ideasonboard.com, voice.shen@atmel.com
Subject: Re: [PATCH 4/4] drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz
Date: Mon, 25 Feb 2019 14:01:55 +0100	[thread overview]
Message-ID: <a1263f0d-2231-ede7-235b-8394e6c3a36b@samsung.com> (raw)
In-Reply-To: <538ba3bce4c287d8e137003cc3c4e13e570ea8fe.1551090126.git.jsarha@ti.com>

On 25.02.2019 12:23, Jyri Sarha wrote:
> The pixel clock unit in the first two registers (0x00 and 0x01) of
> sii9022 is 10kHz, not 1kHz as in struct drm_display_mode. Division by
> 10 fixes the issue.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

 --
Regards
Andrzej
> ---
>  drivers/gpu/drm/bridge/sii902x.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index f296a33c57c7..9cf0dbb6c764 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -358,10 +358,11 @@ static void sii902x_bridge_mode_set(struct drm_bridge *bridge,
>  	struct regmap *regmap = sii902x->regmap;
>  	u8 buf[HDMI_INFOFRAME_SIZE(AVI)];
>  	struct hdmi_avi_infoframe frame;
> +	u16 pixel_clock_10kHz = adj->clock / 10;
>  	int ret;
>  
> -	buf[0] = adj->clock;
> -	buf[1] = adj->clock >> 8;
> +	buf[0] = pixel_clock_10kHz & 0xFF;
> +	buf[1] = pixel_clock_10kHz >> 8;
>  	buf[2] = adj->vrefresh;
>  	buf[3] = 0x00;
>  	buf[4] = adj->hdisplay;


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2019-02-25 13:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 11:23 [PATCH 0/4] drm/bridge: sii902x: HDMI-audio support and some fixes Jyri Sarha
2019-02-25 11:23 ` [PATCH 1/4] drm/bridge: sii902x: add input_bus_flags Jyri Sarha
2019-02-25 12:48   ` Andrzej Hajda
2019-02-25 18:15   ` kbuild test robot
2019-02-25 18:22   ` kbuild test robot
2019-02-25 11:23 ` [PATCH 2/4] drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID Jyri Sarha
2019-02-25 12:48   ` Andrzej Hajda
2019-02-25 11:23 ` [PATCH 3/4] drm/bridge: sii902x: Implement HDMI audio support Jyri Sarha
2019-02-25 13:57   ` Andrzej Hajda
2019-02-25 14:40     ` Jyri Sarha
2019-02-25 21:44   ` kbuild test robot
2019-02-25 21:44   ` [PATCH] drm/bridge: sii902x: fix semicolon.cocci warnings kbuild test robot
2019-02-25 11:23 ` [PATCH 4/4] drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz Jyri Sarha
2019-02-25 13:01   ` Andrzej Hajda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1263f0d-2231-ede7-235b-8394e6c3a36b@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=Songjun.Wu@atmel.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=voice.shen@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.